searching for reviewer(Honza)
8c833d50284dbcdabc004cc0a2676750bd5fb6af: Bug 1564105 - Enable WS Monitor in Nightly. r=Honza,jdescottes
tanhengyeow <E0032242@u.nus.edu> - Thu, 18 Jul 2019 13:49:59 +0000 - rev 483321
Push 113717 by opoprus@mozilla.com at Thu, 18 Jul 2019 22:06:59 +0000
Bug 1564105 - Enable WS Monitor in Nightly. r=Honza,jdescottes Enable WS Monitor in Nightly Differential Revision: https://phabricator.services.mozilla.com/D38230
03bb034db3d6e806e915fd36874f20dd5adb14b6: Bug 1566435 - Stop emitting requests when the netmonitor closes. r=Honza
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 18 Jul 2019 08:53:02 +0000 - rev 483295
Push 113713 by malexandru@mozilla.com at Thu, 18 Jul 2019 16:01:09 +0000
Bug 1566435 - Stop emitting requests when the netmonitor closes. r=Honza There is no guarantee that any RDP request will be completed when the toolbox closes, so that we should do the cleanup from the actor side if anything needs to be stopped or removed. Differential Revision: https://phabricator.services.mozilla.com/D38371
fb91c01b8bdb5c4ab6afa449cccc1582c4671d79: Bug 1566435 - Make netmonitor destroy codepath synchronous. r=Honza
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 17 Jul 2019 16:57:53 +0000 - rev 483294
Push 113713 by malexandru@mozilla.com at Thu, 18 Jul 2019 16:01:09 +0000
Bug 1566435 - Make netmonitor destroy codepath synchronous. r=Honza Differential Revision: https://phabricator.services.mozilla.com/D38370
67f2361d7b49752d06d31504f8856bbc5006aa48: Bug 1565781 - Fix ConsoleTable with nested holey array. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 18 Jul 2019 12:04:42 +0000 - rev 483293
Push 113713 by malexandru@mozilla.com at Thu, 18 Jul 2019 16:01:09 +0000
Bug 1565781 - Fix ConsoleTable with nested holey array. r=Honza. A test is added to ensure this is fixed properly. We also fix the Array previewer to properly return undefined for unknown array properties, rather than null. Differential Revision: https://phabricator.services.mozilla.com/D38467
399e6fc3c9d0f0812d2afa6c411dcdc1b40d571c: Bug 1567082 - Fix console table overflow. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 18 Jul 2019 11:58:16 +0000 - rev 483292
Push 113713 by malexandru@mozilla.com at Thu, 18 Jul 2019 16:01:09 +0000
Bug 1567082 - Fix console table overflow. r=Honza. Differential Revision: https://phabricator.services.mozilla.com/D38466
d3adcc44e73e1b56bdef0ba03919f4d9b3d4df43: Bug 1567084 - Move netmonitor package.json to test/node folder r=Honza
Julian Descottes <jdescottes@mozilla.com> - Thu, 18 Jul 2019 10:38:07 +0000 - rev 483286
Push 113713 by malexandru@mozilla.com at Thu, 18 Jul 2019 16:01:09 +0000
Bug 1567084 - Move netmonitor package.json to test/node folder r=Honza Depends on D38462 Try at https://treeherder.mozilla.org/#/jobs?repo=try&revision=11540772729bce1614b75e7cf6b71931eed1582e Differential Revision: https://phabricator.services.mozilla.com/D38463
599ecdac4aa85a137d000f041c13fcd1447e8a29: Bug 1567084 - Remove files related to running netmonitor with launchpad/chrome r=Honza
Julian Descottes <jdescottes@mozilla.com> - Thu, 18 Jul 2019 10:33:57 +0000 - rev 483285
Push 113713 by malexandru@mozilla.com at Thu, 18 Jul 2019 16:01:09 +0000
Bug 1567084 - Remove files related to running netmonitor with launchpad/chrome r=Honza Differential Revision: https://phabricator.services.mozilla.com/D38462
98859206f576cc3a341c7686f78b2ceb3b5dfdf0: Bug 1554877 - Make JsTerm editor resizable. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 18 Jul 2019 05:51:44 +0000 - rev 483281
Push 113713 by malexandru@mozilla.com at Thu, 18 Jul 2019 16:01:09 +0000
Bug 1554877 - Make JsTerm editor resizable. r=Honza. We add a GridElementWidthResizer to handle the editor width. The width is then persisted in a pref. A test is added to ensure this works as expected. Differential Revision: https://phabricator.services.mozilla.com/D37687
3f8a8dd8f881a3db24d538e8ab17202313d8b015: Bug 1565963 - Add props to NotificationBox to render top and bottom borders. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 18 Jul 2019 05:51:24 +0000 - rev 483280
Push 113713 by malexandru@mozilla.com at Thu, 18 Jul 2019 16:01:09 +0000
Bug 1565963 - Add props to NotificationBox to render top and bottom borders. r=Honza. We need this in the console to put the borders on the right position, depending on the NotificationBox place. Differential Revision: https://phabricator.services.mozilla.com/D38039
5b3664109ecc2e18ab23a64ca25810f0d9073873: Bug 1565962 - Refactor webconsole layout. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 18 Jul 2019 09:02:46 +0000 - rev 483279
Push 113713 by malexandru@mozilla.com at Thu, 18 Jul 2019 16:01:09 +0000
Bug 1565962 - Refactor webconsole layout. r=Honza. Since we now have a GridElementWidthResizer element, we can get rid of the SplitBox wrapping the SideBar, and have all major elements as child of the App element, controlled by a CSS Grid. This makes it easy to change the console layout when toggling the editor mode (re-ordering element in JS, changing the CSS grid templates, and placing the element in different areas). This also means we can take advantage of subgrid to align the sidebar toolbar with the filter bar for example. As the part of the stylesheet dedicated to layout grew, it made sense to have it all in a separate stylesheet, App.css, that lives next to the App component. Differential Revision: https://phabricator.services.mozilla.com/D38038
bdedafc3cec7e8c1e69f2c6ec479f8dcb84b968b: Bug 1567067 - Fix PropTypes error in Message.js .r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 18 Jul 2019 08:55:36 +0000 - rev 483278
Push 113713 by malexandru@mozilla.com at Thu, 18 Jul 2019 16:01:09 +0000
Bug 1567067 - Fix PropTypes error in Message.js .r=Honza. Differential Revision: https://phabricator.services.mozilla.com/D38454
e17749201d35d24e2f7c12289ec588a657761e61: Bug 1565662 - Fix test_HSplitBox_01.html intermittent. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 18 Jul 2019 08:53:24 +0000 - rev 483277
Push 113713 by malexandru@mozilla.com at Thu, 18 Jul 2019 16:01:09 +0000
Bug 1565662 - Fix test_HSplitBox_01.html intermittent. r=Honza. Differential Revision: https://phabricator.services.mozilla.com/D38161
209c91065bfb9c86dc2dc9613fa1c209c26fa521: Bug 1563680 - Move network monitor actor files into the network-monitor directory r=Honza
Jeremy <vanhagarsux@hotmail.com> - Wed, 17 Jul 2019 07:48:34 +0000 - rev 483070
Push 113703 by archaeopteryx@coole-files.de at Wed, 17 Jul 2019 16:57:18 +0000
Bug 1563680 - Move network monitor actor files into the network-monitor directory r=Honza Moved network monitor actor files: network-monitor.js network-event.js into devtools/server/actors/network-monitor directory. And updated moz.build files presented in related directories. Differential Revision: https://phabricator.services.mozilla.com/D38219
b1a964205023bdb3ef2f7cc11b912eca7da0c5a7: Bug 1564105 - Enable WS Monitor in Nightly. r=Honza
tanhengyeow <E0032242@u.nus.edu> - Tue, 16 Jul 2019 19:48:56 +0000 - rev 483014
Push 113703 by archaeopteryx@coole-files.de at Wed, 17 Jul 2019 16:57:18 +0000
Bug 1564105 - Enable WS Monitor in Nightly. r=Honza Enable WS Monitor in Nightly Differential Revision: https://phabricator.services.mozilla.com/D38230
09ae43a6d4ba26b21c703f9c4a421d541423587b: Bug 1555634 - Summary stats at the bottom of Messages panel. r=Honza,nchevobbe,flod
tanhengyeow <E0032242@u.nus.edu> - Tue, 16 Jul 2019 18:05:35 +0000 - rev 482983
Push 113703 by archaeopteryx@coole-files.de at Wed, 17 Jul 2019 16:57:18 +0000
Bug 1555634 - Summary stats at the bottom of Messages panel. r=Honza,nchevobbe,flod Add summary stats at bottom of Messages panel. Differential Revision: https://phabricator.services.mozilla.com/D38051
9a87637d6ebee396eaf267584d3c4888e68733c6: Bug 1561549 - Move WebSocket type to an icon in Data column and reorder columns; r=Honza
Florens Verschelde <florens@fvsch.com> - Tue, 16 Jul 2019 14:32:53 +0000 - rev 482924
Push 113699 by rgurzau@mozilla.com at Wed, 17 Jul 2019 03:57:10 +0000
Bug 1561549 - Move WebSocket type to an icon in Data column and reorder columns; r=Honza - Remove WebSocket Type column - Move the frame type information to the Data column as an arrow icon - Add L10N strings for frame types and time format - Reorder columns - Set percentage widths for columns to give more room to data and time Differential Revision: https://phabricator.services.mozilla.com/D37064
350d2267c02f688f1e27c96badaa8b409f822d0c: Bug 1521452 - Create a GridElementWidthResizer component. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Fri, 12 Jul 2019 16:48:27 +0000 - rev 482641
Push 113678 by csabou@mozilla.com at Sat, 13 Jul 2019 10:07:02 +0000
Bug 1521452 - Create a GridElementWidthResizer component. r=Honza. This component is placed by the consumer on a grid, and act on one of the grid element size. The component can be placed at the inline start or the inline end of the area it is in. This component relies on the existing Draggable component. A test is added to ensure this works as expected. Differential Revision: https://phabricator.services.mozilla.com/D37686
41d8b9ebef4937d229be0e442d2da689900a76bd: Bug 1555628 - Toolbar for Messages side panel. r=Honza,nchevobbe
tanhengyeow <E0032242@u.nus.edu> - Fri, 12 Jul 2019 07:37:23 +0000 - rev 482547
Push 113677 by apavel@mozilla.com at Fri, 12 Jul 2019 21:57:56 +0000
Bug 1555628 - Toolbar for Messages side panel. r=Honza,nchevobbe Implement Toolbar for WebSocketsPanel. Differential Revision: https://phabricator.services.mozilla.com/D36455
ad78f4b2fceee01c0d49c82e2c252b42d47be873: Bug 1521452 - Create a GridElementWidthResizer component. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 11 Jul 2019 14:37:11 +0000 - rev 482536
Push 113677 by apavel@mozilla.com at Fri, 12 Jul 2019 21:57:56 +0000
Bug 1521452 - Create a GridElementWidthResizer component. r=Honza. This component is placed by the consumer on a grid, and act on one of the grid element size. The component can be placed at the inline start or the inline end of the area it is in. This component relies on the existing Draggable component. A test is added to ensure this works as expected. Differential Revision: https://phabricator.services.mozilla.com/D37686
f5d458cf80ae0540d5a1d40a23b7722e021b69d4: Bug 1555628 - Toolbar for Messages side panel. r=Honza,nchevobbe
tanhengyeow <E0032242@u.nus.edu> - Thu, 11 Jul 2019 14:49:48 +0000 - rev 482432
Push 113674 by dvarga@mozilla.com at Fri, 12 Jul 2019 10:08:07 +0000
Bug 1555628 - Toolbar for Messages side panel. r=Honza,nchevobbe Implement Toolbar for WebSocketsPanel. Differential Revision: https://phabricator.services.mozilla.com/D36455
e85a0177b2f7f3a25db03d6c14f0823736e8af43: Bug 1424076 - P2 adjust Origin header comparison for POST request r=Honza
Junior Hsu <juhsu@mozilla.com> - Tue, 09 Jul 2019 18:26:59 +0000 - rev 482011
Push 113647 by aciure@mozilla.com at Wed, 10 Jul 2019 09:46:39 +0000
Bug 1424076 - P2 adjust Origin header comparison for POST request r=Honza We'd like to enable the Origin header for all eligible reqeusts, which include POST. The test should be adjusted. Differential Revision: https://phabricator.services.mozilla.com/D33382
c002ddb976e95cde3a83730f221d9f2d6e90cf02: Bug 1424076 - P2 adjust Origin header comparison for POST request r=Honza
Junior Hsu <juhsu@mozilla.com> - Tue, 09 Jul 2019 18:26:59 +0000 - rev 481978
Push 113647 by aciure@mozilla.com at Wed, 10 Jul 2019 09:46:39 +0000
Bug 1424076 - P2 adjust Origin header comparison for POST request r=Honza We'd like to enable the Origin header for all eligible reqeusts, which include POST. The test should be adjusted. Differential Revision: https://phabricator.services.mozilla.com/D33382
6127a13715c9da590bbda3c5156738b6d61d64d7: Bug 1424076 - P2 adjust Origin header comparison for POST request r=Honza
Junior Hsu <juhsu@mozilla.com> - Tue, 09 Jul 2019 17:15:21 +0000 - rev 481960
Push 113647 by aciure@mozilla.com at Wed, 10 Jul 2019 09:46:39 +0000
Bug 1424076 - P2 adjust Origin header comparison for POST request r=Honza We'd like to enable the Origin header for all eligible reqeusts, which include POST. The test should be adjusted. Differential Revision: https://phabricator.services.mozilla.com/D33382
8274e31c4e2fdd53698512d29a37233b1fb0d625: Bug 1564363 - Close the network detail on Escape. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 09 Jul 2019 10:50:50 +0000 - rev 481903
Push 113647 by aciure@mozilla.com at Wed, 10 Jul 2019 09:46:39 +0000
Bug 1564363 - Close the network detail on Escape. r=Honza. We use the openNetworkDetails prop which is already in use in the netmonitor to collapse the message if the parameter passed to the function is falsy (i.e. the panel is already displayed) Depends on D37388 Differential Revision: https://phabricator.services.mozilla.com/D37389
825dbb82f4a0c502f34cbbebee6cdcdc22090688: Bug 1564363 - Set toggleNetworkDetails prop as non required. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 09 Jul 2019 10:50:48 +0000 - rev 481902
Push 113647 by aciure@mozilla.com at Wed, 10 Jul 2019 09:46:39 +0000
Bug 1564363 - Set toggleNetworkDetails prop as non required. r=Honza. This prop is only used when hideToggleButton isn't truthy. In the case of the console, it won't ever be called, so it's not mandatory. Differential Revision: https://phabricator.services.mozilla.com/D37388
607e46906b3e819c92a618904f3aa75ed844986d: Bug 1534706 - Don't focus ConfirmDialog when displaying it. r=Honza
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 09 Jul 2019 12:28:38 +0000 - rev 481898
Push 113647 by aciure@mozilla.com at Wed, 10 Jul 2019 09:46:39 +0000
Bug 1534706 - Don't focus ConfirmDialog when displaying it. r=Honza Some people found that the ConfirmDialog was getting into their way when typing into the console, as it was stealing the focus. This patch fixes this by not focusing the ConfirmDialog when we show it, so the user can still type. This means that we now handle the dialog confirm and dismiss from JSTerm, when the former is displayed. Since it wasn't clear how you could close the popup, we add a close button that makes it very obvious. This means we can drop the key handler in the dialog as the jsterm is always focused. We also simply remove the feature to open the MDN link on `?` key stroke as it's not discoverable and was the only part of the panel where you could do such thing. Existing tests are adapted and extended to cover the new behaviour. Differential Revision: https://phabricator.services.mozilla.com/D36174
4ae0d9b11abd4e16704a74b1f7b767241605e1de: Bug 1563914 - Fix ConsoleTable with invalid headers. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 09 Jul 2019 08:47:58 +0000 - rev 481897
Push 113647 by aciure@mozilla.com at Wed, 10 Jul 2019 09:46:39 +0000
Bug 1563914 - Fix ConsoleTable with invalid headers. r=Honza. Differential Revision: https://phabricator.services.mozilla.com/D37164
ec67eb8eebef4e0f64883b08b7e441ee39c3be3b: Bug 1558355 - Remove devtools.netmonitor.features.resizeColumns pref, r=Honza
Javier Olaechea <pirata@gmail.com> - Tue, 09 Jul 2019 08:33:12 +0000 - rev 481854
Push 113641 by rgurzau@mozilla.com at Tue, 09 Jul 2019 16:13:03 +0000
Bug 1558355 - Remove devtools.netmonitor.features.resizeColumns pref, r=Honza Remove devtools.netmonitor.features.resizeColumns pref and any reference to it. Differential Revision: https://phabricator.services.mozilla.com/D37159
cab912119d7999d329e3cb06f15ad780547fa119: Bug 1562914 - Fix PropTypes error in FilterBar in split console. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 03 Jul 2019 11:15:28 +0000 - rev 481136
Push 113602 by opoprus@mozilla.com at Thu, 04 Jul 2019 03:40:43 +0000
Bug 1562914 - Fix PropTypes error in FilterBar in split console. r=Honza. Differential Revision: https://phabricator.services.mozilla.com/D36618
5289c222f0d082ea10ef220b698ceeceb74ac2d1: Bug 1562839 - Put editor mode behind a pref. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 03 Jul 2019 11:14:22 +0000 - rev 481135
Push 113602 by opoprus@mozilla.com at Thu, 04 Jul 2019 03:40:43 +0000
Bug 1562839 - Put editor mode behind a pref. r=Honza. Differential Revision: https://phabricator.services.mozilla.com/D36582
938ba43a3350c4f81a5ed152b02eb92f9e68c949: Bug 1519315 - Display CodeMirror's gutter in console input when devtools.webconsole.input.editor is true. r=Honza.
Bryan Kok <bryan.wyern1@gmail.com> - Fri, 28 Jun 2019 16:27:55 +0000 - rev 480589
Push 113558 by shindli@mozilla.com at Fri, 28 Jun 2019 23:24:53 +0000
Bug 1519315 - Display CodeMirror's gutter in console input when devtools.webconsole.input.editor is true. r=Honza. Differential Revision: https://phabricator.services.mozilla.com/D33995
8cb2280adc9c245ead1fe1de49793a38486bc92a: Bug 1519105 - Add a keyboard shortcut to switch between inline and editor mode. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Fri, 28 Jun 2019 09:25:59 +0000 - rev 480526
Push 113555 by csabou@mozilla.com at Fri, 28 Jun 2019 16:23:03 +0000
Bug 1519105 - Add a keyboard shortcut to switch between inline and editor mode. r=Honza. We use Cmd/Ctrl + B to switch between inline and editor mode. This should be familiar for VSCode users as it toggles the file sidebar. When changing the layout, we persist the choice into the editor pref so the user keeps the same layout the next time they open the console. Differential Revision: https://phabricator.services.mozilla.com/D34718
adf05ab240a59a1054e2d5f0dca0bf518b529283: Bug 1519312 - Render the console input to the left of the panel when editor preference is true; r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 27 Jun 2019 13:13:32 +0000 - rev 480525
Push 113555 by csabou@mozilla.com at Fri, 28 Jun 2019 16:23:03 +0000
Bug 1519312 - Render the console input to the left of the panel when editor preference is true; r=Honza. When the editor preference is true, a CSS class is added to the panel that allow us to shift the layout to a CSS Grid, where the input panel is on the left and the output on the right. A toolbar is added to be able to execute an expression when in editor mode. Differential Revision: https://phabricator.services.mozilla.com/D17096
5bb0858a753789688471fdeabe33538d9af22ed4: Bug 1560804 - Fix double scrollbar in network message detail. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Fri, 28 Jun 2019 08:50:43 +0000 - rev 480520
Push 113555 by csabou@mozilla.com at Fri, 28 Jun 2019 16:23:03 +0000
Bug 1560804 - Fix double scrollbar in network message detail. r=Honza. We take this as an opportunity to fix the alignment between the XHR badge and the URL. Differential Revision: https://phabricator.services.mozilla.com/D36297
42fa48dca98885b5da0568284a5e1a0456ffd289: Bug 1559398 - Implement table and preview sections in WebSocket side panel. r=Honza
tanhengyeow <E0032242@u.nus.edu> - Fri, 28 Jun 2019 07:24:59 +0000 - rev 480510
Push 113555 by csabou@mozilla.com at Fri, 28 Jun 2019 16:23:03 +0000
Bug 1559398 - Implement table and preview sections in WebSocket side panel. r=Honza Implement table and preview sections in WebSocket side panel. Differential Revision: https://phabricator.services.mozilla.com/D35983
89d1a2584683d3159cf1ed79a73e83bc04263775: Bug 1561676 - WebSocket panel crashes in WebConsole. r=nchevobbe,Honza
tanhengyeow <E0032242@u.nus.edu> - Thu, 27 Jun 2019 11:54:37 +0000 - rev 480353
Push 113547 by rmaries@mozilla.com at Thu, 27 Jun 2019 21:52:00 +0000
Bug 1561676 - WebSocket panel crashes in WebConsole. r=nchevobbe,Honza Hide WebSocketsPanel in console. Differential Revision: https://phabricator.services.mozilla.com/D36158
9c00486078c9290f0750159958aebc1730e0156d: Bug 1560320 - Dismiss autocomplete on Ctrl+A on OSX. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 27 Jun 2019 11:48:34 +0000 - rev 480351
Push 113547 by rmaries@mozilla.com at Thu, 27 Jun 2019 21:52:00 +0000
Bug 1560320 - Dismiss autocomplete on Ctrl+A on OSX. r=Honza. Ctrl + A moves the cursor to the beginning of the line, so we need to dismiss autocomplete. A test case is added to make sure this behaves as expected. Differential Revision: https://phabricator.services.mozilla.com/D35573
87fa4e9eb13a108440f136703c218a345f5ff8f4: Bug 1559329 - Set "group similar messages" to true by default. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 27 Jun 2019 11:42:15 +0000 - rev 480350
Push 113547 by rmaries@mozilla.com at Thu, 27 Jun 2019 21:52:00 +0000
Bug 1559329 - Set "group similar messages" to true by default. r=Honza. This was making browser_webconsole_scroll.js fail. After some investigation, I found that the `isInWarningGroup` prop, a function defined in `mapStateToProp` was causing a re-rendering (because we were creating a new function each time), impacting the shouldScrollToBottom behaviour. To fix this, we no longer create a `isInWarningGroup` prop, but directly use the `isMessageInWarningGroup` selector, which was modified to take an array of visible messages instead of the whole state. Differential Revision: https://phabricator.services.mozilla.com/D35016
3e211dfbeb71fd8868e9e9d941e1a64e1d760981: Bug 1559335 - Fix messages ordering when 2 messages have the same timestamp. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 27 Jun 2019 11:41:56 +0000 - rev 480349
Push 113547 by rmaries@mozilla.com at Thu, 27 Jun 2019 21:52:00 +0000
Bug 1559335 - Fix messages ordering when 2 messages have the same timestamp. r=Honza. If 2 messages are emitted during the same microsecond, their timestamps are similar, and the sorting we do when filtering for warning groups might be erroneous. In such case, we now check the message id, to see which one we handled first, which should be enough. A test is added to ensure this works as expected. Basically, we now render 2 logs one after the another, to increase the chance they'll get the same timestamp. The updated test was failing without the fix, and seems to pass with it. Differential Revision: https://phabricator.services.mozilla.com/D35015
49ba71fb412d5de62e59bfdd0a0723fe83145c9b: Bug 1174100 - Cache information is not exposed to HAR. r=Honza
lloan <lloanalas@outlook.com> - Wed, 26 Jun 2019 15:07:06 +0000 - rev 480215
Push 113537 by ccoroiu@mozilla.com at Thu, 27 Jun 2019 09:46:01 +0000
Bug 1174100 - Cache information is not exposed to HAR. r=Honza Differential Revision: https://phabricator.services.mozilla.com/D33570
c239c5218b5beb7712243663a833384cd9ca8718: Bug 1555625 - Basic skeleton of side panel for WS frames. r=Honza
tanhengyeow <E0032242@u.nus.edu> - Wed, 19 Jun 2019 20:00:30 +0000 - rev 479597
Push 113474 by rmaries@mozilla.com at Thu, 20 Jun 2019 11:21:48 +0000
Bug 1555625 - Basic skeleton of side panel for WS frames. r=Honza Implement basic skeleton of side panel for WS frames. Differential Revision: https://phabricator.services.mozilla.com/D34704
1b06448abd9346a6a3a0161e94a9f3f3bec6a8ef: Bug 1554881 - Simplify RequestListItem render r=Honza
Gregor Weber <gweber@mozilla.com> - Fri, 14 Jun 2019 13:38:55 +0000 - rev 478872
Push 113443 by dvarga@mozilla.com at Fri, 14 Jun 2019 21:53:52 +0000
Bug 1554881 - Simplify RequestListItem render r=Honza Differential Revision: https://phabricator.services.mozilla.com/D35010
b4f0ee392b9771796370b8f2b3194abba3599ff6: Bug 1174100 - Cache information is not exposed to HAR. r=Honza
lloan <lloanalas@outlook.com> - Fri, 14 Jun 2019 12:12:44 +0000 - rev 478865
Push 113443 by dvarga@mozilla.com at Fri, 14 Jun 2019 21:53:52 +0000
Bug 1174100 - Cache information is not exposed to HAR. r=Honza Differential Revision: https://phabricator.services.mozilla.com/D33570
7428c765611785fbd85b41aea1069d671bfc259d: Bug 1557632 - Don't check if input is compilable unit on Ctrl+Enter. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 13 Jun 2019 12:35:04 +0000 - rev 478668
Push 113434 by shindli@mozilla.com at Thu, 13 Jun 2019 22:05:34 +0000
Bug 1557632 - Don't check if input is compilable unit on Ctrl+Enter. r=Honza. In the regular webconsole input, on Enter, we check that the input is a compilable unit, so the user don't accidentally execute an incomplete snippet. In the editor mode, the user will have to use Ctrl/Cmd + Enter to execute, so we don't have to worry about Enter (it will simply append a new line). And since the user might deal with a large number of characters, we don't want to prevent them to execute. If it's malformed, they will get an error in the output and can fix their input easily, since it wasn't cleared. The patch adds a test to ensure this work as expected. Differential Revision: https://phabricator.services.mozilla.com/D34522
3a9e09d5a4d7663c9016b011b4f15d9a34364071: Bug 1494796 - fix netmonitor test to ensure elements exist on the dom before testing; r=Honza
yulia <ystartsev@mozilla.com> - Wed, 12 Jun 2019 23:34:59 +0000 - rev 478617
Push 113428 by opoprus@mozilla.com at Thu, 13 Jun 2019 10:07:38 +0000
Bug 1494796 - fix netmonitor test to ensure elements exist on the dom before testing; r=Honza the test `browser_net_params_sorted` may not have been functioning for some time. While investigating this, I discovered that we were getting an empty array for `actualKeys`. Iterating over this array returned immediately. As a result the test always passed, even though the shape of the data changed. I updated this code so that it waits for the dom to be populated with the number of keys expected. I also updated the test to reflect the data the front end has today. Differential Revision: https://phabricator.services.mozilla.com/D32713
ee33e076cbcbe786125f83079bd8e5b43bb73a99: Bug 1552458 - Implement backend actor for WebSocket inspection. r=Honza,jdescottes
tanhengyeow <E0032242@u.nus.edu> - Tue, 11 Jun 2019 15:27:08 +0000 - rev 478286
Push 113412 by rgurzau@mozilla.com at Tue, 11 Jun 2019 21:39:14 +0000
Bug 1552458 - Implement backend actor for WebSocket inspection. r=Honza,jdescottes Implement backend actor for WebSocket inspection Differential Revision: https://phabricator.services.mozilla.com/D33278
eb9868016897672165b4a95e9adf41c3883b6ec0: Bug 1558237 - Prevent unwanted background for event listener breakpoints toggles r=Honza
David Walsh <dwalsh@mozilla.com> - Tue, 11 Jun 2019 08:49:38 +0000 - rev 478273
Push 113412 by rgurzau@mozilla.com at Tue, 11 Jun 2019 21:39:14 +0000
Bug 1558237 - Prevent unwanted background for event listener breakpoints toggles r=Honza Differential Revision: https://phabricator.services.mozilla.com/D34381
d218c415396f9188c5d19ac09c50b6db82730016: Bug 1545888 - Use template-styled message with placeholders as warning group labels. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 11 Jun 2019 13:47:37 +0000 - rev 478261
Push 113412 by rgurzau@mozilla.com at Tue, 11 Jun 2019 21:39:14 +0000
Bug 1545888 - Use template-styled message with placeholders as warning group labels. r=Honza. This allows to have more meaningful warning group messages, i.e. "Content Blocking" is turned into something like "The resource at '<URL>' was blocked because content blocking is enabled". This is done by parsing the message of the first warning to put in the group, and replacing the URL with a generic placeholder. We take this as an opportunity to decouple content blocked messages and storage access blocked ones, as they have slightly different meanings and consequences. Tests are updated to match the new labels, and a new test is added to make sure that we can have multiple warning group in a single "page navigation" session. Differential Revision: https://phabricator.services.mozilla.com/D34339
be1ba46ab9fd608f8fb61882d0e23ffe01f8739e: Bug 1557324 - Fix JSTerm keyboard navigation in old input. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 11 Jun 2019 08:26:22 +0000 - rev 478217
Push 113412 by rgurzau@mozilla.com at Tue, 11 Jun 2019 21:39:14 +0000
Bug 1557324 - Fix JSTerm keyboard navigation in old input. r=Honza. Hitting Ctrl+ArrowRight didn't have any effect on windows/linux. The patch fixes this and add a test to make sure a user can navigate from word to word using Ctrl (or Alt on OSX) and Arrow Left/Right keys. Differential Revision: https://phabricator.services.mozilla.com/D34312
de1dc8a5ce5403163d5b2d4215795ca429358433: Bug 1552458 - Implement backend actor for WebSocket inspection. r=Honza
tanhengyeow <E0032242@u.nus.edu> - Tue, 11 Jun 2019 08:16:31 +0000 - rev 478216
Push 113412 by rgurzau@mozilla.com at Tue, 11 Jun 2019 21:39:14 +0000
Bug 1552458 - Implement backend actor for WebSocket inspection. r=Honza Implement backend actor for WebSocket inspection Differential Revision: https://phabricator.services.mozilla.com/D33278