c8e9b6a81194dff2d37b4f67d23a419fd4587e49: Bug 1519577 Convert toolbarbutton to a custom element r=surkov default tip
Andrew Swan <aswan@mozilla.com> - Mon, 20 May 2019 10:01:02 -0700 - rev 474978
Push 113185 by aswan@mozilla.com at Wed, 22 May 2019 23:25:35 +0000
Bug 1519577 Convert toolbarbutton to a custom element r=surkov Differential Revision: https://phabricator.services.mozilla.com/D31941
595c3065e9ac64ed1d4ada38c3a83c6ba2a0ff91: Bug 1519577 Mark badged page action toolbarbuttons before inserting r=Gijs
Andrew Swan <aswan@mozilla.com> - Tue, 14 May 2019 20:39:38 -0700 - rev 474977
Push 113185 by aswan@mozilla.com at Wed, 22 May 2019 23:25:35 +0000
Bug 1519577 Mark badged page action toolbarbuttons before inserting r=Gijs The "add search engine" page action wants to use badged toolbarbuttons, but it does this by adding the "badged-button" class (which changes the XBL binding) after the button has already been created and added to the DOM. To avoid having to switch between non-badged and badged buttons when toolbarbutton is converted to custom elements, add a property to page actions so that the badged status can be determined when the element is created. Differential Revision: https://phabricator.services.mozilla.com/D31940
82d77e63f4d3971ee341c6a49daacc6524e9d80c: Bug 1519577 Remove support for unused toolbarbutton anchor attribute r=NeilDeakin
Andrew Swan <aswan@mozilla.com> - Tue, 14 May 2019 13:08:53 -0700 - rev 474976
Push 113185 by aswan@mozilla.com at Wed, 22 May 2019 23:25:35 +0000
Bug 1519577 Remove support for unused toolbarbutton anchor attribute r=NeilDeakin This code contains an undesirable dependency between the layout code and the implementation of toolbarbutton. Since it isn't actually used anywhere by the firefox UI, remove it here. Differential Revision: https://phabricator.services.mozilla.com/D31939
8f0abb76f7bb982c13424019f7bda30089acf1e8: Bug 1519577 Update devtools test to use a test-only xbl binding r=jdescottes
Andrew Swan <aswan@mozilla.com> - Thu, 02 May 2019 20:39:20 -0700 - rev 474975
Push 113185 by aswan@mozilla.com at Wed, 22 May 2019 23:25:35 +0000
Bug 1519577 Update devtools test to use a test-only xbl binding r=jdescottes Differential Revision: https://phabricator.services.mozilla.com/D31938
8de5e0880f85d8986b2995cd8685245922e41b5f: Bug 1519577 Remove test_bug562554.xul dependence on button.xml r=bzbarsky
Andrew Swan <aswan@mozilla.com> - Tue, 14 May 2019 16:33:38 -0700 - rev 474974
Push 113185 by aswan@mozilla.com at Wed, 22 May 2019 23:25:35 +0000
Bug 1519577 Remove test_bug562554.xul dependence on button.xml r=bzbarsky This is essentially reverting the test changes from bug 653881. The platform changes that motivated bug 653881 were reverted in bug 888787 but the test changes were left in place at that time. Differential Revision: https://phabricator.services.mozilla.com/D31937
57bf01d965797fac39ca0f267050633039aa4c57: Bug 1519577 Update test_bug467123 to not rely on button.xml r=smaug
Andrew Swan <aswan@mozilla.com> - Thu, 02 May 2019 13:56:15 -0700 - rev 474973
Push 113185 by aswan@mozilla.com at Wed, 22 May 2019 23:25:35 +0000
Bug 1519577 Update test_bug467123 to not rely on button.xml r=smaug Differential Revision: https://phabricator.services.mozilla.com/D31936
f287bb6c18942c75aca41d54987006951270628d: Backed out 18 changesets (bug 1525720) for mass failures on Windows platform e.g ProcessPriorityManager.cpp on a CLOSED TREE.
Gurzau Raul <rgurzau@mozilla.com> - Thu, 23 May 2019 01:57:16 +0300 - rev 474972
Push 113184 by rgurzau@mozilla.com at Wed, 22 May 2019 22:58:26 +0000
Backed out 18 changesets (bug 1525720) for mass failures on Windows platform e.g ProcessPriorityManager.cpp on a CLOSED TREE. Backed out changeset 1f2e86c2d691 (bug 1525720) Backed out changeset 9b79caa460a0 (bug 1525720) Backed out changeset e65cb2d4c5a5 (bug 1525720) Backed out changeset 99f971a02d87 (bug 1525720) Backed out changeset d25963c72ff7 (bug 1525720) Backed out changeset 810b73719871 (bug 1525720) Backed out changeset ee10a8254481 (bug 1525720) Backed out changeset 1bcf9f586c55 (bug 1525720) Backed out changeset d3b2ac8d5ca4 (bug 1525720) Backed out changeset 697774dd8984 (bug 1525720) Backed out changeset eadeacbe4483 (bug 1525720) Backed out changeset 32eeee79d628 (bug 1525720) Backed out changeset 07678a2fa9e7 (bug 1525720) Backed out changeset 757b4f595cc4 (bug 1525720) Backed out changeset b255e0a84e12 (bug 1525720) Backed out changeset 9a255864f75d (bug 1525720) Backed out changeset 5f1c1b609ec1 (bug 1525720) Backed out changeset 00d83f1d02e0 (bug 1525720)
1f2e86c2d6912946eac17beabdd27e4c42accf27: Bug 1525720 - Try to fix build bustage. r=me on a CLOSED TREE
Ryan Hunt <rhunt@eqrion.net> - Wed, 22 May 2019 16:03:26 -0500 - rev 474971
Push 113183 by rhunt@eqrion.net at Wed, 22 May 2019 21:05:09 +0000
Bug 1525720 - Try to fix build bustage. r=me on a CLOSED TREE
9b79caa460a01a7bdf9c27ede487de0ec642ae0b: Bug 1525720, part 17 - Ignore nsIRemoteTab methods after we have destroyed the browser. r=nika
Ryan Hunt <rhunt@eqrion.net> - Wed, 15 May 2019 12:34:14 -0500 - rev 474970
Push 113182 by rhunt@eqrion.net at Wed, 22 May 2019 20:02:12 +0000
Bug 1525720, part 17 - Ignore nsIRemoteTab methods after we have destroyed the browser. r=nika It's possible for front-end references to nsIRemoteTab to outlive the IPDL actor. When this happens, we should ignore methods and property accesses. The one special case is that some code expects to be able to access the TabId after the browser has been destroyed. For this we can just cache the ID. Differential Revision: https://phabricator.services.mozilla.com/D31449
e65cb2d4c5a55e3049922df02af643337b7a58b2: Bug 1525720, part 16 - Cycle collect RemoteBrowser and support weak references in BrowserHost. r=nika
Ryan Hunt <rhunt@eqrion.net> - Tue, 14 May 2019 16:28:10 -0500 - rev 474969
Push 113182 by rhunt@eqrion.net at Wed, 22 May 2019 20:02:12 +0000
Bug 1525720, part 16 - Cycle collect RemoteBrowser and support weak references in BrowserHost. r=nika BrowserParent is cycle collected and supported weak references, so this commit adds support for these things to BrowserHost. Differential Revision: https://phabricator.services.mozilla.com/D31448
99f971a02d87941ee49a391de0e0626c170c0821: Bug 1525720, part 15 - Apply appropriate nsIRemoteTab methods to all BrowserParents. r=nika
Ryan Hunt <rhunt@eqrion.net> - Wed, 08 May 2019 16:12:26 -0500 - rev 474968
Push 113182 by rhunt@eqrion.net at Wed, 22 May 2019 20:02:12 +0000
Bug 1525720, part 15 - Apply appropriate nsIRemoteTab methods to all BrowserParents. r=nika This commit finally updates some nsIRemoteTab methods to apply to the whole tree of BrowserParent's. Differential Revision: https://phabricator.services.mozilla.com/D31447
d25963c72ff7981990660050182a82ea3e935f53: Bug 1525720, part 14 - Move final bits of nsIRemoteTab implementation to BrowserHost. r=nika
Ryan Hunt <rhunt@eqrion.net> - Wed, 08 May 2019 15:47:18 -0500 - rev 474967
Push 113182 by rhunt@eqrion.net at Wed, 22 May 2019 20:02:12 +0000
Bug 1525720, part 14 - Move final bits of nsIRemoteTab implementation to BrowserHost. r=nika This commit moves the actual implementation of nsIRemoteTab from BrowserParent to BrowserHost, without any functional changes. Differential Revision: https://phabricator.services.mozilla.com/D31445
810b7371987139844429d0206f9da6a7701a1efc: Bug 1525720, part 13 - Stop inheriting nsIRemoteTab interface in BrowserParent. r=nika
Ryan Hunt <rhunt@eqrion.net> - Wed, 08 May 2019 14:34:47 -0500 - rev 474966
Push 113182 by rhunt@eqrion.net at Wed, 22 May 2019 20:02:12 +0000
Bug 1525720, part 13 - Stop inheriting nsIRemoteTab interface in BrowserParent. r=nika This commit removes nsIRemoteTab as a parent class from BrowserParent, so that BrowserHost is the only concrete implementation of nsIRemoteTab. Some static_cast's are updated to cast to BrowserHost, and other places have to be updated to pass a BrowserHost instead of a BrowserParent. WindowGlobalParent had a getter to return it's managing BrowserParent as a nsIRemoteTab. I couldn't find a use of this in-tree, so I've just opt-ed to remove it. If there's a use-case, we can add something back in. Differential Revision: https://phabricator.services.mozilla.com/D31444
ee10a825448133635dbd933c3d60fe427400647b: Bug 1525720, part 12 - Make BrowserHost implement nsIRemoteTab by delegating to nsIRemoteTab. r=nika
Ryan Hunt <rhunt@eqrion.net> - Wed, 08 May 2019 11:45:23 -0500 - rev 474965
Push 113182 by rhunt@eqrion.net at Wed, 22 May 2019 20:02:12 +0000
Bug 1525720, part 12 - Make BrowserHost implement nsIRemoteTab by delegating to nsIRemoteTab. r=nika This commit implements nsIRemoteTab in BrowserHost by delegating to nsIRemoteTab. In a future commit, these methods will be implemented by BrowserHost. Differential Revision: https://phabricator.services.mozilla.com/D31443
1bcf9f586c5582ddeb822f4c2be3ca314694337e: Bug 1525720, part 11 - Use RemoteBrowser interface instead of IPDL actors in nsFrameLoader. r=nika
Ryan Hunt <rhunt@eqrion.net> - Mon, 06 May 2019 21:29:48 -0500 - rev 474964
Push 113182 by rhunt@eqrion.net at Wed, 22 May 2019 20:02:12 +0000
Bug 1525720, part 11 - Use RemoteBrowser interface instead of IPDL actors in nsFrameLoader. r=nika This commit replaces the direct use of the IPDL actors in nsFrameLoader with the RemoteBrowser interface. Some special use cases are adapted to still use the IPDL actors. In the future, we should burn these use cases down. Differential Revision: https://phabricator.services.mozilla.com/D31442
d3b2ac8d5ca4bd350603085c3cb9f6a51269e075: Bug 1525720, part 10 - Link BrowserParent and BrowserHost on creation. r=nika
Ryan Hunt <rhunt@eqrion.net> - Wed, 15 May 2019 10:34:03 -0500 - rev 474963
Push 113182 by rhunt@eqrion.net at Wed, 22 May 2019 20:02:12 +0000
Bug 1525720, part 10 - Link BrowserParent and BrowserHost on creation. r=nika This commit adds a link from BrowserParent to it's owning BrowserHost if it is the root BrowserParent. Differential Revision: https://phabricator.services.mozilla.com/D31441
697774dd89848fb992355abaae97bba35b8c74ba: Bug 1525720, part 9 - Fill out implementations of BrowserHost and BrowserBridgeHost. r=nika
Ryan Hunt <rhunt@eqrion.net> - Wed, 08 May 2019 11:27:49 -0500 - rev 474962
Push 113182 by rhunt@eqrion.net at Wed, 22 May 2019 20:02:12 +0000
Bug 1525720, part 9 - Fill out implementations of BrowserHost and BrowserBridgeHost. r=nika This commit implements the RemoteBrowser interface for BrowserHost and BrowserBridgeHost. For BrowserHost, most methods delegate to the root BrowserParent. In the future, we should move these over to BrowserHost. For BrowserBridgeHost, most methods are taken from BrowserBridgeParent. Differential Revision: https://phabricator.services.mozilla.com/D31439
eadeacbe44838a0db21d5f535fd14bfd62455a22: Bug 1525720, part 8 - Add RemoteBrowser interface and BrowserHost/BrowserBridgeHost implementations. r=nika
Ryan Hunt <rhunt@eqrion.net> - Mon, 06 May 2019 16:04:34 -0500 - rev 474961
Push 113182 by rhunt@eqrion.net at Wed, 22 May 2019 20:02:12 +0000
Bug 1525720, part 8 - Add RemoteBrowser interface and BrowserHost/BrowserBridgeHost implementations. r=nika RemoteBrowser is a common interface between the chrome/content process cases for nsFrameLoader, that allows us to abstract IPC details away. BrowserHost is a concrete implementation for the chrome process, while BrowserBridgeHost implements the content process case. Differential Revision: https://phabricator.services.mozilla.com/D31438
32eeee79d628dade8109454c636d5f8aaff0c93e: Bug 1525720, part 7 - Use getter methods to access mBrowserParent and mBrowserBridgeChild. r=farre
Ryan Hunt <rhunt@eqrion.net> - Thu, 25 Apr 2019 12:36:16 -0500 - rev 474960
Push 113182 by rhunt@eqrion.net at Wed, 22 May 2019 20:02:12 +0000
Bug 1525720, part 7 - Use getter methods to access mBrowserParent and mBrowserBridgeChild. r=farre This prepares nsFrameLoader for replacing mBrowserParent and mBrowserBridgeChild with a common interface by making special case code use a getter method instead of direct access. Differential Revision: https://phabricator.services.mozilla.com/D31437
07678a2fa9e7cb164b2d3b07b8c61653253b7540: Bug 1525720, part 6 - Move BrowserBridgeChild creation to ContentChild. r=farre
Ryan Hunt <rhunt@eqrion.net> - Wed, 24 Apr 2019 23:52:47 -0500 - rev 474959
Push 113182 by rhunt@eqrion.net at Wed, 22 May 2019 20:02:12 +0000
Bug 1525720, part 6 - Move BrowserBridgeChild creation to ContentChild. r=farre This makes it symmetrical to how BrowserParent is created by ContentParent. Differential Revision: https://phabricator.services.mozilla.com/D31436
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 tip