fd67a4332060ea5389d448b3453ea23064e50b5e: Merge mozilla-inbound to mozilla-central. a=merge
Daniel Varga <dvarga@mozilla.com> - Mon, 04 Mar 2019 11:37:31 +0200 - rev 462197
Push 112269 by dvarga@mozilla.com at Mon, 04 Mar 2019 09:43:27 +0000
Merge mozilla-inbound to mozilla-central. a=merge
8cdde0ff59a15f59736e810524a649a4c8a5a7ef: Bug 1531246: Support keyboard activation (space/enter) of the Downloads toolbar button when focused. r=Gijs
James Teh <jteh@mozilla.com> - Fri, 01 Mar 2019 12:00:45 +0000 - rev 462196
Push 112269 by dvarga@mozilla.com at Mon, 04 Mar 2019 09:43:27 +0000
Bug 1531246: Support keyboard activation (space/enter) of the Downloads toolbar button when focused. r=Gijs Depends on D21614 Differential Revision: https://phabricator.services.mozilla.com/D21615
fa59aea64e120e5be00269d062c2f04569278320: Bug 1515543: Support keyboard activation (space/enter) of toolbar overflow buttons when focused. r=Gijs
James Teh <jteh@mozilla.com> - Mon, 04 Mar 2019 06:48:43 +0000 - rev 462195
Push 112269 by dvarga@mozilla.com at Mon, 04 Mar 2019 09:43:27 +0000
Bug 1515543: Support keyboard activation (space/enter) of toolbar overflow buttons when focused. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D21614
76475dd4031be7f326f25d5bff12126365962002: Backed out changeset 458edf3460d4 (bug 1531930) for tidy bustage CLOSED TREE
Bogdan Tara <btara@mozilla.com> - Mon, 04 Mar 2019 05:58:40 +0200 - rev 462194
Push 112269 by dvarga@mozilla.com at Mon, 04 Mar 2019 09:43:27 +0000
Backed out changeset 458edf3460d4 (bug 1531930) for tidy bustage CLOSED TREE
458edf3460d42b50405db25edded051f94532cb3: Bug 1531930 - Interneration refactoring r=gw
Dzmitry Malyshau <dmalyshau@mozilla.com> - Sun, 03 Mar 2019 21:14:49 +0000 - rev 462193
Push 112269 by dvarga@mozilla.com at Mon, 04 Mar 2019 09:43:27 +0000
Bug 1531930 - Interneration refactoring r=gw Remove the intern_types module in favor of the associated Internable types that we already have. The only bit of magic I had to do is around serialization bounds, and it's nicely isolated. Differential Revision: https://phabricator.services.mozilla.com/D21797
d75868102ceaeb949d2bbd50c3067acd97dae217: Bug 1526475 - Add file logging to the updater r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Mon, 04 Mar 2019 01:36:49 +0000 - rev 462192
Push 112269 by dvarga@mozilla.com at Mon, 04 Mar 2019 09:43:27 +0000
Bug 1526475 - Add file logging to the updater r=rstrong File logging can be turned on by setting `app.update.log.file=true`. It will log update messages that would normally go to the browser console (assuming `app.update.log==true`) to a file in the user profile directory called "update_messages.log". File logging will last for a single Firefox session only before it automatically disables itself. The goal of this is to make it easier to get troubleshooting/debugging information from users that might complain of update problems. This will be especially important when upcoming changes are made to the update mechanism. Differential Revision: https://phabricator.services.mozilla.com/D19422
5bb743ffae8c391c6481936bbc5d0b26489e4430: Bug 1530177 - Downgrade an assertion to a diagnostic assert since it exposes pre-existing bugs. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 28 Feb 2019 23:37:44 +0000 - rev 462191
Push 112269 by dvarga@mozilla.com at Mon, 04 Mar 2019 09:43:27 +0000
Bug 1530177 - Downgrade an assertion to a diagnostic assert since it exposes pre-existing bugs. r=dholbert nsIconChannel (for moz-icon:// images) is unsound, see bug 1438939. nsMenuPopupFrame::Init is also unsound on mac, looks like... I'll try to get them fixed on trunk, but it's not worth crashing release for this IMO, given it's pre-existing. The assert in PresShell::~PresShell hopefully avoids exploitable issues. Differential Revision: https://phabricator.services.mozilla.com/D20945
23359968e785bf0a57c5f0d3d373384d12a27e60: Bug 1528635 - Check urlExtraReferrer not null before dereference to avoid crash r=longsonr
violet <violet.bugreport@gmail.com> - Sun, 03 Mar 2019 19:35:42 +0000 - rev 462190
Push 112269 by dvarga@mozilla.com at Mon, 04 Mar 2019 09:43:27 +0000
Bug 1528635 - Check urlExtraReferrer not null before dereference to avoid crash r=longsonr urlExtraReferrer could be null, we should check before dereference. Otherwise it will cause crash when webrender is enabled by gfx.webrender.enabled=true and gfx.webrender.all=true, Differential Revision: https://phabricator.services.mozilla.com/D20805
deb832a494bb9930a617fb08629f6f07bade9dab: Bug 1466208 - part 28: Make PresShell::EventHandler::HandleEvent() handle non-using-coordinates events without frame before with frame case r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Sat, 02 Mar 2019 20:35:21 +0000 - rev 462189
Push 112269 by dvarga@mozilla.com at Mon, 04 Mar 2019 09:43:27 +0000
Bug 1466208 - part 28: Make PresShell::EventHandler::HandleEvent() handle non-using-coordinates events without frame before with frame case r=smaug When the event is not handled with coordinates and there is no frame for `mPresShell`, `PresShell::EventHandler::HandleEvent()` handles the events simpler than the case there is a frame. Therefore, this patch moves the `else` block of `if (aFrame)` and reduce the indent of `if (aFrame)` case. Differential Revision: https://phabricator.services.mozilla.com/D21194
ab0fd75fd14200dc24e08d6c5b67e044c09bd59f: Bug 1531540 - Don't specialise SubChunkLimit for mobile r=sfink
Paul Bone <pbone@mozilla.com> - Fri, 01 Mar 2019 17:53:38 +0000 - rev 462188
Push 112269 by dvarga@mozilla.com at Mon, 04 Mar 2019 09:43:27 +0000
Bug 1531540 - Don't specialise SubChunkLimit for mobile r=sfink This was specialised so that it wouldn't crash on mobile wouldn't crash when: SubChunkLimit + SubChunkStepstep > NurseryChunkUsableSize becase NurseryChunkUsableSize is smaller on mobile. However Bug 1530575 reduced the value of SubChunkStep so now we no-longer need to specialise SubChunkLimit. We never tested the impact of SubChunkLimit on mobile so it's just simpler to have one value. Differential Revision: https://phabricator.services.mozilla.com/D21645
f9fb3fea307246f272cce497d34e818f060b5515: Merge mozilla-central to autoland. a=merge CLOSED TREE
Gurzau Raul <rgurzau@mozilla.com> - Mon, 04 Mar 2019 00:09:40 +0200 - rev 462187
Push 112269 by dvarga@mozilla.com at Mon, 04 Mar 2019 09:43:27 +0000
Merge mozilla-central to autoland. a=merge CLOSED TREE
eb002115d6be1e8a06b3f97c717b90a55e39c441: Bug 1532110 handle homepage/newtab when extension settings is not initialized r=rpl
Shane Caraveo <scaraveo@mozilla.com> - Sun, 03 Mar 2019 20:20:53 +0000 - rev 462186
Push 112269 by dvarga@mozilla.com at Mon, 04 Mar 2019 09:43:27 +0000
Bug 1532110 handle homepage/newtab when extension settings is not initialized r=rpl If no extension controls the settings, ExtensionSettings may not be initialized on startup. Fall back to the defaults in that case. Differential Revision: https://phabricator.services.mozilla.com/D21866
390f162b7d9b04c1c0337aac1149303daad52e02: Bug 1495985 - Restart input method to remove composition on some IMEs. r=geckoview-reviewers,esawin
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Thu, 21 Feb 2019 17:27:07 +0900 - rev 462185
Push 112268 by m_kato@ga2.so-net.ne.jp at Mon, 04 Mar 2019 04:07:52 +0000
Bug 1495985 - Restart input method to remove composition on some IMEs. r=geckoview-reviewers,esawin When removing composing text, we call `InputMethodManager.updateSelection(start, end, -1, -1)`. But ATOK (Japanese input method by Justsystem) series do nothing. So, shadow text and current text becomes mismatched. As workaround, we need call `restartInput` to remove composing text if using ATOK series. According to ATOK team, ATOK has several packages name since they release several customize version. - `com.justsystems.atokmobile.*` (ATOK, ATOK subscription and etc) - `com.atok.mobile.*` (OEM version) Differential Revision: https://phabricator.services.mozilla.com/D20632
0d261741c46150c46144dd5ef382d57e40e45279: Merge inbound to mozilla-central. a=merge
Gurzau Raul <rgurzau@mozilla.com> - Sun, 03 Mar 2019 23:57:22 +0200 - rev 462184
Push 112267 by rgurzau@mozilla.com at Sun, 03 Mar 2019 22:12:55 +0000
Merge inbound to mozilla-central. a=merge
325cacd860797a527eddfb6652984169a3882523: Bug 1529230 - Drop bracket for IPv6 URL in mDomain of MatchPattern. r=robwu,mixedpuppy
violet <violet.bugreport@gmail.com> - Sat, 02 Mar 2019 13:20:10 +0000 - rev 462183
Push 112267 by rgurzau@mozilla.com at Sun, 03 Mar 2019 22:12:55 +0000
Bug 1529230 - Drop bracket for IPv6 URL in mDomain of MatchPattern. r=robwu,mixedpuppy mDomain in MatchPattern is inconsistent with nsIURI for IPv6 URL, which causes failure of IPv6 matching. We normalize mDomain by droping the brackets so that it's consistent with nsIURI. Differential Revision: https://phabricator.services.mozilla.com/D20603
9506816277411c422b23f1b74b2e058dda615d6d: Bug 1532134 - Remove Options from TransformOperation. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 03 Mar 2019 11:31:54 +0000 - rev 462182
Push 112267 by rgurzau@mozilla.com at Sun, 03 Mar 2019 22:12:55 +0000
Bug 1532134 - Remove Options from TransformOperation. r=xidorn This may or may not be part of the plan to get rid of nsCSSValue ;) Option is not usable via FFI, and they should not be needed (we should be following the shortest serialization principle instead). These patches also do that, which matches the other transform properties. I think that slight change is fine, if we can make it work, and consistent with other properties. Alternative is adding more TransformOperation variants or such, which I rather not do. Differential Revision: https://phabricator.services.mozilla.com/D21862
2b811ffbed9b8b4c71092e90cbb11201c8d9a7c6: Bug 1532134 - Use contextual_skip_if for background-size. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 03 Mar 2019 11:31:40 +0000 - rev 462181
Push 112267 by rgurzau@mozilla.com at Sun, 03 Mar 2019 22:12:55 +0000
Bug 1532134 - Use contextual_skip_if for background-size. r=xidorn Also drive-by cleanup. Differential Revision: https://phabricator.services.mozilla.com/D21861
5a4a2f2465b0142e901d52f1850c2fc1a6e0cc6b: Bug 1532134 - Use skip_if for translate serialization. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 03 Mar 2019 11:31:30 +0000 - rev 462180
Push 112267 by rgurzau@mozilla.com at Sun, 03 Mar 2019 22:12:55 +0000
Bug 1532134 - Use skip_if for translate serialization. r=xidorn Trivial drive-by cleanup. Differential Revision: https://phabricator.services.mozilla.com/D21860
7aa72a6aa1b501c6f7a0efc7a4a4ea14d15f0030: Bug 1532134 - When deriving something with an output type, map preconditions as well. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 03 Mar 2019 11:31:21 +0000 - rev 462179
Push 112267 by rgurzau@mozilla.com at Sun, 03 Mar 2019 22:12:55 +0000
Bug 1532134 - When deriving something with an output type, map preconditions as well. r=xidorn Otherwise, deriving ToComputedValue and ToAnimatedValue in structs or enums with other where clauses just doesn't work. Differential Revision: https://phabricator.services.mozilla.com/D21859
b5dec9e96f42cd166b4cdaf70b6765be34454aae: Bug 1532134 - Implement a version of #[css(skip_if)] that takes more context. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 03 Mar 2019 11:31:06 +0000 - rev 462178
Push 112267 by rgurzau@mozilla.com at Sun, 03 Mar 2019 22:12:55 +0000
Bug 1532134 - Implement a version of #[css(skip_if)] that takes more context. r=xidorn I called it contextual_skip_if, though better names welcome. Differential Revision: https://phabricator.services.mozilla.com/D21858
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip