f24a18bffbc70de57437b69fcd9e36734d252199: Bug 1404422 - Part 4. Remove imgIOnloadBlocker and related from tree as redundant. r=tnikkel
Andrew Osmond <aosmond@mozilla.com> - Wed, 01 Nov 2017 06:59:10 -0400 - rev 389546
Push 96868 by aosmond@gmail.com at Wed, 01 Nov 2017 10:59:36 +0000
Bug 1404422 - Part 4. Remove imgIOnloadBlocker and related from tree as redundant. r=tnikkel
5c766b0509d52fd217c00596af227a1758c73370: Bug 1404422 - Part 3. Disable triggering imgIOnloadBlocker block/unblock events. r=tnikkel
Andrew Osmond <aosmond@mozilla.com> - Wed, 01 Nov 2017 06:59:10 -0400 - rev 389545
Push 96868 by aosmond@gmail.com at Wed, 01 Nov 2017 10:59:36 +0000
Bug 1404422 - Part 3. Disable triggering imgIOnloadBlocker block/unblock events. r=tnikkel
1a1bcb63456d28348616e19782a635159f6347e0: Bug 1404422 - Part 2. Make chrome test ignore generic, unrelated chrome URLs from events. r=tnikkel
Andrew Osmond <aosmond@mozilla.com> - Wed, 01 Nov 2017 06:59:10 -0400 - rev 389544
Push 96868 by aosmond@gmail.com at Wed, 01 Nov 2017 10:59:36 +0000
Bug 1404422 - Part 2. Make chrome test ignore generic, unrelated chrome URLs from events. r=tnikkel
fe1b72af47407a2d5cbb2198d55521738d43994d: Bug 1404422 - Part 1d. Ensure imgRequestProxy::PerformClone consistently adds the clone to the expected load group. r=tnikkel
Andrew Osmond <aosmond@mozilla.com> - Wed, 01 Nov 2017 06:59:10 -0400 - rev 389543
Push 96868 by aosmond@gmail.com at Wed, 01 Nov 2017 10:59:36 +0000
Bug 1404422 - Part 1d. Ensure imgRequestProxy::PerformClone consistently adds the clone to the expected load group. r=tnikkel Historically imgRequestProxy::PerformClone would only add the cloned request to the (original proxy's) document's load group if the request was still being validated. Now it adds the cloned request to the given document's load group before requesting the notifications, unless the request has already been completed. We ensure that any removals from the load group occur outside the current execution context. Legacy listeners may use imgRequestProxy::SyncClone to request notifications on the image state. Ideally they would not, but they do not work as expected with the asynchronous notifications all new callers must use. While in theory this would suggest their code is re-entrant, not all of it is. In particular we need to be sensitive about when we remove a request from a load group.
1b420c5a7b11eaf2fa1849f90769659f5146a8e9: Bug 1404422 - Part 1c. Refactor how an imgRequestProxy is added/removed from its load group. r=tnikkel
Andrew Osmond <aosmond@mozilla.com> - Wed, 01 Nov 2017 06:59:10 -0400 - rev 389542
Push 96868 by aosmond@gmail.com at Wed, 01 Nov 2017 10:59:36 +0000
Bug 1404422 - Part 1c. Refactor how an imgRequestProxy is added/removed from its load group. r=tnikkel There should be no functional change here, but we rely upon the new structure in the next patch in the series. This separates out the notions of removing a request from the load group (which is always final, and must be executed outside of synchronous calls from the owner of the imgRequestProxy) and wanting to readd a request to the load group as a background request (for multipart images). The most important addition is mForceDispatchLoadGroup which if true when imgRequestProxy::RemoveFromLoadGroup is called, will dispatch the removal from the load group instead of executing it inline. This ensures safety for any callers (e.g. to CancelAndForgetObserver) as above.
a943db5eaa646573e38426a18d059ffd956bd3e7: Bug 1404422 - Part 1b. Make imgRequestProxy::SetLoadGroup return an error if changing the load group. r=tnikkel
Andrew Osmond <aosmond@mozilla.com> - Wed, 01 Nov 2017 06:59:09 -0400 - rev 389541
Push 96868 by aosmond@gmail.com at Wed, 01 Nov 2017 10:59:36 +0000
Bug 1404422 - Part 1b. Make imgRequestProxy::SetLoadGroup return an error if changing the load group. r=tnikkel imgRequestProxy::SetLoadGroup did not have a predictable effect and it appears to be unused. It is somewhat complicated to support given we must be sensitive about what context we execute removing the request from the original load group.
442e399f7cb68da5e76f58ff4882f862085d16e9: Bug 1404422 - Part 1a. Ensure imgLoader::LoadImage(WithChannel) adds the request to the expected load group. r=tnikkel
Andrew Osmond <aosmond@mozilla.com> - Wed, 01 Nov 2017 06:59:09 -0400 - rev 389540
Push 96868 by aosmond@gmail.com at Wed, 01 Nov 2017 10:59:36 +0000
Bug 1404422 - Part 1a. Ensure imgLoader::LoadImage(WithChannel) adds the request to the expected load group. r=tnikkel imgLoader::LoadImage now asserts in debug builds that the load group given as a parameter matches that of the given document (if any). If they mismatch, then we won't be blocking the document's load event as we expect with the future removal of the imgIOnloadBlocker. imgLoader::LoadImageWithChannel never actually added the request to the load group at all, unless it was done as part of the validator. Now it will consistently add the request to the channel's load group as expected. Additionally it also asserts in debug builds that the channel's load group matches that of the given document, as in LoadImage.
19d68ad55452ab72ff9662e3ac778f5aaac751a5: Bug 1394831 part 9 - Remove allowDictionary argument from addAccessorProperty. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Wed, 01 Nov 2017 11:40:17 +0100 - rev 389539
Push 96867 by jandemooij@gmail.com at Wed, 01 Nov 2017 10:41:02 +0000
Bug 1394831 part 9 - Remove allowDictionary argument from addAccessorProperty. r=bhackett
444453765199fc52a86a1d44832f893a02e7ff80: Bug 1394831 part 8 - Remove flags argument from addAccessorProperty. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Wed, 01 Nov 2017 11:39:52 +0100 - rev 389538
Push 96867 by jandemooij@gmail.com at Wed, 01 Nov 2017 10:41:02 +0000
Bug 1394831 part 8 - Remove flags argument from addAccessorProperty. r=bhackett
706c6d3891116441afca9d9a762a1dea20424883: Bug 1394831 part 7 - Remove flags and allowDictionary arguments from addDataProperty. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Wed, 01 Nov 2017 11:39:22 +0100 - rev 389537
Push 96867 by jandemooij@gmail.com at Wed, 01 Nov 2017 10:41:02 +0000
Bug 1394831 part 7 - Remove flags and allowDictionary arguments from addDataProperty. r=bhackett
88bfd12dc09931dcda7d143e06a7314fe3480176: Bug 1394831 part 6 - Remove flags argument from putAccessorProperty. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Wed, 01 Nov 2017 11:38:58 +0100 - rev 389536
Push 96867 by jandemooij@gmail.com at Wed, 01 Nov 2017 10:41:02 +0000
Bug 1394831 part 6 - Remove flags argument from putAccessorProperty. r=bhackett
70623eaf6ab0b353d6506a21b8dc027e90bd3e28: Merge mozilla-central to mozilla-inbound. r=merge a=merge on a CLOSED TREE
Csoregi Natalia <ncsoregi@mozilla.com> - Wed, 01 Nov 2017 12:26:00 +0200 - rev 389535
Push 96866 by ncsoregi@mozilla.com at Wed, 01 Nov 2017 10:29:43 +0000
Merge mozilla-central to mozilla-inbound. r=merge a=merge on a CLOSED TREE
cd7217cf05a2332a8fd7b498767a07b2c31ea657: Merge inbound to mozilla-central r=merge a=merge
Csoregi Natalia <ncsoregi@mozilla.com> - Wed, 01 Nov 2017 12:14:00 +0200 - rev 389534
Push 96866 by ncsoregi@mozilla.com at Wed, 01 Nov 2017 10:29:43 +0000
Merge inbound to mozilla-central r=merge a=merge
7651a53b3faf36d9f76202eab9f1338b9d839c72: Backed out changeset fdebe274e971 (bug 1413092) for failures in test_mozbuild_reading.py
Phil Ringnalda <philringnalda@gmail.com> - Tue, 31 Oct 2017 20:27:48 -0700 - rev 389533
Push 96866 by ncsoregi@mozilla.com at Wed, 01 Nov 2017 10:29:43 +0000
Backed out changeset fdebe274e971 (bug 1413092) for failures in test_mozbuild_reading.py CLOSED TREE MozReview-Commit-ID: JA9UPvYmWMF
9ee7c95489827c94babf15c0d4886957c1c44dac: Backed out changeset 83a7ad25941e (bug 1412437) for robocop testAccessibleCarets bustage
Phil Ringnalda <philringnalda@gmail.com> - Tue, 31 Oct 2017 20:07:15 -0700 - rev 389532
Push 96866 by ncsoregi@mozilla.com at Wed, 01 Nov 2017 10:29:43 +0000
Backed out changeset 83a7ad25941e (bug 1412437) for robocop testAccessibleCarets bustage CLOSED TREE MozReview-Commit-ID: Lg1GSdLDyin
e626359954d05c43899c71f77cbb4f4655f52d72: Backed out 4 changesets (bug 1402284) for build bustage
Phil Ringnalda <philringnalda@gmail.com> - Tue, 31 Oct 2017 20:06:26 -0700 - rev 389531
Push 96866 by ncsoregi@mozilla.com at Wed, 01 Nov 2017 10:29:43 +0000
Backed out 4 changesets (bug 1402284) for build bustage CLOSED TREE Backed out changeset f894ea204bb4 (bug 1402284) Backed out changeset a0c193d65799 (bug 1402284) Backed out changeset 8f83dc111aed (bug 1402284) Backed out changeset 7b7818155442 (bug 1402284) MozReview-Commit-ID: DNthJ588QYa
fdebe274e9713dc87f2e9b8a165d78e1001a9231: Bug 1413092 - Cleanup and move formValidation b-c tests. r=Felipe
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Mon, 30 Oct 2017 22:12:35 -0700 - rev 389530
Push 96866 by ncsoregi@mozilla.com at Wed, 01 Nov 2017 10:29:43 +0000
Bug 1413092 - Cleanup and move formValidation b-c tests. r=Felipe MozReview-Commit-ID: 9lVE2ulrtV7
f894ea204bb4cc71a1f060b3085259a2a2ca5b13: Bug 1402284 - Separate arenas created from moz_arena_* functions from others. r=njn
Mike Hommey <mh+mozilla@glandium.org> - Tue, 31 Oct 2017 07:13:39 +0900 - rev 389529
Push 96866 by ncsoregi@mozilla.com at Wed, 01 Nov 2017 10:29:43 +0000
Bug 1402284 - Separate arenas created from moz_arena_* functions from others. r=njn We introduce the notion of private arenas, separate from other arenas (main and thread-local). They are kept in a separate arena tree, and arena lookups from moz_arena_* functions only access the tree of private arenas. Iteration still goes through all arenas, private and non-private.
a0c193d657995a58caacf88f9bf557eb6544f1c5: Bug 1402284 - Move arena tree related globals to a static singleton of a new class. r=njn
Mike Hommey <mh+mozilla@glandium.org> - Sat, 28 Oct 2017 07:13:58 +0900 - rev 389528
Push 96866 by ncsoregi@mozilla.com at Wed, 01 Nov 2017 10:29:43 +0000
Bug 1402284 - Move arena tree related globals to a static singleton of a new class. r=njn We create the ArenaCollection class to handle operations on the arena tree. Ideally, iter() would trigger locking, but the prefork/postfork code complicates things, so we leave this for later.
8f83dc111aed677458289f6df71e055be55c5b99: Bug 1402284 - Initialize arena_t objects via a constructor instead of manually with an Init method. r=njn
Mike Hommey <mh+mozilla@glandium.org> - Sat, 28 Oct 2017 08:42:59 +0900 - rev 389527
Push 96866 by ncsoregi@mozilla.com at Wed, 01 Nov 2017 10:29:43 +0000
Bug 1402284 - Initialize arena_t objects via a constructor instead of manually with an Init method. r=njn Note we use the deprecated `new (fallible_t())` form because using `new (fallible)` would require some figuring out for non-Firefox builds (e.g. standalone js).
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip