e81f8c1e38fbcd3763bf0bb87f17133ddf36d8b4: merge fx-team to mozilla-central a=merge
Carsten "Tomcat" Book <cbook@mozilla.com> - Tue, 20 Sep 2016 12:00:36 +0200 - rev 314509
Push
81903 by cbook@mozilla.com at Tue, 20 Sep 2016 10:04:26 +0000
merge fx-team to mozilla-central a=merge
270611a85c6f0a0bdcd3dcad732f2e98da61206c: Bug 1303862 - update new debugger frontend (9/19/2016) r=me
James Long <longster@gmail.com> - Mon, 19 Sep 2016 21:58:05 -0400 - rev 314508
Push
81903 by cbook@mozilla.com at Tue, 20 Sep 2016 10:04:26 +0000
Bug 1303862 - update new debugger frontend (9/19/2016) r=me
671c2af548b204f1d28bfb3f69beee5931aa12b2: Merge m-c to fx-team, a=merge
Wes Kocher <wkocher@mozilla.com> - Mon, 19 Sep 2016 15:56:52 -0700 - rev 314507
Push
81903 by cbook@mozilla.com at Tue, 20 Sep 2016 10:04:26 +0000
Merge m-c to fx-team, a=merge
d00cd0cd33e660837abc9c025153ec8fd2b267a3: Bug 1303468 - Follow-up: Unbust Gradle lint. r=me
Nick Alexander <nalexander@mozilla.com> - Mon, 19 Sep 2016 14:54:24 -0700 - rev 314506
Push
81903 by cbook@mozilla.com at Tue, 20 Sep 2016 10:04:26 +0000
Bug 1303468 - Follow-up: Unbust Gradle lint. r=me
MozReview-Commit-ID: IWB0CMVuNPr
6105bfa46e9a23c16dc51b75507680f8e3268607: Bug 1303468 - Follow-up: Unbust Gradle builds. r=me
Nick Alexander <nalexander@mozilla.com> - Mon, 19 Sep 2016 14:24:13 -0700 - rev 314505
Push
81903 by cbook@mozilla.com at Tue, 20 Sep 2016 10:04:26 +0000
Bug 1303468 - Follow-up: Unbust Gradle builds. r=me
MozReview-Commit-ID: IbqnIC4L83A
690b85efea256f02bb46f032397257aa7b99de3a: Bug 1276418 - Remove getNode and all references to it in inspector tests; r=gl
Patrick Brosset <pbrosset@mozilla.com> - Fri, 16 Sep 2016 15:58:50 +0200 - rev 314504
Push
81903 by cbook@mozilla.com at Tue, 20 Sep 2016 10:04:26 +0000
Bug 1276418 - Remove getNode and all references to it in inspector tests; r=gl
MozReview-Commit-ID: HIhOHZvtUl
d5f96835f8355a672c0fa75d2980af22af02ebb3: Bug 1303468 - Part 2: Move Fennec- and Gradle-specific file back to base/. r=jchen
Nick Alexander <nalexander@mozilla.com> - Fri, 16 Sep 2016 15:55:01 -0700 - rev 314503
Push
81903 by cbook@mozilla.com at Tue, 20 Sep 2016 10:04:26 +0000
Bug 1303468 - Part 2: Move Fennec- and Gradle-specific file back to base/. r=jchen
This is only there to silence the linter.
MozReview-Commit-ID: 8zEDsrbjyeo
49a5ddfbe8a5273e2872d3072497bfa2df6a5ca6: Bug 1303468 - Part 1: Move more things into GeckoView. r=jchen
Nick Alexander <nalexander@mozilla.com> - Fri, 16 Sep 2016 15:53:39 -0700 - rev 314502
Push
81903 by cbook@mozilla.com at Tue, 20 Sep 2016 10:04:26 +0000
Bug 1303468 - Part 1: Move more things into GeckoView. r=jchen
MozReview-Commit-ID: CEjyq0TFn6j
2af2eaac5b485f3c88874439759bd1620deb3d80: Bug 1302040 - don't enter buffering while prerolling. r=cpearce
JW Wang <jwwang@mozilla.com> - Mon, 12 Sep 2016 15:45:36 +0800 - rev 314501
Push
81903 by cbook@mozilla.com at Tue, 20 Sep 2016 10:04:26 +0000
Bug 1302040 - don't enter buffering while prerolling. r=cpearce
MozReview-Commit-ID: Br9wC8PNorA
e1bf663363fd84b7c7c9f3c08bc22bce4874dede: Bug 1302006. Part 4 - Let StateObject handle dormant request. r=kikuo
JW Wang <jwwang@mozilla.com> - Mon, 12 Sep 2016 10:49:46 +0800 - rev 314500
Push
81903 by cbook@mozilla.com at Tue, 20 Sep 2016 10:04:26 +0000
Bug 1302006. Part 4 - Let StateObject handle dormant request. r=kikuo
MozReview-Commit-ID: FK3UwbYDexV
c12f64bf259899d61108e556ac7bd437cd1d03d7: Bug 1302006. Part 3 - Let SeekingState handle dormant request. r=kikuo
JW Wang <jwwang@mozilla.com> - Mon, 12 Sep 2016 10:41:20 +0800 - rev 314499
Push
81903 by cbook@mozilla.com at Tue, 20 Sep 2016 10:04:26 +0000
Bug 1302006. Part 3 - Let SeekingState handle dormant request. r=kikuo
MozReview-Commit-ID: ADVsUSpE8Az
66359c23a6b6f49aeba4f6e88d9b53cc0a189a3d: Bug 1302006. Part 2 - Let ShutdownState handle dormant request. r=kikuo
JW Wang <jwwang@mozilla.com> - Mon, 12 Sep 2016 10:34:35 +0800 - rev 314498
Push
81903 by cbook@mozilla.com at Tue, 20 Sep 2016 10:04:26 +0000
Bug 1302006. Part 2 - Let ShutdownState handle dormant request. r=kikuo
MozReview-Commit-ID: 1uw7YjQps0i
7fb80e9897fa529df5925279623576fde86c195b: Bug 1302006. Part 1 - Let DormantState handle dormant request. r=kikuo
JW Wang <jwwang@mozilla.com> - Tue, 06 Sep 2016 15:15:48 +0800 - rev 314497
Push
81903 by cbook@mozilla.com at Tue, 20 Sep 2016 10:04:26 +0000
Bug 1302006. Part 1 - Let DormantState handle dormant request. r=kikuo
MozReview-Commit-ID: 8JqqAnlXzh4
2db6d45d00706912f8671d485f3bc3fcd64e0ac3: Bug 1303920 - Update stylo reftest list; r=heycam
Manish Goregaokar <manishsmail@gmail.com> - Mon, 19 Sep 2016 20:20:03 +0530 - rev 314496
Push
81903 by cbook@mozilla.com at Tue, 20 Sep 2016 10:04:26 +0000
Bug 1303920 - Update stylo reftest list; r=heycam
MozReview-Commit-ID: 6fKFLbTL2gW
5dc379423bd6bcce41dfed874a5ffc127cde1de4: Bug 1288909, part 4 - Use a strong reference to the set in ClassInfo2NativeSetMap. r=billm
Andrew McCreight <continuation@gmail.com> - Tue, 06 Sep 2016 12:58:27 -0700 - rev 314495
Push
81903 by cbook@mozilla.com at Tue, 20 Sep 2016 10:04:26 +0000
Bug 1288909, part 4 - Use a strong reference to the set in ClassInfo2NativeSetMap. r=billm
Entries should end up getting cleared out from this table before the
value dies, so let's just make the reference strong so that any
mistakes will result in leaks and not use-after-frees.
Using smart pointer classes with PLDHashtable is a little
questionable, and I don't want to convert this one hash table to
nsTHashtable, so I use manual addref and release.
MozReview-Commit-ID: Kfg9veS6r11
862e46017481f434ade36618444f7eb94ac13558: Bug 1288909, part 3 - XPCWrappedNative:: and XPCWrappedNativeProto::Mark() don't do anything any more. r=billm
Andrew McCreight <continuation@gmail.com> - Fri, 05 Aug 2016 13:56:14 -0700 - rev 314494
Push
81903 by cbook@mozilla.com at Tue, 20 Sep 2016 10:04:26 +0000
Bug 1288909, part 3 - XPCWrappedNative:: and XPCWrappedNativeProto::Mark() don't do anything any more. r=billm
Also clean up some random comments for code that was deleted earlier.
MozReview-Commit-ID: 8JQx0FAH8wA
8dd979e76e1c4a73690a7f5636c769c51a30c0b4: Bug 1288909, part 2 - Remove a bunch of now-useless XPCNativeSet marking-related things. r=billm
Andrew McCreight <continuation@gmail.com> - Wed, 27 Jul 2016 16:38:42 -0700 - rev 314493
Push
81903 by cbook@mozilla.com at Tue, 20 Sep 2016 10:04:26 +0000
Bug 1288909, part 2 - Remove a bunch of now-useless XPCNativeSet marking-related things. r=billm
MozReview-Commit-ID: 4YRn9Wx64a4
9769cc42f54995f1d087200259ad3464be881a2c: Bug 1288909, part 1 - Implement refcounting of XPCNativeSet. r=billm
Andrew McCreight <continuation@gmail.com> - Wed, 27 Jul 2016 16:38:30 -0700 - rev 314492
Push
81903 by cbook@mozilla.com at Tue, 20 Sep 2016 10:04:26 +0000
Bug 1288909, part 1 - Implement refcounting of XPCNativeSet. r=billm
This patch is similar to
bug 1288870.
Strong references:
- XPCCallContext::mSet: Like XPCNativeInterface, this only roots it
when |mState >= HAVE_NAME|, and again this only requires changing
SystemIsBeingShutDown().
- XPCWrappedNativeProto::mSet and XPCWrappedNative::mSet. These become
RefPtrs.
- stack: AutoMarkingNativeSetPtr become RefPtr<XPCNativeSet>. This
lets me eliminate some uses of AutoJSContext. This is the bulk of the
patch.
Weak references:
- mNativeSetMap. This reference gets cleared in the dtor. This
requires
bug 1290239 to actually find the entry for removal.
- mClassInfo2NativeSetMap. The reference is in the value for this hash
table, and we don't have the key in the set dtor. Fortunately, the
only code that adds to this table is
XPCNativeSet::GetNewOrUsed(nsIClassInfo* classInfo), which in turn is
only called by GetNewOrUsed(nsIClassInfo* classInfo). This code
creates a new XPCWrappedNativeProto, which (with my patch) holds a
strong reference to the set that has been added to the table. This set
is never changed or released until the dtor for the proto, which calls
ClearCacheEntryForClassInfo(), removing the entry from the
hashtable. Thus, the lifetime of the set is always going to be longer
than the lifetime of the entry.
Other notes:
- Like XPCNativeInterface, this class uses placement |new| that
requires a special destruction function, which with my patch is hidden
away in the refcounting code.
- This patch delete a bunch of marking/sweeping code from
XPCJSRuntime::FinalizeCallback(), because the lifetimes are managed by
the refcounting now. Some of the marking code is left behind to be
cleaned up in a later patch.
- I didn't see any methods that had XPCNativeSet** outparams.
- MOZ_COUNT_{CTOR,DTOR}(XPCNativeSet) is not needed because it is now
refcounted.
MozReview-Commit-ID: 7oTorCwda1n
ff28b15107631c762ed5db714c8310260343bd27: Bug 888781 part 2 - Scale cursor with the window scale on Windows. r=jimm
Xidorn Quan <me@upsuper.org> - Mon, 19 Sep 2016 10:35:48 +1000 - rev 314491
Push
81903 by cbook@mozilla.com at Tue, 20 Sep 2016 10:04:26 +0000
Bug 888781 part 2 - Scale cursor with the window scale on Windows. r=jimm
MozReview-Commit-ID: C9LZpJF98mQ
b4a82f0cb935511ecb6ea1ff51b4a733db77d5fa: Bug 888781 part 1 - Use cached default scale in GetDefaultScaleInternal of Windows. r=jimm
Xidorn Quan <me@upsuper.org> - Mon, 19 Sep 2016 10:35:12 +1000 - rev 314490
Push
81903 by cbook@mozilla.com at Tue, 20 Sep 2016 10:04:26 +0000
Bug 888781 part 1 - Use cached default scale in GetDefaultScaleInternal of Windows. r=jimm
MozReview-Commit-ID: Ebm7h3h2mrg