e74bd1eae0db0f0b9e13c199a8ef304375b3b0cc: Bug 1488174 - Use UpdateServiceHelper to decide on whether to add Updater notification channel. r=jchen
Jan Henning <jh+bugzilla@buttercookie.de> - Fri, 07 Sep 2018 07:12:50 +0000 - rev 435244
Push 107609 by dvarga@mozilla.com at Fri, 07 Sep 2018 22:22:21 +0000
Bug 1488174 - Use UpdateServiceHelper to decide on whether to add Updater notification channel. r=jchen That way, we only add that notification channel if the updater really is active, i.e. not if we've been installed from the Play Store. Unfortunately, using the UpdateServiceHelper requires a Context, so adding/re- moving the UPDATER_CHANNEL_TAG cannot be done during variable initialisation. Differential Revision: https://phabricator.services.mozilla.com/D4890
ac058fbbed8c8999b655b1eb3b4cc4475c940c29: Bug 1488938 - Round two: migrate mochitest-browser tests to use element variations of firstChild, etc;r=Gijs
Brian Grinstead <bgrinstead@mozilla.com> - Fri, 07 Sep 2018 15:31:38 +0000 - rev 435243
Push 107609 by dvarga@mozilla.com at Fri, 07 Sep 2018 22:22:21 +0000
Bug 1488938 - Round two: migrate mochitest-browser tests to use element variations of firstChild, etc;r=Gijs This is a follow up to Bug 1482667. The list of callers was gathered by instrumenting the webidl calls to these methods and dumping JS stack when they are called in browser.xul. Differential Revision: https://phabricator.services.mozilla.com/D5185
e8936414659b3c7557ca8ecddbac217f1297ad93: Bug 1488938 - Migrate two more nextSibling/previousSibling callers to use element variation;r=Gijs
Brian Grinstead <bgrinstead@mozilla.com> - Fri, 07 Sep 2018 15:31:35 +0000 - rev 435242
Push 107609 by dvarga@mozilla.com at Fri, 07 Sep 2018 22:22:21 +0000
Bug 1488938 - Migrate two more nextSibling/previousSibling callers to use element variation;r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D5184
94a9c739e3293b9de209b28f1f52ba41755622e0: Bug 1488927 - Make about:studies "remove" button work again r=aswan
Michael Cooper <mcooper@mozilla.com> - Fri, 07 Sep 2018 03:01:17 +0000 - rev 435241
Push 107609 by dvarga@mozilla.com at Fri, 07 Sep 2018 22:22:21 +0000
Bug 1488927 - Make about:studies "remove" button work again r=aswan Differential Revision: https://phabricator.services.mozilla.com/D5089
07aa22874105ab39f49f811ec2c6650cd5b68010: Bug 1489485 - Don't apply -moz-appearance on macOS on selected synced tab items when themed. r=jaws
Tim Nguyen <ntim.bugs@gmail.com> - Fri, 07 Sep 2018 15:47:07 +0000 - rev 435240
Push 107609 by dvarga@mozilla.com at Fri, 07 Sep 2018 22:22:21 +0000
Bug 1489485 - Don't apply -moz-appearance on macOS on selected synced tab items when themed. r=jaws Differential Revision: https://phabricator.services.mozilla.com/D5254
4f80e37f27e3c442b046096d6e6c2f50026d3997: Bug 1488105 - Fix routing of extension port messages to non-tab contexts r=mixedpuppy
Rob Wu <rob@robwu.nl> - Fri, 07 Sep 2018 14:59:22 +0000 - rev 435239
Push 107609 by dvarga@mozilla.com at Fri, 07 Sep 2018 22:22:21 +0000
Bug 1488105 - Fix routing of extension port messages to non-tab contexts r=mixedpuppy Fixes bug 1488105 and adds two new test files: - browser test to test ping-pong from background page, sidebar and browserAction. - xpcshell test with same test logic, mainly for Android test coverage. The test uses uses contentScripts.register instead of the manifest file to also have test coverage for contentScripts.register + child frames in the background page. These tests serve as a regression test for bug 1488105 and bug 1463074. Differential Revision: https://phabricator.services.mozilla.com/D5261
078929426a6e1f65e0526b526ceb2bb8fcdc7124: Bug 1488871 - Make browser_windowopen.js workaround account for the toolbar background. r=mconley,florian
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 07 Sep 2018 10:32:23 +0200 - rev 435238
Push 107609 by dvarga@mozilla.com at Fri, 07 Sep 2018 22:22:21 +0000
Bug 1488871 - Make browser_windowopen.js workaround account for the toolbar background. r=mconley,florian With the other patch in this bug, we get two rects, not > 5. Differential Revision: https://phabricator.services.mozilla.com/D5240
39b3a22e25523077461b28ada00492823058d0bf: Bug 1488871 - Don't flush layout in AsyncScrollPortEvent::Run. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 05 Sep 2018 23:18:33 +0000 - rev 435237
Push 107609 by dvarga@mozilla.com at Fri, 07 Sep 2018 22:22:21 +0000
Bug 1488871 - Don't flush layout in AsyncScrollPortEvent::Run. r=mats I'd claim that we don't need it because, in order to enqueue the event, we already need to have overflowed the event in a normal reflow. For now this should not break anything (or anything that wasn't already racy depending on when we paint). The only reason the flush is there is according to roc is to decide whether to fire the event, and because it needs the layout information: https://bugzilla.mozilla.org/show_bug.cgi?id=771822#c4 In practice, however, all the layout information we need we have already computed by the time we post the event. We don't expose the rects via the event details, which is what could get out-of-date, so this patch could only mean that we fire the event slightly more often in cases where people remove stuff from the DOM, right after we do layout and the content has overflowed. But that's actually pretty unlikely. This event in general is pretty problematic because it exposes when we do layout and when we paint, which is not great. Its test coverage is also pretty low (test_overflow_event.html, which of course still passes without this). I still want to do this change first since it's trivial to back out if needed. Then I'd want to change how it fires to match the scrolled area change event (which would allow us to remove the WillPaintObserver stuff), after verifying that chrome consumers are still fine with that, and then put behind a pref and hide it from content, while we leave time for chrome consumers to migrate away from it, and allow us to revert if something breaks. Differential Revision: https://phabricator.services.mozilla.com/D5082
3d4024f3beeccc074d8b08c922c7f99a6339e2fa: Bug 1488412 - make sure we wait for the right loads in browser_privatebrowsing_concurrent.js, r=mconley
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Fri, 07 Sep 2018 14:27:27 +0000 - rev 435236
Push 107609 by dvarga@mozilla.com at Fri, 07 Sep 2018 22:22:21 +0000
Bug 1488412 - make sure we wait for the right loads in browser_privatebrowsing_concurrent.js, r=mconley Differential Revision: https://phabricator.services.mozilla.com/D5173
6ff949d8aeb2f39d46ca37cf1b2b5ef6680196c9: Bug 1489492 - Correct argument passing in VIXL by changing expected sizes r=tcampbell
Matthew Gaudet <mgaudet@mozilla.com> - Fri, 07 Sep 2018 14:19:10 +0000 - rev 435235
Push 107609 by dvarga@mozilla.com at Fri, 07 Sep 2018 22:22:21 +0000
Bug 1489492 - Correct argument passing in VIXL by changing expected sizes r=tcampbell Differential Revision: https://phabricator.services.mozilla.com/D5258
24f9821c42211c7e8ce5d0f660e1a6d432095524: Bug 1489495 - Fix synced tabs sidebar instructions text color with WebExtension themes. r=dao
Tim Nguyen <ntim.bugs@gmail.com> - Fri, 07 Sep 2018 13:29:44 +0000 - rev 435234
Push 107609 by dvarga@mozilla.com at Fri, 07 Sep 2018 22:22:21 +0000
Bug 1489495 - Fix synced tabs sidebar instructions text color with WebExtension themes. r=dao Differential Revision: https://phabricator.services.mozilla.com/D5257
777ad8eb5e8bec7f82bc40838cb4fca458ddca3b: Bug 1478794 - Raptor should turn off the browser proxy after pageload tests are finished r=jmaher
Rob Wood <rwood@mozilla.com> - Fri, 07 Sep 2018 08:29:07 +0000 - rev 435233
Push 107609 by dvarga@mozilla.com at Fri, 07 Sep 2018 22:22:21 +0000
Bug 1478794 - Raptor should turn off the browser proxy after pageload tests are finished r=jmaher Differential Revision: https://phabricator.services.mozilla.com/D5202
c1583f2f382b23fa742faa4d50d6081ede64f309: Bug 1486377. Avoid repeat sampling when not wanted. r=mstange
Jeff Muizelaar <jmuizelaar@mozilla.com> - Fri, 07 Sep 2018 12:00:43 -0400 - rev 435232
Push 107608 by jmuizelaar@mozilla.com at Fri, 07 Sep 2018 22:12:29 +0000
Bug 1486377. Avoid repeat sampling when not wanted. r=mstange Differential Revision: https://phabricator.services.mozilla.com/D5279
b04a830d12cdaa298b97a8135c10b64255d88ffe: Backed out changeset a5b2607fc188 (bug 1434391) for failing linux sm build bustages on a CLOSED TREE
Andreea Pavel <apavel@mozilla.com> - Sat, 08 Sep 2018 00:58:58 +0300 - rev 435231
Push 107607 by apavel@mozilla.com at Fri, 07 Sep 2018 21:59:19 +0000
Backed out changeset a5b2607fc188 (bug 1434391) for failing linux sm build bustages on a CLOSED TREE
238267dc78ec3dd4bbf2f996bea4e877547e69e8: Bug 1488632 - Don't disable the clang plugin on ASAN builds. r=dmajor
Mike Hommey <mh+mozilla@glandium.org> - Wed, 05 Sep 2018 10:44:32 +0900 - rev 435230
Push 107606 by mh@glandium.org at Fri, 07 Sep 2018 21:51:37 +0000
Bug 1488632 - Don't disable the clang plugin on ASAN builds. r=dmajor Somehow, bug 1488631 "fixes" the test failure that the original landing of bug 1487330 caused. Differential Revision: https://phabricator.services.mozilla.com/D5001
e1e83e95d0a98912d3fc4cd4218c58b2e01f5424: Bug 1488631 - Remove annotations that the clang plugin doesn't handle. r=andi
Mike Hommey <mh+mozilla@glandium.org> - Wed, 05 Sep 2018 10:37:36 +0900 - rev 435229
Push 107606 by mh@glandium.org at Fri, 07 Sep 2018 21:51:37 +0000
Bug 1488631 - Remove annotations that the clang plugin doesn't handle. r=andi As per bug 1487622, annotations have side effects on codegen, one of which changes a leak signature that the wpt harness doesn't match against its whitelist anymore. Interestingly, while looking at the issue, I found multiple moz_* annotations that weren't actually looked for by the clang plugin, making them useless. Even more interestingly, removing them changes codegen in such a way that the leak signature mentioned above is not altered anymore. Differential Revision: https://phabricator.services.mozilla.com/D5000
5f51b3b73cd4b87cffde3e687657e1371fc9a489: Bug 1487799 - Remove JOF_LEFTASSOC. r=nbp
Jason Orendorff <jorendorff@mozilla.com> - Fri, 31 Aug 2018 10:18:47 -0500 - rev 435228
Push 107605 by apavel@mozilla.com at Fri, 07 Sep 2018 21:42:50 +0000
Bug 1487799 - Remove JOF_LEFTASSOC. r=nbp
ef3bab52fbd0a9fb45f50f2112155bb15bdf3813: Bug 1467272 - Memory leak with OOM in js::jit::CodeGenerator::link(JSContext*, js::CompilerConstraintList*). r=nbp
Jason Orendorff <jorendorff@mozilla.com> - Fri, 31 Aug 2018 11:52:40 -0500 - rev 435227
Push 107604 by apavel@mozilla.com at Fri, 07 Sep 2018 21:41:49 +0000
Bug 1467272 - Memory leak with OOM in js::jit::CodeGenerator::link(JSContext*, js::CompilerConstraintList*). r=nbp
7e7d80003930936a587312ebc3794090d5dfbb8d: Bug 1442587 - Part 4: Ban js::Vector<Value>. r=sfink
Jason Orendorff <jorendorff@mozilla.com> - Thu, 30 Aug 2018 15:30:50 -0500 - rev 435226
Push 107603 by apavel@mozilla.com at Fri, 07 Sep 2018 21:41:00 +0000
Bug 1442587 - Part 4: Ban js::Vector<Value>. r=sfink
217ce4f92eb9938e7e08368f1347deb9fcc09eac: Bug 1442587 - Part 3: Avoid Vector<Value> in the front end. r=Waldo
Jason Orendorff <jorendorff@mozilla.com> - Thu, 30 Aug 2018 15:28:32 -0500 - rev 435225
Push 107603 by apavel@mozilla.com at Fri, 07 Sep 2018 21:41:00 +0000
Bug 1442587 - Part 3: Avoid Vector<Value> in the front end. r=Waldo
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip