dbb51f1914eb10e9f1b0001e0e6f982d9d31bcc5: Bug 1486487 - Toggle a label's control in case it's a checkbox; r=dao
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 30 Aug 2018 01:03:36 -0400 - rev 434589
Push 107434 by eakhgari@mozilla.com at Tue, 04 Sep 2018 14:19:04 +0000
Bug 1486487 - Toggle a label's control in case it's a checkbox; r=dao Differential Revision: https://phabricator.services.mozilla.com/D4833
2664e26623fc9c18898451343e9e91000cb298b5: Bug 1487850 - Link.cpp doesn't build if MOZ_PLACES is not defined on non-ANDROID platforms r=Ehsan
Fabrice Desré <fabrice@desre.org> - Tue, 04 Sep 2018 10:07:38 -0400 - rev 434588
Push 107433 by eakhgari@mozilla.com at Tue, 04 Sep 2018 14:07:49 +0000
Bug 1487850 - Link.cpp doesn't build if MOZ_PLACES is not defined on non-ANDROID platforms r=Ehsan
3f7d8944d6707fca3a3a40a8804997984b750dea: Bug 1488266 - Use const nsACString& in the argument to ToUTF8() in nsMIMEHeaderParamImpl.cpp; r=hsivonen
Ehsan Akhgari <ehsan@mozilla.com> - Mon, 03 Sep 2018 15:20:20 -0400 - rev 434587
Push 107432 by eakhgari@mozilla.com at Tue, 04 Sep 2018 13:55:09 +0000
Bug 1488266 - Use const nsACString& in the argument to ToUTF8() in nsMIMEHeaderParamImpl.cpp; r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D4886
3cf15cc00ee5657511cfff206271c3a5bb7ff179: Bug 1488306 - Remove the XPCOM component registration for nsUnknwonDecoder; r=valentin
Ehsan Akhgari <ehsan@mozilla.com> - Mon, 03 Sep 2018 21:49:18 -0400 - rev 434586
Push 107431 by eakhgari@mozilla.com at Tue, 04 Sep 2018 13:43:59 +0000
Bug 1488306 - Remove the XPCOM component registration for nsUnknwonDecoder; r=valentin Differential Revision: https://phabricator.services.mozilla.com/D4897
fd24042d3bfa728d0a663f9aa40ebe93cd57c17c: Bug 1488420 - Update pdf.js to version 2.0.813. r=bdahl
Ryan VanderMeulen <ryanvm@gmail.com> - Tue, 04 Sep 2018 09:32:38 -0400 - rev 434585
Push 107430 by ryanvm@gmail.com at Tue, 04 Sep 2018 13:32:59 +0000
Bug 1488420 - Update pdf.js to version 2.0.813. r=bdahl
41b45139750fe0c226af8ef7f40cec3f3b0d085b: Bug 1488006: mozprofile: derive Default for prefreader::Position. r=jgraham
Andreas Tolfsen <ato@sny.no> - Tue, 04 Sep 2018 13:53:17 +0100 - rev 434584
Push 107429 by ato@sny.no at Tue, 04 Sep 2018 13:29:32 +0000
Bug 1488006: mozprofile: derive Default for prefreader::Position. r=jgraham The user might expect to be able to use Default as the type can be constructed without arguments.
4136b6f97a9add33da424e851d4cc130067387e6: Bug 1488006: mozprofile: avoid incidental functional call; r=jgraham
Andreas Tolfsen <ato@sny.no> - Sat, 01 Sep 2018 16:59:16 +0100 - rev 434583
Push 107429 by ato@sny.no at Tue, 04 Sep 2018 13:29:32 +0000
Bug 1488006: mozprofile: avoid incidental functional call; r=jgraham There is a functional call after ok_or() which is called and evaluated before escape_char is converted due to RHS evaluation. We can avoid this by employing a closure with ok_or_else().
1e63eff2c38104dc45413c8b313d7377a26d6f5b: Bug 1488006: mozprofile: deref token to avoid & prefix; r=jgraham
Andreas Tolfsen <ato@sny.no> - Sat, 01 Sep 2018 16:56:31 +0100 - rev 434582
Push 107429 by ato@sny.no at Tue, 04 Sep 2018 13:29:32 +0000
Bug 1488006: mozprofile: deref token to avoid & prefix; r=jgraham It is considered more idiomatic to dereference the match expression than to peek at each variant through a reference. This silences a clippy lint warning.
5b38507b76cb9e0c7bb38b6e3de157d212acae4d: Bug 1488006: mozprofile: turn single-character strings into chars; r=jgraham
Andreas Tolfsen <ato@sny.no> - Sat, 01 Sep 2018 16:54:49 +0100 - rev 434581
Push 107429 by ato@sny.no at Tue, 04 Sep 2018 13:29:32 +0000
Bug 1488006: mozprofile: turn single-character strings into chars; r=jgraham Where we have single-character strings we can convert them to chars for efficiency.
c8373045be479ef2f63f029973a6b782d3c59934: Bug 1488006: mozprofile: avoid identical conversions; r=jgraham
Andreas Tolfsen <ato@sny.no> - Sat, 01 Sep 2018 16:52:08 +0100 - rev 434580
Push 107429 by ato@sny.no at Tue, 04 Sep 2018 13:29:32 +0000
Bug 1488006: mozprofile: avoid identical conversions; r=jgraham PrefReaderError::new already expects a &str.
7f018c99822e7a770908e43e099fbe2ac5f4d381: Bug 1488006: mozprofile: loop over references to container; r=jgraham
Andreas Tolfsen <ato@sny.no> - Sat, 01 Sep 2018 16:50:10 +0100 - rev 434579
Push 107429 by ato@sny.no at Tue, 04 Sep 2018 13:29:32 +0000
Bug 1488006: mozprofile: loop over references to container; r=jgraham It is considered more idiomatic Rust to loop over references to containers rather than calling the iteration protocol's x.iter() or x.into_iter() explicitly.
7b9df7da7d3900f1be52d6f6dea71e5e7e248c71: Bug 1488006: mozprofile: replace call to io::Write::write() with ::write_all(); r=jgraham
Andreas Tolfsen <ato@sny.no> - Sat, 01 Sep 2018 16:47:11 +0100 - rev 434578
Push 107429 by ato@sny.no at Tue, 04 Sep 2018 13:29:32 +0000
Bug 1488006: mozprofile: replace call to io::Write::write() with ::write_all(); r=jgraham io::Write::write() is not guaranteed to process the entire buffer. It returns how many bytes were processed, which may be smaller than the given buffer's length. mozprofile does not need to deal with partial writes, so all the calls to ::write() may be replaced with ::write_all().
a03963a35bcd4cb8622def2d37a288296b5d46e6: Bug 1488006: mozprofile: prefer byte string literals to as_bytes() where possible; r=jgraham
Andreas Tolfsen <ato@sny.no> - Sat, 01 Sep 2018 16:44:09 +0100 - rev 434577
Push 107429 by ato@sny.no at Tue, 04 Sep 2018 13:29:32 +0000
Bug 1488006: mozprofile: prefer byte string literals to as_bytes() where possible; r=jgraham Where string literals contain only ASCII characters, it is considered better style to define byte strings using b"foo" rather than calling "foo".as_bytes().
86af1d4f044ef6bdf6a3ded40171c47024d18ce8: Bug 1488006: mozprofile: drop needless lifetimes; r=jgraham
Andreas Tolfsen <ato@sny.no> - Sat, 01 Sep 2018 16:39:30 +0100 - rev 434576
Push 107429 by ato@sny.no at Tue, 04 Sep 2018 13:29:32 +0000
Bug 1488006: mozprofile: drop needless lifetimes; r=jgraham Drops all the unnecessary lifetime definitions in mozprofile.
a680beaf94c4c84662e7a9028fd3471a1d16cef2: Bug 1488006: mozprofile: avoid redundant field names in struct init; r=jgraham
Andreas Tolfsen <ato@sny.no> - Sat, 01 Sep 2018 16:35:36 +0100 - rev 434575
Push 107429 by ato@sny.no at Tue, 04 Sep 2018 13:29:32 +0000
Bug 1488006: mozprofile: avoid redundant field names in struct init; r=jgraham
03fde1788da9380ac3e17a7772920cf686f16fb0: Bug 1488006: mozprofile: format code; r=jgraham
Andreas Tolfsen <ato@sny.no> - Sat, 01 Sep 2018 16:32:21 +0100 - rev 434574
Push 107429 by ato@sny.no at Tue, 04 Sep 2018 13:29:32 +0000
Bug 1488006: mozprofile: format code; r=jgraham No functional changes, apart from running all the code through rustfmt prior to fixing clippy lint warnings.
3a5debeb1020b64f9b26fc9eca320c3109c03bcf: Backed out changeset 015d294ad0ea (bug 1488395) for spidermokey failures
Narcis Beleuzu <nbeleuzu@mozilla.com> - Tue, 04 Sep 2018 16:26:31 +0300 - rev 434573
Push 107428 by nbeleuzu@mozilla.com at Tue, 04 Sep 2018 13:27:02 +0000
Backed out changeset 015d294ad0ea (bug 1488395) for spidermokey failures
66a735968247fa45eb63016c901b565b21222c2e: Bug 1488007: mozversion: format; r=jgraham
Andreas Tolfsen <ato@sny.no> - Sat, 01 Sep 2018 17:16:21 +0100 - rev 434572
Push 107427 by ato@sny.no at Tue, 04 Sep 2018 12:47:17 +0000
Bug 1488007: mozversion: format; r=jgraham No functional changes, except applying rustfmt.
52af3a20610dcd9f6bc517d446913401648f38fe: Bug 1488007: mozversion: lint; r=jgraham
Andreas Tolfsen <ato@sny.no> - Sat, 01 Sep 2018 17:15:51 +0100 - rev 434571
Push 107427 by ato@sny.no at Tue, 04 Sep 2018 12:47:17 +0000
Bug 1488007: mozversion: lint; r=jgraham Address clippy lint warnings in mozversion.
6597fea4b50bcb2038adc37bb12b769f0c708ced: Bug 1488347 - [wdspec] Re-enable tests formerly disabled for webrender. r=ato
Henrik Skupin <mail@hskupin.info> - Tue, 04 Sep 2018 09:48:48 +0200 - rev 434570
Push 107426 by hskupin@mozilla.com at Tue, 04 Sep 2018 12:42:45 +0000
Bug 1488347 - [wdspec] Re-enable tests formerly disabled for webrender. r=ato
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip