da575947bd0295a1ed7c32e76bf32fe78771e590: Bug 1423714 - Add an API to retrieve a password from Keychain by account and service. r=mstange
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Wed, 18 Sep 2019 04:47:10 +0000 - rev 493699
Push 114097 by malexandru@mozilla.com at Wed, 18 Sep 2019 10:10:26 +0000
Bug 1423714 - Add an API to retrieve a password from Keychain by account and service. r=mstange Differential Revision: https://phabricator.services.mozilla.com/D45968
6dc8d6013f15c4c73289b6f655890b586cc564c7: Merge mozilla-central to autoland
Daniel Varga <dvarga@mozilla.com> - Wed, 18 Sep 2019 07:43:57 +0300 - rev 493698
Push 114097 by malexandru@mozilla.com at Wed, 18 Sep 2019 10:10:26 +0000
Merge mozilla-central to autoland
7442cbe672da9b1d4d3856b1881b0ca2a15ed145: Bug 1540029 - part 5: Replace `HTMLEditRules::GetListState()` with new stack class r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 18 Sep 2019 03:39:00 +0000 - rev 493697
Push 114097 by malexandru@mozilla.com at Wed, 18 Sep 2019 10:10:26 +0000
Bug 1540029 - part 5: Replace `HTMLEditRules::GetListState()` with new stack class r=m_kato It takes a lot of `bool` out arguments. Therefore, we should make it a stack only class and caller should retrieve only necessary information. Differential Revision: https://phabricator.services.mozilla.com/D45787
396a5f6301a3147ba25b447c050d9ff846c56848: Bug 1540029 - part 4: Merge `BeforeEdit()` and `OnStartToHandleTopLevelEditSubAction()`, and `AfterEdit()` and `OnEndHandlingTopLevelEditSubAction()` r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 18 Sep 2019 03:01:28 +0000 - rev 493696
Push 114097 by malexandru@mozilla.com at Wed, 18 Sep 2019 10:10:26 +0000
Bug 1540029 - part 4: Merge `BeforeEdit()` and `OnStartToHandleTopLevelEditSubAction()`, and `AfterEdit()` and `OnEndHandlingTopLevelEditSubAction()` r=m_kato And also this patch make each `AutoEditSubActionNotifier` creator check the result of `OnStartToHandleTopLevelEditSubAction()` at least for `NS_ERROR_EDITOR_DESTROYED`. We need to take care of its destructor's result later, though. Differential Revision: https://phabricator.services.mozilla.com/D45786
c7301314dcfcbeddffccf02d90504d465a8cf871: Bug 1568427 - Add {expectExceptionOnFailure: false} to test r=jandem
Paul Bone <pbone@mozilla.com> - Tue, 17 Sep 2019 08:10:30 +0000 - rev 493695
Push 114097 by malexandru@mozilla.com at Wed, 18 Sep 2019 10:10:26 +0000
Bug 1568427 - Add {expectExceptionOnFailure: false} to test r=jandem Differential Revision: https://phabricator.services.mozilla.com/D46112
4dd3945f8b0a2be5d591cf0a96fab41b70b8a8d0: Bug 1571375 - Don't remove white space when committing composition. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Wed, 18 Sep 2019 03:56:25 +0000 - rev 493694
Push 114097 by malexandru@mozilla.com at Wed, 18 Sep 2019 10:10:26 +0000
Bug 1571375 - Don't remove white space when committing composition. r=masayuki This is regression by bug 1530649. After landing bug 1530649, we try to scan end point of replacement text. But in this bug's situation, afterRun becomes same as current ws run by landing bug 1530649. To get white space type of next of replacement end, we have to scan around end point again. Differential Revision: https://phabricator.services.mozilla.com/D45947
905f54445001d5ce354621bf35506488dfde363f: Bug 1567423 - Allow for searching passwords in about:logins when MP is disabled. r=MattN
Jared Wein <jwein@mozilla.com> - Wed, 18 Sep 2019 03:47:22 +0000 - rev 493693
Push 114097 by malexandru@mozilla.com at Wed, 18 Sep 2019 10:10:26 +0000
Bug 1567423 - Allow for searching passwords in about:logins when MP is disabled. r=MattN Differential Revision: https://phabricator.services.mozilla.com/D45016
cd9efd25e7cebf1a9fd9e2b1aef704aae546f120: Bug 1567423 - Combine all synchronous messages sent at startup of about:logins. r=MattN
Jared Wein <jwein@mozilla.com> - Tue, 17 Sep 2019 15:01:02 +0000 - rev 493692
Push 114097 by malexandru@mozilla.com at Wed, 18 Sep 2019 10:10:26 +0000
Bug 1567423 - Combine all synchronous messages sent at startup of about:logins. r=MattN Differential Revision: https://phabricator.services.mozilla.com/D45739
06f79f0a1cd502ba37edfb39c845092e37e93f66: Bug 1581999 - Fix event logging while replaying, r=jlast.
Brian Hackett <bhackett1024@gmail.com> - Wed, 18 Sep 2019 03:22:33 +0000 - rev 493691
Push 114097 by malexandru@mozilla.com at Wed, 18 Sep 2019 10:10:26 +0000
Bug 1581999 - Fix event logging while replaying, r=jlast. Differential Revision: https://phabricator.services.mozilla.com/D46245
d16463e5698c360909016b15ed01d867bf59eb2d: Bug 1578661 - Add a note about CSS use counters to the documentation. r=chutten
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 18 Sep 2019 02:31:36 +0000 - rev 493690
Push 114097 by malexandru@mozilla.com at Wed, 18 Sep 2019 10:10:26 +0000
Bug 1578661 - Add a note about CSS use counters to the documentation. r=chutten Not sure how much detail does it need (it just works) but suggestions welcome. Differential Revision: https://phabricator.services.mozilla.com/D45929
c6d64ac858ba342075b60571f8ad3617a555c9e3: Bug 1578661 - Add static_assert messages for use counter assertions. r=boris
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 18 Sep 2019 02:31:34 +0000 - rev 493689
Push 114097 by malexandru@mozilla.com at Wed, 18 Sep 2019 10:10:26 +0000
Bug 1578661 - Add static_assert messages for use counter assertions. r=boris This was a review comment which was easier to address as a separate patch. Differential Revision: https://phabricator.services.mozilla.com/D45928
db306f1467f7fdcce65b22936069c694f5cb01db: Bug 1578661 - Deduplicate a bit the code to add use counters for a CSS property. r=chutten
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 18 Sep 2019 02:31:26 +0000 - rev 493688
Push 114097 by malexandru@mozilla.com at Wed, 18 Sep 2019 10:10:26 +0000
Bug 1578661 - Deduplicate a bit the code to add use counters for a CSS property. r=chutten Just some minor cleanup while I think on how to best integrate this with probe-scraper. Differential Revision: https://phabricator.services.mozilla.com/D45927
273535aab82dde60d12b49fae4dd0e9079ad31b5: Bug 1578661 - Report counted unknown properties as well. r=boris
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 18 Sep 2019 02:31:25 +0000 - rev 493687
Push 114097 by malexandru@mozilla.com at Wed, 18 Sep 2019 10:10:26 +0000
Bug 1578661 - Report counted unknown properties as well. r=boris Differential Revision: https://phabricator.services.mozilla.com/D44717
f643262a8c250b10b5a0632af407bead6a0feb75: Bug 1578661 - Add telemetry histograms for unknown counted CSS properties. r=chutten
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 18 Sep 2019 02:31:23 +0000 - rev 493686
Push 114097 by malexandru@mozilla.com at Wed, 18 Sep 2019 10:10:26 +0000
Bug 1578661 - Add telemetry histograms for unknown counted CSS properties. r=chutten This adds histograms for the stuff added in bug 1575062, which is needed for the webcompat metrics project. This also tweaks the naming to be consistent across all CSS properties. Normally the method is just equivalent to the camel_case thing except for: * The css float property, whose method is CssFloat. * Internal properties (but we don't count those anyway). This is so that we get consistent usage data if we ever implement some of those properties. I had to increase the PHF table size to make build times sane again (for some reason adding the "d" property in there blows up the phf map generation time). But according to Nika the binary size impact of that change is minimal / irrelevant: https://mozilla.logbot.info/content/20190904#c16590376 So I think it should be fine. chance Differential Revision: https://phabricator.services.mozilla.com/D44716
b0db409ada967d9d45ede4b2132932710bffb067: Bug 1578661 - Merge the stylesheet use counters, report them, and add tests. r=boris
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 18 Sep 2019 02:31:21 +0000 - rev 493685
Push 114097 by malexandru@mozilla.com at Wed, 18 Sep 2019 10:10:26 +0000
Bug 1578661 - Merge the stylesheet use counters, report them, and add tests. r=boris C'est fini. Now to do the same with the unimplemented ones remains, but it should be straight-forward. Differential Revision: https://phabricator.services.mozilla.com/D44698
dc96d13728e0d0ae81b7f674700b415f484e7784: Bug 1578661 - Fix use counter test. r=boris
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 18 Sep 2019 02:31:19 +0000 - rev 493684
Push 114097 by malexandru@mozilla.com at Wed, 18 Sep 2019 10:10:26 +0000
Bug 1578661 - Fix use counter test. r=boris By reporting the properties in MappedAttrParser that we used to (the test relies on counting those), and by adjusting the histogram name to the new thing. Differential Revision: https://phabricator.services.mozilla.com/D44697
11e1e8f0a1b772213a5fdf53df2cb1996334dd5e: Bug 1578661 - Add telemetry histograms for all CSS properties. r=chutten,boris
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 18 Sep 2019 02:33:04 +0000 - rev 493683
Push 114097 by malexandru@mozilla.com at Wed, 18 Sep 2019 10:10:26 +0000
Bug 1578661 - Add telemetry histograms for all CSS properties. r=chutten,boris And add them to the UseCounter enum. Also add some sanity-check assertions that the reporting code relies on. This works much like the deprecated operation list. Differential Revision: https://phabricator.services.mozilla.com/D44696
6dd7a0d914d9a514fc2a28dbb9de47bfb66b1939: Bug 1578661 - Remove old CSS use counters. r=boris
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 18 Sep 2019 02:32:52 +0000 - rev 493682
Push 114097 by malexandru@mozilla.com at Wed, 18 Sep 2019 10:10:26 +0000
Bug 1578661 - Remove old CSS use counters. r=boris We only have two counters enabled, just for testing, and they just count from the SVG mapped attribute code. That's not great, and they mostly complicate the next few patches. Differential Revision: https://phabricator.services.mozilla.com/D44695
4001594f15ddce3fe53854af67efa86c490478e9: Bug 1581049 - Use AutoCStrings in StreamSamplesToJSON to avoid mallocs - r=gregtatum
Gerald Squelart <gsquelart@mozilla.com> - Wed, 18 Sep 2019 01:23:12 +0000 - rev 493681
Push 114097 by malexandru@mozilla.com at Wed, 18 Sep 2019 10:10:26 +0000
Bug 1581049 - Use AutoCStrings in StreamSamplesToJSON to avoid mallocs - r=gregtatum Profiling the profiler showed a lot of time spent allocating memory for the frame-address strings, almost half the time of `StreamSamplesToJSON`! Using an "Auto" string will prevent these allocations in most cases. Also removed the `printf("0x%llx")`, instead just appending "0x" and an hex- formatted number with `AppendInt()` (which handles 32- and 64-bit numbers separately, so there is no more needs to do a double-cast to avoid sign extensions -- There is still a double cast, but a no-op one to fix the type to either `uint32_t` or `uint64_t`). Using an Auto string for nearby frame labels as well. Differential Revision: https://phabricator.services.mozilla.com/D45841
1ceccc3c86a49e4195e8aa077d69d45e8d88aef9: Bug 1581049 - Gather stack sample data into fewer entries - r=gregtatum
Gerald Squelart <gsquelart@mozilla.com> - Wed, 18 Sep 2019 01:23:00 +0000 - rev 493680
Push 114097 by malexandru@mozilla.com at Wed, 18 Sep 2019 10:10:26 +0000
Bug 1581049 - Gather stack sample data into fewer entries - r=gregtatum Stack samples may contain up to hundreds or thousands of entries, which need to be copied (during sampling and duplicating), and also mostly skipped when creating the JSON output for other threads or other types of profile data. This patch gathers all sample legacy entries (apart from the thread id and the timestamp) into a single non-legacy entry, which is much faster to copy or skip. The preceding timestamp now has a distinct Kind (`TimeBeforeCompactStack`) to know whether to handle legacy entries of the new `CompactStack` entry kind. Differential Revision: https://phabricator.services.mozilla.com/D45840
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 tip