d6b890b102b7197415317b0966e6a5c636fd5f57: Bug 1276438 part 4. Move the .body getter from HTMLDocument to Document. r=mystor
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 26 Jan 2018 00:53:34 -0500 - rev 401326
Push 99352 by bzbarsky@mozilla.com at Tue, 30 Jan 2018 05:02:52 +0000
Bug 1276438 part 4. Move the .body getter from HTMLDocument to Document. r=mystor The "body" part of responsexml-document-properties.htm is not really per current spec text, and fails in every non-Firefox browser, and in Firefox after this change. https://github.com/w3c/web-platform-tests/issues/2668 tracks this issue to some extent, but if all browsers are going to align here anyway, we should just adjust the test and move on. MozReview-Commit-ID: HTLfggvi5LL
82958e09a8c6d376e17a0dce0b1379f86e61f747: Bug 1276438 part 3. Align the .body setter with the spec a bit better. r=mystor
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 26 Jan 2018 00:52:40 -0500 - rev 401325
Push 99352 by bzbarsky@mozilla.com at Tue, 30 Jan 2018 05:02:52 +0000
Bug 1276438 part 3. Align the .body setter with the spec a bit better. r=mystor There are two changes here: 1) We allow setting .body even if the root element is not an <html:html>. This is what the spec says to do, and what we used to do before the changes in bug 366200. No tests for this yet, pending https://github.com/whatwg/html/issues/3403 getting resolved. 2) We use GetBody(), not GetBodyElement(), to look for an existing thing to replace. This matters if there are <frameset>s involved. MozReview-Commit-ID: JCaQGHKgzE7
7f8a7edd37851786280250d8c2e30efcc91930bf: Bug 1276438 part 2. Move the implementation of the .body setter from nsHTMLDocument to nsIDocument. r=mystor
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 26 Jan 2018 00:36:57 -0500 - rev 401324
Push 99352 by bzbarsky@mozilla.com at Tue, 30 Jan 2018 05:02:52 +0000
Bug 1276438 part 2. Move the implementation of the .body setter from nsHTMLDocument to nsIDocument. r=mystor MozReview-Commit-ID: EJAZfrXC0QJ
e8d6e35f38a79effea655ba3aecb173a067bf5dc: Bug 1276438 part 1. Move the implementation of the .body getter from nsHTMLDocument to nsIDocument. r=mystor
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 25 Jan 2018 06:55:47 -0500 - rev 401323
Push 99352 by bzbarsky@mozilla.com at Tue, 30 Jan 2018 05:02:52 +0000
Bug 1276438 part 1. Move the implementation of the .body getter from nsHTMLDocument to nsIDocument. r=mystor MozReview-Commit-ID: BhQuGS1NdmQ
c1deaf1c9d505039a3ad7bf295d0a80a0d798dd0: Bug 1432977 part 3. Remove nsIDOMHTMLElement's offsetWidth/Height attributes. r=mccr8
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 29 Jan 2018 23:40:11 -0500 - rev 401322
Push 99351 by bzbarsky@mozilla.com at Tue, 30 Jan 2018 04:50:40 +0000
Bug 1432977 part 3. Remove nsIDOMHTMLElement's offsetWidth/Height attributes. r=mccr8 MozReview-Commit-ID: EoSwBkeGj60
b99a55d47c97b9735dad72c782155b5b2a3d93e8: Bug 1432977 part 2. Remove nsIDOMHTMLElement's spellcheck attribute. r=mccr8
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 29 Jan 2018 23:37:57 -0500 - rev 401321
Push 99351 by bzbarsky@mozilla.com at Tue, 30 Jan 2018 04:50:40 +0000
Bug 1432977 part 2. Remove nsIDOMHTMLElement's spellcheck attribute. r=mccr8 MozReview-Commit-ID: B07hMx3LAed
e0759dfa715ed7bbeca71b3ee37574c59b0e9f29: Bug 1432977 part 1. Remove nsIDOMHTMLElement's draggable attribute. r=mccr8
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 29 Jan 2018 23:37:54 -0500 - rev 401320
Push 99351 by bzbarsky@mozilla.com at Tue, 30 Jan 2018 04:50:40 +0000
Bug 1432977 part 1. Remove nsIDOMHTMLElement's draggable attribute. r=mccr8 MozReview-Commit-ID: Gj8thsaNGCF
f01a1eb49c2efde027c33bb85a02f082446c201d: Bug 1432944 part 13. Remove the NS_FORWARD_NSIDOMELEMENT_TO_GENERIC macro. r=mccr8
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 29 Jan 2018 23:29:11 -0500 - rev 401319
Push 99350 by bzbarsky@mozilla.com at Tue, 30 Jan 2018 04:37:27 +0000
Bug 1432944 part 13. Remove the NS_FORWARD_NSIDOMELEMENT_TO_GENERIC macro. r=mccr8 MozReview-Commit-ID: 8A1VcWArVcP
e723bf17f405b99ffdd479a9541e55405c97248a: Bug 1432944 part 12. Change nsIFormProcessor to pass Element, not nsIDOMHTMLElement, for elements. r=mccr8
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 29 Jan 2018 23:29:11 -0500 - rev 401318
Push 99350 by bzbarsky@mozilla.com at Tue, 30 Jan 2018 04:37:27 +0000
Bug 1432944 part 12. Change nsIFormProcessor to pass Element, not nsIDOMHTMLElement, for elements. r=mccr8 MozReview-Commit-ID: K6w7FR254UC
76c001daf2656dd2ba7396d56f667fc0c555e7b9: Bug 1432944 part 11. Remove nsIDOMElement::GetAttribute. r=mccr8
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 29 Jan 2018 23:28:00 -0500 - rev 401317
Push 99350 by bzbarsky@mozilla.com at Tue, 30 Jan 2018 04:37:27 +0000
Bug 1432944 part 11. Remove nsIDOMElement::GetAttribute. r=mccr8 MozReview-Commit-ID: 2f1vFvRdCPG
a59431cb28a1315ae036b2be828242da97ef54cc: Bug 1432944 part 10. Remove nsIDOMElement::SetAttribute. r=mccr8
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 29 Jan 2018 23:28:00 -0500 - rev 401316
Push 99350 by bzbarsky@mozilla.com at Tue, 30 Jan 2018 04:37:27 +0000
Bug 1432944 part 10. Remove nsIDOMElement::SetAttribute. r=mccr8 MozReview-Commit-ID: 6eIdX8iA5Rg
a5250222f3d5e1c1a21990cef6735bd713ba7241: Bug 1432944 part 9. Remove nsIDOMElement::HasAttribute. r=mccr8
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 29 Jan 2018 23:27:59 -0500 - rev 401315
Push 99350 by bzbarsky@mozilla.com at Tue, 30 Jan 2018 04:37:27 +0000
Bug 1432944 part 9. Remove nsIDOMElement::HasAttribute. r=mccr8 MozReview-Commit-ID: KDeeVkeRmQr
e7ad723a13ffdea0ced1ea4be9c4016420ddfcea: Bug 1432944 part 8. Remove usage of nsIDOMElement::HasAttribute in editor code. r=m_kato
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 29 Jan 2018 23:27:59 -0500 - rev 401314
Push 99350 by bzbarsky@mozilla.com at Tue, 30 Jan 2018 04:37:27 +0000
Bug 1432944 part 8. Remove usage of nsIDOMElement::HasAttribute in editor code. r=m_kato MozReview-Commit-ID: 926Dzqv7Oj4
2b200ba1a37e77ad56184d9e1206129a5c5e684d: Bug 1432944 part 7. Remove nsIDOMElement's tagName attribute. r=mccr8
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 29 Jan 2018 23:27:59 -0500 - rev 401313
Push 99350 by bzbarsky@mozilla.com at Tue, 30 Jan 2018 04:37:27 +0000
Bug 1432944 part 7. Remove nsIDOMElement's tagName attribute. r=mccr8 MozReview-Commit-ID: 8rmd120L2BK
3524d4390de93615af13aa449e8b3acc24f0a820: Bug 1432944 part 6. Remove the nsIDOMNode overloads of HTMLEditUtils::IsNamedAnchor and HTMLEditUtils::IsTable. r=m_kato
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 29 Jan 2018 23:27:59 -0500 - rev 401312
Push 99350 by bzbarsky@mozilla.com at Tue, 30 Jan 2018 04:37:27 +0000
Bug 1432944 part 6. Remove the nsIDOMNode overloads of HTMLEditUtils::IsNamedAnchor and HTMLEditUtils::IsTable. r=m_kato MozReview-Commit-ID: 4KlppKdzJGy
7587d756a885a6dfc86f4764c918ef4553614cf6: Bug 1432944 part 5. Remove the now-unused nsIDOMNode overload of HTMLEditUtils::IsLink. r=m_kato
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 29 Jan 2018 23:27:59 -0500 - rev 401311
Push 99350 by bzbarsky@mozilla.com at Tue, 30 Jan 2018 04:37:27 +0000
Bug 1432944 part 5. Remove the now-unused nsIDOMNode overload of HTMLEditUtils::IsLink. r=m_kato MozReview-Commit-ID: CDnYK194JB9
8d4336d56112f3abf27e6d7ef9843512f6b9a518: Bug 1432944 part 4. Work with Element, not nsIDOMElement, inside HTMLEditor::GetSelectedElement. r=m_kato
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 29 Jan 2018 23:27:59 -0500 - rev 401310
Push 99350 by bzbarsky@mozilla.com at Tue, 30 Jan 2018 04:37:27 +0000
Bug 1432944 part 4. Work with Element, not nsIDOMElement, inside HTMLEditor::GetSelectedElement. r=m_kato MozReview-Commit-ID: 3F1rbPMgkAR
84d651460f98f1e1a973393a2adf1d4cdbc4fa7b: Bug 1432944 part 3. Take an early return from HTMLEditor::GetSelectedElement when we can. r=m_kato
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 29 Jan 2018 23:27:59 -0500 - rev 401309
Push 99350 by bzbarsky@mozilla.com at Tue, 30 Jan 2018 04:37:27 +0000
Bug 1432944 part 3. Take an early return from HTMLEditor::GetSelectedElement when we can. r=m_kato MozReview-Commit-ID: EAEzpom7oXo
15f093275a0df22eca0c4692c1fbc02fa783d593: Bug 1432944 part 2. Make nsIHTMLEditor.getSelectedElement return nsISupports. r=m_kato
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 29 Jan 2018 23:27:59 -0500 - rev 401308
Push 99350 by bzbarsky@mozilla.com at Tue, 30 Jan 2018 04:37:27 +0000
Bug 1432944 part 2. Make nsIHTMLEditor.getSelectedElement return nsISupports. r=m_kato The only C++ caller immediately QIs the result anyway, and the exact type returned doesn't matter for JS callers because the return values are DOM objects. This makes it simpler to rejigger the internals to work with nsINode and Element and whatnot. MozReview-Commit-ID: 863IDGECqYY
93c1d149d757d49da158cc64f6eb21fb3406da18: Bug 1432944 part 1. Stop returning NS_EDITOR_ELEMENT_NOT_FOUND from nsIHTMLEditor::GetSelectedElement. r=m_kato
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 29 Jan 2018 23:27:58 -0500 - rev 401307
Push 99350 by bzbarsky@mozilla.com at Tue, 30 Jan 2018 04:37:27 +0000
Bug 1432944 part 1. Stop returning NS_EDITOR_ELEMENT_NOT_FOUND from nsIHTMLEditor::GetSelectedElement. r=m_kato The only C++ caller doesn't care, and JS callers can't tell that a non-NS_OK success code was returned anyway. MozReview-Commit-ID: FNhQYR0a9ur
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip