d637ee5ceb51cbed026b130c8e221e1be91abf02: Bug 1552145 - Change HLS seek to seek before seek target and drop frames until next keyframe. r=jya
Chris Pearce <cpearce@mozilla.com> - Tue, 04 Jun 2019 22:20:49 +0000 - rev 477364
Push 113327 by malexandru@mozilla.com at Wed, 05 Jun 2019 10:00:10 +0000
Bug 1552145 - Change HLS seek to seek before seek target and drop frames until next keyframe. r=jya The Java ExoPlayer that we use for HLS support on Android does an accurate seek, that is, it seeks to the frame at the seek target. This may not be a keyframe, which we can start decoding at. So change the HLS seek to seek 2 seconds behind the seek target, and drop all frames up to the next keyframe. This means that after a seek the HLSDemuxer will output a keyframe, and hopefully (but we can't guarantee of course) it will lie behind the actual seek target. We also need to purge the GeckoHlsVideoRenderer's queue of frames which it is holding onto in order to determine their durations, otherwise after a seek, we'll get output from this queue of frames. That is, after a seek we would still get a few frames from the old playback position. This seek case is particularly problematic as we aggressively shutdown decoders when the media is paused, including right after the load reaches loadedmetadata, and we need to seek in order to recover from going dormant. Differential Revision: https://phabricator.services.mozilla.com/D33254
421f9e16c210ce04a472be4ad9ad2a447f100a77: Bug 1526818 - QuantumBar: Expose an autocomplete.properties bundle from UrlbarUtils r=adw
Omkar Konaraddi <okonaraddi@mozilla.com> - Wed, 05 Jun 2019 00:28:40 +0000 - rev 477363
Push 113327 by malexandru@mozilla.com at Wed, 05 Jun 2019 10:00:10 +0000
Bug 1526818 - QuantumBar: Expose an autocomplete.properties bundle from UrlbarUtils r=adw Differential Revision: https://phabricator.services.mozilla.com/D33726
43819c0ec5768e0612e691100fc5dbde462c99b7: Bug 1556857 - Return true in AttributeChangeRequiresSubtreeRestyle whenever lwtheme attrs change in any chrome doc, not just those with XUL document elements r=emilio
Brian Grinstead <bgrinstead@mozilla.com> - Tue, 04 Jun 2019 20:43:51 +0000 - rev 477362
Push 113327 by malexandru@mozilla.com at Wed, 05 Jun 2019 10:00:10 +0000
Bug 1556857 - Return true in AttributeChangeRequiresSubtreeRestyle whenever lwtheme attrs change in any chrome doc, not just those with XUL document elements r=emilio In preparation for an <html> root node in browser.xhtml, we need to react to lwtheme changes correctly. Differential Revision: https://phabricator.services.mozilla.com/D33693
246b4a16ab9610d0a91d4e5270b01537c7efc792: Bug 1552621 - Include optional steps in Sync engine telemetry. r=tcsc,tdsmith
Lina Cambridge <lina@yakshaving.ninja> - Tue, 04 Jun 2019 20:08:07 +0000 - rev 477361
Push 113327 by malexandru@mozilla.com at Wed, 05 Jun 2019 10:00:10 +0000
Bug 1552621 - Include optional steps in Sync engine telemetry. r=tcsc,tdsmith Before this commit, we used event telemetry to record timing and counts for the different steps of a bookmark merge (fetching the local tree, new local contents, remote tree, and new remote contents; merging; applying; fetching outgoing records; and notifying observers). This has several limitations. We need to store all numbers as strings, include a "flow ID" to tag events from the same merge, and collect failure reasons twice. We also can't correlate these events to the existing engine telemetry, meaning we can't see other stats for that engine, or for the entire sync. Finally, we need to run separate queries on these events for analysis, instead of extending our existing engine dashboards. This approach also feels like an abuse of event telemetry, so this commit adds a "steps" field for each engine in the Sync ping. Each step has a name, time taken, and additional named counts, like the number of items in the tree, or merged structure stats. Currently, only the `buffered-bookmarks` engine records these steps. Differential Revision: https://phabricator.services.mozilla.com/D33411
22fa4447a9a2f2fe231fdb35597ba3e021646968: Bug 1552621 - Record bookmark validation telemetry for the buffered engine. r=tcsc
Lina Cambridge <lina@yakshaving.ninja> - Tue, 04 Jun 2019 20:08:51 +0000 - rev 477360
Push 113327 by malexandru@mozilla.com at Wed, 05 Jun 2019 10:00:10 +0000
Bug 1552621 - Record bookmark validation telemetry for the buffered engine. r=tcsc Differential Revision: https://phabricator.services.mozilla.com/D33410
7a67c62d4b8b1a36c98b98a0d8c6cdeff425160a: Bug 1552621 - Record shutdown blocker progress in the bookmarks mirror. r=markh,tcsc
Lina Cambridge <lina@yakshaving.ninja> - Mon, 03 Jun 2019 23:04:37 +0000 - rev 477359
Push 113327 by malexandru@mozilla.com at Wed, 05 Jun 2019 10:00:10 +0000
Bug 1552621 - Record shutdown blocker progress in the bookmarks mirror. r=markh,tcsc This commit introduces a `mozISyncedBookmarksMirrorProgressListener` interface for capturing telemetry and updating shutdown blocker state after each step of the merge, instead of waiting until the end. This also means we can also record events for interrupted and failed merges, and pass validation data through to the Sync ping. Shutdown hang crash reports now have a `steps` field, indicating the sequence of completed steps and when they were recorded. If the last step in the hang report is `fetchLocalTree`, we know the merger is blocked on `fetchNewLocalContents`. If the last step is `fetchNewLocalContents`, the merger is stuck at `fetchRemoteTree`, since that's the next step after `fetchNewLocalContents`. This commit also implements `Driver::record_telemetry_event` to dispatch progress callback runnables to the main thread. Differential Revision: https://phabricator.services.mozilla.com/D31950
f397460e4d9d505b552d576f2b5393183ab602f8: Backed out 4 changesets (bug 1551902) for browser-chrome failure at browser/base/content/test/trackingUI/browser_trackingUI_cryptominers.js. On a CLOSED TREE
Daniel Varga <dvarga@mozilla.com> - Wed, 05 Jun 2019 02:48:37 +0300 - rev 477358
Push 113327 by malexandru@mozilla.com at Wed, 05 Jun 2019 10:00:10 +0000
Backed out 4 changesets (bug 1551902) for browser-chrome failure at browser/base/content/test/trackingUI/browser_trackingUI_cryptominers.js. On a CLOSED TREE Backed out changeset 762ba28bc409 (bug 1551902) Backed out changeset 4c8afa61cbec (bug 1551902) Backed out changeset 212cfe3c1893 (bug 1551902) Backed out changeset 29cbb321a610 (bug 1551902)
ead19b73c93d934f2ac5b993d27771024227ff78: Backed out changeset afa5d3807c8b (bug 1556857) for mochitest failure at builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/RefPtr.h:268. On a CLOSED TREE
Daniel Varga <dvarga@mozilla.com> - Wed, 05 Jun 2019 02:24:07 +0300 - rev 477357
Push 113327 by malexandru@mozilla.com at Wed, 05 Jun 2019 10:00:10 +0000
Backed out changeset afa5d3807c8b (bug 1556857) for mochitest failure at builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/RefPtr.h:268. On a CLOSED TREE
78531ba046cf411b85c834e8448ad25f1fee552d: Bug 1556360. Release nsIconChannel on main thread. r=aosmond
Timothy Nikkel <tnikkel@gmail.com> - Tue, 04 Jun 2019 22:46:59 +0000 - rev 477356
Push 113327 by malexandru@mozilla.com at Wed, 05 Jun 2019 10:00:10 +0000
Bug 1556360. Release nsIconChannel on main thread. r=aosmond It will cause releasing nsLoadGroup which doesn't like being released off main thread. Differential Revision: https://phabricator.services.mozilla.com/D33590
3149eddf5db567f05556ea198d1ceccffdb4c490: Bug 1556617 - Remove old mozilla.widget.* prefs from GV. r=geckoview-reviewers,esawin
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Tue, 04 Jun 2019 14:50:27 +0000 - rev 477355
Push 113327 by malexandru@mozilla.com at Wed, 05 Jun 2019 10:00:10 +0000
Bug 1556617 - Remove old mozilla.widget.* prefs from GV. r=geckoview-reviewers,esawin `mozilla.widget.*` was used by old Fennec (Maemo/GTK2). But Android widget doesn't reference this. ### `mozilla.widget.disable-native-theme` This preference is unused on Android widget. This is for GTK and Windows. Reftests on Android are disabled by `layout/reftests/reftest.list`. ### `mozilla.widget.force-24bpp` This is unused on Android. This is GTK only. ### `mozilla.widget.use-buffer-pixmap` No one uses this preference. Differential Revision: https://phabricator.services.mozilla.com/D33609
71d3424191f63751068077270a32f9f3aeb026b8: Bug 1556662 - Fix a typo in change from bug 1469091. r=dmajor
Mike Hommey <mh+mozilla@glandium.org> - Tue, 04 Jun 2019 11:39:44 +0000 - rev 477354
Push 113327 by malexandru@mozilla.com at Wed, 05 Jun 2019 10:00:10 +0000
Bug 1556662 - Fix a typo in change from bug 1469091. r=dmajor In a branch for `isinstance(obj, (HostSources, HostGeneratedSources))`, `isinstance(obj, GeneratedSources)` is clearly not going to match anything. `isinstance(obj, HostGeneratedSources)` is what was intended. Differential Revision: https://phabricator.services.mozilla.com/D33603
894b83e9960615505910a674690222e1f9c74f50: Bug 1556590 - Display root render task instead of last render task in WebRender debugger r=gw
Connor Brewster <cbrewster@mozilla.com> - Tue, 04 Jun 2019 20:52:29 +0000 - rev 477353
Push 113327 by malexandru@mozilla.com at Wed, 05 Jun 2019 10:00:10 +0000
Bug 1556590 - Display root render task instead of last render task in WebRender debugger r=gw Differential Revision: https://phabricator.services.mozilla.com/D33582
350091c5dde1c2734707b9738395f499e1920ce0: Bug 1552571: Optimize GetUserMediaWindowListener's source listener iteration and ownership. r=pehrsons
Jan-Ivar Bruaroey <jib@mozilla.com> - Tue, 04 Jun 2019 22:39:14 +0000 - rev 477352
Push 113327 by malexandru@mozilla.com at Wed, 05 Jun 2019 10:00:10 +0000
Bug 1552571: Optimize GetUserMediaWindowListener's source listener iteration and ownership. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D31687
611f5c630114a99eceb2f4e4c0f4e18167e4cf54: Bug 1534552 - Properly document selection resetting in UrlbarInput::_loadURL r=adw
Omkar Konaraddi <okonaraddi@mozilla.com> - Tue, 04 Jun 2019 22:33:44 +0000 - rev 477351
Push 113327 by malexandru@mozilla.com at Wed, 05 Jun 2019 10:00:10 +0000
Bug 1534552 - Properly document selection resetting in UrlbarInput::_loadURL r=adw Differential Revision: https://phabricator.services.mozilla.com/D33713
b6b8498819a7cce318800024a72db7713031cd3e: Bug 1556268 - Remove aboutCompartments.xhtml. r=mccr8
Nicholas Nethercote <nnethercote@mozilla.com> - Sun, 02 Jun 2019 23:05:01 +0000 - rev 477350
Push 113327 by malexandru@mozilla.com at Wed, 05 Jun 2019 10:00:10 +0000
Bug 1556268 - Remove aboutCompartments.xhtml. r=mccr8 about:compartments hasn't resolved for a long time. Differential Revision: https://phabricator.services.mozilla.com/D33431
afa5d3807c8b5810203718e158fa4b185e109f55: Bug 1556857 - Return true in AttributeChangeRequiresSubtreeRestyle whenever lwtheme attrs change in any chrome doc, not just those with XUL document elements r=emilio
Brian Grinstead <bgrinstead@mozilla.com> - Tue, 04 Jun 2019 20:43:51 +0000 - rev 477349
Push 113327 by malexandru@mozilla.com at Wed, 05 Jun 2019 10:00:10 +0000
Bug 1556857 - Return true in AttributeChangeRequiresSubtreeRestyle whenever lwtheme attrs change in any chrome doc, not just those with XUL document elements r=emilio In preparation for an <html> root node in browser.xhtml, we need to react to lwtheme changes correctly. Differential Revision: https://phabricator.services.mozilla.com/D33693
d64cb52ebf88093b7c4b40597a795ed5d46a2214: Bug 1543812 - Add ability to block all autoplay. r=johannh,alwu,flod,fluent-reviewers
Dale Harvey <dale@arandomurl.com> - Tue, 04 Jun 2019 17:33:06 +0000 - rev 477348
Push 113327 by malexandru@mozilla.com at Wed, 05 Jun 2019 10:00:10 +0000
Bug 1543812 - Add ability to block all autoplay. r=johannh,alwu,flod,fluent-reviewers Differential Revision: https://phabricator.services.mozilla.com/D30135
762ba28bc409af7e664ca6a76537b105b9a44f95: Bug 1551902 - Add a test for the toggle switch in the protections panel. r=johannh
Nihanth Subramanya <nhnt11@gmail.com> - Tue, 04 Jun 2019 21:48:43 +0000 - rev 477347
Push 113327 by malexandru@mozilla.com at Wed, 05 Jun 2019 10:00:10 +0000
Bug 1551902 - Add a test for the toggle switch in the protections panel. r=johannh Differential Revision: https://phabricator.services.mozilla.com/D32982
4c8afa61cbecb154538974e62354c4e8aaa86b0f: Bug 1551902 - ContentBlocking: Set hasException attribute in onLocationChange. r=johannh
Nihanth Subramanya <nhnt11@gmail.com> - Tue, 04 Jun 2019 21:48:30 +0000 - rev 477346
Push 113327 by malexandru@mozilla.com at Wed, 05 Jun 2019 10:00:10 +0000
Bug 1551902 - ContentBlocking: Set hasException attribute in onLocationChange. r=johannh Differential Revision: https://phabricator.services.mozilla.com/D32981
212cfe3c1893e508f6330fecd6ce758b33dc49c3: Bug 1551902 - Hide protections panel when focus is lost. r=johannh
Nihanth Subramanya <nhnt11@gmail.com> - Tue, 04 Jun 2019 21:48:03 +0000 - rev 477345
Push 113327 by malexandru@mozilla.com at Wed, 05 Jun 2019 10:00:10 +0000
Bug 1551902 - Hide protections panel when focus is lost. r=johannh Differential Revision: https://phabricator.services.mozilla.com/D32980
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip