d56e561be43f7494a3f5362a427589947b4345f2: Bug 1538113 - Fix dom/media/webrtc static-analysis warnings. r=jib
Andreas Pehrson <apehrson@mozilla.com> - Mon, 25 Mar 2019 18:52:57 +0000 - rev 465993
Push 112550 by rgurzau@mozilla.com at Tue, 26 Mar 2019 09:57:15 +0000
Bug 1538113 - Fix dom/media/webrtc static-analysis warnings. r=jib Initially indicated by: https://phabricator.services.mozilla.com/D22910#inline-142013 Rest found by: ./mach static-analysis check dom/media/webrtc Differential Revision: https://phabricator.services.mozilla.com/D24511
946a9c169fb4c366369e37dbd8a372868e6216f7: Bug 1538113 - Fix TestVideoTrackEncoder static-analysis warnings. r=bryce
Andreas Pehrson <apehrson@mozilla.com> - Fri, 22 Mar 2019 16:43:28 +0000 - rev 465992
Push 112550 by rgurzau@mozilla.com at Tue, 26 Mar 2019 09:57:15 +0000
Bug 1538113 - Fix TestVideoTrackEncoder static-analysis warnings. r=bryce Initially indicated by https://phabricator.services.mozilla.com/D22909#inline-140683 Some more found by ./mach static-analysis check dom/media/gtest/TestVideoTrackEncoder.cpp Differential Revision: https://phabricator.services.mozilla.com/D24510
4644878c0feb19f76dc05e8847ece9a0fc75ba4b: Bug 1538192 - Remove NIGHTLY_BUILD ifdef around Picture-in-Picture context menu item. r=jaws
Mike Conley <mconley@mozilla.com> - Mon, 25 Mar 2019 18:16:49 +0000 - rev 465991
Push 112550 by rgurzau@mozilla.com at Tue, 26 Mar 2019 09:57:15 +0000
Bug 1538192 - Remove NIGHTLY_BUILD ifdef around Picture-in-Picture context menu item. r=jaws Depends on D24519 Differential Revision: https://phabricator.services.mozilla.com/D24520
3d053fe26d1c6ae8fef226d4c445124a2780905f: Bug 1538216 - Remove NIGHTLY_BUILD ifdef around Picture-in-Picture media assets. r=jaws
Mike Conley <mconley@mozilla.com> - Mon, 25 Mar 2019 18:17:01 +0000 - rev 465990
Push 112550 by rgurzau@mozilla.com at Tue, 26 Mar 2019 09:57:15 +0000
Bug 1538216 - Remove NIGHTLY_BUILD ifdef around Picture-in-Picture media assets. r=jaws Differential Revision: https://phabricator.services.mozilla.com/D24519
c6b4e466e15887eed24f7017f8cc25d1b887d5d0: Bug 1537550 - Use PlainOldDataSerializer for POD types in VRMessageUtils r=daoshengmu
Kearwood "Kip" Gilbert <kgilbert@mozilla.com> - Mon, 25 Mar 2019 18:06:32 +0000 - rev 465989
Push 112550 by rgurzau@mozilla.com at Tue, 26 Mar 2019 09:57:15 +0000
Bug 1537550 - Use PlainOldDataSerializer for POD types in VRMessageUtils r=daoshengmu Moved non-POD member of VRDisplayInfo to VRDisplayHost VRDisplayInfo is now also a POD type (And asserted so) Use PlainOldDataSerializer for POD types in VRMessageUtils Moved non-POD member of VRDisplayInfo to VRDisplayHost VRDisplayInfo is now also a POD type (And asserted so) Differential Revision: https://phabricator.services.mozilla.com/D24577
d641ac81d9f07ef75cb3e13f9c33e13564d47fb1: bug 1529044 - intermediate certificate caching: import on a background thread to not block certificate verification r=mgoodwin
Dana Keeler <dkeeler@mozilla.com> - Mon, 25 Mar 2019 17:09:37 +0000 - rev 465988
Push 112550 by rgurzau@mozilla.com at Tue, 26 Mar 2019 09:57:15 +0000
bug 1529044 - intermediate certificate caching: import on a background thread to not block certificate verification r=mgoodwin Apparently importing a certificate into the NSS certificate DB is slow enough to materially impact the time it takes to connect to a site. This patch addresses this by importing any intermediate certificates we want to cache from verified connections on a background thread (so the certificate verification thread can return faster). Differential Revision: https://phabricator.services.mozilla.com/D24384
87be6cf9c45bbb60dbabb19caee172b5141ef5ab: Bug 1522358 - Requery VRDisplayHost from VRManagers instead of using weakptr from the hash table. r=kip
Daosheng Mu <daoshengmu@gmail.com> - Mon, 25 Mar 2019 17:51:51 +0000 - rev 465987
Push 112550 by rgurzau@mozilla.com at Tue, 26 Mar 2019 09:57:15 +0000
Bug 1522358 - Requery VRDisplayHost from VRManagers instead of using weakptr from the hash table. r=kip Differential Revision: https://phabricator.services.mozilla.com/D24584
127610bec3fc4d268f0dfda04ffa5028523ae9ef: Bug 1532395 - Clear the DNS cache before each TRR test r=JuniorHsu
Valentin Gosu <valentin.gosu@gmail.com> - Mon, 25 Mar 2019 17:55:45 +0000 - rev 465986
Push 112550 by rgurzau@mozilla.com at Tue, 26 Mar 2019 09:57:15 +0000
Bug 1532395 - Clear the DNS cache before each TRR test r=JuniorHsu It is likely that the test is flaky because we resolve the same host with a different TRR endpoint and sometimes we use a cached record. We should clear the DNS cache before each test to ensure that we're actually checking the right thing. Differential Revision: https://phabricator.services.mozilla.com/D24355
55be3316a5cb5b4cc2220189c0bff4112c792745: Bug 1537776 - dom/ manual ESLint no-throw-literal fixes. r=asuth
Ian Moody <moz-ian@perix.co.uk> - Mon, 25 Mar 2019 16:49:03 +0000 - rev 465985
Push 112550 by rgurzau@mozilla.com at Tue, 26 Mar 2019 09:57:15 +0000
Bug 1537776 - dom/ manual ESLint no-throw-literal fixes. r=asuth Differential Revision: https://phabricator.services.mozilla.com/D24370
9e380dd146f39cfd47b2ce9fed22999c3bc42c6c: Bug 1529122 - P2 - Make sure checking initialized if clear all is requested; r=asuth
Tom Tung <shes050117@gmail.com> - Mon, 25 Mar 2019 17:50:17 +0000 - rev 465984
Push 112550 by rgurzau@mozilla.com at Tue, 26 Mar 2019 09:57:15 +0000
Bug 1529122 - P2 - Make sure checking initialized if clear all is requested; r=asuth Differential Revision: https://phabricator.services.mozilla.com/D24680
5cdeddb92f1692b1b9327a209d1c479bce32ab15: Bug 1529122 - P1 - Remove the origin directory if the requesting client is the only client in the directroy; r=asuth
Tom Tung <shes050117@gmail.com> - Mon, 25 Mar 2019 17:49:44 +0000 - rev 465983
Push 112550 by rgurzau@mozilla.com at Tue, 26 Mar 2019 09:57:15 +0000
Bug 1529122 - P1 - Remove the origin directory if the requesting client is the only client in the directroy; r=asuth This patch do: - Removing the directroy if the requesting client is the only client. - Avoid unnecessary initialization for a client if it hasn't been initialized. Differential Revision: https://phabricator.services.mozilla.com/D24371
9eaef2b8b2c843a3f4e50eeec631749ff4373f61: Backed out changeset 69f5724fb0f3 (bug 1524653) for not properly disabling the test.
Cosmin Sabou <csabou@mozilla.com> - Mon, 25 Mar 2019 19:28:45 +0200 - rev 465982
Push 112550 by rgurzau@mozilla.com at Tue, 26 Mar 2019 09:57:15 +0000
Backed out changeset 69f5724fb0f3 (bug 1524653) for not properly disabling the test.
9e8fee5e4f3d9371b1bb2a9d032a2461f7253dad: Bug 1519825 - Update grcov to revision 9214a916805838265764f9c69eaed657ea3db021 r=marco
Calixte Denizet <cdenizet@mozilla.com> - Mon, 25 Mar 2019 17:07:23 +0000 - rev 465981
Push 112550 by rgurzau@mozilla.com at Tue, 26 Mar 2019 09:57:15 +0000
Bug 1519825 - Update grcov to revision 9214a916805838265764f9c69eaed657ea3db021 r=marco This revision corresponds to grcov 0.4.2 Differential Revision: https://phabricator.services.mozilla.com/D16465
842871b6e080ecb0e826e53c89582811bfc0234c: Bug 1537776 - dom/ automated ESLint no-throw-literal fixes. r=asuth,mccr8
Ian Moody <moz-ian@perix.co.uk> - Mon, 25 Mar 2019 16:03:38 +0000 - rev 465980
Push 112550 by rgurzau@mozilla.com at Tue, 26 Mar 2019 09:57:15 +0000
Bug 1537776 - dom/ automated ESLint no-throw-literal fixes. r=asuth,mccr8 Result of running: $ mach eslint -funix dom/ | sed -Ee 's/:.+//' - | xargs sed -E \ -e 's/throw ((["`])[^"]+\2);/throw new Error(\1);/g' \ -e 's/throw ((["`])[^"]+\2 \+ [^ ";]+);/throw new Error(\1);/g' \ -e 's/throw \(/throw new Error(/g' -i Differential Revision: https://phabricator.services.mozilla.com/D24369
35240b0ae4a5af0c329b40e1a453cfb397f809f1: Bug 1536659 - docshell/ manual ESLint no-throw-literal fixes. r=nika
Ian Moody <moz-ian@perix.co.uk> - Thu, 21 Mar 2019 22:40:36 +0000 - rev 465979
Push 112550 by rgurzau@mozilla.com at Tue, 26 Mar 2019 09:57:15 +0000
Bug 1536659 - docshell/ manual ESLint no-throw-literal fixes. r=nika Differential Revision: https://phabricator.services.mozilla.com/D24368
621f825b37e816da9e19364af21f88a281284bfd: Bug 1536659 - docshell/ automated ESLint no-throw-literal fixes. r=nika
Ian Moody <moz-ian@perix.co.uk> - Thu, 21 Mar 2019 16:53:45 +0000 - rev 465978
Push 112550 by rgurzau@mozilla.com at Tue, 26 Mar 2019 09:57:15 +0000
Bug 1536659 - docshell/ automated ESLint no-throw-literal fixes. r=nika Result of running: $ mach eslint -funix docshell/ | sed -Ee 's/:.+//' - | xargs sed -E \ -e 's/throw ((["`])[^"]+\2);/throw new Error(\1);/g' \ -e 's/throw ((["`])[^"]+\2 \+ [^ ";]+);/throw new Error(\1);/g' \ -e 's/throw \(/throw new Error(/g' -i Differential Revision: https://phabricator.services.mozilla.com/D24367
0ebb51472ce4081235fea82701839bcdfc10642c: Bug 1500719 - Ensure toolbar is hidden when going fullscreen r=botond
Randall Barker <rbarker@mozilla.com> - Thu, 21 Mar 2019 23:39:59 +0000 - rev 465977
Push 112550 by rgurzau@mozilla.com at Tue, 26 Mar 2019 09:57:15 +0000
Bug 1500719 - Ensure toolbar is hidden when going fullscreen r=botond Differential Revision: https://phabricator.services.mozilla.com/D24348
5a29abda45117075cc7ce1299d96edecaa4bb0dc: Bug 1537964 - Call bindService() with BIND_IMPORTANT r=snorp
Randall Barker <rbarker@mozilla.com> - Mon, 25 Mar 2019 14:29:54 +0000 - rev 465976
Push 112550 by rgurzau@mozilla.com at Tue, 26 Mar 2019 09:57:15 +0000
Bug 1537964 - Call bindService() with BIND_IMPORTANT r=snorp Differential Revision: https://phabricator.services.mozilla.com/D24418
6ef62825d79f142b9aabd982d84f2e69e4eded06: Bug 1538474 - Enable dav1d in RDD process. r=mjf
Alex Chronopoulos <achronop@gmail.com> - Mon, 25 Mar 2019 16:41:48 +0000 - rev 465975
Push 112550 by rgurzau@mozilla.com at Tue, 26 Mar 2019 09:57:15 +0000
Bug 1538474 - Enable dav1d in RDD process. r=mjf Differential Revision: https://phabricator.services.mozilla.com/D24726
5b0704b4bf50c69b9552c0f4f9043444b2e04b19: Bug 1509620 - Computed style inspector CSS cascade calculation is wrong r=ladybenko
Michael Ratcliffe <mratcliffe@mozilla.com> - Mon, 25 Mar 2019 16:32:19 +0000 - rev 465974
Push 112550 by rgurzau@mozilla.com at Tue, 26 Mar 2019 09:57:15 +0000
Bug 1509620 - Computed style inspector CSS cascade calculation is wrong r=ladybenko ### Try https://treeherder.mozilla.org/#/jobs?repo=try&revision=f1bad5e5282812225da95c0ea9e2ef173640b5da ### Summary !!Comparing numerous complex websites such as github, facebook, cnn etc. the cascade now matchers that of Chrome so we are in a much better place.!! According to https://www.w3.org/TR/css-cascade-3/#cascading (which platform follows now) and https://www.w3.org/TR/css-cascade-4/#cascading we should now be doing this (descending order): - Transition declarations - User-Agent & !important - User & !important - Author & !important - CSS Animations, @keyframes - Author, normal weight - User, normal weight - User-Agent, normal weight - specificity - Sheet Index - Rule Line - Rule Column We are only dealing with CSS selectors here so we can safely drop Transition declarations and CSS Animations because their presence here is irrelevant when it comes to the CSS cascade information we display in the computed view. This leaves us with: - User-Agent & !important - User & !important - Author & !important - Author, normal weight - User, normal weight - User-Agent, normal weight - specificity - Sheet Index - Rule Line - Rule Column ### Changes - References to content stylesheets have been changed to author stylesheet to closely match the technical terms author, user and agent stylesheets. - Simplified and modernized a bunch of for loops to make the code easier to understand. - Previous to these changes all matching parent rules were classed as equal e.g. color on the body tag was equal to color on a node's immediate container. We now use the `distance` variable to tell how close a rule is to the current node. This is the highest qualifier in our cascade calculation. - The `_agentSheet`, `_authorSheet` and `_userSheet` properties are now used to obtain a sheets origin. - `elementStyle` was renamed to `inlineStyle` in order to correctly identify the rule's origin. - We used to sort the matchedSelectors to move rules with `STATUS.MATCHED` above `STATUS.PARENT_MATCH` but this is unnecessary now that we have the `distance` property so we no longer do this. - The `compareTo()` method has been updated to match https://www.w3.org/TR/css-cascade-3/#cascading (which platform follows now) and https://www.w3.org/TR/css-cascade-4/#cascading. It has also been simplified and made far less prone to error. Differential Revision: https://phabricator.services.mozilla.com/D23711
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip