d331391aee4d2b41740d0b8615c07ffbb668585b: Bug 1415549: Use correct encoding when reporting an error with wasm module/field utf8 names; r=luke
Benjamin Bouvier <benj@benj.me> - Thu, 09 Nov 2017 14:57:50 +0100 - rev 391506
Push 97287 by bbouvier@mozilla.com at Mon, 13 Nov 2017 15:42:53 +0000
Bug 1415549: Use correct encoding when reporting an error with wasm module/field utf8 names; r=luke MozReview-Commit-ID: 8PcgvVfLa2V
5125625bd2c3d263f2dcfd9bb5b4b2b39efd54ea: Bug 1414275 - Part 3: Add unit test for the flexbox highlighter toggle in the rule view. r=pbro
Gabriel Luong <gabriel.luong@gmail.com> - Mon, 13 Nov 2017 10:02:13 -0500 - rev 391505
Push 97286 by gabriel.luong@gmail.com at Mon, 13 Nov 2017 15:02:27 +0000
Bug 1414275 - Part 3: Add unit test for the flexbox highlighter toggle in the rule view. r=pbro
2fa72fbd301425b1a16f62d3c5350edf553197a5: Bug 1414275 - Part 2: Toggle flexbox layout highlighter from the rule view next to 'display: flex|inline-flex' declarations. r=pbro
Gabriel Luong <gabriel.luong@gmail.com> - Mon, 13 Nov 2017 10:01:20 -0500 - rev 391504
Push 97286 by gabriel.luong@gmail.com at Mon, 13 Nov 2017 15:02:27 +0000
Bug 1414275 - Part 2: Toggle flexbox layout highlighter from the rule view next to 'display: flex|inline-flex' declarations. r=pbro
e5f002dcdb23d9e254f8c0e3d77b7390849bab01: Bug 1414275 - Part 1: Convert HighlightersOverlay to use es6 classes. r=pbro
Gabriel Luong <gabriel.luong@gmail.com> - Mon, 13 Nov 2017 10:01:03 -0500 - rev 391503
Push 97286 by gabriel.luong@gmail.com at Mon, 13 Nov 2017 15:02:27 +0000
Bug 1414275 - Part 1: Convert HighlightersOverlay to use es6 classes. r=pbro
0f2f2e48e66d7616a7b97c940122a0d3b7c6c290: Bug 1414362 - Outline the flex container and items in the flexbox highlighter. r=pbro
Gabriel Luong <gabriel.luong@gmail.com> - Mon, 13 Nov 2017 10:00:39 -0500 - rev 391502
Push 97285 by gabriel.luong@gmail.com at Mon, 13 Nov 2017 15:00:48 +0000
Bug 1414362 - Outline the flex container and items in the flexbox highlighter. r=pbro
baa3bbe7a9d075d8a90d8c0d899ae730f3eca6dc: Bug 1414490 - Permanently undefine the insertion point at EOF. r=smaug.
Henri Sivonen <hsivonen@hsivonen.fi> - Sun, 12 Nov 2017 20:12:31 +0200 - rev 391501
Push 97284 by hsivonen@mozilla.com at Mon, 13 Nov 2017 14:59:45 +0000
Bug 1414490 - Permanently undefine the insertion point at EOF. r=smaug. MozReview-Commit-ID: Kijs3Rxhq0X
15fa308daad34deadae4bf219cb984cf559578c2: Bug 1416235 - Don't crash when there are late writes in the Windows coverage build. r=froydnj
Marco Castelluccio <mcastelluccio@mozilla.com> - Sat, 11 Nov 2017 12:29:00 +0100 - rev 391500
Push 97283 by mcastelluccio@mozilla.com at Mon, 13 Nov 2017 14:18:42 +0000
Bug 1416235 - Don't crash when there are late writes in the Windows coverage build. r=froydnj
0d54bbebadb2879bf73f492e9bf216a458e22878: Bug 1416239 - Use GCOV_PREFIX_STRIP to strip prefix from the gcda target path. r=jmaher
Marco Castelluccio <mcastelluccio@mozilla.com> - Sat, 11 Nov 2017 12:00:50 +0100 - rev 391499
Push 97282 by mcastelluccio@mozilla.com at Mon, 13 Nov 2017 13:45:41 +0000
Bug 1416239 - Use GCOV_PREFIX_STRIP to strip prefix from the gcda target path. r=jmaher
e3e146e9bf9c1f9706597c4a656f73618348c99b: Bug 1416628 - Wait for the "popupshown" event when opening the Site Identity panel. r=johannh
Paolo Amadini <paolo.mozmail@amadzone.org> - Mon, 13 Nov 2017 13:27:54 +0000 - rev 391498
Push 97281 by paolo.mozmail@amadzone.org at Mon, 13 Nov 2017 13:35:05 +0000
Bug 1416628 - Wait for the "popupshown" event when opening the Site Identity panel. r=johannh MozReview-Commit-ID: D6JW4h32O5T
7664017a8e916b6dbe7f66e86de09d1f685abb19: Merge mozilla-central to inbound. r=merge a=merge on a CLOSED TREE
Narcis Beleuzu <nbeleuzu@mozilla.com> - Mon, 13 Nov 2017 12:02:59 +0200 - rev 391497
Push 97280 by nbeleuzu@mozilla.com at Mon, 13 Nov 2017 10:03:29 +0000
Merge mozilla-central to inbound. r=merge a=merge on a CLOSED TREE
fc194660762d1b92e1679d860a8bf41116d0f54f: Merge inbound to mozilla-central r=merge a=merge
Narcis Beleuzu <nbeleuzu@mozilla.com> - Mon, 13 Nov 2017 11:53:28 +0200 - rev 391496
Push 97280 by nbeleuzu@mozilla.com at Mon, 13 Nov 2017 10:03:29 +0000
Merge inbound to mozilla-central r=merge a=merge
47752e9824da5125cb99c9d8160795b59adcc407: Bug 1396057: Update test expectations. r=me
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 13 Nov 2017 04:18:37 +0100 - rev 391495
Push 97280 by nbeleuzu@mozilla.com at Mon, 13 Nov 2017 10:03:29 +0000
Bug 1396057: Update test expectations. r=me MozReview-Commit-ID: 4h7bVe5pHkt
6bed71583aa9a40f73db1d8cf7d386ca793c08f5: Bug 1396057: Change tests of calc in media-queries so that the root element style has been resolved first. r=Manishearth
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 10 Nov 2017 16:48:44 +0100 - rev 391494
Push 97280 by nbeleuzu@mozilla.com at Mon, 13 Nov 2017 10:03:29 +0000
Bug 1396057: Change tests of calc in media-queries so that the root element style has been resolved first. r=Manishearth This modify the tests so that the media query evaluation they're testing happens after style resolution, which would've caught a bug in rem unit evaluation inside media queries in stylo. MozReview-Commit-ID: ByaR4ZA995l
b7ebbb451e5a493673f89edb06307caefed0833a: servo: Merge #19194 - stylo: Bring back support for calc() in media-queries (from emilio:media-query-calc); r=Manishearth
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 12 Nov 2017 20:06:12 -0600 - rev 391493
Push 97280 by nbeleuzu@mozilla.com at Mon, 13 Nov 2017 10:03:29 +0000
servo: Merge #19194 - stylo: Bring back support for calc() in media-queries (from emilio:media-query-calc); r=Manishearth Bug: 1396057 Reviewed-by: Manishearth Source-Repo: https://github.com/servo/servo Source-Revision: 4970b5d1544fe8f33287b01540e972a639baa689
138f68288387ca1ae709d54b3cd452ad59a87651: Merge m-c to autoland. a=merge
Ryan VanderMeulen <ryanvm@gmail.com> - Sun, 12 Nov 2017 21:26:51 -0500 - rev 391492
Push 97280 by nbeleuzu@mozilla.com at Mon, 13 Nov 2017 10:03:29 +0000
Merge m-c to autoland. a=merge
d0207f4cfe8dc7537f8f992f051a2c2b9c9d329e: servo: Merge #19178 - enhance android build debug info in `build_commands.py` (from tigercosmos:python12); r=emilio
tigercosmos <b04209032@ntu.edu.tw> - Sun, 12 Nov 2017 18:37:10 -0600 - rev 391491
Push 97280 by nbeleuzu@mozilla.com at Mon, 13 Nov 2017 10:03:29 +0000
servo: Merge #19178 - enhance android build debug info in `build_commands.py` (from tigercosmos:python12); r=emilio <!-- Please describe your changes on the following line: --> I have some experience with building android. Sometimes I forget to set `ANDROID_NDK` or `ANDROID_SDK` when I create a new clean environment, and I would know only when build error message come out.(After very long time) I think we could enhance the debug engineering at the beginning. Also fix the previous work #19109 I forgot to consider if `open()` crash(file not exist). --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #19095 (github issue number if applicable). <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: ccc739d635b8071e0375fbf6c9fb2eb2366882eb
9ed88d4cc9b6207136fba334bb3298efdf01acae: servo: Merge #19127 - scroll, SetScrollTop, SetScrollLeft in `element.rs` (from tigercosmos:overflow10); r=emilio
tigercosmos <b04209032@ntu.edu.tw> - Sun, 12 Nov 2017 17:24:33 -0600 - rev 391490
Push 97280 by nbeleuzu@mozilla.com at Mon, 13 Nov 2017 10:03:29 +0000
servo: Merge #19127 - scroll, SetScrollTop, SetScrollLeft in `element.rs` (from tigercosmos:overflow10); r=emilio <!-- Please describe your changes on the following line: --> Currently dom-element-scroll have not finished yet. (Step 10) This PR finish the step 10 of `scroll`, `SetScrollTop`, `SetScrollLeft` [Step 10 description](https://drafts.csswg.org/cssom-view/#dom-element-scrolltop): > If the element does not have any associated CSS layout box, the element has no associated scrolling box, or the element has no overflow, terminate these steps. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #19114 (github issue number if applicable). <!-- Either: --> - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 37760054e2cf742c9043b96b832d2fbdf796d367
cf6e51eb9bae57ae0ea5a674342666a2a33f0597: Bug 1416597 - Include Printf.h in Logging.cpp. r=froydnj
Chris Pearce <cpearce@mozilla.com> - Mon, 13 Nov 2017 10:07:39 +1300 - rev 391489
Push 97280 by nbeleuzu@mozilla.com at Mon, 13 Nov 2017 10:03:29 +0000
Bug 1416597 - Include Printf.h in Logging.cpp. r=froydnj MozReview-Commit-ID: 5ZMMkvaOKtO
64bd4d75004d2af2256ad76f4f23c50e2d7ffe8c: Bug 1353319 - Fix cyrillic text test after re-adding the HTML preview. r=Honza
Brandon Cheng <brandon.cheng@protonmail.com> - Sat, 28 Oct 2017 23:33:41 -0400 - rev 391488
Push 97280 by nbeleuzu@mozilla.com at Mon, 13 Nov 2017 10:03:29 +0000
Bug 1353319 - Fix cyrillic text test after re-adding the HTML preview. r=Honza Adding an HTML preview above the raw payload viewer on the developer tools response tab caused browser_net_cyrillic-02.js to fail since CodeMirror only renders visible lines to the DOM. The new HTML preview shares space with the CodeMirror editor, so the resulting height became shorter; enough to hide the line this test was looking for. This solution uses CodeMirror.getValue() to retrieve the contents of all lines stored in memory. Checking against that will allow the test to pass since it contains the cyrillic text. One downside is that this makes the test less reliable since it may not be guaranteed that what CodeMirror has buffered to render will actually be what's inserted into the DOM. Two other solutions were explored before settling on the one above. The first was simulating scroll events through EventUtils.sendWheelAndPaint. const event = { deltaMode: WheelEvent.DOM_DELTA_LINE, deltaY: 20 } yield new Promise(resolve => { EventUtils.sendWheelAndPaint( document.querySelector(".CodeMirror-scroll"), 10, 10, event, resolve, monitor.panelWin ); }) This did scroll the editor enough to render content and pass the test, but caused additional errors since monitor.panelWin did not have a .waitForAllPaintsFlushed() method that EventUtils.sendWheelAndPaint expected. The below alternative uses a hard-coded scroll amount and a requestAnimationFrame as a rough estimate of when scrolling finished. It worked in the ten or so runs I tested, but there's nothing guaranteed about requestAnimationFrame that indicates when CodeMirror's rendering has finished. document.querySelector(".CodeMirror-scroll").scrollBy(0, 200); yield new Promise(resolve => requestAnimationFrame(resolve)); MozReview-Commit-ID: H95HjR8UNpx
edbc03f93f6a03fcc376cae723b0c6ed12228616: Bug 1353319 - Make SourceEditor flex when next to an HTML preview. r=Honza
Brandon Cheng <brandon.cheng@protonmail.com> - Sat, 28 Oct 2017 23:33:22 -0400 - rev 391487
Push 97280 by nbeleuzu@mozilla.com at Mon, 13 Nov 2017 10:03:29 +0000
Bug 1353319 - Make SourceEditor flex when next to an HTML preview. r=Honza MozReview-Commit-ID: 71sq86ka2ZL
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip