d2d0b0d3b43b3d730ec468e13d9de86ec4cc86b5: Bug 1463985 - part 10: Rename EditSubAction::deleteSelection to EditSubAction::eDeleteSelectedContent r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 28 May 2018 21:49:56 +0900 - rev 420641
Push 103846 by apavel@mozilla.com at Thu, 31 May 2018 10:08:04 +0000
Bug 1463985 - part 10: Rename EditSubAction::deleteSelection to EditSubAction::eDeleteSelectedContent r=m_kato MozReview-Commit-ID: 8LNY42KnyDf
a343a1752684bb0a4867da6748a766b3baeea55f: Bug 1463985 - part 9: Rename EditSubAction::insertIMEText to EditSubAction::eInsertTextComingFromIME r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 28 May 2018 21:44:39 +0900 - rev 420640
Push 103846 by apavel@mozilla.com at Thu, 31 May 2018 10:08:04 +0000
Bug 1463985 - part 9: Rename EditSubAction::insertIMEText to EditSubAction::eInsertTextComingFromIME r=m_kato MozReview-Commit-ID: 1TmryMStB7H
666cdc7ef8e2075f7b3cce136e64c8395b6b5ccd: Bug 1463985 - part 8: Rename EditSubAction::insertText to EditSubAction::eInsertText r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 28 May 2018 21:36:47 +0900 - rev 420639
Push 103846 by apavel@mozilla.com at Thu, 31 May 2018 10:08:04 +0000
Bug 1463985 - part 8: Rename EditSubAction::insertText to EditSubAction::eInsertText r=m_kato MozReview-Commit-ID: Bd7GMng3T1T
e1135fe082bcdb789cc6c73f761ec114da4c706a: Bug 1463985 - part 7: Rename EditSubAction::eDeleteText to EditSubAction::deleteText r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 28 May 2018 21:29:14 +0900 - rev 420638
Push 103846 by apavel@mozilla.com at Thu, 31 May 2018 10:08:04 +0000
Bug 1463985 - part 7: Rename EditSubAction::eDeleteText to EditSubAction::deleteText r=m_kato And the odd number assign does not make sense anymore. So, removes it. MozReview-Commit-ID: JSyMNcrNhpP
432c41a3f433d25a102d8de273362d0306d3b0d9: Bug 1463985 - part 6: Rename EditSubAction::splitNode and EditSubAction::joinNode to EditSubAction::eSplitNode and EditSubAction::eJoinNodes r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 28 May 2018 21:25:20 +0900 - rev 420637
Push 103846 by apavel@mozilla.com at Thu, 31 May 2018 10:08:04 +0000
Bug 1463985 - part 6: Rename EditSubAction::splitNode and EditSubAction::joinNode to EditSubAction::eSplitNode and EditSubAction::eJoinNodes r=m_kato MozReview-Commit-ID: Lk0UKyzWK8d
1e428fda3c71f4d0201411fc6b13f466f275284c: Bug 1463985 - part 5: Rename EditSubAction::deleteNode to EditSubAction::eDeleteNode r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 28 May 2018 21:19:34 +0900 - rev 420636
Push 103846 by apavel@mozilla.com at Thu, 31 May 2018 10:08:04 +0000
Bug 1463985 - part 5: Rename EditSubAction::deleteNode to EditSubAction::eDeleteNode r=m_kato MozReview-Commit-ID: 1K5bdzvNUaF
fba1566eb6a061dfa0c486e62c14ebd5b78400be: Bug 1463985 - part 4: Rename EditSubAction::insertNode and EditSubAction::createNode to EditSubAction::eInsertNode and EditSubAction::eCreateNode r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 28 May 2018 21:16:44 +0900 - rev 420635
Push 103846 by apavel@mozilla.com at Thu, 31 May 2018 10:08:04 +0000
Bug 1463985 - part 4: Rename EditSubAction::insertNode and EditSubAction::createNode to EditSubAction::eInsertNode and EditSubAction::eCreateNode r=m_kato Although, there might be no reason to have those edit sub-actions separately. MozReview-Commit-ID: BaaNCqfk4V4
14054ff180108dd6338a4ac67a3f122685cc5631: Bug 1463985 - part 3: Rename EditSubAction::undo and EditSubAction::redo to EditSubAction::eUndo and EditSubAction::eRedo r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 28 May 2018 20:36:06 +0900 - rev 420634
Push 103846 by apavel@mozilla.com at Thu, 31 May 2018 10:08:04 +0000
Bug 1463985 - part 3: Rename EditSubAction::undo and EditSubAction::redo to EditSubAction::eUndo and EditSubAction::eRedo r=m_kato MozReview-Commit-ID: 3eNlmFimFlu
a653f964dbf802de11470426a12b68af67ca084b: Bug 1463985 - part 2: Rename EditSubAction::none to EditSubAction::eNone r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 28 May 2018 20:29:34 +0900 - rev 420633
Push 103846 by apavel@mozilla.com at Thu, 31 May 2018 10:08:04 +0000
Bug 1463985 - part 2: Rename EditSubAction::none to EditSubAction::eNone r=m_kato MozReview-Commit-ID: 4wJyaNS1P1y
1d39e0165b4169ee3711644b2a31656bad2c59f3: Bug 1463985 - part 1: Rename EditAction to EditSubAction and related stuff r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 28 May 2018 20:12:34 +0900 - rev 420632
Push 103846 by apavel@mozilla.com at Thu, 31 May 2018 10:08:04 +0000
Bug 1463985 - part 1: Rename EditAction to EditSubAction and related stuff r=m_kato When we implement InputEvent.inputType, we need to set a stack class to record which edit action is currently handled. However, currently, we call smaller jobs as edit action. For example, when user types a character at selecting some characters, then, EditAction::deleteSelection is performed first, then, EditAction::insertText is performed. However, for the InputEvent.inputType, we need inserText information. So, for making new enum EditAction, we need to rename current EditAction to EditSubAction. And also this renames related stuff: EditorBase::mIsInEditAction -> EditorBase::mIsInEditSubAction EditorBase::IsInEditAction() -> EditorBase::IsInEditSubAction() EditorBase::mAction -> EditorBase::mTopLevelEditSubAction TextEditRules::mTheAction -> TextEditRules::mTopLevelEditSubAction EditorBase::StartOperation() -> EditorBase::OnStartToHandleTopLevelEditSubAction() EditorBase::EndOperation() -> EditorBase::OnEndHandlingTopLevelEditSubAction() AutoRules -> AutoTopLevelEditSubActionNotifier RulesInfo -> EditSubActionInfo MozReview-Commit-ID: cvSkPUjFm1
76b492ce782870d2371708b2187eb9506530b4af: Bug 1457353 - P3: Disable failing SMIL tests. r=hiro,xidorn
Dan Glastonbury <dan.glastonbury@gmail.com> - Wed, 30 May 2018 14:12:08 +1000 - rev 420631
Push 103846 by apavel@mozilla.com at Thu, 31 May 2018 10:08:04 +0000
Bug 1457353 - P3: Disable failing SMIL tests. r=hiro,xidorn Disable failing SMIL tests for lighting-color with currentcolor until StyleComplexColor is extended to support addition. MozReview-Commit-ID: 6tbDYPFI9ey
9ca706d68d3f936d3880bb14b2d6a780882dd875: Bug 1457353 - P2: Simple reftests. r=xidorn
Dan Glastonbury <dan.glastonbury@gmail.com> - Fri, 27 Apr 2018 15:14:30 +1000 - rev 420630
Push 103846 by apavel@mozilla.com at Thu, 31 May 2018 10:08:04 +0000
Bug 1457353 - P2: Simple reftests. r=xidorn To show the feature working. MozReview-Commit-ID: SR7Z1tMaal
f82bde34ccde67f3ed2246e992552f8ee0eb8a83: Bug 1457353 - P1: Change nscolor to StyleComplexColor. r=xidorn
Dan Glastonbury <dan.glastonbury@gmail.com> - Fri, 27 Apr 2018 12:07:20 +1000 - rev 420629
Push 103846 by apavel@mozilla.com at Thu, 31 May 2018 10:08:04 +0000
Bug 1457353 - P1: Change nscolor to StyleComplexColor. r=xidorn Change mStopColor, mFloodColor, and mLightingColor in nsStyleSVGReset. MozReview-Commit-ID: KMRMtHk1jNK
07db1154d5b9411004d33cfe5d6a0e842cf15163: Bug 1253064 - Prefer Clang to GCC in local developer builds. r=gps
Mike Hommey <mh+mozilla@glandium.org> - Thu, 31 May 2018 10:16:10 +0900 - rev 420628
Push 103846 by apavel@mozilla.com at Thu, 31 May 2018 10:08:04 +0000
Bug 1253064 - Prefer Clang to GCC in local developer builds. r=gps For Android targets, we just ignore plain clang, it's unlikely to work.
5e985e187d857338b2ee3c8ade078cc901897450: Backed out changeset b9bf5db54805 (bug 1463750) for ESlint failure at test_remote_settings.js on a CLOSED TREE
Coroiu Cristina <ccoroiu@mozilla.com> - Thu, 31 May 2018 04:48:38 +0300 - rev 420627
Push 103846 by apavel@mozilla.com at Thu, 31 May 2018 10:08:04 +0000
Backed out changeset b9bf5db54805 (bug 1463750) for ESlint failure at test_remote_settings.js on a CLOSED TREE
b9bf5db54805043c8e35e43f60824cf34c4a061b: Bug 1463750 - Move RemoteSettings to services/settings/ r=mgoodwin
Mathieu Leplatre <mathieu@mozilla.com> - Thu, 24 May 2018 15:32:40 +0200 - rev 420626
Push 103846 by apavel@mozilla.com at Thu, 31 May 2018 10:08:04 +0000
Bug 1463750 - Move RemoteSettings to services/settings/ r=mgoodwin MozReview-Commit-ID: 7IwUysPBHZu
b87edc90b50d29f0f90bd493c5f87c0cfb224c8e: Bug 1463589 - Add contain:size and contain:content parsing functionality. r=emilio
Morgan Rae Reschenberg <mreschenberg@mozilla.com> - Wed, 30 May 2018 07:49:31 -0700 - rev 420625
Push 103846 by apavel@mozilla.com at Thu, 31 May 2018 10:08:04 +0000
Bug 1463589 - Add contain:size and contain:content parsing functionality. r=emilio MozReview-Commit-ID: 4fOqln3oOpC
85d13ab240face6ef86b27f7fc22e8b255fb7b72: Bug 1457590 - Use the HitTestingTreeNodeAutoLock. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 30 May 2018 15:54:51 -0400 - rev 420624
Push 103846 by apavel@mozilla.com at Thu, 31 May 2018 10:08:04 +0000
Bug 1457590 - Use the HitTestingTreeNodeAutoLock. r=botond This updates the GetTargetAPZC function to produce a HitTestingTreeNodeAutoLock out-param instead of a RefPtr<HitTestingTreeNode>, to ensure that the node can be used safely in calling functions. It then propagates that change outward as needed, which covers all the scrollbar dragging code. MozReview-Commit-ID: 43K4eSECb4E
437b901404dbea22d9fc7fdf8c3d363adbdf20f3: Bug 1457590 - Add the HitTestingTreeNodeAutoLock class. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 30 May 2018 15:54:50 -0400 - rev 420623
Push 103846 by apavel@mozilla.com at Thu, 31 May 2018 10:08:04 +0000
Bug 1457590 - Add the HitTestingTreeNodeAutoLock class. r=botond This adds the HitTestingTreeNodeAutoLock RAII class that allows using a HitTestingTreeNode safely outside a tree lock, and ensures that the node won't get destroyed or recycled concurrently. MozReview-Commit-ID: 8Tb3vdIeUgr
8a1bdb8d8bf5a1c8869bf3f82fd86c56f9f4b72c: Bug 1457590 - Strengthen the contract around recycling HitTestingTreeNodes. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 30 May 2018 15:54:50 -0400 - rev 420622
Push 103846 by apavel@mozilla.com at Thu, 31 May 2018 10:08:04 +0000
Bug 1457590 - Strengthen the contract around recycling HitTestingTreeNodes. r=botond This patch makes three related changes: - A non-functional change that factors a IsRecyclable function on HitTestingTreeNode. - A non-functional change that sprinkles proof-of-tree-lock arguments to a few HitTestingTreeNode functions, to ensure at compile-time that they can only be called while holding the tree lock. - A functional change that stops clearing mLayersId in HitTestingTreeNode::Destroy, so that if a node is non-recyclable, and it gets Destroy()'d while other code still has a RefPtr to it, that other code can still read the layers id off in a safe manner. These changes provide a stronger set of checks around node recycling, and allows for a safe mechanism to use a HitTestingTreeNode on the controller thread without having to lock the entire APZ tree. The mechanism is effectively a per-node lock, which will be added in the next patch. MozReview-Commit-ID: DBIjFDZJwhE
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip