d29131a841689c606dc2ced3be4298fa748ee59b: Bug 1501502 - Assertion failure: IsObjectValueInCompartment(v, compartment()) with bogus queuing strategy object. r=tcampbell
Jason Orendorff <jorendorff@mozilla.com> - Sat, 03 Nov 2018 13:13:55 +0000 - rev 444319
Push 109553 by ncsoregi@mozilla.com at Sat, 03 Nov 2018 21:48:14 +0000
Bug 1501502 - Assertion failure: IsObjectValueInCompartment(v, compartment()) with bogus queuing strategy object. r=tcampbell Differential Revision: https://phabricator.services.mozilla.com/D10773
e6860806fc1fc0f4e8144af6e7fa7cfae8eb88f3: Backed out 2 changesets (bug 1501503) as requested by bradwerth on the ticket.
Brindusan Cristian <cbrindusan@mozilla.com> - Sat, 03 Nov 2018 15:03:29 +0200 - rev 444318
Push 109553 by ncsoregi@mozilla.com at Sat, 03 Nov 2018 21:48:14 +0000
Backed out 2 changesets (bug 1501503) as requested by bradwerth on the ticket. Backed out changeset 814414676c25 (bug 1501503) Backed out changeset c2d9f82adf43 (bug 1501503)
bb81f74e232ad6a145f7ebf526bd066a228d01ec: Bug 1503473 - part 5: Move InsertParagraphSeparator*() into HTMLEditor r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Sat, 03 Nov 2018 04:19:22 +0000 - rev 444317
Push 109553 by ncsoregi@mozilla.com at Sat, 03 Nov 2018 21:48:14 +0000
Bug 1503473 - part 5: Move InsertParagraphSeparator*() into HTMLEditor r=m_kato Now, TextEditor needs only InsertLineBreak*() so that InsertParagraphSeparator*() is necessary only in HTMLEditor. With overriding nsIPlaintextEditor::InsertLineBreak() in HTMLEditor, we can do it simply. Differential Revision: https://phabricator.services.mozilla.com/D10525
dffafc01a94d0455fc4b44e42548d36b573fdbf5: Bug 1503473 - part 4: Create a new path to handle Enter key press in TextEditor r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Sat, 03 Nov 2018 11:22:13 +0000 - rev 444316
Push 109553 by ncsoregi@mozilla.com at Sat, 03 Nov 2018 21:48:14 +0000
Bug 1503473 - part 4: Create a new path to handle Enter key press in TextEditor r=m_kato This patch creates new path to insert a line break in TextEditor. Declares new EditSubAction::eInsertLineBreak and makes the path use EditAction::eInsertLineBreak instead of EditAction::eInsertParagraphSeparator. Unfortunately, this patch makes TextEditor::InsertLineBreakAsAction() as a virtual method for keeping this change as small as possible. Differential Revision: https://phabricator.services.mozilla.com/D10524
952458a5da30ad6f6542c8899755c8c6ef16db79: Bug 1503473 - part 3: Move inserting a line break code in TextEditor::InsertParagraphSeparatorAsSubAction() to TextEditRules::WillInsertLineBreak() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Sat, 03 Nov 2018 11:21:15 +0000 - rev 444315
Push 109553 by ncsoregi@mozilla.com at Sat, 03 Nov 2018 21:48:14 +0000
Bug 1503473 - part 3: Move inserting a line break code in TextEditor::InsertParagraphSeparatorAsSubAction() to TextEditRules::WillInsertLineBreak() r=m_kato When TextEditRules::WillDoAction() and HTMLEditRules::WillDoAction() didn't return error, didn't handle it, and didn't cancel it, TextEditor::InsertParagraphSeparatorAsSubAction() inserts a line breaker. However, this case is only when the instance is TextEditRules and TextEditRules::WillInsertLineBreak() prepares to insert a line break without any errors. So, we can move the part into TextEditRules::WillInsertLineBreak() simply. Differential Revision: https://phabricator.services.mozilla.com/D10523
45bc2423e812560a8cd69b0639e70096cbac83b5: Bug 1503473 - part 2: Make TextEditRules::WillInsertBreak() and HTMLEditRules::WillInsertBreak() return EditActionResult r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Sat, 03 Nov 2018 11:20:06 +0000 - rev 444314
Push 109553 by ncsoregi@mozilla.com at Sat, 03 Nov 2018 21:48:14 +0000
Bug 1503473 - part 2: Make TextEditRules::WillInsertBreak() and HTMLEditRules::WillInsertBreak() return EditActionResult r=m_kato With this cleaning up, we can know when they return NS_OK with both aCanceled is false and aHandled is false. (Look for EditActionIgnored().) Additionally, this patch renames HTMLEditRules::WillInsertBreak() to WillInsertParagraphSeparator() and TextEditRules::WillInsertBreak() to TextEditRules::WillInsertLineBreak(). Differential Revision: https://phabricator.services.mozilla.com/D10522
3f5d390db0faf52000531b31b579b27fb73c04b1: Bug 1503473 - part 1: Rename TextEditor::OnInputParagraphSeparator() and HTMLEditor::OnInputLineBreak() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Sat, 03 Nov 2018 11:19:07 +0000 - rev 444313
Push 109553 by ncsoregi@mozilla.com at Sat, 03 Nov 2018 21:48:14 +0000
Bug 1503473 - part 1: Rename TextEditor::OnInputParagraphSeparator() and HTMLEditor::OnInputLineBreak() r=m_kato TextEditor::OnInputParagraphSeparator() and HTMLEditor::OnInputLineBreak() are also used by command handlers. Therefore, they should be renamed to TextEditor::InsertParagraphSeparatorAsAction() and HTMLEditor::InsertLineBreakAsAction(). Then, current TextEditor::InsertParagraphSeparatorAsAction() should be renamed to AsSubAction() and each caller of it should create AutoPlaceholderBatch by themselves. Differential Revision: https://phabricator.services.mozilla.com/D10521
86ab0cd2855c06099abce0a68700127dcbd26193: Bug 1504447 - Grant runtime permissions to test app before running geckoview-junit; r=bc
Geoff Brown <gbrown@mozilla.com> - Sat, 03 Nov 2018 14:22:50 -0600 - rev 444312
Push 109552 by gbrown@mozilla.com at Sat, 03 Nov 2018 20:23:05 +0000
Bug 1504447 - Grant runtime permissions to test app before running geckoview-junit; r=bc
ef27c14b46bf58f710753ae6bb6d2c01a8c3631f: Merge inbound to mozilla-central. a=merge
shindli <shindli@mozilla.com> - Sat, 03 Nov 2018 11:40:50 +0200 - rev 444311
Push 109551 by shindli@mozilla.com at Sat, 03 Nov 2018 09:55:44 +0000
Merge inbound to mozilla-central. a=merge
6655fa7cff4800390e15d164968923da168ce7c8: Merge autoland to mozilla-central. a=merge
shindli <shindli@mozilla.com> - Sat, 03 Nov 2018 11:39:41 +0200 - rev 444310
Push 109551 by shindli@mozilla.com at Sat, 03 Nov 2018 09:55:44 +0000
Merge autoland to mozilla-central. a=merge
75e4c3050cac5acc38d3031fb97bed8eaca59222: Backed out 5 changesets (bug 1503473) for crashes in Thunderbird on request of jorgk. a=backout
Cosmin Sabou <csabou@mozilla.com> - Sat, 03 Nov 2018 02:08:42 +0200 - rev 444309
Push 109551 by shindli@mozilla.com at Sat, 03 Nov 2018 09:55:44 +0000
Backed out 5 changesets (bug 1503473) for crashes in Thunderbird on request of jorgk. a=backout Backed out changeset a7f7d9f366b9 (bug 1503473) Backed out changeset d067907793ef (bug 1503473) Backed out changeset 130ba0de053f (bug 1503473) Backed out changeset ec732243e9ad (bug 1503473) Backed out changeset 13511cab2b41 (bug 1503473)
4ec5f59ab7236bce89f734ccdea1ec4c7f5fd95d: Bug 1496242 - Part III, nsFocusManager should account for UA Widget when deciding to traverse into NAC r=smaug
Timothy Guan-tin Chien <timdream@gmail.com> - Mon, 29 Oct 2018 19:51:17 +0000 - rev 444308
Push 109551 by shindli@mozilla.com at Sat, 03 Nov 2018 09:55:44 +0000
Bug 1496242 - Part III, nsFocusManager should account for UA Widget when deciding to traverse into NAC r=smaug In bug 1430692, a special case was added in nsFocusManager::GetNextTabbableContentInScope() that traverse into the element when the primany frame implements nsIAnonymousContentCreator, assuming there will be NAC to focus within. This is not the case when UA Widget is turned on, where the focusable inner inputs will be put in the UA Widget Shadow DOM. The change here account this fact. Depends on D9057 Differential Revision: https://phabricator.services.mozilla.com/D9303
66df568f60f633bb8e361be0a256cb4490330bf8: Bug 1496242 - Part II, Convert datetimebox to UA Widget r=dholbert,jaws,smaug
Timothy Guan-tin Chien <timdream@gmail.com> - Sat, 03 Nov 2018 05:31:05 +0000 - rev 444307
Push 109551 by shindli@mozilla.com at Sat, 03 Nov 2018 09:55:44 +0000
Bug 1496242 - Part II, Convert datetimebox to UA Widget r=dholbert,jaws,smaug This patch converts datetimebox.xml to datetimebox.js and loads it as a UA Widget, while touches things here and there to make it work. In HTMLInputElement manages the lifecycle of the datetimebox UA Widget. It is loaded when in <input> has type date or time, or have its type switch to date or time. nsDateTimeControlFrame is changed so that when UA Widget is enabled, it would not generate <xul:datetimebox>. Like bug 1483972, a check is added in nsCSSFrameConstructor::CreateGeneratedContentItem() to make sure we don't generate pseudo content inside <input>. Assertions in IntlUtils is changed to allow UAWidget to call the methods. Depends on D9056 Differential Revision: https://phabricator.services.mozilla.com/D9057
1387262d2f93391e11c1298f5148fc62ffcc4557: Bug 1496242 - Part I, Simplify nsIDateTimeInputArea interface r=mconley,smaug
Timothy Guan-tin Chien <timdream@gmail.com> - Fri, 02 Nov 2018 23:29:42 +0000 - rev 444306
Push 109551 by shindli@mozilla.com at Sat, 03 Nov 2018 09:55:44 +0000
Bug 1496242 - Part I, Simplify nsIDateTimeInputArea interface r=mconley,smaug This patch simplifies the nsIDateTimeInputArea interface, implemented by the datetimebox bindings, to a point that is easier to convert it to dispatch events, by doing the following: - hasBadInput() is re-implemented in C++ in nsIDateTimeControlFrame since C++ needs the return value synchronously. - SetValueFromPicker() and SetPickerState() are avoided completed since they are simply called by HTMLInputElement methods exposed to the frame script. They are avoided by having the frame script access the NAC and call the nsIDateTimeInputArea methods directly. - Merge setEditAttribute() and removeEditAttribute() to updateEditAttributes() which takes no arguments, and have the method access the attribute values by reading the values from <input>. This patch is a scaled-down version of the patch proposed in bug 1456833. The event approach is only usable in UA Widget version of datetimebox because there is no way to avoid leaking events to the document without Shadow DOM. Differential Revision: https://phabricator.services.mozilla.com/D9056
e9ac4160d051f7ec520c7a0534b75c4b10386873: Bug 1504361: Add MOZ_LOG logging to note when we reflow a flex item extra times. r=emilio
Daniel Holbert <dholbert@cs.stanford.edu> - Sat, 03 Nov 2018 00:41:05 +0000 - rev 444305
Push 109551 by shindli@mozilla.com at Sat, 03 Nov 2018 09:55:44 +0000
Bug 1504361: Add MOZ_LOG logging to note when we reflow a flex item extra times. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D10791
c0536dc391c345430a421309ab67e837a89efd5d: Backed out 3 changesets (bug 1417976) for causing devtools failures in builds/worker/workspace/build/src/tools/profiler/core/platform.cpp
Noemi Erli <nerli@mozilla.com> - Sat, 03 Nov 2018 01:40:27 +0200 - rev 444304
Push 109551 by shindli@mozilla.com at Sat, 03 Nov 2018 09:55:44 +0000
Backed out 3 changesets (bug 1417976) for causing devtools failures in builds/worker/workspace/build/src/tools/profiler/core/platform.cpp Backed out changeset e70a24d50f20 (bug 1417976) Backed out changeset 01ca16ef0b25 (bug 1417976) Backed out changeset ede2fbe20d14 (bug 1417976)
7f054082806036d22e2fe7899a6be66e7706c515: Backed out changeset 2a3a7c533bc0 (bug 1501502) for spidermonkey bustages on non262/ReadableStream/bug-1501502.js CLOSED TREE
arthur.iakab <aiakab@mozilla.com> - Sat, 03 Nov 2018 01:02:35 +0200 - rev 444303
Push 109551 by shindli@mozilla.com at Sat, 03 Nov 2018 09:55:44 +0000
Backed out changeset 2a3a7c533bc0 (bug 1501502) for spidermonkey bustages on non262/ReadableStream/bug-1501502.js CLOSED TREE
2a3a7c533bc0a897051fe31e9fd85c2f7764e43f: Bug 1501502 - Assertion failure: IsObjectValueInCompartment(v, compartment()) with bogus queuing strategy object. r=tcampbell
Jason Orendorff <jorendorff@mozilla.com> - Fri, 02 Nov 2018 21:52:23 +0000 - rev 444302
Push 109551 by shindli@mozilla.com at Sat, 03 Nov 2018 09:55:44 +0000
Bug 1501502 - Assertion failure: IsObjectValueInCompartment(v, compartment()) with bogus queuing strategy object. r=tcampbell Differential Revision: https://phabricator.services.mozilla.com/D10773
07f248c9a47d0be914ef9dd17f6cfb63721a895e: Bug 1503468 - Add more AUTO_PROFILER_THREAD_SLEEP's - r=mstange
Gerald Squelart <gsquelart@mozilla.com> - Fri, 02 Nov 2018 16:26:50 +0000 - rev 444301
Push 109551 by shindli@mozilla.com at Sat, 03 Nov 2018 09:55:44 +0000
Bug 1503468 - Add more AUTO_PROFILER_THREAD_SLEEP's - r=mstange These are around wait functions that already had an IDLE marker. Differential Revision: https://phabricator.services.mozilla.com/D10671
7cd7b017af5dda8ba59af4348997614a48c9e8b2: Bug 1489858 - Simplify a bit the conditional. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 02 Nov 2018 22:42:09 +0100 - rev 444300
Push 109551 by shindli@mozilla.com at Sat, 03 Nov 2018 09:55:44 +0000
Bug 1489858 - Simplify a bit the conditional. r=smaug
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip