c75d6a0539eb4b2c7961f0c9782fcb364198c6b2: Merge autoland to mozilla-central. a=merge FIREFOX_BETA_70_BASE
Dorel Luca <dluca@mozilla.com> - Mon, 26 Aug 2019 12:42:03 +0300 - rev 489839
Push 113971 by dluca@mozilla.com at Mon, 26 Aug 2019 09:49:12 +0000
Merge autoland to mozilla-central. a=merge
714f6061c12c657c5d9b9a5f6be7127f07be90bb: Bug 1575548 - Enable websockets in netmonitor's browser_net_ws-* tests to prevent them from failing on non-central branches. r=Honza DONTBUILD a=Aryx
Sebastian Hengst <archaeopteryx@coole-files.de> - Mon, 26 Aug 2019 09:19:35 +0000 - rev 489838
Push 113971 by dluca@mozilla.com at Mon, 26 Aug 2019 09:49:12 +0000
Bug 1575548 - Enable websockets in netmonitor's browser_net_ws-* tests to prevent them from failing on non-central branches. r=Honza DONTBUILD a=Aryx Differential Revision: https://phabricator.services.mozilla.com/D43298
dcd9ee807647b01a5bf493ad0c8e11cfb5c17e8b: Backed out 2 changesets (bug 1427877) for causing Thunderbird xpcshell-bustages. a=backout
Jorg K <jorgk@jorgk.com> - Mon, 26 Aug 2019 09:42:37 +0200 - rev 489837
Push 113971 by dluca@mozilla.com at Mon, 26 Aug 2019 09:49:12 +0000
Backed out 2 changesets (bug 1427877) for causing Thunderbird xpcshell-bustages. a=backout MANUAL PUSH: Approval from sheriffs via IRC. Immediate fix for massive xpcshell failures. Backed out changeset 6b90caa175cb (bug 1427877) Backed out changeset bf126cb4b08f (bug 1427877)
fbbcc4e9d6f4408eceb646f1ba877cff009a54b9: Bug 1575548 - Enable websockets in netmonitor's browser_net_ws-* tests to prevent them from failing on non-central branches. r=Honza
Sebastian Hengst <archaeopteryx@coole-files.de> - Mon, 26 Aug 2019 09:19:35 +0000 - rev 489836
Push 113971 by dluca@mozilla.com at Mon, 26 Aug 2019 09:49:12 +0000
Bug 1575548 - Enable websockets in netmonitor's browser_net_ws-* tests to prevent them from failing on non-central branches. r=Honza Differential Revision: https://phabricator.services.mozilla.com/D43298
2871d02f3f7b9c776240b38adda364d34a2954d2: Bug 1574852 - part 37: Move `HTMLEditRules::ApplyBlockStyle()` to `HTMLEditor` r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 26 Aug 2019 04:48:21 +0000 - rev 489835
Push 113971 by dluca@mozilla.com at Mon, 26 Aug 2019 09:49:12 +0000
Bug 1574852 - part 37: Move `HTMLEditRules::ApplyBlockStyle()` to `HTMLEditor` r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D43198
85b7e9527466c46c42891d7542cf0f28159d756b: Bug 1574852 - part 36: Move `HTMLEditRules::RemvoeBlockStyle()` to `HTMLEditor` r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 26 Aug 2019 04:00:15 +0000 - rev 489834
Push 113971 by dluca@mozilla.com at Mon, 26 Aug 2019 09:49:12 +0000
Bug 1574852 - part 36: Move `HTMLEditRules::RemvoeBlockStyle()` to `HTMLEditor` r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D43197
9d63a239b705340e93e1fe7b9ff497f63f34a63a: Bug 1574852 - part 35: Move `HTMLEditRules::SplitRangeOffFromBlockAndRemoveMiddleContainer()` to `HTMLEditor` r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 26 Aug 2019 03:59:48 +0000 - rev 489833
Push 113971 by dluca@mozilla.com at Mon, 26 Aug 2019 09:49:12 +0000
Bug 1574852 - part 35: Move `HTMLEditRules::SplitRangeOffFromBlockAndRemoveMiddleContainer()` to `HTMLEditor` r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D43196
c701cf449d2ccf1695392a7ad2348d3922a2bd08: Bug 1574852 - part 34: Move `HTMLEditRules::SplitRangeOffFromBlock()` to `HTMLEditor` r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 26 Aug 2019 03:20:35 +0000 - rev 489832
Push 113971 by dluca@mozilla.com at Mon, 26 Aug 2019 09:49:12 +0000
Bug 1574852 - part 34: Move `HTMLEditRules::SplitRangeOffFromBlock()` to `HTMLEditor` r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D43195
03f0d268860463a053a72413b7e10596c97fbd88: Bug 1575495: part 5) Add comment to `setWrapColumn` that value 0 disables wrapping. r=hsivonen
Mirko Brodesser <mbrodesser@mozilla.com> - Fri, 23 Aug 2019 13:17:08 +0000 - rev 489831
Push 113971 by dluca@mozilla.com at Mon, 26 Aug 2019 09:49:12 +0000
Bug 1575495: part 5) Add comment to `setWrapColumn` that value 0 disables wrapping. r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D42841
60893d2dc2d52d63d1c200154bfefbf55740db0d: Bug 1575495: part 4) Add `AddLineBreak` to `CurrentLineContent`. r=hsivonen
Mirko Brodesser <mbrodesser@mozilla.com> - Fri, 23 Aug 2019 14:00:50 +0000 - rev 489830
Push 113971 by dluca@mozilla.com at Mon, 26 Aug 2019 09:49:12 +0000
Bug 1575495: part 4) Add `AddLineBreak` to `CurrentLineContent`. r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D42840
4f533bb7002667afaf762c30f33a675fd8afad42: Bug 1575495: part 3) Sync argument names of declaration and definition of `DoAddText`. r=hsivonen
Mirko Brodesser <mbrodesser@mozilla.com> - Fri, 23 Aug 2019 13:16:46 +0000 - rev 489829
Push 113971 by dluca@mozilla.com at Mon, 26 Aug 2019 09:49:12 +0000
Bug 1575495: part 3) Sync argument names of declaration and definition of `DoAddText`. r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D42839
149e16997325445797f0bbc47bb5b4bdef458eb4: Bug 1575495: part 2) Move `MaybeReplaceNbspsForOutput` to `CurrentLineContent`. r=hsivonen
Mirko Brodesser <mbrodesser@mozilla.com> - Fri, 23 Aug 2019 13:16:37 +0000 - rev 489828
Push 113971 by dluca@mozilla.com at Mon, 26 Aug 2019 09:49:12 +0000
Bug 1575495: part 2) Move `MaybeReplaceNbspsForOutput` to `CurrentLineContent`. r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D42838
0fd980b158e3a9566edcac0d7614e5ff4c32ee25: Bug 1575495: part 1) Simplify assignments to `mAtFirstColumn`. r=hsivonen
Mirko Brodesser <mbrodesser@mozilla.com> - Fri, 23 Aug 2019 13:16:30 +0000 - rev 489827
Push 113971 by dluca@mozilla.com at Mon, 26 Aug 2019 09:49:12 +0000
Bug 1575495: part 1) Simplify assignments to `mAtFirstColumn`. r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D42837
25e387fe2c17749fa16dacffa11121cd1feebaaa: Bug 1576284 - Land strings for Firefox 70 What's New messages r=fluent-reviewers,flod
Ed Lee <edilee@mozilla.com> - Mon, 26 Aug 2019 04:57:45 +0000 - rev 489826
Push 113971 by dluca@mozilla.com at Mon, 26 Aug 2019 09:49:12 +0000
Bug 1576284 - Land strings for Firefox 70 What's New messages r=fluent-reviewers,flod Differential Revision: https://phabricator.services.mozilla.com/D43311
8257421bca60a40a94cd3c1e19a62511080d9bae: Bug 1574852 - part 33: Move `HTMLEditRules::MakeBlockquote()` to `HTMLEditor` r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 26 Aug 2019 01:55:01 +0000 - rev 489825
Push 113971 by dluca@mozilla.com at Mon, 26 Aug 2019 09:49:12 +0000
Bug 1574852 - part 33: Move `HTMLEditRules::MakeBlockquote()` to `HTMLEditor` r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D43194
15bfd420d0244d5d60bdee01d831e672e674bbc7: Bug 1574852 - part 32: Move `HTMLEditRules::MaybeSplitAncestorsForInsertWithTransaction()` to `HTMLEditor` r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 26 Aug 2019 01:38:56 +0000 - rev 489824
Push 113971 by dluca@mozilla.com at Mon, 26 Aug 2019 09:49:12 +0000
Bug 1574852 - part 32: Move `HTMLEditRules::MaybeSplitAncestorsForInsertWithTransaction()` to `HTMLEditor` r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D43193
70ec0ddc8f325ad57741865e7bd58bb311e9bb20: Bug 1576391 - Override _titlebarHeight so that the window's NSTitlebarContainerView includes the full height of the window buttons even after we've shifted them down, and re-enable the floating titlebar. r=mattwoodrow
Markus Stange <mstange@themasta.com> - Mon, 26 Aug 2019 02:05:24 +0000 - rev 489823
Push 113971 by dluca@mozilla.com at Mon, 26 Aug 2019 09:49:12 +0000
Bug 1576391 - Override _titlebarHeight so that the window's NSTitlebarContainerView includes the full height of the window buttons even after we've shifted them down, and re-enable the floating titlebar. r=mattwoodrow I've tried hard to find a solution for the clipped window button problem which does not involve swizzling but could not find one. The officially ratified ways of moving the window buttons are: 1. Use an NSToolbar in your window, or 2. Make a custom window with your own buttons. I don't think having an NSToolbar is an option for us. And making our own window frame implementation would be hard to get right and can easily behave differently from the native implementation. I've also tried asking the window to not render any window buttons on its own; then we could make our own buttons and place them on top of our view. But if I change the window's styleMask to be just NSTitledWindowMask, it doesn't only make the buttons disappear, it also makes the window non-resizable. And if I include NSResizableWindowMask, the buttons come back (only the zoom button is enabled, the other two are grayed out). This change also stops overriding _wantsFloatingTitlebar when CoreAnimation is enabled, which is necessary for the window buttons to render. Depends on D43341 Differential Revision: https://phabricator.services.mozilla.com/D43361
d09424718fea616398a3fd7cba8e809c348fb8ed: Bug 1576391 - Use NSFullSizeContentViewWindowMask for ToolbarWindows. r=mattwoodrow
Markus Stange <mstange@themasta.com> - Mon, 26 Aug 2019 02:03:56 +0000 - rev 489822
Push 113971 by dluca@mozilla.com at Mon, 26 Aug 2019 09:49:12 +0000
Bug 1576391 - Use NSFullSizeContentViewWindowMask for ToolbarWindows. r=mattwoodrow This gives us two behaviors for free which we were achieving through manual overrides: - The content view is sized to cover the entire window frame. - The window controls are placed on top of the content view (instead of underneath it in z-order). It also forces CoreAnimation layers for the window's entire NSView hierarchy, so we only use it when the CoreAnimation pref is enabled. NSFullSizeContentViewWindowMask is only available on 10.10 and up, but we still support 10.9, so we cannot remove the code with the manual overrides just yet. This change also requires a change to NonDraggableView in order to preserve window dragging behavior in the titlebar: When NSFullSizeContentViewWindowMask is used, the method which assembles the window's draggable region takes a different path. It treats the titlebar specially, and traverses the NSView hierarchy twice, once for the titlebar area and once for the rest of the window. Outside the titlebar, it calls _opaqueRect on every visible NSView, but for the titlebar area, it calls _opaqueRectForWindowMoveWhenInTitlebar instead. Overriding _opaqueRectForWindowMoveWhenInTitlebar allows us to achieve the old dragging behavior. Differential Revision: https://phabricator.services.mozilla.com/D43341
b1ea03f73bae5a29e91a2582b5c147727672759b: Bug 1576391 - Move some method overrides to ToolbarWindow. r=mattwoodrow
Markus Stange <mstange@themasta.com> - Mon, 26 Aug 2019 02:04:09 +0000 - rev 489821
Push 113971 by dluca@mozilla.com at Mon, 26 Aug 2019 09:49:12 +0000
Bug 1576391 - Move some method overrides to ToolbarWindow. r=mattwoodrow This makes them only apply in windows with titlebars, which is the only place where they're needed. The setContentView override can even cause harm for other windows, such as sheet windows, because it'll move the content view below a full-window covering solid grey view provided by the system, in builds that link against the 10.14 SDK and don't override _wantsFloatingTitlebar. Differential Revision: https://phabricator.services.mozilla.com/D43340
2d881c1ee2d0f3a92767dedd5b311e446cc138b7: Bug 1572332 - Move non-debugger devtools prefs into all.js and firefox.js. r=jdescottes
Nicholas Nethercote <nnethercote@mozilla.com> - Mon, 26 Aug 2019 01:44:59 +0000 - rev 489820
Push 113971 by dluca@mozilla.com at Mon, 26 Aug 2019 09:49:12 +0000
Bug 1572332 - Move non-debugger devtools prefs into all.js and firefox.js. r=jdescottes This makes prefs definition simpler, more consistent, and less error-prone. Differential Revision: https://phabricator.services.mozilla.com/D41145
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip