c52a3f7f06ad32032bf355cc4a3ac698832112a5: Bug 1504323 - P2 Enable ESLint for netwerk/test/httpserver/ (manual changes) r=Standard8,dragana
Junior Hsu <juhsu@mozilla.com> - Fri, 09 Nov 2018 11:28:32 +0000 - rev 445892
Push 109795 by rmaries@mozilla.com at Mon, 12 Nov 2018 17:23:23 +0000
Bug 1504323 - P2 Enable ESLint for netwerk/test/httpserver/ (manual changes) r=Standard8,dragana Differential Revision: https://phabricator.services.mozilla.com/D10986
2a943fb3c3ac81b161e08764a64bb91dbd2a6f47: Bug 1504323 - P1 Enable ESLint for netwerk/test/httpserver/ (automatic changes) r=Standard8,dragana
Junior Hsu <juhsu@mozilla.com> - Sun, 11 Nov 2018 21:25:52 +0000 - rev 445891
Push 109795 by rmaries@mozilla.com at Mon, 12 Nov 2018 17:23:23 +0000
Bug 1504323 - P1 Enable ESLint for netwerk/test/httpserver/ (automatic changes) r=Standard8,dragana Differential Revision: https://phabricator.services.mozilla.com/D10985
4e85e83ad3f86b100f6c47914ab1825b6267d271: Backed out changeset 25ccc02a44ff (bug 1504751) for high frequency browser_aboutURLs.js failures CLOSED TREE
Ciure Andrei <aciure@mozilla.com> - Mon, 12 Nov 2018 13:55:03 +0200 - rev 445890
Push 109795 by rmaries@mozilla.com at Mon, 12 Nov 2018 17:23:23 +0000
Backed out changeset 25ccc02a44ff (bug 1504751) for high frequency browser_aboutURLs.js failures CLOSED TREE
93f251e48d4d5e721ec23ca679e1045190b0724d: Bug 1506128 - Add share icon rule for url bar. r=Gijs
Dale Harvey <dale@arandomurl.com> - Mon, 12 Nov 2018 10:49:52 +0000 - rev 445889
Push 109795 by rmaries@mozilla.com at Mon, 12 Nov 2018 17:23:23 +0000
Bug 1506128 - Add share icon rule for url bar. r=Gijs MozReview-Commit-ID: IrlcPL93wrF Differential Revision: https://phabricator.services.mozilla.com/D11551
c26ee8ef2e421919588bb60e9a82c417ccc66829: Bug 1505175 - Prevent a crash in XPCNativeWrapper call by always passing a non-undefined object. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 12 Nov 2018 09:51:35 +0000 - rev 445888
Push 109795 by rmaries@mozilla.com at Mon, 12 Nov 2018 17:23:23 +0000
Bug 1505175 - Prevent a crash in XPCNativeWrapper call by always passing a non-undefined object. r=yulia In XPCShell tests, this `console` variable ends up being null and it later triggers an assertion that makes the test crash in debug builds. We should always pass a defined object to this constructor. MozReview-Commit-ID: F7QRXD15lH9 Depends on D11154 Differential Revision: https://phabricator.services.mozilla.com/D11445
47ae67e772a976fe7ce72d74110e990ba5df3196: Bug 1505175 - Cleanup head_dbg.js from unecessary usages of rootForm. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Fri, 09 Nov 2018 09:38:50 +0000 - rev 445887
Push 109795 by rmaries@mozilla.com at Mon, 12 Nov 2018 17:23:23 +0000
Bug 1505175 - Cleanup head_dbg.js from unecessary usages of rootForm. r=yulia MozReview-Commit-ID: 2ZfghtMuAH2 Depends on D11153 Differential Revision: https://phabricator.services.mozilla.com/D11154
74dbfbf5624545e007b3c0ed9c456e1e9d91ebdb: Bug 1505175 - Refactor get_parent_process_actors to only create a DebuggerClient. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Fri, 09 Nov 2018 09:38:40 +0000 - rev 445886
Push 109795 by rmaries@mozilla.com at Mon, 12 Nov 2018 17:23:23 +0000
Bug 1505175 - Refactor get_parent_process_actors to only create a DebuggerClient. r=yulia MozReview-Commit-ID: ChcKTEaO80a Depends on D11152 Differential Revision: https://phabricator.services.mozilla.com/D11153
702485851935a8b3efb62b5efd3b82543b5167a4: Bug 1506410 - Fix up two other instances of ParseError not passing in metadata r=jgraham
Wes Kocher <wkocher@mozilla.com> - Mon, 12 Nov 2018 10:11:48 +0000 - rev 445885
Push 109795 by rmaries@mozilla.com at Mon, 12 Nov 2018 17:23:23 +0000
Bug 1506410 - Fix up two other instances of ParseError not passing in metadata r=jgraham Depends on D11575 Differential Revision: https://phabricator.services.mozilla.com/D11576
a55ab1b0e47865c7a63ac60b0a54a1a9c871813c: Merge mozilla-central to autoland. a=merge on a CLOSED TREE
Andreea Pavel <apavel@mozilla.com> - Mon, 12 Nov 2018 12:15:06 +0200 - rev 445884
Push 109795 by rmaries@mozilla.com at Mon, 12 Nov 2018 17:23:23 +0000
Merge mozilla-central to autoland. a=merge on a CLOSED TREE
b6509b248af41520402cc18a86fa408af9c8b95d: Bug 1506410 - Make sure wptmanifest's ParseError prints out filename and line number when called r=jgraham
Wes Kocher <wkocher@mozilla.com> - Mon, 12 Nov 2018 10:09:31 +0000 - rev 445883
Push 109795 by rmaries@mozilla.com at Mon, 12 Nov 2018 17:23:23 +0000
Bug 1506410 - Make sure wptmanifest's ParseError prints out filename and line number when called r=jgraham Differential Revision: https://phabricator.services.mozilla.com/D11575
95bd81205750f7a29770060e5cc939dcd71341f5: Bug 1505679 - Make HTMLEditor::RemoveList() sets specific EditAction when it's called by execCommand("insertorderedlist") or execCommand("insertunorderedlist") r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 12 Nov 2018 08:13:58 +0000 - rev 445882
Push 109795 by rmaries@mozilla.com at Mon, 12 Nov 2018 17:23:23 +0000
Bug 1505679 - Make HTMLEditor::RemoveList() sets specific EditAction when it's called by execCommand("insertorderedlist") or execCommand("insertunorderedlist") r=m_kato Even when execCommand("insertorderedlist") and execCommand("insertunorderedlist") remove existing lists, we need to set InputEvent.inputType value to "insertOrderedList" or "insertUnorderedList". Fortunately, the XPCOM method is used only for handling execCommand("insertorderedlist") and execCommand("insertunorderedlist") on Firefox. Therefore, we should make it set EditAction to EditAction::eRemoveOrderedListElement or EditAction::RemoveUnorderedListElement. Note that comm-central uses this method directly and uses "cmd_removeList" which causes calling the XPCOM method with empty string. However, input events for them won't be exposed to the web. Therefore, it's okay to set EditAction::eRemoveListElement for the other cases. Differential Revision: https://phabricator.services.mozilla.com/D11439
01cd5b54d3ee579ce9b5dfbd15a5625a1c4b6531: Bug 1504910 - part 3: Make TextEditor::OnDrop() remove selected content before inserting dropped content and fire "input" event before inserting first content r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 12 Nov 2018 07:19:01 +0000 - rev 445881
Push 109795 by rmaries@mozilla.com at Mon, 12 Nov 2018 17:23:23 +0000
Bug 1504910 - part 3: Make TextEditor::OnDrop() remove selected content before inserting dropped content and fire "input" event before inserting first content r=m_kato Both Chrome and Safari dispatches 2 sets of "beforeinput" and "input" events when user drag and drop content in same editor. One is "deleteByDrag" and the other is "insertFromDrop". We need to follow same behavior since it should be able to cancel only "deleteByDrag" or "insertFromDrop" when we implement "beforeinput" event. HTMLEditor::InsertObject() may handle asynchronously. And we don't need to do anything additionally for HTMLEditor. Therefore, TextEditor::OnDrop() can delete selection before inserting dropped content by itself. Therefore, this patch makes TextEditor::OnDrop() call TextEditor::PrepareToInsertContent() and EditorBase::FireInputEvent() by itself. Unfortunately, it seems that we cannot write automated tests for this. Even if using synthesizeMouse() of EventUtils, synthesizing mouse events won't generate "dragover" nor "drop" events. Perhaps, like EventUtils.js, we need to do something with drag service, but it means that we cannot emulate drag and drop in an editor. Differential Revision: https://phabricator.services.mozilla.com/D11285
7e18b2160df58628de475fedb9c1c062e4e8e10e: Bug 1504910 - part 2: Make TextEditor::InsertTextAt() and HTMLEditor::DoInsertHTMLWithContext() share preparation code before inserting content r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 12 Nov 2018 01:40:46 +0000 - rev 445880
Push 109795 by rmaries@mozilla.com at Mon, 12 Nov 2018 17:23:23 +0000
Bug 1504910 - part 2: Make TextEditor::InsertTextAt() and HTMLEditor::DoInsertHTMLWithContext() share preparation code before inserting content r=m_kato Only TextEditor::InsertTextAt() and HTMLEditor::DoInsertHTMLWithContext() removes selected content before pasting from clipboard or inserting dropped content, and they do same things. Therefore, they can share the code with a helper method. Note that this makes each root caller won't return NS_ERROR_EDITOR_DESTROYED since the destruction is expected by web app. Differential Revision: https://phabricator.services.mozilla.com/D11284
30487cc4d50cef512ad908ea429fed302f592ac7: Bug 1504910 - part 1: Clean up methods which are called by TextEditor::OnDrop() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 09 Nov 2018 08:40:57 +0000 - rev 445879
Push 109795 by rmaries@mozilla.com at Mon, 12 Nov 2018 17:23:23 +0000
Bug 1504910 - part 1: Clean up methods which are called by TextEditor::OnDrop() r=m_kato TextEditor::OnDrop() calls TextEditor::InsertFromDataTransfer() or HTMLEditor::InsertFromDataTransfer() and they are called only by TextEditor::OnDrop(). TextEditor::InsertFromDataTransfer() calls only TextEditor::InsertTextAt() and TextEditor::InsertTextAt() calls only TextEditor::InsertTextAsSubAction() if insertion point is nullptr. Therefore, if the callers sets nullptr, they should call TextEditor::InsertTextAsSubAction() directly. Then, we can make TextEditor::InsertTextAt() require non-nullptr insertion point. HTMLEditor::InsertFromDataTransfer() calls HTMLEditor::InsertObject(), HTMLEditor::DoInsertHTMLWithContext() or TextEditor::InsertTextAt(). HTMLEditor::InsertObject() calls HTMLEditor::DoInsertHTMLWithContext() directly or via BlobReader (in this case, calls asynchronously). Unfortunately both HTMLEditor::InsertObject() and HTMLEditor::DoInsertHTMLWithContext() are called by HTMLEditor::InsertFromTransferable() which is paste event handler. Therefore, we cannot make them require non-nullptr insertion point, though, anyway, they cannot become simpler even if we could do that. This patch marks them as MOZ_CAN_RUN_SCRIPT as far as possible and makes them take |const EditorDOMPoint&| for insertion point. Differential Revision: https://phabricator.services.mozilla.com/D11283
cb6837c0ee5a192ff57bcba2e7dab3a9ff1a5580: Bug 1473184: Remove serialize_basicshape_position. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 12 Nov 2018 09:21:17 +0000 - rev 445878
Push 109795 by rmaries@mozilla.com at Mon, 12 Nov 2018 17:23:23 +0000
Bug 1473184: Remove serialize_basicshape_position. r=xidorn Per https://github.com/w3c/csswg-drafts/issues/2274. There's a whole lot of new failures, but those need to be updated along with the spec changes in that issue. We did resolve that position serialized the same everywhere though. Differential Revision: https://phabricator.services.mozilla.com/D1933
25ccc02a44ff21b13b0145e1a35dac692b40c403: Bug 1504751 Migrate about:networking to Fluent r=jaws,flod
Collin Wing <masterkrombi@gmail.com> - Mon, 12 Nov 2018 02:10:10 +0000 - rev 445877
Push 109795 by rmaries@mozilla.com at Mon, 12 Nov 2018 17:23:23 +0000
Bug 1504751 Migrate about:networking to Fluent r=jaws,flod Differential Revision: https://phabricator.services.mozilla.com/D10977
1c3e48a9ed61f14595c14fb0a633659dede29f6b: Bug 1479366 - Handle Number literals in JsPropertyProvider; r=bgrins.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 12 Nov 2018 07:39:38 +0000 - rev 445876
Push 109795 by rmaries@mozilla.com at Mon, 12 Nov 2018 17:23:23 +0000
Bug 1479366 - Handle Number literals in JsPropertyProvider; r=bgrins. When provided a number literal, JsPropertyProvider would not return anything. This patch solves this issue by adding an if case for those objects. Numerous test cases are added in test_js_property_provider to make sure we handle this as expected and that we don't have false positives. Differential Revision: https://phabricator.services.mozilla.com/D11483
bcf48a8dba79f51f291e476053fab60e6586c9f3: Bug 1505910 - P3. Remove now unused AsTaskQueue(). r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 09 Nov 2018 21:38:38 +0000 - rev 445875
Push 109795 by rmaries@mozilla.com at Mon, 12 Nov 2018 17:23:23 +0000
Bug 1505910 - P3. Remove now unused AsTaskQueue(). r=gerald Depends on D11492 Differential Revision: https://phabricator.services.mozilla.com/D11493
6f08cc82afe3280863c897dda1e141d8c4c165d7: Bug 1505910 - P2. Remove use of AsTaskQueue(). r=cpearce
Jean-Yves Avenard <jyavenard@mozilla.com> - Mon, 12 Nov 2018 01:09:03 +0000 - rev 445874
Push 109795 by rmaries@mozilla.com at Mon, 12 Nov 2018 17:23:23 +0000
Bug 1505910 - P2. Remove use of AsTaskQueue(). r=cpearce Make IsCurrentThreadIn() const. Depends on D11491 Differential Revision: https://phabricator.services.mozilla.com/D11492
1dab4c7062aeae80016ca8043a752271b6ab8a94: Bug 1505910 - P1. Remove taskqueue's shutdown in Benchmark. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 09 Nov 2018 21:36:43 +0000 - rev 445873
Push 109795 by rmaries@mozilla.com at Mon, 12 Nov 2018 17:23:23 +0000
Bug 1505910 - P1. Remove taskqueue's shutdown in Benchmark. r=gerald Differential Revision: https://phabricator.services.mozilla.com/D11491
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip