bf6b1a5f392d5ba60ef4d36487a3fcdb90a7d04a: Bug 1473631: Part 0a - Make preference callbacks typesafe. r=njn
Kris Maglione <maglione.k@gmail.com> - Fri, 06 Jul 2018 12:24:41 -0700 - rev 426843
Push 105341 by maglione.k@gmail.com at Tue, 17 Jul 2018 05:38:58 +0000
Bug 1473631: Part 0a - Make preference callbacks typesafe. r=njn I initially tried to avoid this, but decided it was necessary given the number of times I had to repeat the same pattern of casting a variable to void*, and then casting it back in a part of code far distant from the original type. This changes our preference callback registration functions to match the type of the callback's closure argument to the actual type of the closure pointer passed, and then casting it to the type of our generic callback function. This ensures that the callback function always gets an argument of the type it's actually expecting without adding any additional runtime memory or QueryInterface overhead for tracking it. MozReview-Commit-ID: 9tLKBe10ddP
2793704b84bb08f95a8fc4e41becede57455e012: Bug 1473634: Part 3 - Update nsDOMComputedStyle to use RegisterCallbacks. r=bz
Kris Maglione <maglione.k@gmail.com> - Wed, 04 Jul 2018 19:07:28 -0700 - rev 426842
Push 105341 by maglione.k@gmail.com at Tue, 17 Jul 2018 05:38:58 +0000
Bug 1473634: Part 3 - Update nsDOMComputedStyle to use RegisterCallbacks. r=bz nsComputedDOMStyle is currently one of the biggest sources of pref callback memory overhead. It currently registers about 5KB of callbacks per process. A lot of that has to do with it registering multiple callbacks for the same preference. But even with that problem fixed, we can do better by registering a single callback for all observed preferences. This patch does that, but also adds the optimization of deduplicating the list of observed preferences to avoid wasted cycles needlessly matching against many identical strings. MozReview-Commit-ID: LZNgd7cAwo2
81df12079942560a70b45c2fb4d38a893a49e7fd: Bug 1473634: Part 2 - Update some callers to use RegisterCallbacks where appropriate. r=njn
Kris Maglione <maglione.k@gmail.com> - Wed, 04 Jul 2018 19:06:57 -0700 - rev 426841
Push 105341 by maglione.k@gmail.com at Tue, 17 Jul 2018 05:38:58 +0000
Bug 1473634: Part 2 - Update some callers to use RegisterCallbacks where appropriate. r=njn MozReview-Commit-ID: IqUmuOeSbNm
0ee9a6fb27eb19852c21ecfa035a2340894b2659: Bug 1473634: Part 1 - Add preference callback variant which matches multiple prefs. r=njn
Kris Maglione <maglione.k@gmail.com> - Wed, 04 Jul 2018 19:06:00 -0700 - rev 426840
Push 105341 by maglione.k@gmail.com at Tue, 17 Jul 2018 05:38:58 +0000
Bug 1473634: Part 1 - Add preference callback variant which matches multiple prefs. r=njn Preference callbacks consume a non-trivial amount of memory, which adds up fast given the number of callbacks we register. Many of our consumers, however, register a large number of callbacks with the same function and closure object, but different preference names or prefixes. Since our callback matching is nothing more complicated than iteration over all of our registered callbacks, there's nothing that prevents us from combining all of these into a single callback, with an array of preferences rather than a single string. And since we already allocate an extra 8 bytes for each callback object, we can add a variant tag without increasing our allocation size. MozReview-Commit-ID: I497lWfMUp3
82aed14f58540a117b4a11c042dd70e1353b30ff: Bug 1470306 - Ensure MessagePort is in the right state if the connection to PBackground fails, r=qdot
Andrea Marchesini <amarchesini@mozilla.com> - Tue, 17 Jul 2018 07:14:06 +0200 - rev 426839
Push 105340 by amarchesini@mozilla.com at Tue, 17 Jul 2018 05:16:43 +0000
Bug 1470306 - Ensure MessagePort is in the right state if the connection to PBackground fails, r=qdot
13739445a00b4da1b5975ca1a3b36be337792d3d: Bug 1475882 - clang-tidy: Enable misc-unused-alias-decls check. r=andi
Chris Peterson <cpeterson@mozilla.com> - Mon, 09 Jul 2018 11:04:31 -0700 - rev 426838
Push 105339 by cpeterson@mozilla.com at Tue, 17 Jul 2018 05:05:46 +0000
Bug 1475882 - clang-tidy: Enable misc-unused-alias-decls check. r=andi This check finds unused namespace alias declarations. There are currently no misc-unused-alias-decls warnings in mozilla-central! https://clang.llvm.org/extra/clang-tidy/checks/misc-unused-alias-decls.html MozReview-Commit-ID: LHziGESvaM5
191a529a0208ba9a1bde1943e1299f9c737af9da: Bug 1475882 - clang-tidy: Enable misc-swapped-arguments check. r=andi
Chris Peterson <cpeterson@mozilla.com> - Mon, 09 Jul 2018 00:26:58 -0700 - rev 426837
Push 105339 by cpeterson@mozilla.com at Tue, 17 Jul 2018 05:05:46 +0000
Bug 1475882 - clang-tidy: Enable misc-swapped-arguments check. r=andi This check finds potentially swapped function arguments by looking at implicit conversions. There are currently no misc-swapped-arguments warnings in mozilla-central! https://clang.llvm.org/extra/clang-tidy/checks/bugprone-swapped-arguments.html MozReview-Commit-ID: 6SETUcQhQP
6a5e540c17f3c4db4dacba8a5efd428843593e3e: Bug 1475882 - clang-tidy: Enable misc-macro-repeated-side-effects check. r=andi
Chris Peterson <cpeterson@mozilla.com> - Mon, 09 Jul 2018 10:14:40 -0700 - rev 426836
Push 105339 by cpeterson@mozilla.com at Tue, 17 Jul 2018 05:05:46 +0000
Bug 1475882 - clang-tidy: Enable misc-macro-repeated-side-effects check. r=andi This check finds side effects from repeated macro arguments: https://clang.llvm.org/extra/clang-tidy/checks/bugprone-macro-repeated-side-effects.html There are currently 16 misc-macro-repeated-side-effects warnings in mozilla-central, but they are all in third-party gfx/cairo code: gfx/cairo/cairo/src/cairo-tor-scan-converter.c:1432:10: warning: side effects in the 1st macro argument 'x' are repeated in macro expansion gfx/cairo/libpixman/src/pixman-access.c:1011:16: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion gfx/cairo/libpixman/src/pixman-access.c:1037:16: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion gfx/cairo/libpixman/src/pixman-access.c:1062:16: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion gfx/cairo/libpixman/src/pixman-access.c:1088:16: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion gfx/cairo/libpixman/src/pixman-access.c:1107:16: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion gfx/cairo/libpixman/src/pixman-access.c:1126:27: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion gfx/cairo/libpixman/src/pixman-access.c:1194:21: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion gfx/cairo/libpixman/src/pixman-access.c:1258:16: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion gfx/cairo/libpixman/src/pixman-access.c:600:28: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion gfx/cairo/libpixman/src/pixman-access.c:629:28: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion gfx/cairo/libpixman/src/pixman-access.c:660:28: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion gfx/cairo/libpixman/src/pixman-access.c:690:28: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion gfx/cairo/libpixman/src/pixman-access.c:721:28: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion gfx/cairo/libpixman/src/pixman-access.c:986:16: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion gfx/cairo/libpixman/src/pixman-edge-imp.h:126:20: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion MozReview-Commit-ID: CQ6iO9JO773
082c2cd47f1cd5ae2a9bceb679d1815bcf98be3f: Bug 1475882 - clang-analyzer: Enable clang-analyzer-cplusplus.NewDeleteLeaks check. r=andi
Chris Peterson <cpeterson@mozilla.com> - Sat, 14 Jul 2018 23:10:39 -0700 - rev 426835
Push 105339 by cpeterson@mozilla.com at Tue, 17 Jul 2018 05:05:46 +0000
Bug 1475882 - clang-analyzer: Enable clang-analyzer-cplusplus.NewDeleteLeaks check. r=andi Check for memory leaks. Traces memory managed by new/ delete. There are currently no clang-analyzer-cplusplus.NewDeleteLeaks warnings in mozilla-central! https://clang-analyzer.llvm.org/available_checks.html MozReview-Commit-ID: 3tmwR26UB8K
138f27a016f6dd7dde91c6d8b66c3da179dc6e06: Bug 1475882 - clang-analyzer: Enable clang-analyzer-cplusplus.NewDelete check. r=andi
Chris Peterson <cpeterson@mozilla.com> - Sat, 14 Jul 2018 23:07:40 -0700 - rev 426834
Push 105339 by cpeterson@mozilla.com at Tue, 17 Jul 2018 05:05:46 +0000
Bug 1475882 - clang-analyzer: Enable clang-analyzer-cplusplus.NewDelete check. r=andi Check for double-free, use-after-free and offset problems involving C++ delete. There are currently no clang-analyzer-cplusplus.NewDelete warnings in mozilla-central! https://clang-analyzer.llvm.org/available_checks.html MozReview-Commit-ID: 9sVp4fc4JTj
cb66954c173fce66cfc4b22c34098cd8170eb32e: Bug 1473217 - Part 3: clang-tidy: Enable misc-unused-raii check. r=andi
Chris Peterson <cpeterson@mozilla.com> - Mon, 02 Jul 2018 10:52:35 -0700 - rev 426833
Push 105339 by cpeterson@mozilla.com at Tue, 17 Jul 2018 05:05:46 +0000
Bug 1473217 - Part 3: clang-tidy: Enable misc-unused-raii check. r=andi Finds temporaries that look like RAII objects. https://clang.llvm.org/extra/clang-tidy/checks/bugprone-unused-raii.html MozReview-Commit-ID: KDYoF3YEbMu
bfb8b44ccc42b8f4e9073acf2b0763341e30efae: Bug 1473217 - Part 2: dom: Fix misc-unused-raii warnings. r=baku
Chris Peterson <cpeterson@mozilla.com> - Tue, 03 Jul 2018 22:09:54 -0700 - rev 426832
Push 105339 by cpeterson@mozilla.com at Tue, 17 Jul 2018 05:05:46 +0000
Bug 1473217 - Part 2: dom: Fix misc-unused-raii warnings. r=baku nsPrintfCString creates a formatted string, but doesn't print it. ExtractOriginData is called for its constructor's scope and origin out parameters. This ExtractOriginData object doesn't really need a name because it is unused after we have scope and origin, but this change makes clang-tidy happy and makes the code clear that ExtractOriginData is an object and not a funcion being called. MozReview-Commit-ID: nxUBwzL4Uq
068bb4e7b8494d8ae82dfd1b1f22680234bf038c: Bug 1448034 - Part 2: Lazily create ProxyResolution thread. r=bagder
Eric Rahm <erahm@mozilla.com> - Mon, 16 Jul 2018 16:05:39 -0700 - rev 426831
Push 105338 by erahm@mozilla.com at Tue, 17 Jul 2018 04:44:33 +0000
Bug 1448034 - Part 2: Lazily create ProxyResolution thread. r=bagder This delays the creation of the PAC thread until we need to dispatch a runnable to it.
eb542860b989d4f6ea1ffcb29ff843b857d78482: Bug 1448034 - Part 1: Get rid of SysProxySetting threads. r=bagder
Eric Rahm <erahm@mozilla.com> - Tue, 10 Jul 2018 18:02:21 -0700 - rev 426830
Push 105338 by erahm@mozilla.com at Tue, 17 Jul 2018 04:44:33 +0000
Bug 1448034 - Part 1: Get rid of SysProxySetting threads. r=bagder
59221b30f49baa42ee9f8d12a087e093398165ce: Bug 1445444: Properly initialize plugin window drawing type on Windows r=jimm
David Parks <dparks@mozilla.com> - Mon, 25 Jun 2018 13:16:44 -0700 - rev 426829
Push 105337 by btara@mozilla.com at Tue, 17 Jul 2018 03:49:53 +0000
Bug 1445444: Properly initialize plugin window drawing type on Windows r=jimm Sets the default plugin window type to windowed on Windows. Most of the time, plugins use async drawing so this will be overwritten but it should be properly initialized for cases where we do not switch to async.
d2bdf1f738384b8253d30478fc5bcf9c31673c24: Bug 1474688 - Support line movement granularity and remove defunct paragraph. r=yzen r=jchen
Eitan Isaacson <eitan@monotonous.org> - Mon, 16 Jul 2018 15:59:00 +0300 - rev 426828
Push 105337 by btara@mozilla.com at Tue, 17 Jul 2018 03:49:53 +0000
Bug 1474688 - Support line movement granularity and remove defunct paragraph. r=yzen r=jchen
0fb2b9a769eb581919baf5b824901bcb564c1b74: Bug 1475087 - Include boundaryType in vc change event. r=surkov
Eitan Isaacson <eitan@monotonous.org> - Mon, 16 Jul 2018 13:56:00 +0300 - rev 426827
Push 105337 by btara@mozilla.com at Tue, 17 Jul 2018 03:49:53 +0000
Bug 1475087 - Include boundaryType in vc change event. r=surkov
738e3cb89b4b7513d69438da6a1b3f3748a34538: Bug 1475464 - Add more description about FunctionScope data. r=jandem DONTBUILD because comment only
Tooru Fujisawa <arai_a@mac.com> - Tue, 17 Jul 2018 10:00:42 +0900 - rev 426826
Push 105336 by arai_a@mac.com at Tue, 17 Jul 2018 01:00:52 +0000
Bug 1475464 - Add more description about FunctionScope data. r=jandem DONTBUILD because comment only
70d07e42dcd488f608741f26600fcd7e70987bc2: Bug 1476128 - Have HIDDEN_VIEWPORT_OVERFLOW_TYPE recorded on main process as well. r=botond
Xidorn Quan <me@upsuper.org> - Tue, 17 Jul 2018 08:54:37 +1000 - rev 426825
Push 105335 by xquan@mozilla.com at Mon, 16 Jul 2018 22:54:58 +0000
Bug 1476128 - Have HIDDEN_VIEWPORT_OVERFLOW_TYPE recorded on main process as well. r=botond
e09ba0bb848afe8b66c4cdd56794301b790c6c34: Bug 1475660: Make clang-cl PGO enable LTO (enables ThinLTO in official builds) r=froydnj,glandium
David Major <dmajor@mozilla.com> - Mon, 16 Jul 2018 17:59:49 -0400 - rev 426824
Push 105334 by dmajor@mozilla.com at Mon, 16 Jul 2018 22:10:37 +0000
Bug 1475660: Make clang-cl PGO enable LTO (enables ThinLTO in official builds) r=froydnj,glandium
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip