b6a0a003d609b4d67490367ef717a66fa48dfada: Bug 1508434 - p4: release audio output buffers after processing on task queue. r=jya
John Lin <jolin@mozilla.com> - Fri, 11 Jan 2019 17:08:11 +0000 - rev 453518
Push 111104 by nerli@mozilla.com at Fri, 11 Jan 2019 22:00:51 +0000
Bug 1508434 - p4: release audio output buffers after processing on task queue. r=jya Differential Revision: https://phabricator.services.mozilla.com/D15985
d568d717aa5bb4b4dedd696a5e5b0a127fdf7a1a: Bug 1508434 - p3: assert members are only accessed on task queue. r=jya
John Lin <jolin@mozilla.com> - Fri, 11 Jan 2019 17:08:03 +0000 - rev 453517
Push 111104 by nerli@mozilla.com at Fri, 11 Jan 2019 22:00:51 +0000
Bug 1508434 - p3: assert members are only accessed on task queue. r=jya Differential Revision: https://phabricator.services.mozilla.com/D15740
dcfc482c09693d7289fa275c850ccb4105caa95a: Bug 1508434 - p2: move codec output processing to task queue. r=jya
John Lin <jolin@mozilla.com> - Fri, 11 Jan 2019 17:08:00 +0000 - rev 453516
Push 111104 by nerli@mozilla.com at Fri, 11 Jan 2019 22:00:51 +0000
Bug 1508434 - p2: move codec output processing to task queue. r=jya Processing MediaCodec output in Android binder threads while flushing in task queue could cause race condition and leftover frames. Dispatch the processing to task queue ensures all frames prior to flushing will be cleared (by mDecodedData.Clear()) or ignored (by mInputInfos.Clear()). Also consolidate all flushing operations in one task to avoid frame insertion between emptying mDecodedData and mInputInfos. Differential Revision: https://phabricator.services.mozilla.com/D15228
6e9fd9ef59df4ed2cd1a622a12f4a17aa74d4c81: Bug 1508434 - p1: Support explicitly resetting seek threshold. r=jya
John Lin <jolin@mozilla.com> - Fri, 11 Jan 2019 17:07:49 +0000 - rev 453515
Push 111104 by nerli@mozilla.com at Fri, 11 Jan 2019 22:00:51 +0000
Bug 1508434 - p1: Support explicitly resetting seek threshold. r=jya Usually the threshold is reset internally in MediaDataDecoder subclasses that support the hint in their Flush() implementations so the value will start fresh after seeking completed. But sometimes when there are consecutive seek requests, MediaFormatReader::DecoderData::Flush() could return early because DecoderData::mFlushed stays true when there is no sample demuxed yet, and the threshold will not be cleared. Also, in MediaFormatReader::SetVideoDecodeThreshold() we decide not to set the hint when the seek target is close to EOS by checking the existence of the next keyframe, and that could fail when there are gaps between MSE buffered ranges. To make sure the hint is never out of date, we should clear it rather than leaving it untouched. Differential Revision: https://phabricator.services.mozilla.com/D15227
189dd5e62ffb0f67cbca7e709672da6218d922b4: Backed out changeset ebff3389b3e4 (bug 1518799) incorrect commit message
Andreea Pavel <apavel@mozilla.com> - Fri, 11 Jan 2019 19:15:02 +0200 - rev 453514
Push 111104 by nerli@mozilla.com at Fri, 11 Jan 2019 22:00:51 +0000
Backed out changeset ebff3389b3e4 (bug 1518799) incorrect commit message
ebff3389b3e49c5bcb0638ed4c7f4a0e84ce58b6: Bug 1518799: Show a custom page on startup on a specific date. r=Gijs
Dave Townsend <dtownsend@oxymoronical.com> - Fri, 11 Jan 2019 17:08:16 +0000 - rev 453513
Push 111104 by nerli@mozilla.com at Fri, 11 Jan 2019 22:00:51 +0000
Bug 1518799: Show a custom page on startup on a specific date. r=Gijs Still waiting on a couple of details from product but I'd like to get the review started now as we will want to land this a.s.a.p. Differential Revision: https://phabricator.services.mozilla.com/D16249
729ea50e304585cd0b42ed9138a47b9e7ae68bb0: Bug 1518586 - [mach] Implement bash completion for subcommands and arguments r=nalexander
Andrew Halberstadt <ahalberstadt@mozilla.com> - Fri, 11 Jan 2019 15:28:49 +0000 - rev 453512
Push 111104 by nerli@mozilla.com at Fri, 11 Jan 2019 22:00:51 +0000
Bug 1518586 - [mach] Implement bash completion for subcommands and arguments r=nalexander Since we're calling into a mach command for the current completion implementation anyway (and incurring python startup penalties), we might as well move all the bash logic into the mach command. The new 'mach-completion' command was created in case there are scripts relying on the current behaviour of 'mach-commands'. Depends on D16254 Differential Revision: https://phabricator.services.mozilla.com/D16255
5b651dea28d8891be33a372e61dea9ce3c2422c3: Bug 1518586 - [mach] Add some basic usage docs r=nalexander
Andrew Halberstadt <ahalberstadt@mozilla.com> - Fri, 11 Jan 2019 03:34:30 +0000 - rev 453511
Push 111104 by nerli@mozilla.com at Fri, 11 Jan 2019 22:00:51 +0000
Bug 1518586 - [mach] Add some basic usage docs r=nalexander I was looking for a good place to put documentation for enabling the bash completion script when I realized that the 'mach' documentation is targeted at tool developers rather than users. Seeing as this is the main 'mach' documentation and we want to make 'firefox-source-docs' the place to go for contribution information, we should endeavour to target end users with this documentation. This adds a very basic usage page which should be expanded upon, but is better than nothing. I changed the headers in 'index.rst' to use raw:: html so that they don't show up in the nav bar to the left (and subsequently block the *actually important* things from appearing). Differential Revision: https://phabricator.services.mozilla.com/D16254
696de1cfcb5eab4e11a5234f5bcda72476010278: Bug 1500353 - Update localization for document title r=ladybenko,jdescottes
Ola Gasidlo <ogasidlo@mozilla.com> - Fri, 11 Jan 2019 13:29:56 +0000 - rev 453510
Push 111104 by nerli@mozilla.com at Fri, 11 Jan 2019 22:00:51 +0000
Bug 1500353 - Update localization for document title r=ladybenko,jdescottes - added localization module - added test Differential Revision: https://phabricator.services.mozilla.com/D14415
5686d29392e8aecb57c0f75414bedebf54631447: Bug 1487416 - Handle cbcs data from mp4parse-rust. r=jya
Bryce Van Dyk <bvandyk@mozilla.com> - Fri, 11 Jan 2019 15:13:41 +0000 - rev 453509
Push 111104 by nerli@mozilla.com at Fri, 11 Jan 2019 22:00:51 +0000
Bug 1487416 - Handle cbcs data from mp4parse-rust. r=jya Handle mp4parse-rust providing cbcs data in the track metadata. Explicitly check the crypto scheme we get in the metadata and error if we encounter something outside of cenc and cbcs -- catch unexpected data early. Differential Revision: https://phabricator.services.mozilla.com/D15878
9851d4b03b567f9aba8645dc3560242266d0ffc6: Bug 1487416 - Index.cpp's SampleIterator populates cbcs data. r=jya
Bryce Van Dyk <bvandyk@mozilla.com> - Fri, 11 Jan 2019 15:13:37 +0000 - rev 453508
Push 111104 by nerli@mozilla.com at Fri, 11 Jan 2019 22:00:51 +0000
Bug 1487416 - Index.cpp's SampleIterator populates cbcs data. r=jya Rework our mp4 sample iterator to handle cbcs crypto data. To support this we populate the following new data for samples: - Crypto pattern information, this is split into a count of encrypted blocks and a count of clear blocks. - A constant IV. This information is available at a track level and a sample group level. The sample group level supersedes track level information if both a present. Prior to this patch, some crypto information was written to samples in the SampleIterator in Index.cpp, and some in the MP4Demuxer (based on if the SampleIterator had not populated the data). This patch moves all these operations into the SampleIterator -- the idea being that the sample iterator should be the component responsible for setting up sample meta data. Differential Revision: https://phabricator.services.mozilla.com/D15877
306cd39838d6a53d88020d50ac06c28feafaff53: Bug 1487416 - Support different encryption schemes in mp4 parser's GetAuxInfo. r=jya
Bryce Van Dyk <bvandyk@mozilla.com> - Fri, 11 Jan 2019 15:12:14 +0000 - rev 453507
Push 111104 by nerli@mozilla.com at Fri, 11 Jan 2019 22:00:51 +0000
Bug 1487416 - Support different encryption schemes in mp4 parser's GetAuxInfo. r=jya Differential Revision: https://phabricator.services.mozilla.com/D15876
b5be14338408578650ac26c26e7e1d252cec7e2e: Bug 1487416 - Parse pattern encryption information from the seig box. r=jya
Bryce Van Dyk <bvandyk@mozilla.com> - Fri, 11 Jan 2019 15:11:51 +0000 - rev 453506
Push 111104 by nerli@mozilla.com at Fri, 11 Jan 2019 22:00:51 +0000
Bug 1487416 - Parse pattern encryption information from the seig box. r=jya Differential Revision: https://phabricator.services.mozilla.com/D15875
9922ca87970ee8a50151780cc96d9403e30bce2c: Bug 1487416 - Replace mValid and mMode with mCryptoScheme for track and sample crypto structs. r=jya
Bryce Van Dyk <bvandyk@mozilla.com> - Fri, 11 Jan 2019 15:29:45 +0000 - rev 453505
Push 111104 by nerli@mozilla.com at Fri, 11 Jan 2019 22:00:51 +0000
Bug 1487416 - Replace mValid and mMode with mCryptoScheme for track and sample crypto structs. r=jya Explicitly store the crypto scheme being used on our crypto structs to let us differentiate between cenc and cbcs data. In doing so remove mMode and replace mValid with IsEncrypted() for the following reasons: - Different modes within the existing schemes are not currently utilized by the spec: the scheme implies mode. Having a mode and a scheme could lead to confusion between the two. We can return mMode if ever needed by the spec -- possibly if the isProtected flag which we were tracking with mMode, is ever changed to be more than a bool in the spec. - mValid was typically used to check if these structs contained valid crypto data or not. With only one scheme this was often shorthand for 'IsEncrypted', but with multiple schemes what is considered valid data for one may not be for another. Do away with this and just explicitly have an 'IsEncrypted'. Differential Revision: https://phabricator.services.mozilla.com/D15874
9edd4ab366410d8a6b4a3a9c5c47b630bac08e73: Bug 1487416 - Read pattern information in Sinf parser. r=jya
Bryce Van Dyk <bvandyk@mozilla.com> - Fri, 11 Jan 2019 15:11:05 +0000 - rev 453504
Push 111104 by nerli@mozilla.com at Fri, 11 Jan 2019 22:00:51 +0000
Bug 1487416 - Read pattern information in Sinf parser. r=jya Differential Revision: https://phabricator.services.mozilla.com/D15873
e4cbf560928e09c1d7003e5375a5601eabb79c61: Bug 1517071 - Clear AsyncWaitRunnable::mStream when cancelled. r=froydnj
Andrew McCreight <continuation@gmail.com> - Fri, 11 Jan 2019 16:57:51 +0000 - rev 453503
Push 111104 by nerli@mozilla.com at Fri, 11 Jan 2019 22:00:51 +0000
Bug 1517071 - Clear AsyncWaitRunnable::mStream when cancelled. r=froydnj AsyncWaitRunnable holds a strong reference to its stream, and NonBlockingAsyncInputStream holds a strong reference to the runnable. The cycle gets broken in the RunAsyncWaitCallback() method of the stream, but if the runnable is cancelled then we leak them both. This patch fixes that by clearing the pointer to the stream when the runnable is cancelled, breaking the cycle. Differential Revision: https://phabricator.services.mozilla.com/D16248
49bb9b849c4af957e6f51b16731b98ed0ef72e85: Bug 1517135: Remove dead declaration from BytecodeEmitter.h r=tcampbell
Iain Ireland <iireland@mozilla.com> - Fri, 11 Jan 2019 16:36:40 +0000 - rev 453502
Push 111104 by nerli@mozilla.com at Fri, 11 Jan 2019 22:00:51 +0000
Bug 1517135: Remove dead declaration from BytecodeEmitter.h r=tcampbell Differential Revision: https://phabricator.services.mozilla.com/D16324
f65c31506e4994b8492444585670a6031744c610: Bug 1519081 - Don't fallback to another country in FormAutofillUtils.getFormFormat. r=jaws
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Fri, 11 Jan 2019 03:57:37 +0000 - rev 453501
Push 111104 by nerli@mozilla.com at Fri, 11 Jan 2019 22:00:51 +0000
Bug 1519081 - Don't fallback to another country in FormAutofillUtils.getFormFormat. r=jaws Differential Revision: https://phabricator.services.mozilla.com/D16265
2087dafb1eacbff427122c0b146f9c903658fafc: Bug 1519355 - [Wayland] Produce better error message when mozilla::widget::WaylandShmPool::CreateTemporaryFile() fails, r=jhorak
Martin Stransky <stransky@redhat.com> - Fri, 11 Jan 2019 15:15:10 +0000 - rev 453500
Push 111104 by nerli@mozilla.com at Fri, 11 Jan 2019 22:00:51 +0000
Bug 1519355 - [Wayland] Produce better error message when mozilla::widget::WaylandShmPool::CreateTemporaryFile() fails, r=jhorak Differential Revision: https://phabricator.services.mozilla.com/D16297
fe5073e21dc50bd582c0e73c0585ea379f403134: Bug 1519428 - Fix XML error in Wikipedia searchplugin for zh-TW r=mkaply
Francesco Lodolo (:flod) <flod@lodolo.net> - Fri, 11 Jan 2019 16:17:38 +0000 - rev 453499
Push 111104 by nerli@mozilla.com at Fri, 11 Jan 2019 22:00:51 +0000
Bug 1519428 - Fix XML error in Wikipedia searchplugin for zh-TW r=mkaply Differential Revision: https://phabricator.services.mozilla.com/D16322
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip