b5b964c5db525a62ef9c70ca1a82a6eb63aae358: Bug 1511161 - Part 2: Use Code throughout IPDL codegen, r=froydnj
Nika Layzell <nika@thelayzells.com> - Tue, 21 May 2019 17:04:43 +0000 - rev 474799
Push 113171 by aiakab@mozilla.com at Tue, 21 May 2019 21:56:33 +0000
Bug 1511161 - Part 2: Use Code throughout IPDL codegen, r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D30234
ba0de671a6c4ef10b211d2a684b29f0ebdc3eadb: Bug 1511161 - Part 1: Add new Code object to IPDL codegen, r=froydnj
Nika Layzell <nika@thelayzells.com> - Tue, 21 May 2019 17:04:41 +0000 - rev 474798
Push 113171 by aiakab@mozilla.com at Tue, 21 May 2019 21:56:33 +0000
Bug 1511161 - Part 1: Add new Code object to IPDL codegen, r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D13467
a50b68e0deb2cd736a83d3bd3d40ca18675f908e: Bug 1547218 - Part 2: Stop special casing pointer types in ParamTraits specialization, r=froydnj
Nika Layzell <nika@thelayzells.com> - Tue, 21 May 2019 17:04:39 +0000 - rev 474797
Push 113171 by aiakab@mozilla.com at Tue, 21 May 2019 21:56:33 +0000
Bug 1547218 - Part 2: Stop special casing pointer types in ParamTraits specialization, r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D29779
15b4b7f9d97a77a19b94d64e257bbb6c28cfa134: Bug 1547218 - Part 1: Handle container IPDLParamTraits types more consistently, r=froydnj
Nika Layzell <nika@thelayzells.com> - Tue, 21 May 2019 17:04:37 +0000 - rev 474796
Push 113171 by aiakab@mozilla.com at Tue, 21 May 2019 21:56:33 +0000
Bug 1547218 - Part 1: Handle container IPDLParamTraits types more consistently, r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D29778
5126a1e75cf8743aadac748eba2b201b64b88b86: Bug 1548717 - Part 2: Check CanSend before trying to send, r=froydnj
Nika Layzell <nika@thelayzells.com> - Tue, 21 May 2019 17:04:35 +0000 - rev 474795
Push 113171 by aiakab@mozilla.com at Tue, 21 May 2019 21:56:33 +0000
Bug 1548717 - Part 2: Check CanSend before trying to send, r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D30236
3b9e7122bcfb8b37b7653e5224ce03b377361cbd: Bug 1548717 - Part 1: Remove the unnecessary internal liveness state value, r=froydnj
Nika Layzell <nika@thelayzells.com> - Tue, 21 May 2019 17:04:27 +0000 - rev 474794
Push 113171 by aiakab@mozilla.com at Tue, 21 May 2019 21:56:33 +0000
Bug 1548717 - Part 1: Remove the unnecessary internal liveness state value, r=froydnj These values were only being used for assertions within IPDL send methods. They had no positive impact beyond causing crashes when sending a message over a dead actor. Differential Revision: https://phabricator.services.mozilla.com/D30235
969f29e56fa1b018fe790d888e05df6f1ddbdbb1: Bug 1547085 - Discard messages sent to dead actors, r=jld
Nika Layzell <nika@thelayzells.com> - Tue, 21 May 2019 17:04:25 +0000 - rev 474793
Push 113171 by aiakab@mozilla.com at Tue, 21 May 2019 21:56:33 +0000
Bug 1547085 - Discard messages sent to dead actors, r=jld Historically we've failed very loudly when receiving a message which was destined for an actor which had already been destroyed. This had the effect of requiring manual teardown for most actors, as work would need to be done to ensure messages weren't sent when the target actor might be about to tear itself down. In addition, due to this teardown work being done outside of IPDL, this work would have to manually be checked in subactors, and involved the addition of new flags, such as `mIPCOpen`, in order to track whether IPC had begun to be shut down, and discard messages manually if it had. It is an ongoing issue that we occasionally miss places where we need to discard messages, and it is easy to not remember to perform async destruction when building a new actor, meaning that extra work is required to correctly discard messages when the actor is being torn down. Due to the correct decision, almost all of the time, being to discard the message, this patch takes the approach of transforming the crash which was previously performed into a message discard. The hope is that this will reduce the burden on actor implementors, by allowing the use of `Send__delete__` without first synchronizing with the remote actor, as well as reduce unintentional crashes. Differential Revision: https://phabricator.services.mozilla.com/D28892
11450b71e95eaf5fdb8bbc5e424dc9cc2aafcd61: Bug 1540731 - Part 3: Stop releasing actors within ActorDestroy, r=mayhemer
Nika Layzell <nika@thelayzells.com> - Tue, 21 May 2019 17:04:23 +0000 - rev 474792
Push 113171 by aiakab@mozilla.com at Tue, 21 May 2019 21:56:33 +0000
Bug 1540731 - Part 3: Stop releasing actors within ActorDestroy, r=mayhemer Differential Revision: https://phabricator.services.mozilla.com/D29606
89b214d41e5050aa849bfa6b540b83b4693ffd1d: Bug 1540731 - Part 2: Move toplevel actors to override ActorDestroy, r=froydnj
Nika Layzell <nika@thelayzells.com> - Tue, 21 May 2019 17:04:21 +0000 - rev 474791
Push 113171 by aiakab@mozilla.com at Tue, 21 May 2019 21:56:33 +0000
Bug 1540731 - Part 2: Move toplevel actors to override ActorDestroy, r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D28573
d30842e4cfea49c26c260b3d00355362a680cd13: Bug 1540731 - Part 1: Manage actor object lifecycles within IPC, r=froydnj
Nika Layzell <nika@thelayzells.com> - Tue, 21 May 2019 17:04:14 +0000 - rev 474790
Push 113171 by aiakab@mozilla.com at Tue, 21 May 2019 21:56:33 +0000
Bug 1540731 - Part 1: Manage actor object lifecycles within IPC, r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D28572
bd089729aaeaea30cb38a4d8c4895690a009e07a: Bug 1552987 - Jump-to-function-definition buttons are no longer visible in the console. r=nchevobbe
Jason Laster <jlaster@mozilla.com> - Tue, 21 May 2019 16:54:56 +0000 - rev 474789
Push 113171 by aiakab@mozilla.com at Tue, 21 May 2019 21:56:33 +0000
Bug 1552987 - Jump-to-function-definition buttons are no longer visible in the console. r=nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D32003
f5ae6a49e7911e869c0d003ad725e5c34a765f33: Bug 1552982: Add 'mozilla-beta' CI branch to GeckoView's scn-power-idle test. r=Bebe
Stephen Donner <stephen.donner@gmail.com> - Tue, 21 May 2019 16:53:54 +0000 - rev 474788
Push 113171 by aiakab@mozilla.com at Tue, 21 May 2019 21:56:33 +0000
Bug 1552982: Add 'mozilla-beta' CI branch to GeckoView's scn-power-idle test. r=Bebe Differential Revision: https://phabricator.services.mozilla.com/D31893
da42fc59d4fb71fd6680b5caf0831e752ca03490: Bug 1553039 - default MOZ_GCTIMER output dir to MOZ_UPLOAD_DIR r=jonco
Steve Fink <sfink@mozilla.com> - Tue, 21 May 2019 16:53:05 +0000 - rev 474787
Push 113171 by aiakab@mozilla.com at Tue, 21 May 2019 21:56:33 +0000
Bug 1553039 - default MOZ_GCTIMER output dir to MOZ_UPLOAD_DIR r=jonco Differential Revision: https://phabricator.services.mozilla.com/D31962
96aeb5e59c6685733e6086ade9710abff1d26212: Bug 1066323 - [mozlog] Mozlog shouldn't propagate unremarkable defaults to the raw log r=jgraham
Nikki S <nikkisharpley@gmail.com> - Tue, 21 May 2019 16:45:59 +0000 - rev 474786
Push 113171 by aiakab@mozilla.com at Tue, 21 May 2019 21:56:33 +0000
Bug 1066323 - [mozlog] Mozlog shouldn't propagate unremarkable defaults to the raw log r=jgraham Currently, some of the raw JSON logs for mochitest and marionette, et al, include empty dictionaries, None values and other unremarkable values that are marked as optional. This fix aims to remove these unnecessary items from being passed to the raw log. A method has been added to the log_actions class which removes defaults if they are marked as optional and the value is included in the default list. This is called on the kwargs returned by the convert_known method, before being propagated to the log_raw method for StructuredLogger. Differential Revision: https://phabricator.services.mozilla.com/D25081
c6ab5b9a7c0743eafc9573871f60f7299d6832d5: Bug 1545091 - Spew tracelogger statistics with IONFLAGS=tracelogger r=iain,mstange
Denis Palmeiro <dpalmeiro@mozilla.com> - Tue, 21 May 2019 15:25:32 +0000 - rev 474785
Push 113171 by aiakab@mozilla.com at Tue, 21 May 2019 21:56:33 +0000
Bug 1545091 - Spew tracelogger statistics with IONFLAGS=tracelogger r=iain,mstange Add Jitspewing control for tracelogger data. This can be enabled from the profiler or from the JS shell. Usage is as follows: From browser (ION_SPEW_FILENAME is recommended here so stdout doesn't get clobbered by each process): 1. JS_TRACE_LOGGING=1 IONFLAGS=tracelogger ION_SPEW_FILENAME=tracelogger ./mach run 2. Enable JSTracer feature in profiler addon 3. Start profiling and ctrl+shift+2 to view profile, and the data will be automatically spewed during profile collection. From shell: 1. JS_TRACE_LOGGING=1 IONFLAGS=tracelogger dist/bin/js test.js 2. Data is automatically spewed to stdout when the shell exits, or use ION_SPEW_FILENAME. There is an optional environment variable JS_TRACELOGGER_SPEW that can be used to emit specific events, for example JS_TRACELOGGER_SPEW="Interpreter,Baseline,GC" will emit only those specific events along with the script and self time of each script. The structured spewer is also supported with SPEW=tracelogger, and this will emit the tracelogger data for every recorded event. Differential Revision: https://phabricator.services.mozilla.com/D30033
a25b553e6824a80e7ddc42926d67048f1edf7e85: Bug 1551916 - Flip column numbers back to being counts of code points and not code units. r=arai
Jeff Walden <jwalden@mit.edu> - Tue, 21 May 2019 16:31:51 +0000 - rev 474784
Push 113171 by aiakab@mozilla.com at Tue, 21 May 2019 21:56:33 +0000
Bug 1551916 - Flip column numbers back to being counts of code points and not code units. r=arai Differential Revision: https://phabricator.services.mozilla.com/D31304
1a57fadeb896c57dcea6fd4812b97510811d4754: Bug 1553028 - Fix the condition for enabling new aboutdebugging on DevEdition and Nightly r=jcristau
Julian Descottes <jdescottes@mozilla.com> - Tue, 21 May 2019 16:30:26 +0000 - rev 474783
Push 113171 by aiakab@mozilla.com at Tue, 21 May 2019 21:56:33 +0000
Bug 1553028 - Fix the condition for enabling new aboutdebugging on DevEdition and Nightly r=jcristau Differential Revision: https://phabricator.services.mozilla.com/D32021
9580f1df7a53b17cbda444f9d2809aeb63912743: Bug 1551174 - Inactive CSS - visual polish r=pbro
Michael Ratcliffe <mratcliffe@mozilla.com> - Tue, 21 May 2019 16:29:49 +0000 - rev 474782
Push 113171 by aiakab@mozilla.com at Tue, 21 May 2019 21:56:33 +0000
Bug 1551174 - Inactive CSS - visual polish r=pbro Depends on: D31986 ### Summary - [X] Extra margin between paragraphs (about 14px, or whatever 1em is) - [X] Same amount of padding on all sides - match left spacing. Looks like we need 4px less on the side with the arrow, 2px less on the other side. - [X] Fully opaque, white-colored background - [X] Drop shadow should be half as dark (I think this is the MacOS doubled dropshadow issue - it should match the meatball menu's shadow) - [X] Less space between ending icons and CSS - seems like we can just remove margin-inline-start: 5px - [X] I think florens may have a better info icon that will be more legible at this small size !!I just created a new one!! - [X] Warning icon should be smaller now to match the size of the info icon :) It was an illusion but I have made it slightly smaller and changed the background position to make it look closer to the same size. - [X] Seems like it would be helpful if you could select the tooltip text - Whole tooltip 1px to the right and 2px lower !!I have moved this out to bug 1552146!! Differential Revision: https://phabricator.services.mozilla.com/D31292
62ffe3570de446a92c0eed4c22c81e6c50fb840b: Bug 1543216 - Improved colors for the markup view's inactive elements r=pbro
Michael Ratcliffe <mratcliffe@mozilla.com> - Tue, 21 May 2019 12:09:51 +0000 - rev 474781
Push 113171 by aiakab@mozilla.com at Tue, 21 May 2019 21:56:33 +0000
Bug 1543216 - Improved colors for the markup view's inactive elements r=pbro Changes: - Applied colors from Victorias mockups. - Removed `margin-inline-start` from the icon to move it closer to the property value. Differential Revision: https://phabricator.services.mozilla.com/D31986
afefd7bc17fdfd069206b1b127bcca744a9be7c7: Merge mozilla-central to autoland. a=merge on a CLOSED TREE
Razvan Maries <rmaries@mozilla.com> - Tue, 21 May 2019 19:36:25 +0300 - rev 474780
Push 113171 by aiakab@mozilla.com at Tue, 21 May 2019 21:56:33 +0000
Merge mozilla-central to autoland. a=merge on a CLOSED TREE
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip