b3c8b491dc8a53b14ae09a5c8885917bdd376544: Bug 633062 p5 - Remove event loop spinning from addonutils.js. r=markh
Edouard Oger <eoger@fastmail.com> - Fri, 08 Dec 2017 15:34:29 -0500 - rev 401967
Push 99472 by cbrindusan@mozilla.com at Thu, 01 Feb 2018 10:20:30 +0000
Bug 633062 p5 - Remove event loop spinning from addonutils.js. r=markh MozReview-Commit-ID: 1PSX4tOieEH
9b01e0e6fb03ca5e6a75da47ee1ec953c67ea610: Bug 633062 p4 - Remove miscellaneous uses of event loop spinning in services/. r=markh
Edouard Oger <eoger@fastmail.com> - Fri, 08 Dec 2017 14:41:02 -0500 - rev 401966
Push 99472 by cbrindusan@mozilla.com at Thu, 01 Feb 2018 10:20:30 +0000
Bug 633062 p4 - Remove miscellaneous uses of event loop spinning in services/. r=markh MozReview-Commit-ID: IDGWJevEHLK
1bfcacd0e174de84b1b2acbd30d02c4e81e0bf0f: Bug 633062 p3 - Remove event loop spinning from the EngineManager. r=markh
Edouard Oger <eoger@fastmail.com> - Fri, 08 Dec 2017 13:10:25 -0500 - rev 401965
Push 99472 by cbrindusan@mozilla.com at Thu, 01 Feb 2018 10:20:30 +0000
Bug 633062 p3 - Remove event loop spinning from the EngineManager. r=markh MozReview-Commit-ID: 7tdKT8Wo3t4
da51899ad527c55069f8226f4c07b7f737959195: Bug 633062 p2 - Make getTokenFromBrowserIDAssertion async. r=markh
Edouard Oger <eoger@fastmail.com> - Thu, 07 Dec 2017 14:45:15 -0500 - rev 401964
Push 99472 by cbrindusan@mozilla.com at Thu, 01 Feb 2018 10:20:30 +0000
Bug 633062 p2 - Make getTokenFromBrowserIDAssertion async. r=markh Also move promiseStopServer to the common/ head_helpers.js MozReview-Commit-ID: B3Idnj6rPAZ
96c99982370c56396ca15f50cf8ab0ec01f93bf5: Bug 633062 p1 - Introduce AsyncQueueCaller and AsyncObserver. r=markh
Edouard Oger <eoger@fastmail.com> - Thu, 04 Jan 2018 18:06:57 -0500 - rev 401963
Push 99472 by cbrindusan@mozilla.com at Thu, 01 Feb 2018 10:20:30 +0000
Bug 633062 p1 - Introduce AsyncQueueCaller and AsyncObserver. r=markh MozReview-Commit-ID: GGuSkA5DZUQ
abc4fb535fef78367bb202796408c7ee8952ce07: Bug 1431764 - Change release_mark_as_shipped worker-type to shipit_scriptworker r=aki
Johan Lorenzo <jlorenzo@mozilla.com> - Thu, 25 Jan 2018 17:07:07 +0100 - rev 401962
Push 99472 by cbrindusan@mozilla.com at Thu, 01 Feb 2018 10:20:30 +0000
Bug 1431764 - Change release_mark_as_shipped worker-type to shipit_scriptworker r=aki MozReview-Commit-ID: Lm5lUYDQ3l8
46ccec9ffb88c1fef9a94b991912fc03cc24e0a7: Bug 1417937 - Remove unnecessary LoadContextInfo.jsm r=standard8
hemant <hemantsingh1612@gmail.com> - Wed, 31 Jan 2018 23:16:46 +0530 - rev 401961
Push 99472 by cbrindusan@mozilla.com at Thu, 01 Feb 2018 10:20:30 +0000
Bug 1417937 - Remove unnecessary LoadContextInfo.jsm r=standard8 MozReview-Commit-ID: EnY0uKD4UD1
d4b344456faa71f688dee7f61d90907c4168b2fe: Bug 1434524 - Add more check to D3D11Checks::DoesNV12Work() r=mattwoodrow
sotaro <sotaro.ikeda.g@gmail.com> - Thu, 01 Feb 2018 18:00:09 +0900 - rev 401960
Push 99471 by sikeda@mozilla.com at Thu, 01 Feb 2018 09:00:30 +0000
Bug 1434524 - Add more check to D3D11Checks::DoesNV12Work() r=mattwoodrow
33647efec4ca07eee5474a67a8aef7574d2930f3: Bug 1434224 - Remove excess helper threads now ion compilations no longer pause each other r=lth r=luke
Jon Coppeard <jcoppeard@mozilla.com> - Thu, 01 Feb 2018 08:26:24 +0000 - rev 401959
Push 99470 by jcoppeard@mozilla.com at Thu, 01 Feb 2018 08:35:49 +0000
Bug 1434224 - Remove excess helper threads now ion compilations no longer pause each other r=lth r=luke
03a0fe367bb10467ec034af93e4b26e23fc1e54c: Bug 1423840 - Temporarily disable a small part of the prefs parser gtest due to failures on Windows. r=me
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 01 Feb 2018 19:14:30 +1100 - rev 401958
Push 99469 by nnethercote@mozilla.com at Thu, 01 Feb 2018 08:17:34 +0000
Bug 1423840 - Temporarily disable a small part of the prefs parser gtest due to failures on Windows. r=me
4e655361be5a1971300c15f58ec65c81f82ba826: Bug 1423840 (attempt 2) - Rewrite the prefs parser. r=glandium,Manishearth
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 01 Feb 2018 16:21:47 +1100 - rev 401957
Push 99468 by nnethercote@mozilla.com at Thu, 01 Feb 2018 06:31:53 +0000
Bug 1423840 (attempt 2) - Rewrite the prefs parser. r=glandium,Manishearth The prefs parser has two significant problems. - It doesn't separate tokenizing from parsing. - It is implemented as a loop around a big switch on a "current state" variable. As a result, it is hard to understand and modify, slower than it could be, and in obscure cases (involving comments and whitespace) it fails to parse what should be valid input. This patch replaces it with a recursive descent parser (albeit one without any recursion!) that has separate tokenization. The new parser is easier to understand and modify, more correct, and has better error messages. It doesn't do error recovery, but that would be much easier to add than in the old parser. The new parser also runs about 1.9x faster than the existing parser. (As measured by parsing greprefs.js's contents from memory 1000 times in succession, omitting the prefs hash table construction. If the table construction is included, it's about 1.6x faster.) The new parser is slightly stricter than the old parser in a few ways. - Disconcertingly, the old parser allowed arbitrary junk between prefs (including at the start and end of the prefs file) so long as that junk didn't include any of the following chars: '/', '#', 'u', 's', 'p'. I.e. lines like these: !foo@bar&pref("prefname", true); ticky_pref("prefname", true); // missing 's' at start User_pref("prefname", true); // should be 'u' at start would all be treated the same as this: pref("prefname", true); The new parser disallows such junk because it isn't necessary and seems like an unintentional botch by the old parser. - The old parser allowed character 0x1a (SUB) between tokens and treated it like '\n'. The new parser does not allow this character. SUB was used to indicate end-of-file (*not* end-of-line) in some old operating systems such as MS-DOS, but this doesn't seem necessary today. - The old parser tolerated (with a warning) invalid escape sequences within string literals -- such as "\q" (not a valid escape) and "\x1" and "\u12" (both of which have insufficient hex digits) -- accepting them literally. The new parser does not tolerate invalid escape sequences because it doesn't seem necessary and would complicate things. - The old parser tolerated character 0x00 (NUL) within string literals; this is dangerous because C++ code that manipulates string values with embedded NULs will almost certainly consider those chars as end-of-string markers. The new parser treats NUL chars as end-of-file, to avoid this danger and because it facilitates a significant optimization (described within the code). - The old parser allowed integer literals to overflow, silently wrapping them. The new parser treats integer overflow as a parse error. This seems better, and it caught existing overflows of places.database.lastMaintenance, in testing/profiles/prefs_general.js (bug 1424030) and testing/talos/talos/config.py (bug 1434813). The first of these changes meant that a couple of existing prefs with ";;" at the end had to be changed (done in the preceding patch). The minor increase in strictness shouldn't be a problem for default pref files such as greprefs.js within the application (which we can modify), nor for app-written prefs files such as prefs.js. It could affect user-written prefs files such as user.js; the experience above suggests that integer overflow and ";;" are the most likely problems in practice. In my opinion, the risk here is acceptable. The new parser also does a better job of tracking line numbers because it (a) treats "\r\n" sequences as a single end-of-line marker, and (a) pays attention to end-of-line sequences within string literals. Finally, the patch adds thorough tests of both valid and invalid syntax. MozReview-Commit-ID: JD3beOQl4AJ
8ebdf597ade8b7c25edd3ea75babd721f28fc4a3: Bug 1423840 (attempt 2) - Remove extraneous semicolons in all.js. r=glandium
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 01 Feb 2018 15:44:29 +1100 - rev 401956
Push 99467 by nnethercote@mozilla.com at Thu, 01 Feb 2018 05:10:06 +0000
Bug 1423840 (attempt 2) - Remove extraneous semicolons in all.js. r=glandium MozReview-Commit-ID: 2BMfVOoEtQ2
a9ce3cd892a796726d4a7077b705204d1c9a30b0: Bug 1434813 - Fix integer overflow of places.database.lastMaintenance in testing/profiles/prefs_general.js. r=glandium.
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 01 Feb 2018 15:40:32 +1100 - rev 401955
Push 99467 by nnethercote@mozilla.com at Thu, 01 Feb 2018 05:10:06 +0000
Bug 1434813 - Fix integer overflow of places.database.lastMaintenance in testing/profiles/prefs_general.js. r=glandium. Bug 1383896 added this constant to testing/talos/talos/config.py: > FAR_IN_FUTURE = 7258114800 which is used as the value for the "places.database.lastMaintenance" pref. (7258114800 seconds after 1970 is the start of the year 2200.) libpref stores integers prefs as int32_t and the current parser doesn't detect overflow. So this overflows to -1331819792. (I detected this with the new prefs parser from bug 1423840, which does detect integer overflow.) As a result the condition testing this pref in toolkit/components/places/PlacesCategoriesStarter.js ends up always succeeding in tests, which is the exact opposite of what was intended. This patch changes it to 2147483647 (the year 2038), the maximum int32_t value. (Note: this is much the same as bug 1424030, which was fixed recently.) MozReview-Commit-ID: AQw4b8tmE9u
1afdba933156fc334921e7924e5edca02050e295: Bug 1403334 - Make sure the property value overflow is indented. r=gl
Liam Hodgins <canada8715@gmail.com> - Wed, 31 Jan 2018 22:50:51 -0500 - rev 401954
Push 99466 by gabriel.luong@gmail.com at Thu, 01 Feb 2018 03:57:46 +0000
Bug 1403334 - Make sure the property value overflow is indented. r=gl
1142fe8c0a2e61a2ee73e70bb805bfeaac44d595: Bug 1433344 - Convert encrypted AAC to ADTS before decryption. r=jya
Chris Pearce <cpearce@mozilla.com> - Tue, 30 Jan 2018 14:39:09 +1300 - rev 401953
Push 99465 by cpearce@mozilla.com at Thu, 01 Feb 2018 01:54:01 +0000
Bug 1433344 - Convert encrypted AAC to ADTS before decryption. r=jya MozReview-Commit-ID: IGmBfJtYsCi
63fe40a76a252775c0a24bc65f64a479d8a5946e: Backed out 7 changesets (bug 1434429) for build bustages on regress-618572.js and TokenStream.h on a CLOSED TREE
Cosmin Sabou <csabou@mozilla.com> - Thu, 01 Feb 2018 03:31:45 +0200 - rev 401952
Push 99464 by csabou@mozilla.com at Thu, 01 Feb 2018 01:32:15 +0000
Backed out 7 changesets (bug 1434429) for build bustages on regress-618572.js and TokenStream.h on a CLOSED TREE Backed out changeset 1e0faca62e86 (bug 1434429) Backed out changeset b190c5a3dab2 (bug 1434429) Backed out changeset 95e07a79f4b2 (bug 1434429) Backed out changeset 21c79fd76133 (bug 1434429) Backed out changeset 45c9102825ab (bug 1434429) Backed out changeset 112eaf00632c (bug 1434429) Backed out changeset 024f70aeba70 (bug 1434429)
c272e33a5571f411182688fc2fab94f03bc90a08: Backed out changeset 1fea6030657b (bug 1433344) for mda failures on EMEDecoderModule.cpp on a CLOSED TREE
Cosmin Sabou <csabou@mozilla.com> - Thu, 01 Feb 2018 03:05:53 +0200 - rev 401951
Push 99463 by csabou@mozilla.com at Thu, 01 Feb 2018 01:06:11 +0000
Backed out changeset 1fea6030657b (bug 1433344) for mda failures on EMEDecoderModule.cpp on a CLOSED TREE
c30e31ae61f96947e0737f0faac8f4de64d04a0e: Backed out 2 changesets (bug 1423840) for mass Talos failures due to forbidden connections. CLOSED TREE
Cosmin Sabou <csabou@mozilla.com> - Thu, 01 Feb 2018 03:05:08 +0200 - rev 401950
Push 99463 by csabou@mozilla.com at Thu, 01 Feb 2018 01:06:11 +0000
Backed out 2 changesets (bug 1423840) for mass Talos failures due to forbidden connections. CLOSED TREE Backed out changeset e8b798a5205a (bug 1423840) Backed out changeset e500592d3551 (bug 1423840)
1e0faca62e866db09ca9157d0468f035736484ee: Bug 1434429 - Comment out an assertion whose condition is disliked by certain versions of gcc for entirely mysterious reasons, to be debugged later. r=bustage in a still-CLOSED TREE
Jeff Walden <jwalden@mit.edu> - Wed, 31 Jan 2018 16:53:44 -0800 - rev 401949
Push 99462 by jwalden@mit.edu at Thu, 01 Feb 2018 00:53:56 +0000
Bug 1434429 - Comment out an assertion whose condition is disliked by certain versions of gcc for entirely mysterious reasons, to be debugged later. r=bustage in a still-CLOSED TREE
b190c5a3dab273579a5c8b5b06dd83be75459c17: Bug 1434429 - Followup bustage fix (?) for gcc (and maybe other?) compiler bustage. Worked in recent clang... r=boogstage in a CLOSED TREE
Jeff Walden <jwalden@mit.edu> - Wed, 31 Jan 2018 16:22:24 -0800 - rev 401948
Push 99461 by jwalden@mit.edu at Thu, 01 Feb 2018 00:26:22 +0000
Bug 1434429 - Followup bustage fix (?) for gcc (and maybe other?) compiler bustage. Worked in recent clang... r=boogstage in a CLOSED TREE
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip