a5dd7c81da0ed4e9eaf3181b99298566dfa319f5: Bug 1489532: Check for nsISimpleEnumerator wrapper before searching existing tear-offs. r=mccr8
Kris Maglione <maglione.k@gmail.com> - Fri, 07 Sep 2018 15:17:56 -0700 - rev 435263
Push 107612 by maglione.k@gmail.com at Fri, 07 Sep 2018 22:58:03 +0000
Bug 1489532: Check for nsISimpleEnumerator wrapper before searching existing tear-offs. r=mccr8 When an XPC wrapped JS object returns an object from a property or function which is expected to return a given interface, we create a wrapper for that interface regardless of whether the object has a QueryInterface method which claims to support it. For the nsISimpleEnumerator enumerator case, the check for that existing wrapper comes before the check for the nsISimpleEnumerator special casing, which breaks automatic conversion in those cases. This patch moves that check just before the check for the existing wrapper, and just after the nsIPropertyBag special casing, which has similar semantics. Differential Revision: https://phabricator.services.mozilla.com/D5335
4bb16d5fe59315ab0e7f31e2eff6f6a162002cba: Bug 1487815 - Compute LifoAlloc chunk-size in a manner that doesn't invoke UB. r=tcampbell
Jeff Walden <jwalden@mit.edu> - Thu, 06 Sep 2018 21:37:07 -0700 - rev 435262
Push 107611 by jwalden@mit.edu at Fri, 07 Sep 2018 22:54:12 +0000
Bug 1487815 - Compute LifoAlloc chunk-size in a manner that doesn't invoke UB. r=tcampbell
0e1dd163d6141129e8e58bc835efd2f0cc37be1d: Bug 1487136 - Make OwningCompileOptions::setFile(JSContext*, const char*) MOZ_MUST_USE. r=kmag on fixing the one user requiring any changes, r=me on the obviously-justified attribute-addition
Jeff Walden <jwalden@mit.edu> - Tue, 28 Aug 2018 14:54:20 -0500 - rev 435261
Push 107611 by jwalden@mit.edu at Fri, 07 Sep 2018 22:54:12 +0000
Bug 1487136 - Make OwningCompileOptions::setFile(JSContext*, const char*) MOZ_MUST_USE. r=kmag on fixing the one user requiring any changes, r=me on the obviously-justified attribute-addition
3cbbfc5127e473345c8b0f040a0ed1b254d800ed: Bug 1079662 - Always enable PIE. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Thu, 06 Sep 2018 13:27:49 +0900 - rev 435260
Push 107610 by mh@glandium.org at Fri, 07 Sep 2018 22:45:13 +0000
Bug 1079662 - Always enable PIE. r=froydnj Last attempt, a few years ago, blatantly failed because nautilus (the GNOME file manager) can't start PIE executables, which look like shared libraries, and that it thus considers not being executables. Downstreams don't actually have the problem, because users won't be launching Firefox from a file manager, but for mozilla.org builds, it is a problem because users would download, then extract, and then likely try to run the Firefox executable from a file manager. So for mozilla.org builds, we still need to find a way around the nautilus problem. A .desktop file could be a solution, but .desktop files have not actually been designed for this use case, which leads to: - having to use an awful one-liner shell wrapper to derive the path to the executable from that of the .desktop file, - not even being able to associate an icon, - the .desktop file not being copiable to a location where .desktop files would normally go, because it would then fail to find the executable. Another possibility is to go back to using a shell wrapper, but that's not entirely appealing. What we chose here is similar, where we have a small `firefox` wrapper that launches the real `firefox-bin` (which is still leftover from those old times where we had a shell wrapper, for reasons). The small `firefox` wrapper is a minimalist C executable that just finds the path to the `firefox-bin` executable and executes it with the same args it was called with. The wrapper is only enabled when the MOZ_NO_PIE_COMPAT environment variable is set, which we only take into account on Linux. The variable is only really meant to be used for mozilla.org builds, for the nautilus problem. Downstreams will just pick the default, which is changed to build PIE. On other platforms, PIE was already enabled by default, so we just remove the --enable-pie configure flag. Differential Revision: https://phabricator.services.mozilla.com/D5109
877c851a1b66348627379e9a7a7f4b1f9fd73dfb: Bug 1079662 - Always pass -rdynamic when linking with sanitizers. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Thu, 06 Sep 2018 10:51:30 +0900 - rev 435259
Push 107610 by mh@glandium.org at Fri, 07 Sep 2018 22:45:13 +0000
Bug 1079662 - Always pass -rdynamic when linking with sanitizers. r=froydnj When building executables as PIE, and because we use -Bsymbolic, which symbols are exported from an executable varies based on the libraries it's directly linked against, to fulfil their symbol needs. So when a library depends on e.g. ASAN runtime symbols, and the linker finds that, it will keep those ASAN symbols in the executable for the library. And drop the other, unused symbols. But when the executable then dlopen()s a library (e.g. shlibsign loading libfreebl) that uses another set of ASAN symbols, including symbols that none of the direct dependencies of the executable need, dlopen() fails because of the missing symbols. It's not currently an apparent problem because we don't enable PIE, and we build Gecko executables with -rdynamic already (for mozjemalloc). But we don't build non-Gecko executables this way (like shlibsign). Differential Revision: https://phabricator.services.mozilla.com/D5108
1cfac7a05877a1e4269569f2969eceaf2c14dd7d: Bug 1079662 - Use firefox-bin for updater tests on Linux. r=rstrong
Mike Hommey <mh+mozilla@glandium.org> - Thu, 06 Sep 2018 11:01:03 +0900 - rev 435258
Push 107610 by mh@glandium.org at Fri, 07 Sep 2018 22:45:13 +0000
Bug 1079662 - Use firefox-bin for updater tests on Linux. r=rstrong This sort of reverts the changes from bug 771940, for Linux only, because we're going to turn the firefox binary into a wrapper that executes firefox-bin, and since the updater tests only copy the former, they fail when trying to start firefox. Making them instead use firefox-bin directly works around the issue. This matches what we were doing back when firefox was a shell script that executed firefox-bin. Differential Revision: https://phabricator.services.mozilla.com/D5107
2f0491b762ddc0389761053d1bf35bb1fda29821: Bug 1489001 - Move most of mozconfig.linux to mozconfig.unix. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Thu, 06 Sep 2018 11:43:08 +0900 - rev 435257
Push 107610 by mh@glandium.org at Fri, 07 Sep 2018 22:45:13 +0000
Bug 1489001 - Move most of mozconfig.linux to mozconfig.unix. r=froydnj Bug 1487330 made mozconfig.asan use mozconfig.linux, but while that worked out fine, it turns out that we do have mac builds using e.g. mozconfig.asan, and that those can break when doing linux-specific changes to mozconfig.linux.
ea523d724c7137a326c0e8d3dc7513b36ef489a7: Backed out 4 changesets (bug 1442587) for SM build bustages on a CLOSED TREE
Daniel Varga <dvarga@mozilla.com> - Sat, 08 Sep 2018 01:19:55 +0300 - rev 435256
Push 107609 by dvarga@mozilla.com at Fri, 07 Sep 2018 22:22:21 +0000
Backed out 4 changesets (bug 1442587) for SM build bustages on a CLOSED TREE Backed out changeset 7e7d80003930 (bug 1442587) Backed out changeset 217ce4f92eb9 (bug 1442587) Backed out changeset 60a28b2e2493 (bug 1442587) Backed out changeset f88b838fa1b4 (bug 1442587)
293719637a6250a9ff98082e03b89b940c3ce761: Merge mozilla-central to mozilla-inbound
Daniel Varga <dvarga@mozilla.com> - Sat, 08 Sep 2018 01:13:18 +0300 - rev 435255
Push 107609 by dvarga@mozilla.com at Fri, 07 Sep 2018 22:22:21 +0000
Merge mozilla-central to mozilla-inbound
3026c40acec365f6606c39234bba5f4e99c83dac: Merge mozilla-inbound to mozilla-central a=merge
Daniel Varga <dvarga@mozilla.com> - Sat, 08 Sep 2018 01:04:10 +0300 - rev 435254
Push 107609 by dvarga@mozilla.com at Fri, 07 Sep 2018 22:22:21 +0000
Merge mozilla-inbound to mozilla-central a=merge
36ee80fc14aefdd00385da7fc073f28e78dfbd40: Bug 1488452 - Remove incorrect use of PromiseFlatString in FileUtilsWin. r=froydnj
Henri Sivonen <hsivonen@hsivonen.fi> - Fri, 07 Sep 2018 14:48:36 +0000 - rev 435253
Push 107609 by dvarga@mozilla.com at Fri, 07 Sep 2018 22:22:21 +0000
Bug 1488452 - Remove incorrect use of PromiseFlatString in FileUtilsWin. r=froydnj Also rewrote some code around the actual problem to be more obviously correct and comprehensible. MozReview-Commit-ID: FF2hSjQ4U1x Differential Revision: https://phabricator.services.mozilla.com/D5154
5b5f54aa78d77f0df5ae455265c4b03323e8c731: Bug 1489315 - Move ExtensionTelemetry into its own JSM module. r=mixedpuppy
Luca Greco <lgreco@mozilla.com> - Fri, 07 Sep 2018 16:27:44 +0000 - rev 435252
Push 107609 by dvarga@mozilla.com at Fri, 07 Sep 2018 22:22:21 +0000
Bug 1489315 - Move ExtensionTelemetry into its own JSM module. r=mixedpuppy This patch moves the ExtensionTelemetry helpers (added into ExtensionUtils.jsm by Bug 1483002) into a new ExtensionTelemetry.jsm and makes the ExtensionTelemetry a lazy getter on every one of the JSM and API modules that are going to use it, so that we don't have to load these helpers until they are actually used and we can reduce their impact on the base content memory usage. Differential Revision: https://phabricator.services.mozilla.com/D5266
f2b03dfdb75b41827d20e68edc71d1674d1101d1: Bug 1489455 - Replace evalInSandbox from httpd.js r=valentin
vinoth <cegvinoth@gmail.com> - Fri, 07 Sep 2018 13:27:24 +0000 - rev 435251
Push 107609 by dvarga@mozilla.com at Fri, 07 Sep 2018 22:22:21 +0000
Bug 1489455 - Replace evalInSandbox from httpd.js r=valentin Differential Revision: https://phabricator.services.mozilla.com/D5243
34feae8faf9f1fc6d30b4a3f22d50ee59a020c4b: Bug 1478883: [release] Don't run builds when bumping versions after a release; r=RyanVM,Callek
Tom Prince <mozilla@hocat.ca> - Wed, 05 Sep 2018 23:41:33 +0000 - rev 435250
Push 107609 by dvarga@mozilla.com at Fri, 07 Sep 2018 22:22:21 +0000
Bug 1478883: [release] Don't run builds when bumping versions after a release; r=RyanVM,Callek Differential Revision: https://phabricator.services.mozilla.com/D4805
217dd769d697d52f9e1eec9f4c0e02e2faf95b04: No bug: [taskgraph] Use `memoize` in files_changed; r=dustin
Tom Prince <mozilla@hocat.ca> - Fri, 07 Sep 2018 17:35:07 +0000 - rev 435249
Push 107609 by dvarga@mozilla.com at Fri, 07 Sep 2018 22:22:21 +0000
No bug: [taskgraph] Use `memoize` in files_changed; r=dustin Differential Revision: https://phabricator.services.mozilla.com/D2733
04be4edd4f97f46530ef9a84cceb4bd888f64c72: Bug 1469610: [taskgraph] Use `action.taskGroupId` to set `ACTION_TASK_GROUP_ID`; r=dustin
Tom Prince <mozilla@hocat.ca> - Fri, 07 Sep 2018 17:30:12 +0000 - rev 435248
Push 107609 by dvarga@mozilla.com at Fri, 07 Sep 2018 22:22:21 +0000
Bug 1469610: [taskgraph] Use `action.taskGroupId` to set `ACTION_TASK_GROUP_ID`; r=dustin This makes it consistent with everywhere else in `.taskcluster.yml` where we refer to the action task group. Differential Revision: https://phabricator.services.mozilla.com/D1707
ef66eb6e2fe08ebe482ce8e22b022eb28eaa33a4: Bug 1489546 - Don't drop process priority of webext process r=mconley
Doug Thayer <dothayer@mozilla.com> - Fri, 07 Sep 2018 16:46:42 +0000 - rev 435247
Push 107609 by dvarga@mozilla.com at Fri, 07 Sep 2018 22:22:21 +0000
Bug 1489546 - Don't drop process priority of webext process r=mconley Turned out to be fairly trivial. Not much to explain here - as far as I can tell this looks clean on try now (no web extension failures like there were before). Differential Revision: https://phabricator.services.mozilla.com/D5280
417fae8385d6dcc6dc223fd5340c63ae502769f8: Bug 1488952 - Bump tab close Telemetry probe expiries. data-review=liuche, r=Gijs
Mike Conley <mconley@mozilla.com> - Fri, 07 Sep 2018 16:48:29 +0000 - rev 435246
Push 107609 by dvarga@mozilla.com at Fri, 07 Sep 2018 22:22:21 +0000
Bug 1488952 - Bump tab close Telemetry probe expiries. data-review=liuche, r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D5166
5a3f171733cdd2beb0b0a566c21b155131d51b3a: Merge mozilla-central to autoland
Dorel Luca <dluca@mozilla.com> - Fri, 07 Sep 2018 19:37:17 +0300 - rev 435245
Push 107609 by dvarga@mozilla.com at Fri, 07 Sep 2018 22:22:21 +0000
Merge mozilla-central to autoland
e74bd1eae0db0f0b9e13c199a8ef304375b3b0cc: Bug 1488174 - Use UpdateServiceHelper to decide on whether to add Updater notification channel. r=jchen
Jan Henning <jh+bugzilla@buttercookie.de> - Fri, 07 Sep 2018 07:12:50 +0000 - rev 435244
Push 107609 by dvarga@mozilla.com at Fri, 07 Sep 2018 22:22:21 +0000
Bug 1488174 - Use UpdateServiceHelper to decide on whether to add Updater notification channel. r=jchen That way, we only add that notification channel if the updater really is active, i.e. not if we've been installed from the Play Store. Unfortunately, using the UpdateServiceHelper requires a Context, so adding/re- moving the UPDATER_CHANNEL_TAG cannot be done during variable initialisation. Differential Revision: https://phabricator.services.mozilla.com/D4890
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip