9c83861ca1a12f86b4de7d149c2a3968fc76db97: Bug 1297630 - Make certificate error pages work properly in iframes. r=Gijs
Johann Hofmann <jhofmann@mozilla.com> - Thu, 15 Mar 2018 13:55:13 +0100 - rev 408696
Push 101011 by nerli@mozilla.com at Sat, 17 Mar 2018 22:28:18 +0000
Bug 1297630 - Make certificate error pages work properly in iframes. r=Gijs This adds workarounds to ensure that messages passed from browser.js to content.js in the context of certerror pages always contain a frameId which can be used to identify the frame that is supposed to receive them. This fix is really meant to be temporary until we come up with a good replacement for chrome - content communication, which probably boils down to finding a middle ground between nsAboutCapabilities, RemotePageManager and WebChannel. I did not update communication for Captive Portal pages, since those require one-way broadcasting from chrome to content, which is not supported in this model. This is tracked in bug 1446319. I did also not change the behavior of the "Go Back" button, which still navigates away the top level page, because I consider changing that behavior out of scope for this bug (and in my personal opinion we should not change the behavior). MozReview-Commit-ID: GrM6PFys6Cu
36bfb71a88eaf31a1e89f69920287e3fb74d4065: Bug 1297630 - Test certificate errors in iframes. r=Gijs
Johann Hofmann <jhofmann@mozilla.com> - Thu, 15 Mar 2018 12:57:11 +0100 - rev 408695
Push 101011 by nerli@mozilla.com at Sat, 17 Mar 2018 22:28:18 +0000
Bug 1297630 - Test certificate errors in iframes. r=Gijs This amends the browser_aboutCertError test file to cover error pages in iframes in addition to top-level pages. I figured that instead of re-writing all assertions in a separate test it would be smarter to do the same assertions we apply to the top-level error pages on frames as well. I did not update the checkWrongSystemTimeWarning test, which is currently disabled. MozReview-Commit-ID: 90fS0emPaSN
6c397982f283e459e1623b2b0c7b0c5546981f5c: servo: Merge #20071 - Use typed coordinates more (from paulrouget:typedsize); r=glennw
Paul Rouget <me@paulrouget.com> - Fri, 16 Mar 2018 17:18:24 -0400 - rev 408694
Push 101011 by nerli@mozilla.com at Sat, 17 Mar 2018 22:28:18 +0000
servo: Merge #20071 - Use typed coordinates more (from paulrouget:typedsize); r=glennw Requires https://github.com/servo/servo/pull/19895 We use Size2D and Point2D across compositing, constellation and script, loosing the type of pixels we use (DevicePixel, DeviceIndepententPixel or CSSPixel) along the way, which might lead to bugs like `window.outerHeight` not taking into account the page zoom (using DeviceIndepententPixel instead of CSSPixel). This should make the situation a bit better. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because we can't zoom in a test <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: fc90e613d8851b663e3304d713b2ca08aa397bf4
2e74592c8f953de873f5495d2fa9afa9661ac99c: Bug 1446280: Ensure a11y::SetInstantiator only runs once; r=eeejay
Aaron Klotz <aklotz@mozilla.com> - Fri, 16 Mar 2018 12:23:46 -0600 - rev 408693
Push 101010 by aklotz@mozilla.com at Sat, 17 Mar 2018 18:41:54 +0000
Bug 1446280: Ensure a11y::SetInstantiator only runs once; r=eeejay
a6528c5018d22c41a03fe1353e188ea0f8526d93: Bug 749981: Remove Node.getUserData / setUserData. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 17 Mar 2018 05:30:49 +0100 - rev 408692
Push 101009 by ecoal95@gmail.com at Sat, 17 Mar 2018 18:38:53 +0000
Bug 749981: Remove Node.getUserData / setUserData. r=smaug Summary: MozReview-Commit-ID: JkUCvVZ4V2Y Reviewers: smaug Bug #: 749981 Differential Revision: https://phabricator.services.mozilla.com/D749 MozReview-Commit-ID: KadWzpMjdW
384c57a10906f919aa27af99575186e9f14aaa20: Backed out 5 changesets (bug 1444760) for talos failures regarding undefined params on a CLOSED TREE
Andreea Pavel <apavel@mozilla.com> - Sat, 17 Mar 2018 19:45:06 +0200 - rev 408691
Push 101008 by apavel@mozilla.com at Sat, 17 Mar 2018 17:45:22 +0000
Backed out 5 changesets (bug 1444760) for talos failures regarding undefined params on a CLOSED TREE Backed out changeset 00da6f45a098 (bug 1444760) Backed out changeset 79b40369822f (bug 1444760) Backed out changeset 08e77f90bdb4 (bug 1444760) Backed out changeset c1e0ecafa703 (bug 1444760) Backed out changeset 4c52361ab381 (bug 1444760)
5c72707149c3885a42a573c558dda1224594633c: Bug 1446501 - Update Debugger Frontend v24. r=jdescottes
Jason Laster <jason.laster.11@gmail.com> - Fri, 16 Mar 2018 14:30:34 -0400 - rev 408690
Push 101007 by jlaster@mozilla.com at Sat, 17 Mar 2018 17:32:15 +0000
Bug 1446501 - Update Debugger Frontend v24. r=jdescottes MozReview-Commit-ID: DgETcSJv89H
00da6f45a098a51748cce5759fb3ed6241d6afa9: Bug 1444760 - Followup: Fix 'params is undefined' exception on a CLOSED TREE. r=me
Tim Nguyen <ntim.bugs@gmail.com> - Sat, 17 Mar 2018 16:21:56 +0000 - rev 408689
Push 101006 by ntim.bugs@gmail.com at Sat, 17 Mar 2018 16:22:10 +0000
Bug 1444760 - Followup: Fix 'params is undefined' exception on a CLOSED TREE. r=me
79b40369822f20507569bacefd6a4ee6b8f29871: Bug 1444760 - Followup: Fix params is null exception. r=me
Tim Nguyen <ntim.bugs@gmail.com> - Sat, 17 Mar 2018 15:40:39 +0000 - rev 408688
Push 101005 by ntim.bugs@gmail.com at Sat, 17 Mar 2018 15:40:59 +0000
Bug 1444760 - Followup: Fix params is null exception. r=me
6ec4bc1d3720b22da681ba83b352b056909fb5a1: Bug 1440714 - Convert Android xpcshell test harness to adb.py; r=bc
Geoff Brown <gbrown@mozilla.com> - Sat, 17 Mar 2018 09:28:23 -0600 - rev 408687
Push 101004 by gbrown@mozilla.com at Sat, 17 Mar 2018 15:28:39 +0000
Bug 1440714 - Convert Android xpcshell test harness to adb.py; r=bc
e4470b1b5108d0d7afde070920e48c2d185808ad: Bug 1446601: Devirtualize nsIDocument::Get/SetFailedChannel. r=bz
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 17 Mar 2018 06:13:12 +0100 - rev 408686
Push 101003 by ecoal95@gmail.com at Sat, 17 Mar 2018 15:23:01 +0000
Bug 1446601: Devirtualize nsIDocument::Get/SetFailedChannel. r=bz Summary: The member is already in nsIDocument anyway. Reviewers: bzbarsky Bug #: 1446601 Differential Revision: https://phabricator.services.mozilla.com/D751 MozReview-Commit-ID: 90Ad5wiCeMS
3508bdff5806776fa0d8fec916607a479f88c568: Bug 1446568: Move a couple other methods from nsDocument to nsIDocument. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 15 Mar 2018 19:46:56 +0100 - rev 408685
Push 101003 by ecoal95@gmail.com at Sat, 17 Mar 2018 15:23:01 +0000
Bug 1446568: Move a couple other methods from nsDocument to nsIDocument. r=smaug Need to add an static_cast for nsIDOMDocument, but it'll be temporary, I'd expect. MozReview-Commit-ID: 1cSwlcQZL5N
5d7210ef8a29d0b8eda759c654e6017eabd5c3f7: Bug 1446568: Move UseCounter stuff and IsSynthesized to nsIDocument. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 15 Mar 2018 19:37:02 +0100 - rev 408684
Push 101003 by ecoal95@gmail.com at Sat, 17 Mar 2018 15:23:01 +0000
Bug 1446568: Move UseCounter stuff and IsSynthesized to nsIDocument. r=smaug MozReview-Commit-ID: IeKzmi31e8d
9f3e5bc6ac993b3d4965c188798744d5e9f80de5: Bug 1446568: Make SetScriptGlobalObject not pure virtual. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 15 Mar 2018 18:37:51 +0100 - rev 408683
Push 101003 by ecoal95@gmail.com at Sat, 17 Mar 2018 15:23:01 +0000
Bug 1446568: Make SetScriptGlobalObject not pure virtual. r=smaug MozReview-Commit-ID: 1kKPq7f50jC
0740c8e6d169bf2025ea150e3b7c5d7a1efd50db: Bug 1446568: Make nsIDocument SetContentType / SetDocumentCharacterSet not pure virtual. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 15 Mar 2018 18:34:50 +0100 - rev 408682
Push 101003 by ecoal95@gmail.com at Sat, 17 Mar 2018 15:23:01 +0000
Bug 1446568: Make nsIDocument SetContentType / SetDocumentCharacterSet not pure virtual. r=smaug No good reason for them to be. MozReview-Commit-ID: 7bFVD8YFqo2
d6dec081f644249be33dd761c6cb5aacc61b57d2: Bug 1446568: Move a couple more stuff from nsDocument to nsIDocument. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 15 Mar 2018 19:30:15 +0100 - rev 408681
Push 101003 by ecoal95@gmail.com at Sat, 17 Mar 2018 15:23:01 +0000
Bug 1446568: Move a couple more stuff from nsDocument to nsIDocument. r=smaug MozReview-Commit-ID: JC2nqzJEq7U
b0387ea3bdffe4b4a01705231652aaef82a75d92: Bug 1446568: Move a few of the remaining nsDocument members to nsIDocument. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 15 Mar 2018 19:25:16 +0100 - rev 408680
Push 101003 by ecoal95@gmail.com at Sat, 17 Mar 2018 15:23:01 +0000
Bug 1446568: Move a few of the remaining nsDocument members to nsIDocument. r=smaug MozReview-Commit-ID: 3FdiyHLFOh
cc8a03f7e15e1887367aad6b34bbc03adfeaa2d2: Bug 1446568: Remove an unneeded cast. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 15 Mar 2018 18:45:29 +0100 - rev 408679
Push 101003 by ecoal95@gmail.com at Sat, 17 Mar 2018 15:23:01 +0000
Bug 1446568: Remove an unneeded cast. r=smaug MozReview-Commit-ID: ILtm9ybRwJ7
20d621bd59d5930720936f9bac167a3eb1e94b25: Bug 1446568: Move the blocked tracking nodes methods to nsIDocument. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 15 Mar 2018 18:41:34 +0100 - rev 408678
Push 101003 by ecoal95@gmail.com at Sat, 17 Mar 2018 15:23:01 +0000
Bug 1446568: Move the blocked tracking nodes methods to nsIDocument. r=smaug MozReview-Commit-ID: LuvoFP8UyNg
339d892ddf7ff922dbbda8b0feaae5b289ae1216: Bug 1446568: Remove nsDocument::UnlockPointer. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 15 Mar 2018 18:31:17 +0100 - rev 408677
Push 101003 by ecoal95@gmail.com at Sat, 17 Mar 2018 15:23:01 +0000
Bug 1446568: Remove nsDocument::UnlockPointer. r=smaug And remove some now-unneeded casts. MozReview-Commit-ID: CFfkiC0xJ2C
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip