9be247c306a1250c8416feb2f68d284a5e3f4942: Bug 1306549 part.6 Create KeyboardLayout::ActivateDeadKeyState() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 16 Sep 2016 19:09:12 +0900 - rev 316431
Push 82453 by kwierso@gmail.com at Wed, 05 Oct 2016 00:42:29 +0000
Bug 1306549 part.6 Create KeyboardLayout::ActivateDeadKeyState() r=m_kato There is DeactivateDeadKeyState() but not ActivateDeadKeyState(). There should be both of them and hides the dead key state management into them. MozReview-Commit-ID: JvAPE5f2HVy
adba65212c35be06d1fb6a46303f1583525fe9bd: Bug 1306549 part.5 Create KeyboardLayout::GetCompositeChar() for wrapping VirtualKey::GetCompositeChar() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 16 Sep 2016 18:54:48 +0900 - rev 316430
Push 82453 by kwierso@gmail.com at Wed, 05 Oct 2016 00:42:29 +0000
Bug 1306549 part.5 Create KeyboardLayout::GetCompositeChar() for wrapping VirtualKey::GetCompositeChar() r=m_kato VirtualKey::GetCompositeChar() needs index of virtual keycode which may make around the caller messy. So, KeyboardLayout::GetCompositeChar() should wrap it and KeyboardLayout::MaybeInitNativeKeyWithCompositeChar() should use it. MozReview-Commit-ID: 8KLTJpCFZ8u
fd077161e636ef594f21b1c541f01c7a6701780b: Bug 1306549 part.4 Create KeyboardLayout::GetNativeUniCharsAndModifiers() for wrapping VirtualKey::GetNativeUniChars() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 16 Sep 2016 18:38:53 +0900 - rev 316429
Push 82453 by kwierso@gmail.com at Wed, 05 Oct 2016 00:42:29 +0000
Bug 1306549 part.4 Create KeyboardLayout::GetNativeUniCharsAndModifiers() for wrapping VirtualKey::GetNativeUniChars() r=m_kato Similar to VirtualKey::GetUniChars(), VirtualKey::GetNativeUniChars() needs key index. So, it should be wrapped by a new helper method, KeyboardLayout::GetNativeUniCharsAndModifiers(), and KeyboardEvent::InitNativeKey() should use this instead of accessing its member's GetNativeUniChars(). MozReview-Commit-ID: 7M9OlNF698Y
2e45f263fb199c054454f1c841160a7ff01c7173: Bug 1306549 part.3 KeyboardLayout::InitNativeKey() should use GetUniCharsAndModifiers() instead of using VirtualKey::GetUniChars() directly r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 16 Sep 2016 18:22:12 +0900 - rev 316428
Push 82453 by kwierso@gmail.com at Wed, 05 Oct 2016 00:42:29 +0000
Bug 1306549 part.3 KeyboardLayout::InitNativeKey() should use GetUniCharsAndModifiers() instead of using VirtualKey::GetUniChars() directly r=m_kato When InitNativeKey() retrieves UniCharsAndModifiers for a key, it needs key index for the given virtual keycode. Therefore, wrapping the code with GetUniCharsAndModifiers() makes InitNativeKey() code simpler since each call specifies the virtual keycode to the method instead of key index. MozReview-Commit-ID: Azy8chXexaz
bb92cb94dcac0e4c968d6c712ef1fded2b5d6567: Bug 1306549 part.2 Create overload methods which take ModifierKeyState instead of VirtualKey::ShiftState r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 30 Sep 2016 15:32:10 +0900 - rev 316427
Push 82453 by kwierso@gmail.com at Wed, 05 Oct 2016 00:42:29 +0000
Bug 1306549 part.2 Create overload methods which take ModifierKeyState instead of VirtualKey::ShiftState r=m_kato This patch gets rid of |shiftState| from KeyboardLayout::InitNativeKey() and make each caller clearer. This must make other developers understand what modifier state is used at each call. MozReview-Commit-ID: 6zydP1jkffv
54940e9b9a1b663c95782dde5d6e8aa02caa7231: Bug 1306549 part.1 KeyboardLayout::InitNativeKey() should use KeyboardLayout::IsDeadKey() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 16 Sep 2016 17:24:39 +0900 - rev 316426
Push 82453 by kwierso@gmail.com at Wed, 05 Oct 2016 00:42:29 +0000
Bug 1306549 part.1 KeyboardLayout::InitNativeKey() should use KeyboardLayout::IsDeadKey() r=m_kato KeyboardLayout::InitNativeKey() is very messy because it handles a lot of cases without helper methods. It's important to make it simpler implementation for preventing regressions caused by some patches which are written with misunderstanding. So, let's rewrite the method with helper method. First, this patch make InitNativeKey() use IsDeadKey() instead of referring the table because calling IsDeadKey() is easier to understand. MozReview-Commit-ID: DtN9qoh7Gz7
0d72f5bf9cb4ba7aaef36b41c4a75be450791467: Bug 1303236 - Skip check_vanilla_allocations if -flto flag is set; r=glandium
Enes Goktas <egoktas@mozilla.com> - Wed, 21 Sep 2016 12:31:41 -0700 - rev 316425
Push 82453 by kwierso@gmail.com at Wed, 05 Oct 2016 00:42:29 +0000
Bug 1303236 - Skip check_vanilla_allocations if -flto flag is set; r=glandium MozReview-Commit-ID: 7WOz6LpRP7L
22d95521160beb0c26e6dcee7c979e0cb617bb56: Bug 1303227 - Wrap libxul.so linker to prevent getting the linking process killed; r=glandium
Enes Goktas <egoktas@mozilla.com> - Tue, 20 Sep 2016 17:58:34 -0700 - rev 316424
Push 82453 by kwierso@gmail.com at Wed, 05 Oct 2016 00:42:29 +0000
Bug 1303227 - Wrap libxul.so linker to prevent getting the linking process killed; r=glandium This patch removes the memory usage tracking in the script that wraps the linking of the xul library. This patch also generalizes the wrapping of the xul linking process to all platforms. MozReview-Commit-ID: HyncF3aVwdx
02e7753c526100e7041d94dbc4ae2514d4c093fd: Bug 1306566 - Remove the check for mIsVisible from MDSM::DonePrerollingVideo(). r=kamidphish
JW Wang <jwwang@mozilla.com> - Fri, 30 Sep 2016 16:11:58 +0800 - rev 316423
Push 82453 by kwierso@gmail.com at Wed, 05 Oct 2016 00:42:29 +0000
Bug 1306566 - Remove the check for mIsVisible from MDSM::DonePrerollingVideo(). r=kamidphish MozReview-Commit-ID: GIEibT6YKmC
ff26deb4079871216636252d24fa0dceb6b67c98: Bug 1307595 - Fixup bad merge conflict resolution from Bug 1300654/8eef5d2cc850. r=partial-backout
Chris Pearce <cpearce@mozilla.com> - Wed, 05 Oct 2016 13:12:03 +1300 - rev 316422
Push 82452 by cpearce@mozilla.com at Wed, 05 Oct 2016 00:14:05 +0000
Bug 1307595 - Fixup bad merge conflict resolution from Bug 1300654/8eef5d2cc850. r=partial-backout 8eef5d2cc850 in Bug 1300654 incorrectly resolved a merge conflict and backed out part of the fix for Bug 1280829. Relanding. MozReview-Commit-ID: 6DIkUrc9R4t
3b380b931e81fdc6970dc4011c870cb8a67b2b06: Backed out changeset 327706b55f4e (bug 1306249) on a CLOSED TREE
Steve Fink <sfink@mozilla.com> - Tue, 04 Oct 2016 16:39:22 -0700 - rev 316421
Push 82451 by sfink@mozilla.com at Tue, 04 Oct 2016 23:39:56 +0000
Backed out changeset 327706b55f4e (bug 1306249) on a CLOSED TREE
a178818363a7926749629c49774c87213fd9b98f: Bug 1306249 - Optimize SumChildTimes by only iterating children, r=jonco
Steve Fink <sfink@mozilla.com> - Fri, 30 Sep 2016 13:16:52 -0700 - rev 316420
Push 82450 by sfink@mozilla.com at Tue, 04 Oct 2016 23:18:58 +0000
Bug 1306249 - Optimize SumChildTimes by only iterating children, r=jonco
327706b55f4e13b8c308f0e18b4932347108564d: Bug 1306249 - Report phase with longest self time, not longest total time, r=jonco
Steve Fink <sfink@mozilla.com> - Fri, 30 Sep 2016 12:25:21 -0700 - rev 316419
Push 82450 by sfink@mozilla.com at Tue, 04 Oct 2016 23:18:58 +0000
Bug 1306249 - Report phase with longest self time, not longest total time, r=jonco
6bac3fe84c137ab6ed213a051e3152a1ebc9d9a2: Bug 1306249 - GC statistics commenting, r=jonco
Steve Fink <sfink@mozilla.com> - Fri, 30 Sep 2016 12:24:46 -0700 - rev 316418
Push 82450 by sfink@mozilla.com at Tue, 04 Oct 2016 23:18:58 +0000
Bug 1306249 - GC statistics commenting, r=jonco
eb29ec2808c1cd9ff8a3d5dc69acab04eef09342: Revert "Bug 1306708 - Rename prio to nested in IPDL (r=dvander)" on a CLOSED TREE
Bill McCloskey <billm@mozilla.com> - Tue, 04 Oct 2016 15:55:12 -0700 - rev 316417
Push 82449 by wmccloskey@mozilla.com at Tue, 04 Oct 2016 22:55:34 +0000
Revert "Bug 1306708 - Rename prio to nested in IPDL (r=dvander)" on a CLOSED TREE This reverts commit b1460c626078afbb9290e7d9ecaf3af605d5e893.
977c8d8ccd4b7459622b78143c44abc26709ef0f: Revert "Bug 1306708 - Add prio() for message priority to IPDL (r=dvander)"
Bill McCloskey <billm@mozilla.com> - Tue, 04 Oct 2016 15:55:09 -0700 - rev 316416
Push 82449 by wmccloskey@mozilla.com at Tue, 04 Oct 2016 22:55:34 +0000
Revert "Bug 1306708 - Add prio() for message priority to IPDL (r=dvander)" This reverts commit 952e64ef2fb51f3e945d92b4ea27be271261e40d.
9b9690621e02ec4a590d5d19a933348134030ea6: Revert "Bug 1306708 - Fix rebasing bustage on a CLOSED TREE"
Bill McCloskey <billm@mozilla.com> - Tue, 04 Oct 2016 15:55:00 -0700 - rev 316415
Push 82449 by wmccloskey@mozilla.com at Tue, 04 Oct 2016 22:55:34 +0000
Revert "Bug 1306708 - Fix rebasing bustage on a CLOSED TREE" This reverts commit cfc7bb2a6a9710dd9963185f264c70950fd5595c.
f3b4efa4425516ca4fb96de6a6b24de42cbea94f: Bug 1306708 - Fix rebasing bustage on a CLOSED TREE
Bill McCloskey <billm@mozilla.com> - Tue, 04 Oct 2016 15:43:20 -0700 - rev 316414
Push 82448 by wmccloskey@mozilla.com at Tue, 04 Oct 2016 22:43:42 +0000
Bug 1306708 - Fix rebasing bustage on a CLOSED TREE
bd7123b6858c8f2bb0dde86c7b9c55a451c15b13: Bug 1306708 - Add prio() for message priority to IPDL (r=dvander)
Bill McCloskey <billm@mozilla.com> - Fri, 30 Sep 2016 16:51:53 -0700 - rev 316413
Push 82447 by wmccloskey@mozilla.com at Tue, 04 Oct 2016 22:28:49 +0000
Bug 1306708 - Add prio() for message priority to IPDL (r=dvander)
649af7cb0c87070b1f41cc407b6109f2f83a7889: Bug 1306708 - Rename prio to nested in IPDL (r=dvander)
Bill McCloskey <billm@mozilla.com> - Fri, 30 Sep 2016 16:20:50 -0700 - rev 316412
Push 82447 by wmccloskey@mozilla.com at Tue, 04 Oct 2016 22:28:49 +0000
Bug 1306708 - Rename prio to nested in IPDL (r=dvander)
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip