97b43ea69c41690698b3ab9adc8a7567e3258c3b: Bug 1361843 part 2. Track whether the stylist may need a rebuild in ServoStyleSet and do on-demand rebuilds as needed. r=emilio
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 10 May 2017 13:13:39 -0400 - rev 357711
Push 90186 by cbook@mozilla.com at Thu, 11 May 2017 10:53:57 +0000
Bug 1361843 part 2. Track whether the stylist may need a rebuild in ServoStyleSet and do on-demand rebuilds as needed. r=emilio This does not remove the eager rebuilds we're doing yet. I'm not completely happy with the ad-hoc manner in which we end up doing rebuilds. I considered doing something where we'd make stylist a non-public member of PerDocumentStyleDataImpl and have a getter that updates the stylist on get, with maybe a separate non-flushing getter for special situations, if those arise. But that requires that we make various cases where we currently have a non-mut PerDocumentStyleDataImpl use a mut one. Maybe that would be the right tradeoff... I'm also not sure whether the naming is right here. Maybe we should just talk about needing a stylesheet flush, not a stylist rebuild, in ServoStyleSet? MozReview-Commit-ID: 9C7BG5ygm79
7a8eb08d31d735a8403a95f62c5d524e164793a5: Bug 1363902 - Simplify some browser chrome tests by utilizing TestUtils.topicObserved. r=mikedeboer
Dão Gottwald <dao@mozilla.com> - Thu, 11 May 2017 00:24:37 +0200 - rev 357710
Push 90186 by cbook@mozilla.com at Thu, 11 May 2017 10:53:57 +0000
Bug 1363902 - Simplify some browser chrome tests by utilizing TestUtils.topicObserved. r=mikedeboer MozReview-Commit-ID: Flc8iE19Gkt
0a6194b15bd6c8a8c844336dfa2e5e3420b88707: Bug 1353360 - implement Photon design spec for panel menus. r=Gijs
Mike de Boer <mdeboer@mozilla.com> - Wed, 10 May 2017 17:29:36 -0400 - rev 357709
Push 90186 by cbook@mozilla.com at Thu, 11 May 2017 10:53:57 +0000
Bug 1353360 - implement Photon design spec for panel menus. r=Gijs MozReview-Commit-ID: BPMkiiP31BP
fbe4a19a42e2239a9cf119873509bda67942407f: servo: Merge #16798 - Allow stylo to do lazier stylist rebuilds (from bzbarsky:stylist-lazier-updates); r=emilio
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 10 May 2017 16:22:06 -0500 - rev 357708
Push 90186 by cbook@mozilla.com at Thu, 11 May 2017 10:53:57 +0000
servo: Merge #16798 - Allow stylo to do lazier stylist rebuilds (from bzbarsky:stylist-lazier-updates); r=emilio --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix https://bugzilla.mozilla.org/show_bug.cgi?id=1361843 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because it's optimization, which should have no observable behavior difference. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: c6c0252b19f82ba98ca8a102435067d15f5a1356
2150351429b5c9515589facd9f2aefb1e4640842: Bug 1355343: Take all the snapshots into account. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 07 May 2017 16:36:47 +0200 - rev 357707
Push 90186 by cbook@mozilla.com at Thu, 11 May 2017 10:53:57 +0000
Bug 1355343: Take all the snapshots into account. r=bholley I've chosen this approach mainly because there's no other good way to guarantee the model is correct than holding the snapshots alive until a style refresh. What I tried before this (storing them in a sort of "immutable element data") is a pain, since we call into style from the frame constructor and other content notifications, which makes keeping track of which snapshots should be cleared an which shouldn't an insane task. Ideally we'd have a single entry-point for style, but that's not the case right now, and changing that requires pretty non-trivial changes to the frame constructor. MozReview-Commit-ID: FF1KWZv2iBM
eaf4e461619e685ef1eefaf31464ad0f1c133448: Bug 1355343: Move node restyle bits to Element, and add bits for snapshot handling. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 16 Apr 2017 08:16:24 +0200 - rev 357706
Push 90186 by cbook@mozilla.com at Thu, 11 May 2017 10:53:57 +0000
Bug 1355343: Move node restyle bits to Element, and add bits for snapshot handling. r=bholley MozReview-Commit-ID: 6OrUKX5RcBq Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
37bea3f592dc00e7ebcf5c016c40bd9d37406b9a: Bug 1341102 - Hopefully fix busted reftest annotations by removing whitespaces. r=me on a CLOSED TREE
Sebastian Hengst <archaeopteryx@coole-files.de> - Thu, 11 May 2017 00:08:45 +0200 - rev 357705
Push 90186 by cbook@mozilla.com at Thu, 11 May 2017 10:53:57 +0000
Bug 1341102 - Hopefully fix busted reftest annotations by removing whitespaces. r=me on a CLOSED TREE
d0e5a5ba01b5078071fc195897b083563dc4f918: Bug 1344398 part 3: Add reftests for dynamic changes to "overflow" on html & body elements. r=tnikkel
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 10 May 2017 13:55:37 -0700 - rev 357704
Push 90186 by cbook@mozilla.com at Thu, 11 May 2017 10:53:57 +0000
Bug 1344398 part 3: Add reftests for dynamic changes to "overflow" on html & body elements. r=tnikkel MozReview-Commit-ID: 8WP2qDiKpyP
d70f9de401d140408973d260aa9967473e1a2da6: Bug 1344398 part 2: React to some CSS 'overflow' changes on body/html by simply calling UpdateViewportScrollbarStylesOverride() instead of reframing. r=bz,tnikkel
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 10 May 2017 13:53:27 -0700 - rev 357703
Push 90186 by cbook@mozilla.com at Thu, 11 May 2017 10:53:57 +0000
Bug 1344398 part 2: React to some CSS 'overflow' changes on body/html by simply calling UpdateViewportScrollbarStylesOverride() instead of reframing. r=bz,tnikkel MozReview-Commit-ID: Lpr9aNv9hAB
647d0bb3714d6adf904e83ad9e46706f529cb934: Bug 1344398 part 1: Move presContext variable a little earlier in a nsCSSFrameConstructor method. r=tnikkel
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 10 May 2017 13:53:25 -0700 - rev 357702
Push 90186 by cbook@mozilla.com at Thu, 11 May 2017 10:53:57 +0000
Bug 1344398 part 1: Move presContext variable a little earlier in a nsCSSFrameConstructor method. r=tnikkel Also, assert that this presContext is non-null (which we already implicitly assume, when we dereference it without null-checking it). MozReview-Commit-ID: IIYUqGQTOnb
13a6ff7f76c814b7d05a8e61247ddb48c29beda4: Bug 1363095 - Remove unused PREF_SKIPDEFAULTBROWSERCHECK define. r=jimm
Dão Gottwald <dao@mozilla.com> - Wed, 10 May 2017 22:20:06 +0200 - rev 357701
Push 90186 by cbook@mozilla.com at Thu, 11 May 2017 10:53:57 +0000
Bug 1363095 - Remove unused PREF_SKIPDEFAULTBROWSERCHECK define. r=jimm MozReview-Commit-ID: 962MPM09tDw
a9dedd866433f9d5f8979942559cc49e57e2aeb4: Backed out 2 changesets (bug 1362800) for eslint failures a=backout
Wes Kocher <wkocher@mozilla.com> - Wed, 10 May 2017 14:42:49 -0700 - rev 357700
Push 90186 by cbook@mozilla.com at Thu, 11 May 2017 10:53:57 +0000
Backed out 2 changesets (bug 1362800) for eslint failures a=backout Backed out changeset 0492e6f16df1 (bug 1362800) Backed out changeset 785cf0c4b67b (bug 1362800) MozReview-Commit-ID: EY2RYz7lwtI
42168646d2997c974f9ae9e692453d9a0f615c1d: Bug 1341102 - Update reftest expectations; r=manishearth
Manish Goregaokar <manishearth@gmail.com> - Wed, 10 May 2017 14:32:45 -0700 - rev 357699
Push 90186 by cbook@mozilla.com at Thu, 11 May 2017 10:53:57 +0000
Bug 1341102 - Update reftest expectations; r=manishearth MozReview-Commit-ID: IJkqsizeaQH
305d9e751c2437fc881c34ece01f62af55e92704: No bug - Revendor rust dependencies
Servo VCS Sync <servo-vcs-sync@mozilla.com> - Wed, 10 May 2017 21:23:02 +0000 - rev 357698
Push 90186 by cbook@mozilla.com at Thu, 11 May 2017 10:53:57 +0000
No bug - Revendor rust dependencies
f190f2c09ad8028a7d11d58aa7e4195691cdd25e: servo: Merge #16778 - Take all the snapshots into account in the style system (from emilio:snapshots); r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 10 May 2017 15:08:59 -0500 - rev 357697
Push 90186 by cbook@mozilla.com at Thu, 11 May 2017 10:53:57 +0000
servo: Merge #16778 - Take all the snapshots into account in the style system (from emilio:snapshots); r=bholley See [bug 1355343](https://bugzilla.mozilla.org/show_bug.cgi?id=1355343). The servo part of this patch presumably needs some polishing, let's see. Source-Repo: https://github.com/servo/servo Source-Revision: c8171ed5d7d4b715ab30795311724420c95dfa10
0492e6f16df1050ac69ceba7801e52a1d68bad9e: Bug 1362800 - Expose geckoProfiler.getProfileAsArrayBuffer. r=kmag
Markus Stange <mstange@themasta.com> - Wed, 10 May 2017 17:09:51 -0400 - rev 357696
Push 90186 by cbook@mozilla.com at Thu, 11 May 2017 10:53:57 +0000
Bug 1362800 - Expose geckoProfiler.getProfileAsArrayBuffer. r=kmag MozReview-Commit-ID: 7uFPWAhh25L
785cf0c4b67b662598f82b7da3f7c8c64f4ccbd1: Bug 1362800 - Add a way to get the profile as an array buffer. r=njn
Markus Stange <mstange@themasta.com> - Wed, 10 May 2017 17:08:46 -0400 - rev 357695
Push 90186 by cbook@mozilla.com at Thu, 11 May 2017 10:53:57 +0000
Bug 1362800 - Add a way to get the profile as an array buffer. r=njn MozReview-Commit-ID: 6qpcm3LQn1r
e0d7b3f048cd618bb33fb277239f01a0645e7acd: Bug 1358583 - Handle NS_DispatchToMainThread failures gracefully. r=njn
Markus Stange <mstange@themasta.com> - Wed, 10 May 2017 17:05:00 -0400 - rev 357694
Push 90186 by cbook@mozilla.com at Thu, 11 May 2017 10:53:57 +0000
Bug 1358583 - Handle NS_DispatchToMainThread failures gracefully. r=njn MozReview-Commit-ID: GP1yC1CL9GA
e204f93b4a39bc67d612198c5f92566e68b2adbb: Bug 1363497 - Include react-addons-perf for launchpad via `npm run dev`;r=nchevobbe
Brian Grinstead <bgrinstead@mozilla.com> - Wed, 10 May 2017 10:20:10 -0700 - rev 357693
Push 90186 by cbook@mozilla.com at Thu, 11 May 2017 10:53:57 +0000
Bug 1363497 - Include react-addons-perf for launchpad via `npm run dev`;r=nchevobbe MozReview-Commit-ID: AicGHXQeW6f
d5b141b9583e2755381c48ea2d7b218e1e442f6d: Bug 1349651 - stylo: Implement HasAuthorSpecifiedRules. r=bholley
Matt Brubeck <mbrubeck@mozilla.com> - Wed, 10 May 2017 13:11:36 -0700 - rev 357692
Push 90186 by cbook@mozilla.com at Thu, 11 May 2017 10:53:57 +0000
Bug 1349651 - stylo: Implement HasAuthorSpecifiedRules. r=bholley MozReview-Commit-ID: 8ta5KqKzncZ
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip