922ba5fbebbea6536173b2d8e7f6ab60d50bd1a4: Bug 1269933 - Teach CounterStyles their name and remove the string member from the style structs. r=xidorn
Bobby Holley <bobbyholley@gmail.com> - Wed, 04 May 2016 11:42:08 -0700 - rev 296326
Push 76300 by bholley@mozilla.com at Fri, 06 May 2016 07:09:43 +0000
Bug 1269933 - Teach CounterStyles their name and remove the string member from the style structs. r=xidorn
382ae5a4758827203896dc52b7fa37368386cd0a: Bug 1269933 - Pass the builtin counter manager corresponding to the appropriate default when initializing style structs for servo. r=xidorn
Bobby Holley <bobbyholley@gmail.com> - Tue, 03 May 2016 17:30:39 -0700 - rev 296325
Push 76300 by bholley@mozilla.com at Fri, 06 May 2016 07:09:43 +0000
Bug 1269933 - Pass the builtin counter manager corresponding to the appropriate default when initializing style structs for servo. r=xidorn
0fd722ed257caa229cffdd3aa4949eb1fd326068: Bug 1261012 - Check whether nsIObserverService is nullptr. r=smaug
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Wed, 27 Apr 2016 19:10:11 +0900 - rev 296324
Push 76299 by m_kato@ga2.so-net.ne.jp at Fri, 06 May 2016 04:56:34 +0000
Bug 1261012 - Check whether nsIObserverService is nullptr. r=smaug During shutdown, mozilla::services::GetObserverServie will return nullptr. So we should check it. Add another nullptr check MozReview-Commit-ID: 9xBbltRatJF
95e5e81a23509c062bc5b4804bd9662ca25e1d14: Bug 1270626 - Don't leave an unhandled ErrorResult and assert when media query listeners throw exceptions. r=bzbarsky
L. David Baron <dbaron@dbaron.org> - Thu, 05 May 2016 21:33:47 -0700 - rev 296323
Push 76298 by dbaron@mozilla.com at Fri, 06 May 2016 04:34:42 +0000
Bug 1270626 - Don't leave an unhandled ErrorResult and assert when media query listeners throw exceptions. r=bzbarsky I'm acting under the assumption that this is what's closest to what the code does now, except without asserting in ~ErrorResult. It also seems closest to what event listeners will do, both based on examining code (EventListenerManager::HandleEventSubType, which I'm hoping is the right code to look at, calls StealNSResult, and then stores it in a member that's ignored by most callers) and based on testing (for both click events, and for media query listeners with this patch, the exception gets reported to the console as an unhandled exception). That said, I'm not particularly well versed in the current error handling rules so I may well be off here. This code should presumably go away when we change this code to use EventListeners in bug 1265622, so I don't think there's any spec that covers this. Without the patch, the mochitest hits the fatal assertion (after reporting hitting the expected uncaught exception). With the patch the test passes. (Tested locally.) MozReview-Commit-ID: 5kxp6jzGzX8
87607f70a502452edfa6f40787e38dcd98bd7e0b: Bug 1269963. Part 1 - Add a SyncRunnable::DispatchToThread() overload for AbstractThread. r=bobbyholley.
JW Wang <jwwang@mozilla.com> - Wed, 04 May 2016 16:24:25 +0800 - rev 296322
Push 76297 by jwwang@mozilla.com at Fri, 06 May 2016 03:46:16 +0000
Bug 1269963. Part 1 - Add a SyncRunnable::DispatchToThread() overload for AbstractThread. r=bobbyholley. MozReview-Commit-ID: Jog4glNrUHw
55fb703a89e57bbf1972e6363124936b50f10dc4: Bug 851214 followup, actually compile
Phil Ringnalda <philringnalda@gmail.com> - Thu, 05 May 2016 20:24:20 -0700 - rev 296321
Push 76296 by philringnalda@gmail.com at Fri, 06 May 2016 03:24:51 +0000
Bug 851214 followup, actually compile CLOSED TREE
7c71d376dfac6280c520b09acf3acba01da33bbc: Bug 1264497 - Call GMPSetNodeId in GMPLoader. r=gerald
Chris Pearce <cpearce@mozilla.com> - Fri, 06 May 2016 14:49:12 +1200 - rev 296320
Push 76295 by cpearce@mozilla.com at Fri, 06 May 2016 03:08:27 +0000
Bug 1264497 - Call GMPSetNodeId in GMPLoader. r=gerald MozReview-Commit-ID: I6BApLKpjPS
5fbcba6455cb98a95705249606afbe6fb53cdc3d: Bug 1266022 - skip checking of LoadInfo for chrome resources. r=sicking
Yoshi Huang <allstars.chh@mozilla.com> - Fri, 29 Apr 2016 10:52:47 +0800 - rev 296319
Push 76294 by yhuang@mozilla.com at Fri, 06 May 2016 03:05:30 +0000
Bug 1266022 - skip checking of LoadInfo for chrome resources. r=sicking When tab with a userContextId!=0 contains a chrome page (such as about:newtab) the userContextId in the LoadInfo won't match the userContextId in the LoadContext. The LoadInfo will contain the systemPrincipal and so use userContextId=0, the LoadContext has the userContextId of the tab (!=0). This is fine as long as we page only loads chrome-URLs and other non-http URLs since those don't use cookies anyway. So avoid asserting in this situation. Long term we want the chrome page to use the default userContextId for cookies, since that's what it chrome code normally use. This will work properly once we get the cookie jar information from the LoadInfo rather than from the LoadContext.
b2cc990b42461e111ca854d4111965cc5fe5ff80: Bug 1269813 - Don't run test_bug1264380.html on Windows. r=wchen
Bevis Tseng <btseng@mozilla.com> - Wed, 04 May 2016 13:12:59 +0800 - rev 296318
Push 76293 by ryanvm@gmail.com at Fri, 06 May 2016 02:44:21 +0000
Bug 1269813 - Don't run test_bug1264380.html on Windows. r=wchen
93bc222914a2988a46002e9d8b4348043caec19a: Bug 1264467 - Force a reload only when crossOrigin's state is really changed. r=jdm
Edgar Chen <echen@mozilla.com> - Thu, 14 Apr 2016 18:53:44 -0400 - rev 296317
Push 76293 by ryanvm@gmail.com at Fri, 06 May 2016 02:44:21 +0000
Bug 1264467 - Force a reload only when crossOrigin's state is really changed. r=jdm MozReview-Commit-ID: F0wvy4TkPiQ
d72759589f6f7304f7539542879815fa7d4efdbe: Bug 851214 - Allow OOP mozbrowser w/o enclosing app. r=billm
Jason Duell <jduell.mcbugs@gmail.com> - Thu, 18 Feb 2016 17:37:00 -0500 - rev 296316
Push 76293 by ryanvm@gmail.com at Fri, 06 May 2016 02:44:21 +0000
Bug 851214 - Allow OOP mozbrowser w/o enclosing app. r=billm
cd173f0d00f16ca21ac191cada286da133b99fcd: Bug 1270374 - Create style context with correct pseudo tag in ServoStyleSet::ResolveAnonymousBoxStyle. r=bholley
Cameron McCormack <cam@mcc.id.au> - Wed, 04 May 2016 22:33:00 -0400 - rev 296315
Push 76293 by ryanvm@gmail.com at Fri, 06 May 2016 02:44:21 +0000
Bug 1270374 - Create style context with correct pseudo tag in ServoStyleSet::ResolveAnonymousBoxStyle. r=bholley
49dab7b4a276d14dacf73cd5b1fb12716fa741a2: Bug 1270387 - Disable Node.rootNode in release builds due to web compatibility issues. r=smaug
Jocelyn Liu <joliu@mozilla.com> - Thu, 05 May 2016 14:21:22 +0800 - rev 296314
Push 76292 by joliu@mozilla.com at Fri, 06 May 2016 02:28:42 +0000
Bug 1270387 - Disable Node.rootNode in release builds due to web compatibility issues. r=smaug MozReview-Commit-ID: Gc2XGuFAYlD
f33893ecd47c56e5e24c34314f7776d6122c4d17: Bug 1263116 - Stop throwing for DOMTokenList's.contains() when using empty string or ASCII whitespace, r=baku
Ben Tian <btian@mozilla.com> - Thu, 05 May 2016 18:07:22 +0800 - rev 296313
Push 76291 by btian@mozilla.com at Fri, 06 May 2016 02:26:02 +0000
Bug 1263116 - Stop throwing for DOMTokenList's.contains() when using empty string or ASCII whitespace, r=baku
567a13dc5e5117ec8561dcdafc511e6ea04c2e86: Bug 1266336 - Clarify expected usage of CDM wrapper - r=cpearce
Gerald Squelart <gsquelart@mozilla.com> - Fri, 06 May 2016 12:10:59 +1000 - rev 296312
Push 76290 by gsquelart@mozilla.com at Fri, 06 May 2016 02:16:19 +0000
Bug 1266336 - Clarify expected usage of CDM wrapper - r=cpearce Assert that the CDM wrapper is given a non-null CDM pointer. (so GetCDM() doesn't need to be null-checked.) Renamed WidevineVideoDecoder mCDM to mCDMWrapper, to avoid (my) confusion. Assert that WidevineVideoDecoder is given a non-null CDM-wrapper pointer. Assert that WidevineVideoDecoder only accesses the CDM before DecodingComplete. Small optimization: Move aCDM into mCDM (to save an AddRef/Release pair). MozReview-Commit-ID: yKupY067ly
22cfbb1cc6c4e8183e4195b86181da9e5c6c546b: Bug 1266336 - Check actual CDM creation - r=cpearce
Gerald Squelart <gsquelart@mozilla.com> - Thu, 05 May 2016 12:04:07 +1000 - rev 296311
Push 76290 by gsquelart@mozilla.com at Fri, 06 May 2016 02:16:19 +0000
Bug 1266336 - Check actual CDM creation - r=cpearce Check the return result from Widevine's CDM creation function, and handle failure. MozReview-Commit-ID: HYvKgdK53aQ
5bc06c379df71070a0eec512b8cc24fe8f733db1: Bug 1266336 - Check sCDMWrapper before creating video decoder - r=cpearce
Gerald Squelart <gsquelart@mozilla.com> - Thu, 05 May 2016 11:37:22 +1000 - rev 296310
Push 76290 by gsquelart@mozilla.com at Fri, 06 May 2016 02:16:19 +0000
Bug 1266336 - Check sCDMWrapper before creating video decoder - r=cpearce Ensure that there is a CDM before creating a video decoder that relies on that CDM. This is mainly to prevent using the Widevine video decoder alone, without decryption. MozReview-Commit-ID: 7p49CnmV2r7
4d03fa80f416cdb0d8aa6d0f9df870b7dafc5b0c: Bug 1268984 - Prefer to re-use a GMPParent with the requested nodeId rather than clone. r=jesup
Chris Pearce <cpearce@mozilla.com> - Thu, 05 May 2016 22:35:44 +1200 - rev 296309
Push 76289 by cpearce@mozilla.com at Fri, 06 May 2016 01:57:12 +0000
Bug 1268984 - Prefer to re-use a GMPParent with the requested nodeId rather than clone. r=jesup If you request a GMPParent with a nodeId, you should get any already running instances with the same nodeId in preference to cloning an existing GMP and assigning it the nodeId. This is ensures that EME GMP actors that are same-origin run in the same GMP instance. The GMP gtests are failing because of the cross-origin checks in GeckoMediaPluginServiceParent::SelectPluginForAPI(). The loop there selects the first GMPParent that can be used from the nodeId passed in. We previously assumed a GMPParent can be used from a nodeId if the GMPParent has the same nodeId, or if it has not loaded its process and it has no nodeId. The problem with assuming that, is if an in-use GMPParent with the target nodeId lies in the GeckoMediaPluginServiceParent::mPlugins list after a GMPParent with no nodeId, we'll end up using the first GMPParent (the one with no nodeId) rather than the one with the target nodeId. The solution is to change GeckoMediaPluginServiceParent::SelectPluginForAPI() so that effectively if we have a target nodeId, we'll select the first GMPParent that has the same nodeId, or we'll clone the first which supported all the requested capabilities/tags. This means when you request a GMPParent with a given nodeId, you'll get the one with the same nodeId (origin) by preference. MozReview-Commit-ID: 4yVnrO8B1Pg
e5dd268f592d4fb54da18cf1fd28ea4c09ab1cc6: Bug 1268984 - Store GMPStorage on GMPServiceParent so that it persists inside the same PB session. r=gerald
Chris Pearce <cpearce@mozilla.com> - Thu, 05 May 2016 11:41:33 +1200 - rev 296308
Push 76289 by cpearce@mozilla.com at Fri, 06 May 2016 01:57:12 +0000
Bug 1268984 - Store GMPStorage on GMPServiceParent so that it persists inside the same PB session. r=gerald Prior to this change, we'd store the GMPStorage records for private browsing sessions in the GMPStorageParent. The problem with this is that they only have a lifespan matching their corresponding GMPParent. This means that if a GMP stores something in a PB session, and the GMP is shutdown and then re-created, we are likely to loose the stored data. This could mean that the PB session gets results it doesn't expect, and thus expose a way for PB mode to be detected. MozReview-Commit-ID: 1OMD0LvidYs
90a1b756b4ba88fa3480575b65b85d0925a02faa: Bug 1268984 - Ensure GMPs are re-inserted in GMPServiceParent::mPlugins in the same order in ReAddOnGMPThread. r=gerald,jesup
Chris Pearce <cpearce@mozilla.com> - Wed, 04 May 2016 13:57:20 +1200 - rev 296307
Push 76289 by cpearce@mozilla.com at Fri, 06 May 2016 01:57:12 +0000
Bug 1268984 - Ensure GMPs are re-inserted in GMPServiceParent::mPlugins in the same order in ReAddOnGMPThread. r=gerald,jesup The GMP which GeckoMediaPluginServiceParent::FindPluginForAPIFrom() returns depends on the order in which GMPs lie in GMPServiceParent::mPlugins. However when we shutdown a GMPParent we remove and then re-append the GMPParent to mPlugins. This means the order in which GMPs lie in the list changes. So when WebRTC requests an H.264 decoder, the first time it will get OpenH264, since that's first in the list. But once we dispose of that decoder, its GMPParent will be cloned and the clone will be appended to the end of the list. This means the next time WebRTC requests a decoder, it'll get whatever was next in the list. This could be the Adobe GMP, which seems to be able to handle whatever WebRTC is putting into it. However, if you do this enough times, you'll get the Widevine CDM, which can't handle whatever WebRTC is putting into it. So a quick hack to fix this is in ReAddOnGMPThread is to re-insert the clone of the GMP into the slot in mPlugins that the original occupied. Then WebRTC will always get OpenH264 whenever it requests for an H.264 decoder, as the order of the GMPParents in mPlugins won't change. MozReview-Commit-ID: Ii4AMqDqAo9
(0) -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip