8cda3fb3ce1a5ef87cbd03ccbca9b76c8d05555b: Bug 1419226 - Part 2. Remove notify did paint timer. r=mattwoodrow
Mantaroh Yoshinaga <mantaroh@gmail.com> - Mon, 27 Nov 2017 09:33:54 +0900 - rev 393806
Push 97735 by ebalazs@mozilla.com at Mon, 27 Nov 2017 22:11:10 +0000
Bug 1419226 - Part 2. Remove notify did paint timer. r=mattwoodrow This EnsureEventualDidPaintEvent() creates software timer. But this timer will bring several intermittent tests fail. For example, if we want to check the compositor animation property. If test receives MozAfterPaint of the timer, there doesn't have animation property on compositor, as result of this, a test will fail. I think we don't need to create this timer each time since current painting is happening synchronously under the refresh driver. [1] https://searchfox.org/mozilla-central/rev/919dce54f43356c22d6ff6b81c07ef412b1bf933/layout/base/nsPresContext.cpp#189 MozReview-Commit-ID: Hb7UEITer5t
21d9bedcf411188d38a8abb9a64f17ca306e98a1: Bug 1419226 - Part 1.Change observing target window of MozAfterPaint. r=mconley
Mantaroh Yoshinaga <mantaroh@gmail.com> - Mon, 27 Nov 2017 09:33:53 +0900 - rev 393805
Push 97735 by ebalazs@mozilla.com at Mon, 27 Nov 2017 22:11:10 +0000
Bug 1419226 - Part 1.Change observing target window of MozAfterPaint. r=mconley Previous code, print preview waits for content window's MozAfterPaint. However gecko prevents send MozAfterPaint to content window[1]. So this code will not work correctly. However, software timer of firing MozAfterPaint ran this code.[2] This patch will * Change the observing content window to chrome window. * Add timer of MozAfterPaint event in order to ensure this event even if display list invalidation doesn't invalidate. Gecko create this timer in nsPresContext previously[2], but this bug will remove it [1] https://searchfox.org/mozilla-central/rev/919dce54f43356c22d6ff6b81c07ef412b1bf933/layout/base/nsPresContext.cpp#2452 [2] https://searchfox.org/mozilla-central/rev/919dce54f43356c22d6ff6b81c07ef412b1bf933/layout/base/nsPresContext.cpp#3466-3472 MozReview-Commit-ID: GcuKPjn0qhc
9fd9d940dcf07569a8e3a04754a4bf67d6c07693: Backed out 2 changesets (bug 1418433) for unexpected "why should we have flushed style again?" assertion failures
Phil Ringnalda <philringnalda@gmail.com> - Sun, 26 Nov 2017 23:32:41 -0800 - rev 393804
Push 97735 by ebalazs@mozilla.com at Mon, 27 Nov 2017 22:11:10 +0000
Backed out 2 changesets (bug 1418433) for unexpected "why should we have flushed style again?" assertion failures Backed out changeset 761f84b8edb0 (bug 1418433) Backed out changeset 436723f33b10 (bug 1418433) MozReview-Commit-ID: 84FAoZcyQjU
a19a802032da5d5e3ad4abbd87acb4abacafbd15: Bug 1418167 - validate data before send for onboarding telemetry;r=Fischer
Fred Lin <gasolin@gmail.com> - Fri, 17 Nov 2017 10:53:46 +0800 - rev 393803
Push 97735 by ebalazs@mozilla.com at Mon, 27 Nov 2017 22:11:10 +0000
Bug 1418167 - validate data before send for onboarding telemetry;r=Fischer Implement basic validation for new table events and columns, report the incorrect fields. The change is protected by NEW_TABLE flag so not effect the current telemetry. MozReview-Commit-ID: 78K551g0nRj
30264fec78cfc14babe068509be5e64ac1eb9b90: Bug 1420791 - Drop waitForPaints() in runOMTATest(). r=boris
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Mon, 27 Nov 2017 12:29:48 +0900 - rev 393802
Push 97735 by ebalazs@mozilla.com at Mon, 27 Nov 2017 22:11:10 +0000
Bug 1420791 - Drop waitForPaints() in runOMTATest(). r=boris It's no longer used. MozReview-Commit-ID: DO7RRZaKHxm
9b2c659d715297d6bbd0d758f4abc9b32a4c3284: Bug 1420791 - Drop explicit flushing styles before calling waitForPaintsFlushed(). r=boris
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Mon, 27 Nov 2017 12:29:45 +0900 - rev 393801
Push 97735 by ebalazs@mozilla.com at Mon, 27 Nov 2017 22:11:10 +0000
Bug 1420791 - Drop explicit flushing styles before calling waitForPaintsFlushed(). r=boris waitForPaintsFlushed() flushes styles inside it, so we don't need the explicit flush. MozReview-Commit-ID: KcQYRDWyhU0
2df254db1313d9ff1eeb1ef3aadcfa2445a091ab: Bug 1420791 - Use waitForPaintsFlushed() instead of waitForPaints(). r=boris
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Mon, 27 Nov 2017 12:29:41 +0900 - rev 393800
Push 97735 by ebalazs@mozilla.com at Mon, 27 Nov 2017 22:11:10 +0000
Bug 1420791 - Use waitForPaintsFlushed() instead of waitForPaints(). r=boris The waitForPaints() which is defined in function runOMTATest() invokes waitForAllPaintsFlushed(), it is the same what waitForPaintsFlushed() does. MozReview-Commit-ID: BKt2fZO3DuM
2948003d230adfc55c9af05f3e174ad00b2ed27b: Bug 1420298 'layout.display-list.retain.verify' to debug retained-dl - r=mattwoodrow
Gerald Squelart <gsquelart@mozilla.com> - Mon, 20 Nov 2017 17:15:08 +1100 - rev 393799
Push 97735 by ebalazs@mozilla.com at Mon, 27 Nov 2017 22:11:10 +0000
Bug 1420298 'layout.display-list.retain.verify' to debug retained-dl - r=mattwoodrow Setting the 'layout.display-list.retain.verify' gfxPrefs implies 'layout.display-list.build-twice', and then compares the retained-built tree to the non-retained one, and outputs differences&trees to the terminal. MozReview-Commit-ID: 3dnyIUTbtH8
4c259d35fa9f23c29b77b264f057ea37e709d2f1: Bug 1420774 - Drop unnecessary virtual from Animation methods. r=boris
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Mon, 27 Nov 2017 07:44:53 +0900 - rev 393798
Push 97735 by ebalazs@mozilla.com at Mon, 27 Nov 2017 22:11:10 +0000
Bug 1420774 - Drop unnecessary virtual from Animation methods. r=boris MozReview-Commit-ID: wRrKFbjsTx
a612dc93c5989ea0d12123b721940312f7a04cfc: Backed out 4 changesets (bug 1418224) for build bustages r=backout on a CLOSED TREE
dluca <dluca@mozilla.com> - Mon, 27 Nov 2017 07:42:50 +0200 - rev 393797
Push 97735 by ebalazs@mozilla.com at Mon, 27 Nov 2017 22:11:10 +0000
Backed out 4 changesets (bug 1418224) for build bustages r=backout on a CLOSED TREE Backed out changeset 3ef8715cb8d7 (bug 1418224) Backed out changeset 0d58d9fed90d (bug 1418224) Backed out changeset faad7f275749 (bug 1418224) Backed out changeset 1e86ff6b95ae (bug 1418224)
1fb9066a67c910e1476c12d05094a69acdb8372e: Bug 1420016 - remove ChannelMediaResource::IsSuspendedByCache(). r=bechen,gerald
JW Wang <jwwang@mozilla.com> - Thu, 23 Nov 2017 11:30:07 +0800 - rev 393796
Push 97735 by ebalazs@mozilla.com at Mon, 27 Nov 2017 22:11:10 +0000
Bug 1420016 - remove ChannelMediaResource::IsSuspendedByCache(). r=bechen,gerald For it is used internally by CacheClientNotifySuspendedStatusChanged() only. MozReview-Commit-ID: 8XVUHhdERYR
7358a7b7676ba2d0081db032738d193a2214114b: Bug 1418918. P2 - add thread/monitor assertions. r=bechen,gerald
JW Wang <jwwang@mozilla.com> - Mon, 20 Nov 2017 16:30:05 +0800 - rev 393795
Push 97735 by ebalazs@mozilla.com at Mon, 27 Nov 2017 22:11:10 +0000
Bug 1418918. P2 - add thread/monitor assertions. r=bechen,gerald MozReview-Commit-ID: 3J8pRFnpm77
89b125e739e43c0250d3437871f2a94a5d57421c: Bug 1418918. P1 - remove unused FlushPartialBlock(). r=bechen,gerald
JW Wang <jwwang@mozilla.com> - Mon, 20 Nov 2017 16:00:22 +0800 - rev 393794
Push 97735 by ebalazs@mozilla.com at Mon, 27 Nov 2017 22:11:10 +0000
Bug 1418918. P1 - remove unused FlushPartialBlock(). r=bechen,gerald MozReview-Commit-ID: GSda1KfPWXE
f195d80f0bdee12c591733f2ea02454a31e56714: Bug 1413370 - Skip the test case that checks transform animation on scrolled-out element is unthrottled periodically on Android. r=boris
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Mon, 27 Nov 2017 06:20:06 +0900 - rev 393793
Push 97735 by ebalazs@mozilla.com at Mon, 27 Nov 2017 22:11:10 +0000
Bug 1413370 - Skip the test case that checks transform animation on scrolled-out element is unthrottled periodically on Android. r=boris It causes intermittent failure. MozReview-Commit-ID: HDitQV4Yn3P
761f84b8edb00eee06450dca53636a4970631c44: Bug 1418433 - increment RestyleGeneration for undisplayed elements when updating servo stylist. r=heycam
Jeremy Chen <jeremychen@mozilla.com> - Sun, 26 Nov 2017 11:47:27 +0800 - rev 393792
Push 97735 by ebalazs@mozilla.com at Mon, 27 Nov 2017 22:11:10 +0000
Bug 1418433 - increment RestyleGeneration for undisplayed elements when updating servo stylist. r=heycam In the current implementation, we call SetStylistStyleSheetsDirty() every time a style sheet is changed. However, the dirty bit setting may or may not always update the style data. For example, the style data for undisplayed elements are deliberately not updated in Stylo. However, the getComputedStyle API is supposed to provide a way to get the up-to-date computed style data, even for undisplayed elements. In this patch, we increment RestyleGeneration for undisplayed elements when we decide to update style data (i.e., calling ServoStyleSet::UpdateStylist()) due to (XBL)StyleSheet is dirty. This could flush the cached data that getComputedStyle API holds, and ensures the getComputedStyle API computes a new one. MozReview-Commit-ID: JDDhACOG3z4
436723f33b107f99ef71a38d6762f09b15734521: Bug 1418433 - add a test for style data update mechanism for non-displayed elements. r=heycam
Jeremy Chen <jeremychen@mozilla.com> - Sun, 26 Nov 2017 21:49:41 +0800 - rev 393791
Push 97735 by ebalazs@mozilla.com at Mon, 27 Nov 2017 22:11:10 +0000
Bug 1418433 - add a test for style data update mechanism for non-displayed elements. r=heycam In certain situations, we might access a non-displayed (i.e., display: none;) element's style data through getComputedStyle API. In this patch, we add a test to ensure that, if the inline style sheet is changed/modified, the style data of a non-displayed element is always up-to-date. MozReview-Commit-ID: Ggjd4FMqZlo
ba381cfa946f5dfa016b294020894e26662e1b2d: Bug 1416686 - Reduce the uses of IPC_FAIL_NO_REASON in GMPChild.cpp. r=cpearce,dmajor
James Cheng <jacheng@mozilla.com> - Mon, 13 Nov 2017 09:35:03 +0000 - rev 393790
Push 97735 by ebalazs@mozilla.com at Mon, 27 Nov 2017 22:11:10 +0000
Bug 1416686 - Reduce the uses of IPC_FAIL_NO_REASON in GMPChild.cpp. r=cpearce,dmajor Originally, we use IPC_FAIL_NO_REASON to make IPC call return error and then it invokes MOZ_CRASH to kill the process itself. By using IPC_FAIL, we can pass a descriptive reason to GMPChild::ProcessingError and Bug 1416667 will use MOZ_CRASH_UNSAFE_PRINTF to print the reason to the crash report. In addition, we use CrashReporter::AnnotateCrashReport to record the lib path without exposing the data publicly. MozReview-Commit-ID: 15n1PItLgAp
22453f19f0509da901fb06cb17935c127b584bc8: Bug 1416667 - Use MOZ_CRASH_UNSAFE_PRINTF in GMPChild::ProcessingError r=cpearce
James Cheng <jacheng@mozilla.com> - Mon, 13 Nov 2017 08:24:00 +0000 - rev 393789
Push 97735 by ebalazs@mozilla.com at Mon, 27 Nov 2017 22:11:10 +0000
Bug 1416667 - Use MOZ_CRASH_UNSAFE_PRINTF in GMPChild::ProcessingError r=cpearce We passed the crash reason to GMPChild::ProcessingError but we didn't use it anymore. We can simply use MOZ_CRASH_UNSAFE_PRINTF instead of MOZ_CRASH to make the crash more descriptive. MozReview-Commit-ID: D7mU3Dsg9V9
413ed7bee307520b51f402b85ec12af720caa837: Bug 1420192 - when disable autoplay, allow script calls play() once user triggered load() or seek(). r=jwwang
Alastor Wu <alwu@mozilla.com> - Mon, 27 Nov 2017 10:55:02 +0800 - rev 393788
Push 97735 by ebalazs@mozilla.com at Mon, 27 Nov 2017 22:11:10 +0000
Bug 1420192 - when disable autoplay, allow script calls play() once user triggered load() or seek(). r=jwwang This patch is mainly reverting the changing of bug1382574 part3, but not all the same. Since youtube would call load() when user clicks to play, and then call play() later. For the old pref (checking user-input-play), we should still allow the following play() even it's not triggered via user input. It's also same for seeking, Youtube would call play() after seeking completed. In this patch, we would allow the script-calling once play() if user has called load() or seek() before that. MozReview-Commit-ID: 1UcxRCVfhnR
f2f0569649dba4c3147d32d130a0377b7e7b2cc8: Bug 1417297 - Part2 - Convert fake-cdm to use Chromium ContentDecryptionModule_9 interface. r=cpearce
James Cheng <jacheng@mozilla.com> - Thu, 23 Nov 2017 16:51:23 +0800 - rev 393787
Push 97735 by ebalazs@mozilla.com at Mon, 27 Nov 2017 22:11:10 +0000
Bug 1417297 - Part2 - Convert fake-cdm to use Chromium ContentDecryptionModule_9 interface. r=cpearce MozReview-Commit-ID: L0sF2lO3lDX
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip