888dc371081aad0695694e283106b5d2d00f2302: Bug 1347791 - part4 : keep tab's block state consistent after session restore. r=mikedeboer
Alastor Wu <alwu@mozilla.com> - Wed, 17 May 2017 11:56:10 +0800 - rev 358737
Push 90373 by cbook@mozilla.com at Wed, 17 May 2017 10:28:10 +0000
Bug 1347791 - part4 : keep tab's block state consistent after session restore. r=mikedeboer If the tab was resumed before, it could start playing any autoplay media without user's permission after session restore. MozReview-Commit-ID: C3DHIIsLtJA
37d295d7eec9d32ca4ef4f5d1e49ea7af52ea4b8: Bug 1347791 - part3 : move block/resume logic from back-end to front-end. r=baku,mikedeboer
Alastor Wu <alwu@mozilla.com> - Wed, 17 May 2017 11:56:06 +0800 - rev 358736
Push 90373 by cbook@mozilla.com at Wed, 17 May 2017 10:28:10 +0000
Bug 1347791 - part3 : move block/resume logic from back-end to front-end. r=baku,mikedeboer Previous design allows us calling resume/block from both front-end and back-end, it's not easy to know who called these operations. So move all these logic to frond-end side, it's more clear than before. One important thing is that we should block tab before loading the content. If we block the tab after loading, the media might not be blocked because it had already started (that is one situation I observed from test). The value of block state would be stored in the outer window, before media want to start, it would check this value to know whether it can start playing or not. --- In addition, introduce new attribute "media-blocked". The "media-blocked" attribute indicates that whether the tab is allowed to play autoplay media. The "activemedia-blocked" attribute indicates whether the tab has blocked the autoplay media. MozReview-Commit-ID: FnNh3zmItxo
be04f96bf78ba11fb2b6ac4445028124fca24daf: Bug 1347791 - part2 : the tab would always be resumed when it goes to foreground first time. r=baku
Alastor Wu <alwu@mozilla.com> - Wed, 17 May 2017 11:56:03 +0800 - rev 358735
Push 90373 by cbook@mozilla.com at Wed, 17 May 2017 10:28:10 +0000
Bug 1347791 - part2 : the tab would always be resumed when it goes to foreground first time. r=baku Since now we move the block/resume logic to front-end side, we can remove the changing from bug1319771 and other related bugs which are used to ensure the pinned tab should be blocked successfully after session restore. MozReview-Commit-ID: Ixe7tOvCEhv
a9ac97cc2efabb2ba91a85a0d3dd8752dfed0dbd: Bug 1347791 - part1 : rename the attribute for the tab which has blocked the autoplay audio and would show the play-tab icon. r=mikedeboer
Alastor Wu <alwu@mozilla.com> - Wed, 17 May 2017 11:55:54 +0800 - rev 358734
Push 90373 by cbook@mozilla.com at Wed, 17 May 2017 10:28:10 +0000
Bug 1347791 - part1 : rename the attribute for the tab which has blocked the autoplay audio and would show the play-tab icon. r=mikedeboer The "blocked" attribute is too general to indicate the real usage, so rename it to "activemedia-blocked". This attribute indicates that whether the tab has blocked the autoplay media. MozReview-Commit-ID: EAmq6OuBYjq
19c4f1bf59e3c45359f6c835f2ce23484ed095b7: bug 1360494 - part 2 add mochitest to make sure the image files exist. r=evelyn
Ya-Chieh Wu <ywu@mozilla.com> - Fri, 12 May 2017 17:55:07 +0800 - rev 358733
Push 90373 by cbook@mozilla.com at Wed, 17 May 2017 10:28:10 +0000
bug 1360494 - part 2 add mochitest to make sure the image files exist. r=evelyn MozReview-Commit-ID: B66VMsoum6W
1d0a2e2c167d8aae9b5c3a2eb2c9c15e928df0bf: bug 1360494 - part 1 remove duplicate image files and reference them from pdfjs. r=evelyn
Ya-Chieh Wu <ywu@mozilla.com> - Fri, 12 May 2017 09:48:18 +0800 - rev 358732
Push 90373 by cbook@mozilla.com at Wed, 17 May 2017 10:28:10 +0000
bug 1360494 - part 1 remove duplicate image files and reference them from pdfjs. r=evelyn MozReview-Commit-ID: HOphfTkjNK5
69f2e67310e5aece1d252a9b2da25e3825700194: servo: Merge #16795 - Don't optimize display list for projective transforms (from mrobinson:out-of-viewport-transform); r=glennw
Martin Robinson <mrobinson@igalia.com> - Tue, 16 May 2017 21:27:47 -0500 - rev 358731
Push 90373 by cbook@mozilla.com at Wed, 17 May 2017 10:28:10 +0000
servo: Merge #16795 - Don't optimize display list for projective transforms (from mrobinson:out-of-viewport-transform); r=glennw There are situations where elements are transformed from outside the display list. With projective transforms it's currently difficult to detect these. In those cases we just don't optimize the display list, so that they will always be shown. Fixes #13822. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #13822 (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: fada0eb6607fa746cd88426ebb7bb4052f709cda
10841f0c5aff62249b6af244f8abe430c5f10b32: Backed out changeset 102ce41b51ca (bug 1364959) for xpcshell failures in test_ext_downloads_misc.js. a=backout
Iris Hsiao <ihsiao@mozilla.com> - Wed, 17 May 2017 11:26:52 +0800 - rev 358730
Push 90373 by cbook@mozilla.com at Wed, 17 May 2017 10:28:10 +0000
Backed out changeset 102ce41b51ca (bug 1364959) for xpcshell failures in test_ext_downloads_misc.js. a=backout CLOSED TREE
45e204034f66111d233a2c2d3004ff0003e071cd: servo: Merge #16890 - Fix serialization of namespace and universal selectors (from servo:qname); r=emilio
Simon Sapin <simon.sapin@exyr.org> - Tue, 16 May 2017 20:03:53 -0500 - rev 358729
Push 90373 by cbook@mozilla.com at Wed, 17 May 2017 10:28:10 +0000
servo: Merge #16890 - Fix serialization of namespace and universal selectors (from servo:qname); r=emilio Fix #16017 Fix #16020 Source-Repo: https://github.com/servo/servo Source-Revision: c96245898418ff91de6fd51edca288ecace44d2b
3876e96601b17391dc91c1ae138fceed5211c3ff: Bug 1365027 - Add $httpMethod=POST to the query string of Safe Browsing pver4 requests. r=francois
DimiL <dlee@mozilla.com> - Tue, 16 May 2017 16:50:55 +0800 - rev 358728
Push 90373 by cbook@mozilla.com at Wed, 17 May 2017 10:28:10 +0000
Bug 1365027 - Add $httpMethod=POST to the query string of Safe Browsing pver4 requests. r=francois MozReview-Commit-ID: FvFFTcPzTn8
680ad42a723c7557ed6649715fb5388ccf121b89: Bug 1341102 - Update reftest expectations.
Xidorn Quan <me@upsuper.org> - Wed, 17 May 2017 11:52:48 +1000 - rev 358727
Push 90373 by cbook@mozilla.com at Wed, 17 May 2017 10:28:10 +0000
Bug 1341102 - Update reftest expectations. MozReview-Commit-ID: JtSC2YzQYdq
9711f5bbda3baa2e93ac464d6a85e49bc5ee9b3d: Bug 1365194 - Compile mozjemalloc as C++. r=njn
Mike Hommey <mh+mozilla@glandium.org> - Fri, 12 May 2017 21:52:25 +0900 - rev 358726
Push 90373 by cbook@mozilla.com at Wed, 17 May 2017 10:28:10 +0000
Bug 1365194 - Compile mozjemalloc as C++. r=njn The source file is renamed too, because the build system doesn't handle sources changing suffix very well (at least not without a clobber). The _GNU_SOURCE define is removed because GCC/Clang set it by default in C++ mode.
4b9c2fb406538cde0218bb665054396d6ea1b89c: Bug 1365194 - Remove parts of the hacks for memalign in mozjemalloc. r=njn
Mike Hommey <mh+mozilla@glandium.org> - Tue, 16 May 2017 20:01:55 +0900 - rev 358725
Push 90373 by cbook@mozilla.com at Wed, 17 May 2017 10:28:10 +0000
Bug 1365194 - Remove parts of the hacks for memalign in mozjemalloc. r=njn The hack dates back from the originally imported jemalloc code, which couldn't assume it's built for Firefox. Now, we can assume that, which means the code is always built with hidden visibility by default, removing the need for the explicit hidden visibility. Correspondingly, when building on Solaris with GCC, the default visibility should also prevent the inlining, making the noinline attribute redundant. And the Sun Studio path is useless since the compiler is not supported anymore.
b56224bf370da3ccdd8b8254d396db963604981c: Bug 1365194 - Make `extern "C"` part of MOZ_MEMORY_API and MOZ_JEMALLOC_API. r=njn
Mike Hommey <mh+mozilla@glandium.org> - Tue, 16 May 2017 18:46:02 +0900 - rev 358724
Push 90373 by cbook@mozilla.com at Wed, 17 May 2017 10:28:10 +0000
Bug 1365194 - Make `extern "C"` part of MOZ_MEMORY_API and MOZ_JEMALLOC_API. r=njn This avoids many additions of `extern "C"` in C++ code and will avoid having to do the same to mozjemalloc once built as C++.
d8de424663b780d1a78e6e6d796ec737a12e67d2: Bug 1365194 - Remove MOZ_JEMALLOC_API from _malloc_options and _malloc_message. r=njn
Mike Hommey <mh+mozilla@glandium.org> - Tue, 16 May 2017 18:55:24 +0900 - rev 358723
Push 90373 by cbook@mozilla.com at Wed, 17 May 2017 10:28:10 +0000
Bug 1365194 - Remove MOZ_JEMALLOC_API from _malloc_options and _malloc_message. r=njn MOZ_JEMALLOC_API makes those symbols exported, but we're going to make MOZ_JEMALLOC_API include `extern "C"`, which GCC warns about in this case (can't use extern on a variable that is initialized). While we could get around this in some way, there is not much use for those variables being exported altogether: the only reason they are is to allow an override when linking mozjemalloc into executables, but doing that in Firefox requires patching the build system or passing some specific LDFLAGS. People who really need to do that might as well apply a patch. They also allow run-time override through LD_PRELOAD, but one might as well use the MALLOC_OPTIONS environment variable for _malloc_options. As for _malloc_message, it doesn't seem very useful to override, and probably noone ever overrode it at runtime. Note, we may want to remove them in a followup.
484c5137e19f869ba72af620d514f1cd7a891504: Bug 1365194 - Call moz_abort directly instead of using a macro to override abort. r=njn
Mike Hommey <mh+mozilla@glandium.org> - Fri, 12 May 2017 21:51:16 +0900 - rev 358722
Push 90373 by cbook@mozilla.com at Wed, 17 May 2017 10:28:10 +0000
Bug 1365194 - Call moz_abort directly instead of using a macro to override abort. r=njn Using -Dabort=moz_abort actually makes the build fail in some libstdc++ headers when building as C++.
a0c7189d60e3c2deb3af338c0cf6a9e58dc89be1: Bug 1365191 - Remove dead code hidden behind the never set NEEDS_PTHREAD_MMAP_UNALIGNED_TSD. r=njn
Mike Hommey <mh+mozilla@glandium.org> - Thu, 11 May 2017 18:05:14 +0900 - rev 358721
Push 90373 by cbook@mozilla.com at Wed, 17 May 2017 10:28:10 +0000
Bug 1365191 - Remove dead code hidden behind the never set NEEDS_PTHREAD_MMAP_UNALIGNED_TSD. r=njn
09b32bedead38e4b7b94cb09154cbac5686fe215: Bug 1365191 - Remove MALLOC_FILL from mozjemalloc. r=njn
Mike Hommey <mh+mozilla@glandium.org> - Thu, 11 May 2017 17:57:30 +0900 - rev 358720
Push 90373 by cbook@mozilla.com at Wed, 17 May 2017 10:28:10 +0000
Bug 1365191 - Remove MALLOC_FILL from mozjemalloc. r=njn It's always set.
e246baa0d780d8d19337c0cadae739ec7f91829f: Bug 1365191 - Remove MALLOC_STATS from mozjemalloc. r=njn
Mike Hommey <mh+mozilla@glandium.org> - Thu, 11 May 2017 17:55:21 +0900 - rev 358719
Push 90373 by cbook@mozilla.com at Wed, 17 May 2017 10:28:10 +0000
Bug 1365191 - Remove MALLOC_STATS from mozjemalloc. r=njn It's always set.
0f4289fed78bd3636f1d4604aba6d6edd34113af: Bug 1365191 - Remove MALLOC_UTRACE from mozjemalloc. r=njn
Mike Hommey <mh+mozilla@glandium.org> - Thu, 11 May 2017 17:47:02 +0900 - rev 358718
Push 90373 by cbook@mozilla.com at Wed, 17 May 2017 10:28:10 +0000
Bug 1365191 - Remove MALLOC_UTRACE from mozjemalloc. r=njn It's always unset, and Firefox has the logalloc replace-malloc library for something similar.
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip