7ea27dc60ccdbadadb27d89d579894b02c678a0a: Bug 1220766 - Don't assume ListIterator's next slot contains an int32 r=shu
Jon Coppeard <jcoppeard@mozilla.com> - Thu, 05 Nov 2015 10:10:51 +0000 - rev 271233
Push 67609 by jcoppeard@mozilla.com at Thu, 05 Nov 2015 10:12:26 +0000
Bug 1220766 - Don't assume ListIterator's next slot contains an int32 r=shu
51fb5007f68b2d596a8490fb51eead649cd964bb: Bug 1221359 - Fix ARM assembler assertion that doesn't hold if we are OOM r=jolesen
Jon Coppeard <jcoppeard@mozilla.com> - Thu, 05 Nov 2015 10:10:51 +0000 - rev 271232
Push 67609 by jcoppeard@mozilla.com at Thu, 05 Nov 2015 10:12:26 +0000
Bug 1221359 - Fix ARM assembler assertion that doesn't hold if we are OOM r=jolesen
b7d8668ab1e1091dd2e3e413961baeb58e3ccd0a: Bug 1219403 - Account for the fact that MediaStream::Destroy can be run safely
Paul Adenot <paul@paul.cx> - Thu, 05 Nov 2015 11:10:22 +0100 - rev 271231
Push 67608 by paul@paul.cx at Thu, 05 Nov 2015 10:10:44 +0000
Bug 1219403 - Account for the fact that MediaStream::Destroy can be run safely on the main thread during shutdown.
edc82c25a1f9350218ac92be594fc443da528997: Bug 1210920 - regression from talos webserver- talos damp doesn't load a real page. r=bgrins
Joel Maher <jmaher@mozilla.com> - Thu, 05 Nov 2015 01:59:01 -0800 - rev 271230
Push 67607 by jmaher@mozilla.com at Thu, 05 Nov 2015 09:59:28 +0000
Bug 1210920 - regression from talos webserver- talos damp doesn't load a real page. r=bgrins
a0c456c0161fd5a289fbd65ba95b7ab3f10f1f93: Backed out changeset 7195286a81bd (bug 1221159) for e10s bc7 bustage
Nigel Babu <nigelbabu@gmail.com> - Thu, 05 Nov 2015 14:56:59 +0530 - rev 271229
Push 67606 by nigelbabu@gmail.com at Thu, 05 Nov 2015 09:27:18 +0000
Backed out changeset 7195286a81bd (bug 1221159) for e10s bc7 bustage
a4101bc25be52731213e53a3529c4be64c57299e: Bug 1186768 patch 2 - Crashtest. r=heycam
Jesse Ruderman <jruderman@gmail.com> - Thu, 05 Nov 2015 16:50:04 +0800 - rev 271228
Push 67605 by dbaron@mozilla.com at Thu, 05 Nov 2015 08:50:29 +0000
Bug 1186768 patch 2 - Crashtest. r=heycam David Baron confirmed locally that this fails with a fatal assertion without patch 1 and passes with patch 1.
dae1d7e445d3725191acd97a9ba7def427c342e5: Bug 1186768 patch 1 - Avoid setting different font-size conditions due to MathML font size adjustments. r=heycam
L. David Baron <dbaron@dbaron.org> - Thu, 05 Nov 2015 16:50:04 +0800 - rev 271227
Push 67605 by dbaron@mozilla.com at Thu, 05 Nov 2015 08:50:29 +0000
Bug 1186768 patch 1 - Avoid setting different font-size conditions due to MathML font size adjustments. r=heycam
f64c8ef3ca52406c75f1c501dd11e2cc6bb0932e: Bug 1220411 - add XLDFLAGS to correctly find X libs when linking screentopng r=glandium
Landry Breuil <landry@openbsd.org> - Thu, 05 Nov 2015 09:48:37 +0100 - rev 271226
Push 67604 by landry@openbsd.org at Thu, 05 Nov 2015 08:48:59 +0000
Bug 1220411 - add XLDFLAGS to correctly find X libs when linking screentopng r=glandium
cf480f83f25d7bb46d1e174d4c15320d55b8eb1c: Bug 978833 patch 19 - Fix ResolvedStyleCache to use Declaration rather than nsCSSKeyframeRule as keys. r=heycam
L. David Baron <dbaron@dbaron.org> - Thu, 05 Nov 2015 16:44:11 +0800 - rev 271225
Push 67603 by dbaron@mozilla.com at Thu, 05 Nov 2015 08:44:59 +0000
Bug 978833 patch 19 - Fix ResolvedStyleCache to use Declaration rather than nsCSSKeyframeRule as keys. r=heycam This isn't needed today, but it makes more sense, and if we ever gave the cache a longer lifetime, it would be needed, since the nsCSSKeyframeRule can maintain its identity across style changes whereas a matched Declaration cannot.
0ab5ed0dd72f293f4d5ec9e16df136f48f9db4aa: Bug 978833 patch 18 - Eliminate StyleRule::RuleMatched and call Declaration::SetImmutable directly for style rules (like for @page and keyframe rules). r=heycam
L. David Baron <dbaron@dbaron.org> - Thu, 05 Nov 2015 16:44:10 +0800 - rev 271224
Push 67603 by dbaron@mozilla.com at Thu, 05 Nov 2015 08:44:59 +0000
Bug 978833 patch 18 - Eliminate StyleRule::RuleMatched and call Declaration::SetImmutable directly for style rules (like for @page and keyframe rules). r=heycam This is just simplification (plus the addition of an assertion).
6882c096a68365f6e4e3ae49a19541e68b96ff84: Bug 978833 patch 17 - Remove Rule::mWasMatched. r=heycam
L. David Baron <dbaron@dbaron.org> - Thu, 05 Nov 2015 16:44:10 +0800 - rev 271223
Push 67603 by dbaron@mozilla.com at Thu, 05 Nov 2015 08:44:59 +0000
Bug 978833 patch 17 - Remove Rule::mWasMatched. r=heycam
888d7ce53c3e032f6c4f6a70675a8775d710325d: Bug 978833 patch 16 - Always call Declaration::SetImmutable when we match a rule. r=heycam
L. David Baron <dbaron@dbaron.org> - Thu, 05 Nov 2015 16:44:10 +0800 - rev 271222
Push 67603 by dbaron@mozilla.com at Thu, 05 Nov 2015 08:44:59 +0000
Bug 978833 patch 16 - Always call Declaration::SetImmutable when we match a rule. r=heycam This change needs to happen before future work that would get rid of the DeclarationChanged dance in which we make a new StyleRule, but I've postponed that work to a later bug. Without this, those changes would cause a regression, because we'd only call SetImmutable on a StyleRule's first mDeclaration. However, we may as well do this now, as it makes patch 17 and patch 18 possible.
ed25ca545c1f7fe788c10c8d1a29feccb86e2dad: Bug 978833 patch 15 - Make css::Rule no longer inherit from nsIStyleRule. r=heycam
L. David Baron <dbaron@dbaron.org> - Thu, 05 Nov 2015 16:44:10 +0800 - rev 271221
Push 67603 by dbaron@mozilla.com at Thu, 05 Nov 2015 08:44:59 +0000
Bug 978833 patch 15 - Make css::Rule no longer inherit from nsIStyleRule. r=heycam This inheritance was previously needed only by a subset of the classes derived from css::Rule (css::StyleRule, nsCSSKeyframeRule, nsCSSPageRule). After patch 12, it is now needed by none.
5a8bb99e8c87d317306213d6ac600e32266edc58: Bug 978833 patch 14 - Pass mozilla::css::Rule instead of nsIStyleRule to nsIDocument/nsIDocumentObserver style rule methods. r=heycam
L. David Baron <dbaron@dbaron.org> - Thu, 05 Nov 2015 16:44:10 +0800 - rev 271220
Push 67603 by dbaron@mozilla.com at Thu, 05 Nov 2015 08:44:59 +0000
Bug 978833 patch 14 - Pass mozilla::css::Rule instead of nsIStyleRule to nsIDocument/nsIDocumentObserver style rule methods. r=heycam This also fixes bug 980560. This is needed for patch 15, which will make the rules passed to these methods no longer implement nsIStyleRule. TODO (bug 1221908): Given the amount that these parameters are used (not at all), perhaps we should have a followup on removing them and simplifying these notifications?
9f2470877279bdaeed2128a527b81183a3d71bbd: Bug 978833 patch 13 - Remove important rule creation from css::StyleRule. r=heycam
L. David Baron <dbaron@dbaron.org> - Thu, 05 Nov 2015 16:44:10 +0800 - rev 271219
Push 67603 by dbaron@mozilla.com at Thu, 05 Nov 2015 08:44:59 +0000
Bug 978833 patch 13 - Remove important rule creation from css::StyleRule. r=heycam This is the removal half corresponding to the additions in patch 7; the removal needs to happen after patch 12.
f340cdf67edb870645ddf499da690e60eff7f73f: Bug 978833 patch 12 - Use the css::Declaration instead of the css::StyleRule as the matching rule. r=heycam
L. David Baron <dbaron@dbaron.org> - Thu, 05 Nov 2015 16:44:10 +0800 - rev 271218
Push 67603 by dbaron@mozilla.com at Thu, 05 Nov 2015 08:44:59 +0000
Bug 978833 patch 12 - Use the css::Declaration instead of the css::StyleRule as the matching rule. r=heycam This is the key change in this patch series; it changes the object we use for style data (currently nsIStyleRule) identity. It allows removing some hacks we have to deal with that for StyleRule, and avoids having to write similar hacks for nsCSSKeyframeRule and nsCSSPageRule (which are broken without this). I confirmed locally that it is this patch that fixes both of the todo_is mochitests, by building and testing with the patch queue through patch 11, and again through patch 12.
e69922893211b78e5593fbd1c795e66248a357a1: Bug 978833 patch 11 - Add missing #includes in preparation for nsRuleWalker.h #include change in following patch. r=heycam
L. David Baron <dbaron@dbaron.org> - Thu, 05 Nov 2015 16:44:09 +0800 - rev 271217
Push 67603 by dbaron@mozilla.com at Thu, 05 Nov 2015 08:44:59 +0000
Bug 978833 patch 11 - Add missing #includes in preparation for nsRuleWalker.h #include change in following patch. r=heycam Patch 12 changes nsRuleWalker.h from including StyleRule.h to including Declaration.h; this fixes other headers to deal with that change based on the include-what-you-use principle.
da3bf914effe192549fc81b44363fa9ef36a0e69: Bug 978833 patch 10 - Raise consistent exceptions so that the exception doesn't depend on rule destruction timing. r=bzbarsky
L. David Baron <dbaron@dbaron.org> - Thu, 05 Nov 2015 16:44:09 +0800 - rev 271216
Push 67603 by dbaron@mozilla.com at Thu, 05 Nov 2015 08:44:59 +0000
Bug 978833 patch 10 - Raise consistent exceptions so that the exception doesn't depend on rule destruction timing. r=bzbarsky Prior to patch 12, rule destruction for rules that were matched doesn't happen until rule tree GC. This means that GetCSSDeclaration is less likely to return null, but then GetCSSParsingEnvironment might fail. With StyleRule no longer participating in the rule tree, they're more likely to be destroyed quickly, leading to the !olddecl failure case instead of the !env.mPrincipal failure case. This is needed to avoid patch 12 causing: TEST-UNEXPECTED-FAIL | layout/inspector/tests/chrome/test_bug727834.xul | original rule is not available for modification anymore - got "NS_ERROR_FAILURE", expected "NS_ERROR_NOT_AVAILABLE"
3a1bf2c602114a72dfd99a6aeb737f3cb116076b: Bug 978833 patch 9 - Move keyframe !important data assertion to where it will continue to happen. r=heycam
L. David Baron <dbaron@dbaron.org> - Thu, 05 Nov 2015 16:44:09 +0800 - rev 271215
Push 67603 by dbaron@mozilla.com at Thu, 05 Nov 2015 08:44:59 +0000
Bug 978833 patch 9 - Move keyframe !important data assertion to where it will continue to happen. r=heycam The current location of the assertion will stop being called in patch 12 and will go away in patch 15; the new location is valid both before and after patch 12.
0adcd9f3fac0358d859575727b3febeaf420c512: Bug 978833 patch 8 - Call SetImmutable for declarations of @page and keyframe rules. r=heycam
L. David Baron <dbaron@dbaron.org> - Thu, 05 Nov 2015 16:44:09 +0800 - rev 271214
Push 67603 by dbaron@mozilla.com at Thu, 05 Nov 2015 08:44:59 +0000
Bug 978833 patch 8 - Call SetImmutable for declarations of @page and keyframe rules. r=heycam This probably should have been done before, but prior to this patch series, dynamic changes of the declarations on these rules were broken due to rule immutability violations; now that is no longer the case, but to benefit from that, I believe we actually need to mark the declarations as immutable once matched so that dynamic changes will trigger construction of a new declaration (which thus has a new nsIStyleRule identity).
(0) -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip