79010ce706eb83de48b5abb81ea387f2f5f4dc0b: Bug 1550554 - Share computed and specified value representation of -moz-context-properties. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 16 May 2019 23:03:29 +0000 - rev 474255
Push 113144 by shindli@mozilla.com at Fri, 17 May 2019 16:44:55 +0000
Bug 1550554 - Share computed and specified value representation of -moz-context-properties. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D30545
6524a34864c39e0957cc10d124d61a6d795b5894: Bug 1550554 - Use an ArcSlice as the computed value representation of inherited list properties. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 16 May 2019 23:03:27 +0000 - rev 474254
Push 113144 by shindli@mozilla.com at Fri, 17 May 2019 16:44:55 +0000
Bug 1550554 - Use an ArcSlice as the computed value representation of inherited list properties. r=heycam This adds a bit of complexity, which I think will pay off in the end. Removals incoming. Differential Revision: https://phabricator.services.mozilla.com/D30544
7c2ff60588882f354678a676c2028eebd71f7557: Bug 1550554 - Implement ArcSlice::default(). r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 16 May 2019 23:22:04 +0000 - rev 474253
Push 113144 by shindli@mozilla.com at Fri, 17 May 2019 16:44:55 +0000
Bug 1550554 - Implement ArcSlice::default(). r=heycam Share a singleton to avoid allocating for empty lists. Differential Revision: https://phabricator.services.mozilla.com/D30543
7321594dab268ea3f11722178c98d6412f1db078: Bug 1549593 - Use OwnedSlice in the specified and computed values of most vector properties. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 16 May 2019 23:21:37 +0000 - rev 474252
Push 113144 by shindli@mozilla.com at Fri, 17 May 2019 16:44:55 +0000
Bug 1549593 - Use OwnedSlice in the specified and computed values of most vector properties. r=heycam This is just a refactor in the right direction. Eventual goal is: * All inherited properties use ArcSlice<>. * All reset properties use OwnedSlice<> (or ThinVec<>). No conversion happens at all, so we can remove all that glue, and also compute_iter and co. Of course there's work to do, but this is a step towards that. Differential Revision: https://phabricator.services.mozilla.com/D30127
c110061df4c16715a491ead8cab815a259ae7846: Bug 1552084 - Remove lifetime requirements on DrawTarget and ReadTarget in WR. r=emilio
Glenn Watson <github@intuitionlibrary.com> - Thu, 16 May 2019 22:25:35 +0000 - rev 474251
Push 113144 by shindli@mozilla.com at Fri, 17 May 2019 16:44:55 +0000
Bug 1552084 - Remove lifetime requirements on DrawTarget and ReadTarget in WR. r=emilio This makes DrawTarget and ReadTarget no longer require a borrow on a texture. This was previously fine, but in the near future WR will be rendering picture caching surfaces directly into texture handles. To allow this, we need to remove the borrow check requirement on DrawTarget for rustc. Differential Revision: https://phabricator.services.mozilla.com/D31390
c215a31ef6ea248566743ad6f9fd471e356c7b80: Merge mozilla-central to autoland. CLOSED TREE
Csoregi Natalia <ncsoregi@mozilla.com> - Fri, 17 May 2019 02:12:30 +0300 - rev 474250
Push 113144 by shindli@mozilla.com at Fri, 17 May 2019 16:44:55 +0000
Merge mozilla-central to autoland. CLOSED TREE
440aa7a30693d06e6aef4bc256edc226f407ef49: Backed out 2 changesets (bug 1549855) for failing Android mochitests on robocop_text_page.html CLOSED TREE
arthur.iakab <aiakab@mozilla.com> - Fri, 17 May 2019 02:06:35 +0300 - rev 474249
Push 113144 by shindli@mozilla.com at Fri, 17 May 2019 16:44:55 +0000
Backed out 2 changesets (bug 1549855) for failing Android mochitests on robocop_text_page.html CLOSED TREE Backed out changeset 928038c23227 (bug 1549855) Backed out changeset 9383ea5938fe (bug 1549855)
31cf332c9b21698336c5e6c18939a3a8b58a7902: Bug 1547034: Add userFacingName and userFacingDescription to schema r=mythmon
Ethan Glasser-Camp <ethan@betacantrips.com> - Thu, 16 May 2019 15:04:25 +0000 - rev 474248
Push 113144 by shindli@mozilla.com at Fri, 17 May 2019 16:44:55 +0000
Bug 1547034: Add userFacingName and userFacingDescription to schema r=mythmon Display these when available instead of generating one. We play some games here to let SinglePreferenceExperiment continue to validate according to the PreferenceExperiment schema. This is kind of ugly. Another approach might be to move the about-studies code that generates a description. I was hesitant to do this because it would mean losing the formatting. Depends on D29873 Differential Revision: https://phabricator.services.mozilla.com/D30969
0de43d5275d15b83e80fa021bac4175f85a5d3a4: Bug 1547034: PreferenceExperimentAction supports multiple prefs r=mythmon
Ethan Glasser-Camp <ethan@betacantrips.com> - Thu, 16 May 2019 15:04:22 +0000 - rev 474247
Push 113144 by shindli@mozilla.com at Fri, 17 May 2019 16:44:55 +0000
Bug 1547034: PreferenceExperimentAction supports multiple prefs r=mythmon The existing, single-preference action format is supported by a new SinglePreferenceExperimentAction, which converts single-preference actions into multiple-preference actions. We keep the wire format name "preference-experiment" for SinglePreferenceExperimentAction for now, but perhaps one day we can move that to "single-preference-experiment". Depends on D29872 Differential Revision: https://phabricator.services.mozilla.com/D29873
454e86015872654981d491d0867f91e4c6685e6f: Bug 1547034: PreferenceExperiments.start can take multiple prefs r=mythmon
Ethan Glasser-Camp <ethan@betacantrips.com> - Thu, 16 May 2019 15:04:20 +0000 - rev 474246
Push 113144 by shindli@mozilla.com at Fri, 17 May 2019 16:44:55 +0000
Bug 1547034: PreferenceExperiments.start can take multiple prefs r=mythmon Add a little bit to some existing tests to cover this new functionality. Depends on D29871 Differential Revision: https://phabricator.services.mozilla.com/D29872
da4380fe5ce1ea4d7dba885f1127fac61860552e: Bug 1547034: Migrate PreferenceExperiments observers r=mythmon
Ethan Glasser-Camp <ethan@betacantrips.com> - Thu, 16 May 2019 15:04:18 +0000 - rev 474245
Push 113144 by shindli@mozilla.com at Fri, 17 May 2019 16:44:55 +0000
Bug 1547034: Migrate PreferenceExperiments observers r=mythmon Move startObserver to take a preferences object and register its observer for each preference in that object. While we're here, move to the canonical observer interface according to nsIPrefBranch.idl, with an `observe` method instead of just passing a function. Also perform some drive-by cleanups in the tests: add a name to one test, drop some unused arguments to some other tests. Depends on D29293 Differential Revision: https://phabricator.services.mozilla.com/D29871
137380671f01c6185f61a04b3fd55aac9617da4a: Bug 1547034: Migrate PreferenceExperiments to allow for multiple prefs r=mythmon,leplatrem
Ethan Glasser-Camp <ethan@betacantrips.com> - Thu, 16 May 2019 15:04:12 +0000 - rev 474244
Push 113144 by shindli@mozilla.com at Fri, 17 May 2019 16:44:55 +0000
Bug 1547034: Migrate PreferenceExperiments to allow for multiple prefs r=mythmon,leplatrem This is part 1 of the required changes. This just addresses the storage mechanism and any place that uses experiments in their raw form. This updates most callers to support studies with multiple preferences. We update about-studies to assume only one preference. This seems counterproductive, but studies with multiple preferences will include a description field that obviates the need for this. Differential Revision: https://phabricator.services.mozilla.com/D29293
8189bd3d8078b3155a425043b34f6975e9a799d8: Bug 1551696 - Add reveal icon. r=MattN
Jared Wein <jwein@mozilla.com> - Thu, 16 May 2019 20:16:56 +0000 - rev 474243
Push 113144 by shindli@mozilla.com at Fri, 17 May 2019 16:44:55 +0000
Bug 1551696 - Add reveal icon. r=MattN Differential Revision: https://phabricator.services.mozilla.com/D31290
871756833dc4996a9d6113e998ef66932c5b97eb: Bug 1551696 - Change reveal-button to a checkbox. r=MattN,Pike
Jared Wein <jwein@mozilla.com> - Thu, 16 May 2019 20:18:03 +0000 - rev 474242
Push 113144 by shindli@mozilla.com at Fri, 17 May 2019 16:44:55 +0000
Bug 1551696 - Change reveal-button to a checkbox. r=MattN,Pike Differential Revision: https://phabricator.services.mozilla.com/D31289
034521c95944bb02d76ed16b2fb6ec32787cad39: Bug 1551696 - Add edit icon. r=MattN
Jared Wein <jwein@mozilla.com> - Thu, 16 May 2019 20:16:45 +0000 - rev 474241
Push 113144 by shindli@mozilla.com at Fri, 17 May 2019 16:44:55 +0000
Bug 1551696 - Add edit icon. r=MattN Differential Revision: https://phabricator.services.mozilla.com/D31288
15df555adc39c6bffc6c9e7ab647d64229a1495e: Bug 1551696 - Add delete icon. r=MattN
Jared Wein <jwein@mozilla.com> - Thu, 16 May 2019 20:16:40 +0000 - rev 474240
Push 113144 by shindli@mozilla.com at Fri, 17 May 2019 16:44:55 +0000
Bug 1551696 - Add delete icon. r=MattN Differential Revision: https://phabricator.services.mozilla.com/D31287
b8540f8b95a688605b4fee90171f400de3b83995: Bug 1551696 - Add branded logo for official builds. r=MattN
Jared Wein <jwein@mozilla.com> - Thu, 16 May 2019 20:18:01 +0000 - rev 474239
Push 113144 by shindli@mozilla.com at Fri, 17 May 2019 16:44:55 +0000
Bug 1551696 - Add branded logo for official builds. r=MattN I wasn't sure what we should show in the case of unofficial builds. Curently the logo is just hidden for those builds. Differential Revision: https://phabricator.services.mozilla.com/D31286
71171349b87c2d760d6bcb98a7402a36aebfb69a: Bug 1551696 - Fix a color for the deemphasized text of the field-label. r=MattN
Jared Wein <jwein@mozilla.com> - Thu, 16 May 2019 20:16:28 +0000 - rev 474238
Push 113144 by shindli@mozilla.com at Fri, 17 May 2019 16:44:55 +0000
Bug 1551696 - Fix a color for the deemphasized text of the field-label. r=MattN Differential Revision: https://phabricator.services.mozilla.com/D31285
7c03af91db0459ce9624dc1a594b9a11b4f18eb4: Bug 1551696 - Remove type=text/css from style references since its not necessary. r=MattN
Jared Wein <jwein@mozilla.com> - Thu, 16 May 2019 20:17:59 +0000 - rev 474237
Push 113144 by shindli@mozilla.com at Fri, 17 May 2019 16:44:55 +0000
Bug 1551696 - Remove type=text/css from style references since its not necessary. r=MattN Differential Revision: https://phabricator.services.mozilla.com/D31283
507d95016ed26c189386369dac28bd49c5fb3a7d: Bug 1551986 - Do not create unnecessary items inside opacity: 0 containers r=mattwoodrow
Miko Mynttinen <mikokm@gmail.com> - Thu, 16 May 2019 21:13:49 +0000 - rev 474236
Push 113144 by shindli@mozilla.com at Fri, 17 May 2019 16:44:55 +0000
Bug 1551986 - Do not create unnecessary items inside opacity: 0 containers r=mattwoodrow Differential Revision: https://phabricator.services.mozilla.com/D31311
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 tip