7725328be4f545f062fdc7c9fb7146b11339851e: Bug 1272964: [MSE] P5. Default to skipping to the next keyframe if no keyframe was found past currentTime. r=cpearce
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 19 May 2016 15:37:34 +0800 - rev 298252
Push 77085 by jyavenard@mozilla.com at Sat, 21 May 2016 00:13:46 +0000
Bug 1272964: [MSE] P5. Default to skipping to the next keyframe if no keyframe was found past currentTime. r=cpearce If no keyframe are found after our time threshold, we can still skip to another keyframe (despite being prior the desired time). So this is just a workaround for our inability to tell the MDSM when to enter buffering mode and instead the MDSM incorrectly uses the time of the last frame returned. MozReview-Commit-ID: 5sGULpvqY5m
5c6bfbf57df9d521effeedcf1af9cc4e67adc3b2: Bug 1272964: P4. Only flush decoder if skip to next keyframe actually succeeds. r=cpearce
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 19 May 2016 15:02:43 +0800 - rev 298251
Push 77085 by jyavenard@mozilla.com at Sat, 21 May 2016 00:13:46 +0000
Bug 1272964: P4. Only flush decoder if skip to next keyframe actually succeeds. r=cpearce As the decoder was flushed and reset prior the skip to next keyframe started, and future error would be unrecoverable. So only reset the decoder once the skip completes and succeeded. Otherwise we default back to normal decoding. MozReview-Commit-ID: GEj1i0EsaYO
937ac53c342e363b049f0daead7e06fe16adb928: Bug 1272964: [MSE] P3. Do not skip over gaps when searching for the next keyframe. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 17 May 2016 16:18:07 +0800 - rev 298250
Push 77085 by jyavenard@mozilla.com at Sat, 21 May 2016 00:13:46 +0000
Bug 1272964: [MSE] P3. Do not skip over gaps when searching for the next keyframe. r=gerald MozReview-Commit-ID: 1wPbp6JOaa8
13fd3929f83accddd4e8d0154c22bef55431118c: Bug 1272964: P2. Don't activate skip to next keyframe until we passed the internal seek target. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 18 May 2016 11:48:05 +0800 - rev 298249
Push 77085 by jyavenard@mozilla.com at Sat, 21 May 2016 00:13:46 +0000
Bug 1272964: P2. Don't activate skip to next keyframe until we passed the internal seek target. r=gerald currentTime may be past the start of the internal seek time, but before its end, which would have triggered a false positive: we do not want to jump to the next key frame here. MozReview-Commit-ID: H5O9XXnk84T
6f15eecb6ba1198798bfbaf34391fd0344d2930c: Bug 1272964: P1. Only activate skip to next keyframe logic when next keyframe time is known. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 17 May 2016 22:26:34 +0800 - rev 298248
Push 77085 by jyavenard@mozilla.com at Sat, 21 May 2016 00:13:46 +0000
Bug 1272964: P1. Only activate skip to next keyframe logic when next keyframe time is known. r=gerald MozReview-Commit-ID: DoAstqSRnyc
3c46096adeaf7611bed1588d6adfa0c7c7b2d5e3: Bug 1272592 Merge "MediaSelect" key value into "LaunchMediaPlayer" r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 19 May 2016 20:47:32 +0900 - rev 298247
Push 77084 by masayuki@d-toybox.com at Sat, 21 May 2016 00:12:47 +0000
Bug 1272592 Merge "MediaSelect" key value into "LaunchMediaPlayer" r=smaug "MediaSelect" is merged into "LanuchMediaPlayer" in the spec since there is no difference between them and "LaunchMediaPlayer" explains the meaning clearer. This patch removes "MediaSelect" key value and maps all keys which are mapped to "MediaSelect" to "LaunchMediaPlayer". MozReview-Commit-ID: IEZhV4p6Qag
392304ae5264da68fb3e2be789bcbe34137f6951: Bug 1274272 - fix RTL issues with about:privatebrowsing, r=mikedeboer
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Thu, 19 May 2016 22:59:09 +0100 - rev 298246
Push 77083 by gijskruitbosch@gmail.com at Sat, 21 May 2016 00:12:12 +0000
Bug 1274272 - fix RTL issues with about:privatebrowsing, r=mikedeboer MozReview-Commit-ID: rFNLKSWnSX
fdccec38636a68423966a49bbb4b3e3bba095ea2: Bug 1274271 - Remove unused function applyNamedArgs; r=automatedtester
Andreas Tolfsen <ato@mozilla.com> - Thu, 19 May 2016 14:53:00 +0100 - rev 298245
Push 77082 by atolfsen@mozilla.com at Sat, 21 May 2016 00:11:15 +0000
Bug 1274271 - Remove unused function applyNamedArgs; r=automatedtester MozReview-Commit-ID: DU5xHDLL4Ww
63cfc2bd51fab69b6d4f3803af86c4b5a3a0eb01: Bug 1273998 - Proper export of printing IPDL with --disable-printing r=bobowen,glandium,?glandium
Alexandre Lissy <lissyx@lissyx.dyndns.org> - Thu, 19 May 2016 12:25:22 +0200 - rev 298244
Push 77081 by alissy@mozilla.com at Sat, 21 May 2016 00:10:36 +0000
Bug 1273998 - Proper export of printing IPDL with --disable-printing r=bobowen,glandium,?glandium MozReview-Commit-ID: GNUrl6LKcMm
9145f902d54fe189169db465e6e8be9c7eba21e3: Bug 1262937 - part 8 - factor out array length deserialization errors; r=jld
Nathan Froyd <froydnj@gmail.com> - Sat, 21 May 2016 04:07:56 -0400 - rev 298243
Push 77080 by nfroyd@mozilla.com at Sat, 21 May 2016 00:09:07 +0000
Bug 1262937 - part 8 - factor out array length deserialization errors; r=jld
fc5bd59a1e7e194cea24f307b42d6e2a01377381: Bug 1262937 - part 7 - factor out union type deserialization errors; r=jld
Nathan Froyd <froydnj@gmail.com> - Sat, 21 May 2016 04:07:56 -0400 - rev 298242
Push 77080 by nfroyd@mozilla.com at Sat, 21 May 2016 00:09:07 +0000
Bug 1262937 - part 7 - factor out union type deserialization errors; r=jld
6d963cab433c29fbf3e3bd3f1d889867abeb258d: Bug 1262937 - part 6 - enable custom error message for ipdl.py's checkedRead; r=jld
Nathan Froyd <froydnj@gmail.com> - Sat, 21 May 2016 04:07:56 -0400 - rev 298241
Push 77080 by nfroyd@mozilla.com at Sat, 21 May 2016 00:09:07 +0000
Bug 1262937 - part 6 - enable custom error message for ipdl.py's checkedRead; r=jld To enable string sharing, we're going to have helpful functions that take a small, distinguishable, sharable string and construct a more complete error message out of that. To do that easily with checkedRead, we need to be able to pass custom parameters into the error function.
9aa3fa0eb1cc13457961f091babf6aa1a9e0b652: Bug 1262937 - part 5 - factor out actor reading code to a common base class; r=jld
Nathan Froyd <froydnj@gmail.com> - Sat, 21 May 2016 04:07:56 -0400 - rev 298240
Push 77080 by nfroyd@mozilla.com at Sat, 21 May 2016 00:09:07 +0000
Bug 1262937 - part 5 - factor out actor reading code to a common base class; r=jld Actor reading from IPC message is codegen'd with a lot of repeated code. We can improve that by moving the core actor reading code out of subclasses into IProtocolmanager. While we still need to codegen a bit of code to cast the read actor to the proper type, the code overall is smaller. The lone downside is that if we do encounter an error reading the actor id out of the message, the precision of our crash messages is reduced somewhat: we no longer have the protocol name doing the reading, nor do we get crash report annotations, since we can't tell whether we're in the parent or child process.
49c0e922c3ffa997338aea278517b2806fcd7caa: Bug 1262937 - part 4 - publically inherit from MessageListener in IProtocol; r=jld
Nathan Froyd <froydnj@gmail.com> - Sat, 21 May 2016 04:07:56 -0400 - rev 298239
Push 77080 by nfroyd@mozilla.com at Sat, 21 May 2016 00:09:07 +0000
Bug 1262937 - part 4 - publically inherit from MessageListener in IProtocol; r=jld IProtocolManager is templated over some listener type. In our IPDL code, that type is always IProtocol, which is a subclass of MessageListener. It's also important to note that IProtocol uses protected inheritance from MessageListener; the generated code takes advantage of this inheritance structure when it reads actors: // ChannelListener is typedef'd to MessageListener // Lookup here is IProtocolManager::Lookup ChannelListener* listener = Lookup(id); Lookup returns a pointer to the type over which IProtocolManager is templated. As mentioned above, that type is always IProtocol. But thanks to the containing class inheriting from *both* IProtocolManager and IProtocol, the returned pointer can be silently upcasted to MessageListener thanks to C++ visibility rules. It's not clear that this restricted inheritance structure is actually benefitting anybody, or that the inheritance hierarchy of protocol classes is the best way to do things. This particular implementation detail is getting in the way for the next improvement, so let's make the protected inheritance public instead.
89b98926c2fdd4fad17285c0cfc8029277c6b0b0: Bug 1262937 - part 3 - move quoting out of checkedRead; r=jld
Nathan Froyd <froydnj@gmail.com> - Sat, 21 May 2016 04:07:56 -0400 - rev 298238
Push 77080 by nfroyd@mozilla.com at Sat, 21 May 2016 00:09:07 +0000
Bug 1262937 - part 3 - move quoting out of checkedRead; r=jld checkedRead is set up to single-quote whatever message is passed in. This scheme works great for all existing messages, but it makes some callsites a little surprising ("where's the matching quote?") and doesn't work well with message changes to be made in future patches. Let's move the quoting out to client code.
63a20cf3a66d8b845df443b1bfe1d1ce41b5821c: Bug 1262937 - part 2 - don't include the message name when complaining about handler failure; r=jld
Nathan Froyd <froydnj@gmail.com> - Sat, 21 May 2016 04:07:56 -0400 - rev 298237
Push 77080 by nfroyd@mozilla.com at Sat, 21 May 2016 00:09:07 +0000
Bug 1262937 - part 2 - don't include the message name when complaining about handler failure; r=jld Similar to part 1, this change enables the strings passed to ProtocolErrorBreakpoint to be collapsed into a single string, saving ~60K of read-only data (!). This change does affect debuggability slightly, but given that ProtocolErrorBreakpoint only tries to throw the passed-in string to stderr, I don't think it's a huge deal.
7ad129583196b1f1b7b060f7a8caee3909ea18a1: Bug 1262937 - part 1 - don't include the protocol name in Clone error messages; r=jld
Nathan Froyd <froydnj@gmail.com> - Sat, 21 May 2016 04:07:56 -0400 - rev 298236
Push 77080 by nfroyd@mozilla.com at Sat, 21 May 2016 00:09:07 +0000
Bug 1262937 - part 1 - don't include the protocol name in Clone error messages; r=jld We have better ways of getting the protocol name at the point of the error (e.g. backtraces). Removing it means the error message can be condensed to a single string by the compiler/linking, saving ~8k of read-only data.
4174c9e21a403c08491127884ab0bc0d8db819cd: Bug 1273405. Part 4 - add assertions. r=jya.
JW Wang <jwwang@mozilla.com> - Tue, 17 May 2016 17:32:55 +0800 - rev 298235
Push 77079 by jwwang@mozilla.com at Sat, 21 May 2016 00:08:56 +0000
Bug 1273405. Part 4 - add assertions. r=jya. MozReview-Commit-ID: 6tbA0aj5Rto
c123be7651413615bb9886d074c783f4227de06a: Bug 1273405. Part 3 - remove use of FlushableTaskQueue. r=jya.
JW Wang <jwwang@mozilla.com> - Tue, 17 May 2016 17:30:53 +0800 - rev 298234
Push 77079 by jwwang@mozilla.com at Sat, 21 May 2016 00:08:56 +0000
Bug 1273405. Part 3 - remove use of FlushableTaskQueue. r=jya. MozReview-Commit-ID: Do9REbjltEW
7be21b2402d1240667468d33f0dae4e226eda497: Bug 1273405. Part 2 - remove use of FlushableTaskQueue::Flush(). r=jya.
JW Wang <jwwang@mozilla.com> - Tue, 17 May 2016 17:22:45 +0800 - rev 298233
Push 77079 by jwwang@mozilla.com at Sat, 21 May 2016 00:08:56 +0000
Bug 1273405. Part 2 - remove use of FlushableTaskQueue::Flush(). r=jya. MozReview-Commit-ID: bchmGXw1fw
(0) -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip