7632333fd2edbd08b4419d4462d176f6029e0663: Bug 1419581 - Part 1: Simplify MMA GCM sender IDs logic. r=nechen
Tad <tad@spotco.us> - Fri, 12 Jan 2018 15:03:37 -0800 - rev 400906
Push 99254 by dluca@mozilla.com at Fri, 26 Jan 2018 03:51:01 +0000
Bug 1419581 - Part 1: Simplify MMA GCM sender IDs logic. r=nechen Right now, the MMA glue is built into constants.jar. constants.jar is the home of preprocessed Java code; it's built very early in the build process and intended to be a tiny kernel of shared definitions. The fact that the MMA glue has to live there is just a sad consequence of the non-Gradle build system, which makes dependency injection difficult. Unfortunately, another consequence is that it's not possible to move reference org.mozilla.gecko.{gcm,push} in the MMA glue, because those packages are built after constants.jar. Instead, this patch lifts some of the logic into AppConstants, which is part of constants.jar. We had grown a twisty maze of indirection around the GCM sender IDs and it just wasn't necessary; this just lifts the static pieces up a level and removes a bunch of interface indirection. What surprises me is that asking Google's InstanceId.getToken for a GCM token with a "comma,separated,list" of GCM sender IDs works -- and indeed, has worked since we added the second MMA sender ID. I didn't expect that and can't explain it, but this doesn't change that logic and local testing (both of the existing APKs, and APKs with this modification) looks good. MozReview-Commit-ID: 3hObfAwNlPH *** a0c07e53 o draft Bug 1419581 - Part 1: Move MMA setGcmSenderID from MmaDelegate to MmaLeanplumImp. r=nechen MozReview-Commit-ID: A4hrk6pVqGW
a83c011fcfc1f138564266b7d8003da1e1b7e769: Bug 1419581 - Pre: Add missing excludes when building without MOZ_NATIVE_DEVICES. r=nalexander
Nick Alexander <nalexander@mozilla.com> - Thu, 04 Jan 2018 14:49:58 -0800 - rev 400905
Push 99254 by dluca@mozilla.com at Fri, 26 Jan 2018 03:51:01 +0000
Bug 1419581 - Pre: Add missing excludes when building without MOZ_NATIVE_DEVICES. r=nalexander MozReview-Commit-ID: BXNFBEs2017
d47d09e5efae8b19e8420a5192827ec07ce037b9: Backed out changeset 8ebfca2b0c21 (bug 1432437) for Xpcshell test failure on toolkit/components/places/tests/unit/test_sync_utils.js
Dorel Luca <dluca@mozilla.com> - Fri, 26 Jan 2018 01:43:17 +0200 - rev 400904
Push 99254 by dluca@mozilla.com at Fri, 26 Jan 2018 03:51:01 +0000
Backed out changeset 8ebfca2b0c21 (bug 1432437) for Xpcshell test failure on toolkit/components/places/tests/unit/test_sync_utils.js
c0b051e8b50065d52e59a6b1b47844ae464f60d4: Bug 1432773 - listen for unload in capture phase to reset click count; r=whimboo
Maja Frydrychowicz <mjzffr@gmail.com> - Wed, 24 Jan 2018 15:03:53 -0500 - rev 400903
Push 99254 by dluca@mozilla.com at Fri, 26 Jan 2018 03:51:01 +0000
Bug 1432773 - listen for unload in capture phase to reset click count; r=whimboo The bubbling phase is too late so resetClick didn't always get called. MozReview-Commit-ID: JIseY5o3oAX
f8f0d318980c1aae24656cb57024969835b8db96: Bug 1408792 - Add a reftest. r=mstange
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 23 Jan 2018 09:39:09 -0500 - rev 400902
Push 99254 by dluca@mozilla.com at Fri, 26 Jan 2018 03:51:01 +0000
Bug 1408792 - Add a reftest. r=mstange MozReview-Commit-ID: 7vD55lQMGQn
ef78d4e91a01d6a7c86ce338b375f98f6df6a8f1: Bug 1428845 - Removed duplicate definition of waitForCondition(). r=johannh
Rofael Aleezada <me@rofael.com> - Mon, 22 Jan 2018 18:50:32 -0600 - rev 400901
Push 99254 by dluca@mozilla.com at Fri, 26 Jan 2018 03:51:01 +0000
Bug 1428845 - Removed duplicate definition of waitForCondition(). r=johannh MozReview-Commit-ID: UCZwR5eRc5
bc141b951a1b1aac8fefe67cb5488091cf5de43a: servo: Merge #19864 - Make some callback-related code unsafe (from nox:callbacks); r=Manishearth
Anthony Ramine <n.oxyde@gmail.com> - Thu, 25 Jan 2018 16:21:10 -0600 - rev 400900
Push 99254 by dluca@mozilla.com at Fri, 26 Jan 2018 03:51:01 +0000
servo: Merge #19864 - Make some callback-related code unsafe (from nox:callbacks); r=Manishearth Source-Repo: https://github.com/servo/servo Source-Revision: e9ab91d257a983a7c19cb5fada21a0359cfae95d
949b1558f9b9bd4b8975ca5f1ff1ebb75688bcec: Bug 1429759 - Allow Marionette tests to change the user profile. r=automatedtester,maja_zf
Henrik Skupin <mail@hskupin.info> - Thu, 11 Jan 2018 15:21:11 +0100 - rev 400899
Push 99254 by dluca@mozilla.com at Fri, 26 Jan 2018 03:51:01 +0000
Bug 1429759 - Allow Marionette tests to change the user profile. r=automatedtester,maja_zf If Marionette handles the instance of the application including the user profile, the tests should be able to change the user profile. This will enable tests to cover specific bugs in the application as caused by the profile name and path. To prevent dataloss changing the profile should only be allowed when the application is not running. MozReview-Commit-ID: JWQGV4JWP61
804f26b2c6b8284b3f862d5e56814e1128bf1d5b: Bug 1428698 - Align intl::locale::Locale with BCP47. r=jfkthame
Zibi Braniecki <zbraniecki@mozilla.com> - Thu, 25 Jan 2018 14:50:32 -0800 - rev 400898
Push 99254 by dluca@mozilla.com at Fri, 26 Jan 2018 03:51:01 +0000
Bug 1428698 - Align intl::locale::Locale with BCP47. r=jfkthame MozReview-Commit-ID: AT9MPppx99p
bb5db229b32f07af2b06fb085ba34135413e6c95: Bug 1432439 - Remove getBookmarkIdsForURI. r=standard8
Marco Bonardo <mbonardo@mozilla.com> - Tue, 23 Jan 2018 13:12:23 +0100 - rev 400897
Push 99254 by dluca@mozilla.com at Fri, 26 Jan 2018 03:51:01 +0000
Bug 1432439 - Remove getBookmarkIdsForURI. r=standard8 MozReview-Commit-ID: FoXR3IclKQk
8ebfca2b0c21c64227ea273969c07137ca032153: Bug 1432437 - Remove synchronous changeBookmarkURI. r=standard8
Marco Bonardo <mbonardo@mozilla.com> - Wed, 24 Jan 2018 12:13:02 +0100 - rev 400896
Push 99254 by dluca@mozilla.com at Fri, 26 Jan 2018 03:51:01 +0000
Bug 1432437 - Remove synchronous changeBookmarkURI. r=standard8 MozReview-Commit-ID: Jy76eKCN7wp
da7a2109cfff4b07c5cac3b33675e8845c858042: servo: Merge #19855 - Added --progress flag to test-perf git commands (from asajeffrey:test-perf-git-progress); r=jdm
Alan Jeffrey <ajeffrey@mozilla.com> - Thu, 25 Jan 2018 15:30:22 -0600 - rev 400895
Push 99254 by dluca@mozilla.com at Fri, 26 Jan 2018 03:51:01 +0000
servo: Merge #19855 - Added --progress flag to test-perf git commands (from asajeffrey:test-perf-git-progress); r=jdm <!-- Please describe your changes on the following line: --> Adding a `--progress` flag to git commands in test-perf to try to avoid the timeouts we're seeing at http://build.servo.org/builders/linux-nightly/builds/581/steps/test/logs/stdio --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because this is test infrastructure <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 8c1af9cce7197104dda76873be6c713e0b0d3866
38b4e5c32e5a7cccdb710bd372c3d3691b6008c3: Bug 1433273 - Remove mozglue/linker/dladdr.h. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Fri, 26 Jan 2018 06:21:30 +0900 - rev 400894
Push 99254 by dluca@mozilla.com at Fri, 26 Jan 2018 03:51:01 +0000
Bug 1433273 - Remove mozglue/linker/dladdr.h. r=froydnj It was added in bug 683127 as a forced include for nspr, and accidentally became unused after bug 1230117, but it turns out that all versions of Android we care about nowadays (and probably back then) now support dladdr.
3b862e2b9e0b6caee20037f3f7bb33c88468876a: Bug 1414506 - Use system dl_iterate_phdr for system loaded libraries when we can. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Tue, 23 Jan 2018 15:59:18 +0900 - rev 400893
Push 99254 by dluca@mozilla.com at Fri, 26 Jan 2018 03:51:01 +0000
Bug 1414506 - Use system dl_iterate_phdr for system loaded libraries when we can. r=froydnj When looping through the debugger helper links during our dl_iterate_phdr implementation, we effectively race with other threads dlclose()ing libraries while we're working. We do have a (rather involved) check in place to ensure that elf headers are readable. But it turns out in practice, some dlclose() do happen between the check and the actual read of the elf headers. Unfortunately, we can't lock the system linker while we're looping, so a better approach is to only loop through the libraries we loaded, and rely on the system dl_iterate_phdr to iterate over the (remaining) system libraries. Unfortunately (again), Android versions < 5.0 don't have a system dl_iterate_phdr, so we have to rely on the old iterator when it's not present.
ce1f9ca065cf854404d1182d311b4156fd7b08b7: Bug 1414506 - Move dl_phdr_info filling and callback invocation to a separate class. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Tue, 23 Jan 2018 15:50:38 +0900 - rev 400892
Push 99254 by dluca@mozilla.com at Fri, 26 Jan 2018 03:51:01 +0000
Bug 1414506 - Move dl_phdr_info filling and callback invocation to a separate class. r=froydnj We're going to introduce two code paths that need to fill dl_phdr_info from different iterators, so first move the code to a separate class, that both code paths will be able to call.
534f60b7cb2b41b9bc7024b34332521160054c9f: Bug 1414506 - Drive-by: Remove MOZ_CONCAT definition from mozglue/linker/Logging.h. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Fri, 19 Jan 2018 20:12:04 +0900 - rev 400891
Push 99254 by dluca@mozilla.com at Fri, 26 Jan 2018 03:51:01 +0000
Bug 1414506 - Drive-by: Remove MOZ_CONCAT definition from mozglue/linker/Logging.h. r=froydnj The same exists in mozilla/MacroArgs.h, avoiding a macro redefined warning when building on non-Android.
6d040b09b48dc9124bb2e1e885267556e5a4ae05: Bug 1414506 - Drive-by: Add missing <cstring> include to XZStream.cpp. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Fri, 19 Jan 2018 20:08:08 +0900 - rev 400890
Push 99254 by dluca@mozilla.com at Fri, 26 Jan 2018 03:51:01 +0000
Bug 1414506 - Drive-by: Add missing <cstring> include to XZStream.cpp. r=froydnj
1447c185cfb32e6e4132e38caab2d4ab88f2ed40: Bug 1260213 - enable system add-on updates for Fennec r=snorp
Robert Helmer <rhelmer@mozilla.com> - Wed, 24 Jan 2018 11:11:10 -0800 - rev 400889
Push 99254 by dluca@mozilla.com at Fri, 26 Jan 2018 03:51:01 +0000
Bug 1260213 - enable system add-on updates for Fennec r=snorp MozReview-Commit-ID: LH4oPseLBpp
6315cd6fe542c403741145e62ae87d472b213dbf: Bug 1255378 - fix getCSSValuesForProperty for box-shadow and text-shadow; r=heycam,jryans
Tom Tromey <tom@tromey.com> - Wed, 17 Jan 2018 10:34:34 -0700 - rev 400888
Push 99254 by dluca@mozilla.com at Fri, 26 Jan 2018 03:51:01 +0000
Bug 1255378 - fix getCSSValuesForProperty for box-shadow and text-shadow; r=heycam,jryans This fixes InspectorUtils.getCSSValuesForProperty to return the correct values for box-shadow and text-shadow. It also takes a small step toward the goal of getting rid of InspectorUtils.cpp:PropertySupportsVariant, in favor of having all variants listed in nsCSSPropList.h. MozReview-Commit-ID: Dwh5s0IvYTX
e0c7edf0677de0e06d0cd8622cde581f3cbdf158: Bug 1255378 - factor color lists out of expected values in test_bug877690.html; r=jryans
Tom Tromey <tom@tromey.com> - Wed, 17 Jan 2018 09:08:59 -0700 - rev 400887
Push 99254 by dluca@mozilla.com at Fri, 26 Jan 2018 03:51:01 +0000
Bug 1255378 - factor color lists out of expected values in test_bug877690.html; r=jryans This is a minor cleanup to test_bug877690.html that factors out the list of colors into a separate variable, to make future tests a bit simpler to write and understand. MozReview-Commit-ID: JkSBJQxLdxW
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip