6bad89a1756671ae8583c1c0e44b2254a13e45d1: Bug 1415780 - Call UpdateTiming() prior to remove the animtion from the timeline in Animation::CancelNoUpdate. r=birtles
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Sat, 27 Jan 2018 16:55:46 +0900 - rev 401146
Push 99303 by ccoroiu@mozilla.com at Sun, 28 Jan 2018 10:47:18 +0000
Bug 1415780 - Call UpdateTiming() prior to remove the animtion from the timeline in Animation::CancelNoUpdate. r=birtles Now AnimationEventDispatcher ensures that the refresh driver's next tick happens for cancel event, so we don't need to re-observe the timeline (it happens in UpdateTiming) once after removing the animation from the timeline. MozReview-Commit-ID: 7ivclmYIkPa
a88250ad7a3e7bd9efbe205069c794714d785206: Bug 1415780 - Let AnimationEventDispatcher observe nsRefreshDriver. r=birtles
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Sat, 27 Jan 2018 16:55:45 +0900 - rev 401145
Push 99303 by ccoroiu@mozilla.com at Sun, 28 Jan 2018 10:47:18 +0000
Bug 1415780 - Let AnimationEventDispatcher observe nsRefreshDriver. r=birtles So that we can now ensure nsRefreshDriver ticks (i.e. nsRefreshDriver doesn't stop its timer) for all queued events. Before this patch, dispatching CSS animation/transition events relied on the fact that DocumentTimeline observes nsRefreshDriver. For this fact, animationcancel or transitioncancel event did not dispatch properly in some cases, i.e. the case where the animation was dropped from the DocumentTimeline. MozReview-Commit-ID: 7JYro0MY2U2
43d42ca7308feb39b51b057625eca17a096c7f9f: Bug 1415780 - Make AnimationEventDispatcher::SortEvents() private. r=birtles
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Sat, 27 Jan 2018 16:55:45 +0900 - rev 401144
Push 99303 by ccoroiu@mozilla.com at Sun, 28 Jan 2018 10:47:18 +0000
Bug 1415780 - Make AnimationEventDispatcher::SortEvents() private. r=birtles Now we sort pending events only when dispatching the events, i.e. only inside DispatchEvent(). MozReview-Commit-ID: IRqH56BEnKb
79e980195ee82723d21f1543758ec852eaa434a5: Bug 1415780 - Let nsPresContext have AnimationEventDispatcher. r=birtles
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Sat, 27 Jan 2018 16:55:45 +0900 - rev 401143
Push 99303 by ccoroiu@mozilla.com at Sun, 28 Jan 2018 10:47:18 +0000
Bug 1415780 - Let nsPresContext have AnimationEventDispatcher. r=birtles Now we sort CSS animation/transition events by scheduled event time prior to compositor order. SortEvents() will be a private method in the next patch in this patch series. MozReview-Commit-ID: ICkOayquN0f
f0cc29e7ccd7d1b6a296d378256ba1aa38c65c30: Bug 1415780 - Make AnimationEventDispatcher refcountable. r=birtles
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Sat, 27 Jan 2018 16:55:44 +0900 - rev 401142
Push 99303 by ccoroiu@mozilla.com at Sun, 28 Jan 2018 10:47:18 +0000
Bug 1415780 - Make AnimationEventDispatcher refcountable. r=birtles In a subsequent patch in this patch series, we want to make nsPresContext have an AnimationEventDispatcher as RefPtr<>. Instead, if we were trying to make nsPresContext have the AnimationEventDispatcher as data object (not RefPtr<>) just like we did in CommonAnimationManager, we will fall into header inclusion hell since Element.h includes nsPresContext.h and AnimationEventDispatcher.h ends up including Element.h. Even if we could solve the inclusion hell, we will suffer from Rust bindgen issues for some reasons. MozReview-Commit-ID: B0nX2JzIRJD
c6567e4196f6b4e45e5119f0c6f125262b72b8fb: Bug 1415780 - De-templatize AnimationEventDispatcher. r=birtles,masayuki
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Sat, 27 Jan 2018 16:55:44 +0900 - rev 401141
Push 99303 by ccoroiu@mozilla.com at Sun, 28 Jan 2018 10:47:18 +0000
Bug 1415780 - De-templatize AnimationEventDispatcher. r=birtles,masayuki Now single AnimationEventDispatcher can handle both CSS animation/transition events simultaneously. To do this we had to change AnimationEventInfo and TransitionEventInfo into a single struct, the struct is also named AnimationEventInfo. It results we can sort both CSS animation/transition events altogether. Thus we make sure CSS animation/transition events are sorted by scheduled event time prior to their composite order (i.e. transitions is prior to animations). At this moment, we don't sort both events altogether since nsAnimationManager and nsTransitionManager has an AnimationEventDispatcher respectively. In the next patch we move AnimationEventDispatcher into nsPresContext, i.e. each document has an AnimationEventDispatcher without the distinction between CSS animations and transitions. Note that, after this patch, we copy all members in InternalTransitionEvent and InternalAnimationEvent in the copy-constructor of AnimationEventInfo, this will be fixed once WidgetEvent has move-constructor and move-assignment (bug 1433008). MozReview-Commit-ID: 5JAh6N7C6ee
ae7be65f3c88e1b46ac19a1b102726261bfdb5f5: Bug 1415780 - Split AnimationEventDipatcher into an independent file. r=birtles
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Sat, 27 Jan 2018 16:55:44 +0900 - rev 401140
Push 99303 by ccoroiu@mozilla.com at Sun, 28 Jan 2018 10:47:18 +0000
Bug 1415780 - Split AnimationEventDipatcher into an independent file. r=birtles MozReview-Commit-ID: Fcqtu7G400Z
621b9aaf4a8ffa54ca843b3b1eb6cadfaefa4dd8: Bug 1415780 - Rename DelayedEventsDispatcher to AnimationEventDispatcher. r=birtles
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Sat, 27 Jan 2018 16:55:43 +0900 - rev 401139
Push 99303 by ccoroiu@mozilla.com at Sun, 28 Jan 2018 10:47:18 +0000
Bug 1415780 - Rename DelayedEventsDispatcher to AnimationEventDispatcher. r=birtles We plan to use this class to dispatch web animation API events as well (bug 1354501). MozReview-Commit-ID: 7DMmc0aJzJ5
e298f242ce7c443ff27ce9589ad392cd95049657: Bug 1415780 - Drop the comment for nsAnimationManager::DispatchEvents(). r=birtles
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Sat, 27 Jan 2018 16:55:43 +0900 - rev 401138
Push 99303 by ccoroiu@mozilla.com at Sun, 28 Jan 2018 10:47:18 +0000
Bug 1415780 - Drop the comment for nsAnimationManager::DispatchEvents(). r=birtles The comment is no longer correct since bug 1180125. MozReview-Commit-ID: A4NWgmwAOFt
027a7ed3c94857c65bee279a3470e367fc86f987: Bug 1415780 - Move AnimationCollection::PseudoTypeAsString into nsCSSPseudoElements. r=birtles
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Sat, 27 Jan 2018 16:55:43 +0900 - rev 401137
Push 99303 by ccoroiu@mozilla.com at Sun, 28 Jan 2018 10:47:18 +0000
Bug 1415780 - Move AnimationCollection::PseudoTypeAsString into nsCSSPseudoElements. r=birtles It's not need to be a template function since the function is independent from AnimationType. MozReview-Commit-ID: 13WkRIfaQbZ
433a6f0d0ac31d9515be1e48401f378825660ef1: Bug 1415780 - Don't count all observers for nsRefreshDriver. r=smaug
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Sat, 27 Jan 2018 16:55:42 +0900 - rev 401136
Push 99303 by ccoroiu@mozilla.com at Sun, 28 Jan 2018 10:47:18 +0000
Bug 1415780 - Don't count all observers for nsRefreshDriver. r=smaug We just need information whether there is still an observer or not in most cases. The only case we need to know the count is in an assertion in the dtor of nsRefreshDriver. In the dtor we are checking there remains no observers other than early runners. Note that the order in HasObserver() was adjusted to reflect that we check boolean flag first (mViewManagerFlushIsPending) and subsequently check observer which is likey happen to. mFrameRequestCallbackDocs should have checked prior to mResizeEventFlushObservers though. MozReview-Commit-ID: E1qplusqw1Y
3eefd4e1087c7c151485379f6360a05338f8b98d: Bug 1433410 - Add codespell support for mach lint r=ahal
Sylvestre Ledru <sledru@mozilla.com> - Sat, 27 Jan 2018 10:35:31 +0100 - rev 401135
Push 99303 by ccoroiu@mozilla.com at Sun, 28 Jan 2018 10:47:18 +0000
Bug 1433410 - Add codespell support for mach lint r=ahal MozReview-Commit-ID: Ii6QjPMN0Ks
f3e76ecbd9e4422434acc5e25f363d7a35dd942a: Bug 1425559 - nsPrompter must use nsIThreadManager::spinEventLoopUntilOrShutdown, r=smaug
Andrea Marchesini <amarchesini@mozilla.com> - Sun, 28 Jan 2018 08:41:36 +0100 - rev 401134
Push 99302 by amarchesini@mozilla.com at Sun, 28 Jan 2018 07:42:00 +0000
Bug 1425559 - nsPrompter must use nsIThreadManager::spinEventLoopUntilOrShutdown, r=smaug
5a098622dab3390edbfb26fec39f8877097b4b08: Bug 1425559 - "content-child-will-shutdown" notification when the content process starts the shutting down, r=smaug
Andrea Marchesini <amarchesini@mozilla.com> - Sun, 28 Jan 2018 08:41:36 +0100 - rev 401133
Push 99302 by amarchesini@mozilla.com at Sun, 28 Jan 2018 07:42:00 +0000
Bug 1425559 - "content-child-will-shutdown" notification when the content process starts the shutting down, r=smaug
fca93197ead75feb3838a4eee57a84372706dd33: Bug 1425559 - Implement nsIThreadManager::spinEventLoopUntilOrShutdown, r=smaug
Andrea Marchesini <amarchesini@mozilla.com> - Sun, 28 Jan 2018 08:41:36 +0100 - rev 401132
Push 99302 by amarchesini@mozilla.com at Sun, 28 Jan 2018 07:42:00 +0000
Bug 1425559 - Implement nsIThreadManager::spinEventLoopUntilOrShutdown, r=smaug Currently nsIThreadManager::spinEventLoopUntil doesn't monitor the shutting down. Firefox shutting down can be blocked by a 'broken' use of nsIThreadManager::spinEventLoopUntil. nsIThreadManager::spinEventLoopUntilOrShutdown should be used instead.
e665f877a17a6018113e8f25bc4e24a197243cb9: Bug 1415563 - Use the correct app units conversion for nsDisplayZoom items. r=kats
Ethan Lin <ethlin@mozilla.com> - Wed, 17 Jan 2018 10:22:39 +0800 - rev 401131
Push 99301 by kgupta@mozilla.com at Sun, 28 Jan 2018 05:57:39 +0000
Bug 1415563 - Use the correct app units conversion for nsDisplayZoom items. r=kats MozReview-Commit-ID: 9Ml3mOFmooi
3f4f6cb852a490f38a24772c08e03cab4d50222b: Bug 1428170 - Update Codemirror to 5.33.0. r=bgrins
Gabriel Luong <gabriel.luong@gmail.com> - Sun, 28 Jan 2018 00:04:37 -0500 - rev 401130
Push 99300 by gabriel.luong@gmail.com at Sun, 28 Jan 2018 05:05:05 +0000
Bug 1428170 - Update Codemirror to 5.33.0. r=bgrins
7d33cca73ff0b808eacc100d5101b3cd53231309: Bug 685236 - Workaround Skia file path issue. r=jwatt
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Sun, 17 Dec 2017 00:19:51 +0900 - rev 401129
Push 99299 by VYV03354@nifty.ne.jp at Sun, 28 Jan 2018 02:50:48 +0000
Bug 685236 - Workaround Skia file path issue. r=jwatt MozReview-Commit-ID: 7y3tNuOtWCv
e734b0be9a1c801e084658323d3df6363dd3027d: Bug 685236 - Workaround for WebRTC. r=jesup
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Fri, 15 Dec 2017 21:42:49 +0900 - rev 401128
Push 99299 by VYV03354@nifty.ne.jp at Sun, 28 Jan 2018 02:50:48 +0000
Bug 685236 - Workaround for WebRTC. r=jesup MozReview-Commit-ID: 8gdmPmF4V4b
6764713f1dea1dc453c9e395a4f5f3a6da30040f: Bug 685236 - Stop using GetNativePath in PSM. r=keeler
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Sun, 17 Dec 2017 01:24:44 +0900 - rev 401127
Push 99299 by VYV03354@nifty.ne.jp at Sun, 28 Jan 2018 02:50:48 +0000
Bug 685236 - Stop using GetNativePath in PSM. r=keeler GetPersistentDescriptor is good enough for logging purpose. MozReview-Commit-ID: DmyW4lT5rT7
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip