660bf8b6a9ad1810c5eddd34810860de8a82d0ef: Bug 1019191 part 21. Change xpc_qsUnwrapArgImpl and UnwrapArg to take a HandleObject, not a HandleValue. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 22 Oct 2014 11:40:50 -0400 - rev 211736
Push 50791 by bzbarsky@mozilla.com at Wed, 22 Oct 2014 15:41:03 +0000
Bug 1019191 part 21. Change xpc_qsUnwrapArgImpl and UnwrapArg to take a HandleObject, not a HandleValue. r=peterv
7cb6ab1525b28ad1ee4825013084f1d6889f0e72: Bug 1019191 part 20. Replace the getWrapper/castNative stuff in XPCQuickStubs with what I believe is a single function call that's equivalent to it, since the tearoff bit was dead code anyway due to never resetting clasp. r=peterv,bholley
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 22 Oct 2014 11:40:50 -0400 - rev 211735
Push 50791 by bzbarsky@mozilla.com at Wed, 22 Oct 2014 15:41:03 +0000
Bug 1019191 part 20. Replace the getWrapper/castNative stuff in XPCQuickStubs with what I believe is a single function call that's equivalent to it, since the tearoff bit was dead code anyway due to never resetting clasp. r=peterv,bholley
7535aa66fec1aef6f68278e6578e93edf25eaae1: Bug 1019191 part 19. Change GlobalObject::GetAsSupports to not rely on UnwrapArg producing an nsISupports for non-reflectors. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 22 Oct 2014 11:40:50 -0400 - rev 211734
Push 50791 by bzbarsky@mozilla.com at Wed, 22 Oct 2014 15:41:03 +0000
Bug 1019191 part 19. Change GlobalObject::GetAsSupports to not rely on UnwrapArg producing an nsISupports for non-reflectors. r=peterv
e1c5a9cfd0c7ef0b0fa7f8a00582a4fbdbb26a08: Bug 1019191 part 18. Remove the unused tearoff bits in quickstub unwrapping. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 22 Oct 2014 11:40:50 -0400 - rev 211733
Push 50791 by bzbarsky@mozilla.com at Wed, 22 Oct 2014 15:41:03 +0000
Bug 1019191 part 18. Remove the unused tearoff bits in quickstub unwrapping. r=peterv
5b146182cda998748a5fff4c7da5f815de14a2f9: Bug 1019191 part 17. Make some of the remaining quickstub unwrap methods static. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 22 Oct 2014 11:40:50 -0400 - rev 211732
Push 50791 by bzbarsky@mozilla.com at Wed, 22 Oct 2014 15:41:03 +0000
Bug 1019191 part 17. Make some of the remaining quickstub unwrap methods static. r=peterv Note that we know that we always call UnwrapArg with an object, so xpc_qsUnwrapArgImpl knows v is always an object.
99b3f0919b5d5c88606bd1a1d7127d2e8135178b: Bug 1019191 part 16. Remove nsDOMQS.h. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 22 Oct 2014 11:40:49 -0400 - rev 211731
Push 50791 by bzbarsky@mozilla.com at Wed, 22 Oct 2014 15:41:03 +0000
Bug 1019191 part 16. Remove nsDOMQS.h. r=peterv
933bbcafc8e634e9dfacf244c32c4fdbf9abfe49: Bug 1019191 part 15. Remove now-dead DOMCI_DATA bits. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 22 Oct 2014 11:40:49 -0400 - rev 211730
Push 50791 by bzbarsky@mozilla.com at Wed, 22 Oct 2014 15:41:03 +0000
Bug 1019191 part 15. Remove now-dead DOMCI_DATA bits. r=peterv
593ede2c00382a5bbbf5981cda18184093df771b: Bug 1019191 part 14. Remove the now-unused HasBitInInterfacesBitmap and all the interfaces bitmap machinery that ends up unused as a result. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 22 Oct 2014 11:40:49 -0400 - rev 211729
Push 50791 by bzbarsky@mozilla.com at Wed, 22 Oct 2014 15:41:03 +0000
Bug 1019191 part 14. Remove the now-unused HasBitInInterfacesBitmap and all the interfaces bitmap machinery that ends up unused as a result. r=peterv
63d3d488d188de36a4e66cf8db8c8c5b502b0f02: Bug 1019191 part 13. Remove the now-unused castNativeArgFromWrapper and castNativeFromWrapper functions. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 22 Oct 2014 11:40:49 -0400 - rev 211728
Push 50791 by bzbarsky@mozilla.com at Wed, 22 Oct 2014 15:41:03 +0000
Bug 1019191 part 13. Remove the now-unused castNativeArgFromWrapper and castNativeFromWrapper functions. r=peterv
28abe750b8ef6a3d2f5f1643554045ecd8a18a01: Bug 1019191 part 12. Eliminate some unused UnwrapArg specializations. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 22 Oct 2014 11:40:48 -0400 - rev 211727
Push 50791 by bzbarsky@mozilla.com at Wed, 22 Oct 2014 15:41:03 +0000
Bug 1019191 part 12. Eliminate some unused UnwrapArg specializations. r=peterv The following command: grep -Ir "UnwrapArg<" $srcdir/* $objdir/dom/bindings/ | sed 's/^[^<]*<//' | sed 's/>.*//' | sort -u (with $srcdir and $objdir replaced by the relevant paths) produces this list: ${type} _clazz _interface imgINotificationObserver imgIRequest mozilla::dom::EventTarget mozilla::dom::IndirectlyImplementedInterface mozilla::dom::TestExternalInterface nsGenericHTMLElement nsIBrowserDOMWindow nsIChannel nsIDOMCSSRule nsIDOMDataChannel nsIDOMMozMmsMessage nsIDOMMozSmsMessage nsIDOMMozWakeLockListener nsIDOMWindow nsIDOMXPathNSResolver nsIFile nsIFrameRequestCallback nsIInputStream nsIInputStreamCallback nsIJSID nsIMenuBuilder nsIObserver nsIOutputStream nsIPrincipal nsISelectionListener nsISupports nsITreeView nsIURI The ${type} bit is part of codegen. The _clazz and _interface bits are the macros in js/xpconnect/src/nsDOMQS.h that are defining UnwrapArg methods. The nsGenericHTMLElement is only used in xpc_qsUnwrapArg_HTMLElement. Inspection of the above list indicates that none of the classes used with DEFINE_UNWRAP_CAST_HTML are in it, so all those specializations of UnwrapArg, and the xpc_qsUnwrapArg_HTMLElement method they call, are dead code. Moreover, almost all the specializations set up by DEFINE_UNWRAP_CAST are dead code as well; the only exception is the one for mozilla::dom::EventTarget. But since we no longer use Web IDL quickstubs for EventTarget, that one is only used in a few places for method arguments, and none of those should have our one remaining webidl event target passed to them. So it's safe to remove that specialization as well.
649e33dfabd6f8fb975e0766515761c28a739542: Bug 1019191 part 11. Get rid of the now-unused xpc_qsUnwrapArg. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 22 Oct 2014 11:40:48 -0400 - rev 211726
Push 50791 by bzbarsky@mozilla.com at Wed, 22 Oct 2014 15:41:03 +0000
Bug 1019191 part 11. Get rid of the now-unused xpc_qsUnwrapArg. r=peterv
e4df8d92d4f310ec892a455a1831807b0b4d02ca: Bug 1019191 part 10. Stop using xpc_qsUnwrapArg directly in BindingUtils. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 22 Oct 2014 11:40:48 -0400 - rev 211725
Push 50791 by bzbarsky@mozilla.com at Wed, 22 Oct 2014 15:41:03 +0000
Bug 1019191 part 10. Stop using xpc_qsUnwrapArg directly in BindingUtils. r=peterv
d518efb791ac39eb99a5f6b4d035cf312132ab9e: Bug 1019191 part 9. Remove now-dead JS-to-C++ quickstub conversion functions. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 22 Oct 2014 11:40:48 -0400 - rev 211724
Push 50791 by bzbarsky@mozilla.com at Wed, 22 Oct 2014 15:41:03 +0000
Bug 1019191 part 9. Remove now-dead JS-to-C++ quickstub conversion functions. r=peterv
13192ac3910b38b5e173536c6db0be55ec017e23: Bug 1019191 part 8. Stop using xpc_qsACString in XPConnect. r=bholley
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 22 Oct 2014 11:40:48 -0400 - rev 211723
Push 50791 by bzbarsky@mozilla.com at Wed, 22 Oct 2014 15:41:03 +0000
Bug 1019191 part 8. Stop using xpc_qsACString in XPConnect. r=bholley
307ce2aad8815f30c0b71be6fffab786729e114d: Bug 1019191 part 7. Remove various dead-code throwing functions. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 22 Oct 2014 11:40:47 -0400 - rev 211722
Push 50791 by bzbarsky@mozilla.com at Wed, 22 Oct 2014 15:41:03 +0000
Bug 1019191 part 7. Remove various dead-code throwing functions. r=peterv
dc58260747f933c29530c56f8323c084a4a21e90: Bug 1019191 part 6. Remove dead code for setting up quickstubs on a prototype from XPCQuickStubs.h/cpp. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 22 Oct 2014 11:40:47 -0400 - rev 211721
Push 50791 by bzbarsky@mozilla.com at Wed, 22 Oct 2014 15:41:03 +0000
Bug 1019191 part 6. Remove dead code for setting up quickstubs on a prototype from XPCQuickStubs.h/cpp. r=peterv
c74d9fc161ca2baee50b8a0ea3f407a970329ef7: Bug 1019191 part 5. Remove the one remaining quickstub we have and all quickstub codegen. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 22 Oct 2014 11:40:47 -0400 - rev 211720
Push 50791 by bzbarsky@mozilla.com at Wed, 22 Oct 2014 15:41:03 +0000
Bug 1019191 part 5. Remove the one remaining quickstub we have and all quickstub codegen. r=peterv
634e4ac7bc3b4e991d471d49358896711a9cd570: Bug 1019191 part 4. Remove the now-dead xpc_qsThrowGetterSetterFailed and xpc_qsThrowBadSetterValue functions. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 22 Oct 2014 11:40:47 -0400 - rev 211719
Push 50791 by bzbarsky@mozilla.com at Wed, 22 Oct 2014 15:41:03 +0000
Bug 1019191 part 4. Remove the now-dead xpc_qsThrowGetterSetterFailed and xpc_qsThrowBadSetterValue functions. r=peterv
915c98bbdbaa9026e4ecc7c5436dbc7b983d4355: Bug 1019191 part 3. Remove calls to the empty DOM_MarkInterfaces/DOM_ClearInterfaces/DOM_InitInterfaces functions and the functions themselves. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 22 Oct 2014 11:40:47 -0400 - rev 211718
Push 50791 by bzbarsky@mozilla.com at Wed, 22 Oct 2014 15:41:03 +0000
Bug 1019191 part 3. Remove calls to the empty DOM_MarkInterfaces/DOM_ClearInterfaces/DOM_InitInterfaces functions and the functions themselves. r=peterv
3fca92cc722964ba22703ca5515b4fea92982b2b: Bug 1019191 part 2. Remove WebIDL quickstubs for EventTarget, since the only remaining xpconnect EventTargets with classinfo are globals, and we never call PostCreatePrototype on globals. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 22 Oct 2014 11:40:46 -0400 - rev 211717
Push 50791 by bzbarsky@mozilla.com at Wed, 22 Oct 2014 15:41:03 +0000
Bug 1019191 part 2. Remove WebIDL quickstubs for EventTarget, since the only remaining xpconnect EventTargets with classinfo are globals, and we never call PostCreatePrototype on globals. r=peterv
(0) -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip