63f04e426fdae72b049d345f2434dadd478ee2e9: Bug 979557: CanAnimatePropertyOnCompositor should return early when there's no OMT compositing, whether or not logging is enabled. r=dzbarsky
L. David Baron <dbaron@dbaron.org> - Tue, 04 Mar 2014 20:13:22 -0800 - rev 171858
Push 40599 by dbaron@mozilla.com at Wed, 05 Mar 2014 04:13:57 +0000
Bug 979557: CanAnimatePropertyOnCompositor should return early when there's no OMT compositing, whether or not logging is enabled. r=dzbarsky This shouldn't behave differently depending on whether or not logging is enabled; that difference was introduced in bug 785648.
447343d88656aed33db076b1dd637c5e412d14e1: Bug 979555: Add default value for layers.offmainthreadcomposition.log-animations preference to all.js. r=dzbarsky
L. David Baron <dbaron@dbaron.org> - Tue, 04 Mar 2014 20:13:22 -0800 - rev 171857
Push 40599 by dbaron@mozilla.com at Wed, 05 Mar 2014 04:13:57 +0000
Bug 979555: Add default value for layers.offmainthreadcomposition.log-animations preference to all.js. r=dzbarsky It's good practice to have default values for all preferences in all.js. Otherwise some preference APIs throw exceptions and/or leave values uninitialized. It also makes the preference show up in about:config. Bug 875204 accidentally removed this line from all.js even though the pref was not removed. (The pref was initially added in bug 780342.)
55fa3c2f32aa87df79efdd5413c14510c7f6edb2: Bug 828173 patch 6: Remove calls to ForceLayerRerendering from the miniflush code (UpdateThrottledStyles, which flushes animations whose main thread updates are throttled without updating any other styles). r=mattwoodrow
L. David Baron <dbaron@dbaron.org> - Tue, 04 Mar 2014 20:13:22 -0800 - rev 171856
Push 40599 by dbaron@mozilla.com at Wed, 05 Mar 2014 04:13:57 +0000
Bug 828173 patch 6: Remove calls to ForceLayerRerendering from the miniflush code (UpdateThrottledStyles, which flushes animations whose main thread updates are throttled without updating any other styles). r=mattwoodrow I've been wanting to remove this code for a while. I think this code is problematic for three reasons: (1) It's in the middle of code where it doesn't belong, and which ought to be handling purely-style-system things. (This is blocking me from reusing that code elsewhere, e.g., in bug 977991 and bug 960465, both of which could use it in some form.) (2) It defeats the optimization from bug 790505 whenever we do a miniflush (in other words, whenever we have any style change, whether or not it's related) (3) It means the conditions for when we decide to ship a new set of animation data to a layer doesn't cover all the cases the layer needs it. In particular, we only run this miniflush code when we have a currently running animation or transition that's running on the compositor thread. On the other hand, the UpdateTransformLayer style change handling in DoApplyRenderingChangeToTree depends on whether the frame currently has a transform layer, which can continue to be true for a bit after the animation stops. So if we need to send animations to the layer because of a transform style change that happens soon after an animation completes, our style change handling will find the existing layer and call its SetBaseTransformForNextTransaction method but never do anything that triggers layer construction. The style throttling code, in turn, will never stop doing main thread updates because the animation generation on the layer is out-of-date, and these main thread updates will keep the layer active, but they'll never show up because the stale animation data overrides the new transform that we've been setting. (At least, I think that's what was happening; it makes sense to me and matches the behavior I was observing. I didn't verify which main thread updates and which layer updates were actually happening, though.) This shows up, for example, in the animation in attachment 8384813 just halting at a corner if I'm careful not to disturb it. (I'm testing on Linux, with both accelerated layers and OMT animations explicitly enabled.) I think there are probably some other things that can be removed as followups to removing this code, because I think we made some boundary conditions intentionally incorrect so that problem (3) above wouldn't be as bad as it otherwise would have been.
7d436b8eeddadb3101d3fa3f21290ee7242c5d7f: Bug 828173 patch 5: Call AddAnimationsAndTransitionsToLayer when we choose not to repaint when handling an UpdateTransformLayer hint, so that any new animations resulting from the style change get sent to the layer. r=mattwoodrow
L. David Baron <dbaron@dbaron.org> - Tue, 04 Mar 2014 20:13:22 -0800 - rev 171855
Push 40599 by dbaron@mozilla.com at Wed, 05 Mar 2014 04:13:57 +0000
Bug 828173 patch 5: Call AddAnimationsAndTransitionsToLayer when we choose not to repaint when handling an UpdateTransformLayer hint, so that any new animations resulting from the style change get sent to the layer. r=mattwoodrow
4055be226e07e69c17a0b98178de4b4cc017190b: Bug 828173 patch 4: Expose AddAnimationsAndTransitionsToLayer and allow it to be called from style change handling. r=mattwoodrow
L. David Baron <dbaron@dbaron.org> - Tue, 04 Mar 2014 20:13:21 -0800 - rev 171854
Push 40599 by dbaron@mozilla.com at Wed, 05 Mar 2014 04:13:57 +0000
Bug 828173 patch 4: Expose AddAnimationsAndTransitionsToLayer and allow it to be called from style change handling. r=mattwoodrow
8d766ce8ba363779de099f00fce7b66c57390b36: Bug 828173 patch 3.5: Move GetTransformRootFrame to nsLayoutUtils. r=mattwoodrow
L. David Baron <dbaron@dbaron.org> - Tue, 04 Mar 2014 20:13:21 -0800 - rev 171853
Push 40599 by dbaron@mozilla.com at Wed, 05 Mar 2014 04:13:57 +0000
Bug 828173 patch 3.5: Move GetTransformRootFrame to nsLayoutUtils. r=mattwoodrow
2cd385901f970e4c9ae8280ae5a1b40682cdd3ce: Bug 828173 patch 3: Add a concept of pending animations to Layer, like pending transform. r=mattwoodrow
L. David Baron <dbaron@dbaron.org> - Tue, 04 Mar 2014 20:13:21 -0800 - rev 171852
Push 40599 by dbaron@mozilla.com at Wed, 05 Mar 2014 04:13:57 +0000
Bug 828173 patch 3: Add a concept of pending animations to Layer, like pending transform. r=mattwoodrow
b999b6e2ccaba1bf9dafb6b6aa408512481a5c51: Bug 828173 patch 2: Make Layer::AddAnimation have the caller fill in the data instead of taking parameters. r=mattwoodrow
L. David Baron <dbaron@dbaron.org> - Tue, 04 Mar 2014 20:13:21 -0800 - rev 171851
Push 40599 by dbaron@mozilla.com at Wed, 05 Mar 2014 04:13:57 +0000
Bug 828173 patch 2: Make Layer::AddAnimation have the caller fill in the data instead of taking parameters. r=mattwoodrow (This is a bigger simplification later in the patch queue, when I add a variant of AddAnimation called AddAnimationForNextTransaction.)
8bf28c8a36130580550dd299690c8940b1d8f614: Bug 828173 patch 1: Add nsLayoutUtils::GetReferenceFrame. r=mattwoodrow
L. David Baron <dbaron@dbaron.org> - Tue, 04 Mar 2014 20:13:21 -0800 - rev 171850
Push 40599 by dbaron@mozilla.com at Wed, 05 Mar 2014 04:13:57 +0000
Bug 828173 patch 1: Add nsLayoutUtils::GetReferenceFrame. r=mattwoodrow
acabb39782ef80093db8d79bf44322fc7b2f0836: Bug 978903: Fix some uninitialized variable warnings in the CSS parser. r=heycam
L. David Baron <dbaron@dbaron.org> - Tue, 04 Mar 2014 20:13:20 -0800 - rev 171849
Push 40599 by dbaron@mozilla.com at Wed, 05 Mar 2014 04:13:57 +0000
Bug 978903: Fix some uninitialized variable warnings in the CSS parser. r=heycam The first provides a reasonable default (failure to parse) for the case of an unknown value type (which should never happen). The second reorders two failure checks so that the one that returns early when units is uninitialized happens before the one that looks at units.
1a34a6a07d711c3722146962871642887765d81b: Bug 978648: Handle dynamic changes to @keyframes rules and keyframe rules better. r=heycam
L. David Baron <dbaron@dbaron.org> - Tue, 04 Mar 2014 20:13:20 -0800 - rev 171848
Push 40599 by dbaron@mozilla.com at Wed, 05 Mar 2014 04:13:57 +0000
Bug 978648: Handle dynamic changes to @keyframes rules and keyframe rules better. r=heycam
50462316925c11b17422d227183075a64942d0e4: Bug 621618 patch 4: Make conditions in Element::RemoveFromIdTable match those in AddToIdTable, to avoid asymmetric calls to the document's functions. r=bzbarsky
L. David Baron <dbaron@dbaron.org> - Tue, 04 Mar 2014 20:13:20 -0800 - rev 171847
Push 40599 by dbaron@mozilla.com at Wed, 05 Mar 2014 04:13:57 +0000
Bug 621618 patch 4: Make conditions in Element::RemoveFromIdTable match those in AddToIdTable, to avoid asymmetric calls to the document's functions. r=bzbarsky
90990d488dccf970bdffd0b50953f0a177322099: Bug 621618 patch 3: Add FIXMEs in nsXULDocument for ID handling. r=bzbarsky
L. David Baron <dbaron@dbaron.org> - Tue, 04 Mar 2014 20:13:20 -0800 - rev 171846
Push 40599 by dbaron@mozilla.com at Wed, 05 Mar 2014 04:13:57 +0000
Bug 621618 patch 3: Add FIXMEs in nsXULDocument for ID handling. r=bzbarsky
5bd1a27cf9e687a316f15b9ee8970671abda57f9: Bug 621618 patch 2: Make nsXMLElement reuse Element::AddToIdTable and Element::RemoveFromIdTable thoroughly. r=bzbarsky
L. David Baron <dbaron@dbaron.org> - Tue, 04 Mar 2014 20:13:20 -0800 - rev 171845
Push 40599 by dbaron@mozilla.com at Wed, 05 Mar 2014 04:13:57 +0000
Bug 621618 patch 2: Make nsXMLElement reuse Element::AddToIdTable and Element::RemoveFromIdTable thoroughly. r=bzbarsky
57d5722c785b48da73996037d927374ab73fba25: Bug 621618 patch 1: Remove BindToTree overrides in nsXMLElement that exist only to make AddToIdTable/RemoveFromIdTable calls already in the base class (Element). r=bzbarsky
L. David Baron <dbaron@dbaron.org> - Tue, 04 Mar 2014 20:13:20 -0800 - rev 171844
Push 40599 by dbaron@mozilla.com at Wed, 05 Mar 2014 04:13:57 +0000
Bug 621618 patch 1: Remove BindToTree overrides in nsXMLElement that exist only to make AddToIdTable/RemoveFromIdTable calls already in the base class (Element). r=bzbarsky I think this could have been done as part of Bug 700981 part 2, which moved AddToIdTable and RemoveFromIdTable calls from nsStyledElement to nsGenericElement.
72f8a731fc2ea6287ec5b724a65d3952abda7289: Bug 976777: Truncate long source lines in script errors before sending them to the parent process. r=bent
L. David Baron <dbaron@dbaron.org> - Tue, 04 Mar 2014 20:13:19 -0800 - rev 171843
Push 40599 by dbaron@mozilla.com at Wed, 05 Mar 2014 04:13:57 +0000
Bug 976777: Truncate long source lines in script errors before sending them to the parent process. r=bent This fixes an out-of-memory foreground-tab crash that I could reliably reproduce on a 256MB Firefox OS phone, and I think also significantly reduces the number of background tabs I'm seeing killed due to low memory.
9e087156c289631a1ac048dd4b047b0ea2ea092a: Fix merge error between bug 872273 (changeset 46df3fd9b0dc) and bug 946065 (changeset 243259fda9ab) and move this test to the directory where it's listed in mochitest.ini so it will actually be run. No review.
L. David Baron <dbaron@dbaron.org> - Tue, 04 Mar 2014 20:13:19 -0800 - rev 171842
Push 40599 by dbaron@mozilla.com at Wed, 05 Mar 2014 04:13:57 +0000
Fix merge error between bug 872273 (changeset 46df3fd9b0dc) and bug 946065 (changeset 243259fda9ab) and move this test to the directory where it's listed in mochitest.ini so it will actually be run. No review. Bug 979640 is filed on making this mistake harder.
e2db166682ac10bd74e5f1ee67994211443703d1: Bug 800200: Print a deprecation warning to the console when JSD is first used. r=bholley
Jim Blandy <jimb@mozilla.com> - Tue, 04 Mar 2014 20:09:15 -0800 - rev 171841
Push 40598 by jblandy@mozilla.com at Wed, 05 Mar 2014 04:09:36 +0000
Bug 800200: Print a deprecation warning to the console when JSD is first used. r=bholley
adcb1acfc475488fa8a42242b9f441536b30d57e: Bug 979100 - Refactor MediaSource's EndOfStream. r=cajbir
Matthew Gregan <kinetik@flim.org> - Wed, 05 Mar 2014 16:35:47 +1300 - rev 171840
Push 40597 by mgregan@mozilla.com at Wed, 05 Mar 2014 03:36:06 +0000
Bug 979100 - Refactor MediaSource's EndOfStream. r=cajbir
0e26bd5d0ac5685177a61d6f2bb6bba23a428bba: Bug 979099 - Refactor MediaSource's IsTypeSupported. r=cajbir
Matthew Gregan <kinetik@flim.org> - Wed, 05 Mar 2014 16:35:47 +1300 - rev 171839
Push 40597 by mgregan@mozilla.com at Wed, 05 Mar 2014 03:36:06 +0000
Bug 979099 - Refactor MediaSource's IsTypeSupported. r=cajbir
(0) -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip