Bug 1490240 - Fix the remaining compiler warnings in the crash reporter r=ted,glandium Differential Revision: https://phabricator.services.mozilla.com/D5741

Bug 1405235 - Part 2: Show USB devices using SidebarItem. r=jdescottes Depends on D5647 Differential Revision: https://phabricator.services.mozilla.com/D5648

Bug 1405235 - Part 1: Implement a mechanism to show USB devices. r=jdescottes Depends on D5386 Differential Revision: https://phabricator.services.mozilla.com/D5647

Bug 1491609 - Update common.inc.css checkbox and radio styling. r=jaws,k88hudson Differential Revision: https://phabricator.services.mozilla.com/D5983

Bug 1492576 - If no protection is enabled, don't offer the user the ability to disable protection or report a problem. r=Ehsan Differential Revision: https://phabricator.services.mozilla.com/D6408

Bug 1479232 - Only use one matcher for varDecl and parmVarDecl r=andi ParmVarDecl being a subclass of VarDecl, using two matchers then caused ScopeChecker::check to be called twice for ParmVarDecl nodes, once for each match. But the code in ScopeCheck::check is written with the assumption that it's called only once for such nodes. Somehow, this didn't cause problems with clang up to version 6, but makes the plugin spuriously warn about already_AddRefed not being used as temporaries when used as argument in function declarations, with clang 7. Differential Revision: https://phabricator.services.mozilla.com/D6360

Bug 1493017 - Tweak vscode tasks.json problemMatcher regexes to handle clang/Windows output - r=jya The original regex could match linux&mac outputs that look like: `/[...]/ffmpeg/FFmpegVideoDecoder.cpp:315:6: error: expected expression` However on Windows the same outputs have a different line&column format: `c:/[...]/ffmpeg/FFmpegVideoDecoder.cpp(315,7): error: expected expression` Differential Revision: https://phabricator.services.mozilla.com/D6442

Merge mozilla-central to autoland

Backed out 9 changesets (bug 1485676)for perma failures in devtools/client/canvasdebugger/test/browser_canvas-actor-test-01.js CLOSED TREE Backed out changeset 9f5ec2aa7109 (bug 1485676) Backed out changeset 0d530c1316a4 (bug 1485676) Backed out changeset 03278e6fe685 (bug 1485676) Backed out changeset 275463260056 (bug 1485676) Backed out changeset 4c5a956b33f7 (bug 1485676) Backed out changeset d8fe80bb0e3c (bug 1485676) Backed out changeset 56240996921f (bug 1485676) Backed out changeset ec0a322f5cc9 (bug 1485676) Backed out changeset f0f4f9407970 (bug 1485676)

Bug 1492724 - Add ADBScanner once after the extension is installed or is ready. r=jdescottes And remove the ADBScanner once the extension is uninstalled. When RuntimeScanners.add is called for ADBScanner, RuntimeScanner calls ADBScanner.enable(), thus ADB.start() is called. Meanwhile WebIDE installs the devtools adb extension if the extension hasn't installed yet. So if the ADB.start() is called before the installation finishes, ADB.start() fails. Differential Revision: https://phabricator.services.mozilla.com/D6466

Bug 1485676 - Rename DebuggerClient.attachTab to attachTarget. r=jdescottes This method isn't specific to tabs. It can attach to any "target" actor that inherits from BrowsingContextActor. Depends On D6161 Differential Revision: https://phabricator.services.mozilla.com/D6162

Bug 1485676 - Rename TabTarget.makeRemote to TabTarget.attach. r=jdescottes Now that all the "remoting" of this method has been moved to TargetFactory.createTargetForTab, we should rename this method to what it does now. It mostly call attach requests of the target actor and its child console actor. It also "connect" the webextension target actor, but I would like to eventually move that outside of TabTarget.attach, like makeRemote. Depends On D4078 Differential Revision: https://phabricator.services.mozilla.com/D6161

Bug 1485676 - Connect to local server from TargetFactory.forTab and make TabTarget always remote-like. r=yulia Differential Revision: https://phabricator.services.mozilla.com/D4078

Bug 1485676 - Adapt gDevTools API to new async forTab and also adapt its callsites. r=yulia When switching to async, it is important to catch exception or register a rejection handler so that errors keep being logged. So in this patch I'm catching exception in a couple of important codepath. Depends On D4541 Differential Revision: https://phabricator.services.mozilla.com/D4542

Bug 1485676 - Prevent exceptions in the emulation actor when trying to use it while it is already destroyed. r=yulia Depends On D4540 Differential Revision: https://phabricator.services.mozilla.com/D4541

Bug 1485676 - Tweak RDM manage to support new async forTab. r=yulia Fetching any target is now asynchronous. But RDM setup/destroy codepath is very fragile and introduce many low level exception when trying to restore the original browser element if any timing changes. So this patch prevents trying to fetch the target object if a toolbox isn't already opened. The target object is being used only for Telemetry purpose for now. Depends On D4538 Differential Revision: https://phabricator.services.mozilla.com/D4540

Bug 1485676 - Adapt gDevTools.createTargetForTab to new TabTarget class. r=yulia Depends On D4536 Differential Revision: https://phabricator.services.mozilla.com/D4537

Bug 1485676 - Convert TargetFactory.forTab call to forRemoteTab in debugger mochitest. r=yulia We are not passing a tab here. It only works by chance! Depends On D4535 Differential Revision: https://phabricator.services.mozilla.com/D4536

Bug 1485676 - Refactor gDevTools.getTargetForTab callsites to assume getTargetForTab is async. r=yulia Differential Revision: https://phabricator.services.mozilla.com/D4535

Bug 1492770 - Activate google-* checkers that make sense to our code. r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D6391