559ca369351e0d615df3c2f1c270838c8a442561: Bug 1371882 - MediaCache is now ref-counted - r=cpearce
Gerald Squelart <gsquelart@mozilla.com> - Thu, 15 Jun 2017 15:02:25 +1200 - rev 364307
Push 91515 by archaeopteryx@coole-files.de at Fri, 16 Jun 2017 07:52:51 +0000
Bug 1371882 - MediaCache is now ref-counted - r=cpearce MediaCacheStreams have owning shared pointers to their MediaCache, and a MediaCache owns itself while an update is in flight. A non-owning pointer `gMediaCache` is only used by GetMediaCache and ~MediaCache to manage the one file-backed MediaCache. MozReview-Commit-ID: AQHuXWGrKt6
221b43eb5511d803e55ed11343a8d11aaf373fbd: Bug 1371882 - Remove MediaBlockCacheBase::Close() - r=cpearce
Gerald Squelart <gsquelart@mozilla.com> - Thu, 15 Jun 2017 14:10:05 +1200 - rev 364306
Push 91515 by archaeopteryx@coole-files.de at Fri, 16 Jun 2017 07:52:51 +0000
Bug 1371882 - Remove MediaBlockCacheBase::Close() - r=cpearce The only external use of Close was always followed by an implicit destruction (by resetting the RefPtr), so we don't need to expose it, and it can be done from the destructor. FileBlockCache keeps its Close() function for internal use. Also, FileBlockCache::mIsOpen is redundant, as it's true iff mThread is not null. MozReview-Commit-ID: LV7YVrwJvGG
fe82587013c0113e8a7e4791d2176b002b9fa8f4: Bug 1371882 - Avoid MemoryBlockCache when combined sizes > 'media.memory_caches_combined_limit_...' - r=cpearce
Gerald Squelart <gsquelart@mozilla.com> - Mon, 12 Jun 2017 15:42:26 +1200 - rev 364305
Push 91515 by archaeopteryx@coole-files.de at Fri, 16 Jun 2017 07:52:51 +0000
Bug 1371882 - Avoid MemoryBlockCache when combined sizes > 'media.memory_caches_combined_limit_...' - r=cpearce Don't go over the lowest of 'media.memory_caches_combined_limit_kb' (kilobytes) or 'media.memory_caches_combined_limit_pc_sysmem' (percents of system memory). Added more logging around creation/destruction of MediaCaches. MozReview-Commit-ID: Cdz4ycyn1RR
da3bfbe8e711b5c6c8fddf65c92fb2d9bfb6ac17: Bug 1371882 - MediaCache uses MemoryBlockCache when content length is known - r=cpearce
Gerald Squelart <gsquelart@mozilla.com> - Fri, 09 Jun 2017 18:56:34 +1200 - rev 364304
Push 91515 by archaeopteryx@coole-files.de at Fri, 16 Jun 2017 07:52:51 +0000
Bug 1371882 - MediaCache uses MemoryBlockCache when content length is known - r=cpearce MozReview-Commit-ID: 35A4Vc95NtB
77af7cf044e9d6c05b3c4a22e0686d176c483e76: Bug 1371882 - MEMORYBLOCKCACHE_ERRORS telemetry to catch unexpected errors without crashing - r=cpearce,francois
Gerald Squelart <gsquelart@mozilla.com> - Mon, 12 Jun 2017 16:22:28 +1200 - rev 364303
Push 91515 by archaeopteryx@coole-files.de at Fri, 16 Jun 2017 07:52:51 +0000
Bug 1371882 - MEMORYBLOCKCACHE_ERRORS telemetry to catch unexpected errors without crashing - r=cpearce,francois No errors are expected to happen in MemoryBlockCache (except a few 'InitAllocation', which would still be good to know about), but instead of taking drastic measures in these cases (i.e., crash), I would prefer to collect some telemetry first. MozReview-Commit-ID: 4WdFS34lgzj
782b764e00e712cf637ed7800514c48e9cfc1974: Bug 1371882 - Implement MemoryBlockCache - r=cpearce
Gerald Squelart <gsquelart@mozilla.com> - Fri, 09 Jun 2017 15:37:23 +1200 - rev 364302
Push 91515 by archaeopteryx@coole-files.de at Fri, 16 Jun 2017 07:52:51 +0000
Bug 1371882 - Implement MemoryBlockCache - r=cpearce Memory-backed block cache. At initialization, allocates memory needed to store the expected content length. If MediaCache attempts to write/move beyond the expected size, we grow the buffer accordingly, as we cannot fully trust HTTP headers. (Future patch will ensure we put a limit to this growth.) MozReview-Commit-ID: GHxYMGXYrwI
3d948ab0fa87db38e71c18fc49e7481b571e52ce: Bug 1371882 - Rename MediaCache::mFileCache to mBlockCache - r=cpearce
Gerald Squelart <gsquelart@mozilla.com> - Wed, 14 Jun 2017 17:01:46 +1200 - rev 364301
Push 91515 by archaeopteryx@coole-files.de at Fri, 16 Jun 2017 07:52:51 +0000
Bug 1371882 - Rename MediaCache::mFileCache to mBlockCache - r=cpearce Because blocks may not necessarily be held in files anymore. MozReview-Commit-ID: 2GNc7B5w2Jt
deb5f329e7c4d23c2f578708b75ef27e8b6e1140: Bug 1371882 - Virtualize FileBlockCache's API into MediaBlockCacheBase - r=cpearce
Gerald Squelart <gsquelart@mozilla.com> - Fri, 09 Jun 2017 14:26:22 +1200 - rev 364300
Push 91515 by archaeopteryx@coole-files.de at Fri, 16 Jun 2017 07:52:51 +0000
Bug 1371882 - Virtualize FileBlockCache's API into MediaBlockCacheBase - r=cpearce MozReview-Commit-ID: Eya0RWiyiEP
45cf5d142515ef0bf245f1dffe76cca6d75f0ced: Bug 1371882 - Remove FileBlockCache's dependency on Runnable - r=cpearce
Gerald Squelart <gsquelart@mozilla.com> - Fri, 09 Jun 2017 14:51:17 +1200 - rev 364299
Push 91515 by archaeopteryx@coole-files.de at Fri, 16 Jun 2017 07:52:51 +0000
Bug 1371882 - Remove FileBlockCache's dependency on Runnable - r=cpearce This is necessary before we can make FileBlockCache depend on another ref-counted base in the following patch. MozReview-Commit-ID: 8bfNwQhY8k0
0b219d49822a180cb28aeab3385a81d198d1d35a: Bug 1371882 - If content length <= 'media.memory_cache_max_size', use a discrete memory-backed MediaCache - r=cpearce
Gerald Squelart <gsquelart@mozilla.com> - Fri, 09 Jun 2017 23:15:04 +1200 - rev 364298
Push 91515 by archaeopteryx@coole-files.de at Fri, 16 Jun 2017 07:52:51 +0000
Bug 1371882 - If content length <= 'media.memory_cache_max_size', use a discrete memory-backed MediaCache - r=cpearce MozReview-Commit-ID: HH1R6LjKkxb
b417b74fd9540a8d7bf9d48e79bba2d9bd3246f7: Bug 1371882 - Move MEDIACACHESTREAM_NOTIFIED_LENGTH telemetry collection to MediaCacheStream::Init - r=cpearce
Gerald Squelart <gsquelart@mozilla.com> - Mon, 12 Jun 2017 14:27:46 +1200 - rev 364297
Push 91515 by archaeopteryx@coole-files.de at Fri, 16 Jun 2017 07:52:51 +0000
Bug 1371882 - Move MEDIACACHESTREAM_NOTIFIED_LENGTH telemetry collection to MediaCacheStream::Init - r=cpearce The initial telemetry collection was done in NotifyDataLength() because that was the first point where the length was introduced; but some extra code was needed to ensure that were collecting the first length. Now that this initial length is passed directly to Init(), we can report that number instead. In the "worst" case, it will actually be a bit more correct about what we initially wanted to report, i.e., the initial length given by the HTTP response header; and it's what we really want to know, now that we are using this number to make a decision about which MediaCache to use. MozReview-Commit-ID: 11Th8pensZt
200b97bc755b90ba0571dcd7a0d10e616bcbb74e: Bug 1371882 - MediaCacheStream::Init forwards the known content length to the MediaCache factory - r=cpearce
Gerald Squelart <gsquelart@mozilla.com> - Thu, 08 Jun 2017 15:59:43 +1200 - rev 364296
Push 91515 by archaeopteryx@coole-files.de at Fri, 16 Jun 2017 07:52:51 +0000
Bug 1371882 - MediaCacheStream::Init forwards the known content length to the MediaCache factory - r=cpearce This will give enough information (for now) for GetMediaCache to decide whether to use the (one global shared) file-backed MediaCache, or a discrete memory- backed MediaCache. (Note that GetMediaCache doesn't use this length yet in this patch.) MozReview-Commit-ID: 5B2E3sIsc4k
d25c4891077bda93c975ba7ffcd2ec17acc6e93a: Bug 1371882 - Make gMediaCache private inside MediaCache, to avoid misuse - r=cpearce
Gerald Squelart <gsquelart@mozilla.com> - Thu, 08 Jun 2017 17:12:13 +1200 - rev 364295
Push 91515 by archaeopteryx@coole-files.de at Fri, 16 Jun 2017 07:52:51 +0000
Bug 1371882 - Make gMediaCache private inside MediaCache, to avoid misuse - r=cpearce MozReview-Commit-ID: 6MyKmG7DNaG
c361945c67e5f0977bd17eaadc8952ee3013fc71: Bug 1371882 - Delay MediaCache destruction if update queued - r=cpearce
Gerald Squelart <gsquelart@mozilla.com> - Thu, 08 Jun 2017 16:45:21 +1200 - rev 364294
Push 91515 by archaeopteryx@coole-files.de at Fri, 16 Jun 2017 07:52:51 +0000
Bug 1371882 - Delay MediaCache destruction if update queued - r=cpearce MozReview-Commit-ID: LIjZFUIrTtX
995108c4c7053dd46c10dad5f9a933c43311ddd8: Bug 1371882 - Removed unnecessary `gMediaCache->` from MediaCache member functions - r=cpearce
Gerald Squelart <gsquelart@mozilla.com> - Thu, 08 Jun 2017 16:20:37 +1200 - rev 364293
Push 91515 by archaeopteryx@coole-files.de at Fri, 16 Jun 2017 07:52:51 +0000
Bug 1371882 - Removed unnecessary `gMediaCache->` from MediaCache member functions - r=cpearce MozReview-Commit-ID: BKjH9hfoL5g
c2f53f29d78cb57878e9100ec861eff3e820eed3: Bug 1371882 - MediaCacheStream::mInitialized is redundant, mMediaCache is non-null after initialization - r=cpearce
Gerald Squelart <gsquelart@mozilla.com> - Fri, 09 Jun 2017 13:48:06 +1200 - rev 364292
Push 91515 by archaeopteryx@coole-files.de at Fri, 16 Jun 2017 07:52:51 +0000
Bug 1371882 - MediaCacheStream::mInitialized is redundant, mMediaCache is non-null after initialization - r=cpearce MozReview-Commit-ID: 6VIPMLmzuEP
b3878ad0681fef062b1f78f58f78053fb631fb26: Bug 1371882 - MediaCacheStream accesses its MediaCache through a member pointer - r=cpearce
Gerald Squelart <gsquelart@mozilla.com> - Thu, 08 Jun 2017 17:30:40 +1200 - rev 364291
Push 91515 by archaeopteryx@coole-files.de at Fri, 16 Jun 2017 07:52:51 +0000
Bug 1371882 - MediaCacheStream accesses its MediaCache through a member pointer - r=cpearce MozReview-Commit-ID: CM1rXqAc4FT
b0c55ca939f61c334a7247822fdce2156a95bf65: Bug 1371882 - MediaCache::constructor/destructor/Init() don't need to be public - r=cpearce
Gerald Squelart <gsquelart@mozilla.com> - Fri, 09 Jun 2017 12:53:11 +1200 - rev 364290
Push 91515 by archaeopteryx@coole-files.de at Fri, 16 Jun 2017 07:52:51 +0000
Bug 1371882 - MediaCache::constructor/destructor/Init() don't need to be public - r=cpearce MozReview-Commit-ID: 9naYvPbGn14
fd40bd8e4a6a3fd7ee0114081e5400812f7fb57f: Bug 1371882 - static MediaCache::GetMediaCache to get file-backed MediaCache - r=cpearce
Gerald Squelart <gsquelart@mozilla.com> - Thu, 08 Jun 2017 15:09:40 +1200 - rev 364289
Push 91515 by archaeopteryx@coole-files.de at Fri, 16 Jun 2017 07:52:51 +0000
Bug 1371882 - static MediaCache::GetMediaCache to get file-backed MediaCache - r=cpearce This is the new recommended way to create&initialize the file-backed MediaCache. In future patches, this will also allow the creation of memory-backed MediaCache objects. MozReview-Commit-ID: 6RUlNW2eBPP
66550240c5fe52e5b2e120e09e86552e23fea9ed: Bug 1371882 - MediaCache::ResourceStreamIterator is given the MediaCache to work with - r=cpearce
Gerald Squelart <gsquelart@mozilla.com> - Thu, 08 Jun 2017 15:32:13 +1200 - rev 364288
Push 91515 by archaeopteryx@coole-files.de at Fri, 16 Jun 2017 07:52:51 +0000
Bug 1371882 - MediaCache::ResourceStreamIterator is given the MediaCache to work with - r=cpearce MozReview-Commit-ID: 3Xl4WNESdnY
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip