4d39fdf74ae76b02509a190b7081eecf49e25efe: bug 1442776 make CycleCollectedJSContext accessible from JSContext private r=peterv
Karl Tomlinson <karlt+@karlt.net> - Thu, 10 May 2018 17:04:12 +1200 - rev 421596
Push 104075 by nbeleuzu@mozilla.com at Wed, 06 Jun 2018 17:05:41 +0000
bug 1442776 make CycleCollectedJSContext accessible from JSContext private r=peterv Inheriting PerThreadAtomCache on CycleCollectedJSContext permits use of static_cast, avoiding one level of indirection compared to adding a CycleCollectedJSContext* to PerThreadAtomCache. PerThreadAtomCache is over 18kB, and so WorkerJSContext and WorkletJSContext are moved from the stack to the heap. MozReview-Commit-ID: 6jdJeZcviK4
077407e42b77e532de6e307307356673ecbda73e: bug 1442776 treat PinnedStringId as rooted GC pointer in hazard analysis r=sfink
Karl Tomlinson <karlt+@karlt.net> - Tue, 05 Jun 2018 16:51:10 +1200 - rev 421595
Push 104075 by nbeleuzu@mozilla.com at Wed, 06 Jun 2018 17:05:41 +0000
bug 1442776 treat PinnedStringId as rooted GC pointer in hazard analysis r=sfink MozReview-Commit-ID: GFPSwczIZxV
8f5a9e18e9532b1ae5845031aaf9f072cb42db03: Bug 1451859 - Part 3: In FUZZER builds, do not crash on malfored IPC messages. r=jld, r=posidron
Alex Gaynor <agaynor@mozilla.com> - Thu, 05 Apr 2018 15:47:34 -0400 - rev 421594
Push 104074 by ryanvm@gmail.com at Wed, 06 Jun 2018 16:02:26 +0000
Bug 1451859 - Part 3: In FUZZER builds, do not crash on malfored IPC messages. r=jld, r=posidron
950fa584ec8e1ef5fe5133441da0e4be2b4b7c0b: Bug 1451859 - Part 2: Add sanitizer coverage to a handful of places relevant to IPC. r=posidron
Alex Gaynor <agaynor@mozilla.com> - Thu, 05 Apr 2018 15:48:11 -0400 - rev 421593
Push 104074 by ryanvm@gmail.com at Wed, 06 Jun 2018 16:02:26 +0000
Bug 1451859 - Part 2: Add sanitizer coverage to a handful of places relevant to IPC. r=posidron
f1f42726f1ecbb306bec0a3998871b1b793d23f6: Bug 1451859 - Part 1: Implement a fuzzer for IPC handlers using libFuzzer. r=jld, r=posidron
Alex Gaynor <agaynor@mozilla.com> - Fri, 23 Mar 2018 16:18:42 -0400 - rev 421592
Push 104074 by ryanvm@gmail.com at Wed, 06 Jun 2018 16:02:26 +0000
Bug 1451859 - Part 1: Implement a fuzzer for IPC handlers using libFuzzer. r=jld, r=posidron
6de156e08e8e77f514185468e9364ea112fb6d4b: Bug 1467134. Use Atomic<bool> for the staticpref version of layout.css.font-variations.enabled. r=emilio
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 06 Jun 2018 11:34:30 -0400 - rev 421591
Push 104073 by bzbarsky@mozilla.com at Wed, 06 Jun 2018 15:42:18 +0000
Bug 1467134. Use Atomic<bool> for the staticpref version of layout.css.font-variations.enabled. r=emilio Atomic<bool> is implemented in terms of AtomicBase<uint32_t>, because that way you don't need to depend on atomic 1-byte operations. That means that the rust bindgen sees it as a u32, not a bool. It's a bit concerning that the rust code seems to be doing an unsynchronized read here, but given this is a RelaxedAtomic, that's probably ok.
e9b4f255a1160eb87c44bb04ff1b22240165d7e2: Backed out changeset 2491b63fe79a (bug 1417920) for build bustages. CLOSED TREE
Brindusan Cristian <cbrindusan@mozilla.com> - Wed, 06 Jun 2018 18:33:07 +0300 - rev 421590
Push 104072 by cbrindusan@mozilla.com at Wed, 06 Jun 2018 15:34:47 +0000
Backed out changeset 2491b63fe79a (bug 1417920) for build bustages. CLOSED TREE
7b760c430347f138d9c5105e70a67a56a3b595a8: Bug 1467142 - Fix MacroAssembler::branchTestObjCompartment to guard on realm->compartment instead of realm. r=tcampbell
Jan de Mooij <jdemooij@mozilla.com> - Wed, 06 Jun 2018 17:09:17 +0200 - rev 421589
Push 104071 by jandemooij@gmail.com at Wed, 06 Jun 2018 15:10:07 +0000
Bug 1467142 - Fix MacroAssembler::branchTestObjCompartment to guard on realm->compartment instead of realm. r=tcampbell
5fd3144d5d009fdac3fae2ee33143901164e0d12: Bug 1401883 - don't hold unnecessary references to the Windows app shell; r=jimm
Ting-Yu Chou <janus926@gmail.com> - Wed, 06 Jun 2018 11:05:18 -0400 - rev 421588
Push 104070 by nfroyd@mozilla.com at Wed, 06 Jun 2018 15:08:37 +0000
Bug 1401883 - don't hold unnecessary references to the Windows app shell; r=jimm When runnables are posted to the main thread's event loop, the event loop notifies any thread observers that this has been done. The app shell registers itself as just such a runnable, and posts messages to the native event loop that processing native events needs to be done. On Windows, this posting takes an extra reference to the app shell, to keep it alive until the message is processed by the native event loop, since app shell code needs to be invoked during that processing. The processing releases this extra reference, so everything stays balanced. Except that it's possible for messages to be posted to the native event loop, and then browser shutdown happens. Those messages are not processed and the associated references taken are not released. This imbalance means that in debug builds, we appear to be leaking the app shell, and that leaking results in intermittent oranges. This intermittent orange has manifested itself in a variety of ways over the years, depending on how big the app shell itself was (since that changes the number of bytes leaked) and how many leak-checked things the app shell was holding on to. This bug is merely the latest manifestation; the last serious work on analyzing the phenomenon and fixing it was done in bug 1220517. The solution proposed in that bug was that we simply stop the extra reference counting; when the app shell is destroyed normally, we shouldn't be processing the native event loop any more anyway. So even if the native event loop is holding (freed) pointers to the app shell, we'd never execute the callback and perform a use-after-free. Reading through the code suggests that this *ought* to be the case, but the potential for shooting ourselves in the foot seems awfully high. In any event, this is not a problem unique to Windows; we have seen this same sort of thing happen on OS X. See nsAppShell::ProcessGeckoEvents in widget/cocoa/nsAppShell.mm. Here we propose a slightly different solution: we keep track of the number of native event callbacks we have scheduled, incrementing when we schedule, and decrementing when we actually run one. When the app shell is destroyed, we simply set the number of outstanding events to zero, and we prohibit the callback from accessing the app shell if there are no outstanding events. This solution is analogous to dropping the extra reference counting, but avoids potential badness if we do wind up processing native events after the app shell is destroyed.
2491b63fe79aa6113a77c49f2fa9f7c2ed7e59ff: Bug 1417920 - squash pytest warnings about Test* classes; r=ted.mielczarek
Nathan Froyd <froydnj@mozilla.com> - Fri, 01 Jun 2018 15:39:54 -0400 - rev 421587
Push 104070 by nfroyd@mozilla.com at Wed, 06 Jun 2018 15:08:37 +0000
Bug 1417920 - squash pytest warnings about Test* classes; r=ted.mielczarek Having an imported class that begins with `Test` causes pytest to warn: =================================== warnings summary ==================================== mozbuild/test/backend/test_recursivemake.py::TestMetadataBackend cannot collect test class 'TestMetadataBackend' because it has a __init__ constructor -- Docs: http://doc.pytest.org/en/latest/warnings.html After seeing this several times and each time wondering what the yellow output in your terminal might mean, the warning starts to get tiresome. A class-scope `__test__` attribute set to `False` makes this warning go away; let's do that and eliminate this papercut.
3c32805d476c68e3caca8d2be1c537c027f01224: Bug 1465430 - removed references to old winxp in manifest files. r=jmaher
Eliza Balazs <ebalazs@mozilla.com> - Wed, 06 Jun 2018 05:43:00 +0300 - rev 421586
Push 104069 by ebalazs@mozilla.com at Wed, 06 Jun 2018 14:16:05 +0000
Bug 1465430 - removed references to old winxp in manifest files. r=jmaher
7bb7694f5d5d78ae85291b22fff313e9d8e42eb1: Bug 1466222 - Drop now-unused platform config variable. r=catlee
Justin Wood <Callek@gmail.com> - Tue, 05 Jun 2018 20:50:53 -0400 - rev 421585
Push 104068 by Callek@gmail.com at Wed, 06 Jun 2018 14:13:27 +0000
Bug 1466222 - Drop now-unused platform config variable. r=catlee for "Cleanup l10n mozharness config files." (Batch 2) Differential Revision: https://phabricator.services.mozilla.com/D1564
185a82778d94271ed27b60f333e78859bc09605f: Bug 1466222 - Don't allow mar_tools_url to be runtime configured. r=catlee
Justin Wood <Callek@gmail.com> - Tue, 05 Jun 2018 20:47:38 -0400 - rev 421584
Push 104068 by Callek@gmail.com at Wed, 06 Jun 2018 14:13:27 +0000
Bug 1466222 - Don't allow mar_tools_url to be runtime configured. r=catlee for "Cleanup l10n mozharness config files." (Batch 2) Differential Revision: https://phabricator.services.mozilla.com/D1563
18fe0eb0545cfa2b5809289dbd34e00841a5f41e: Bug 1466222 - Drop unused config upload_branch. r=catlee
Justin Wood <Callek@gmail.com> - Tue, 05 Jun 2018 15:21:50 -0400 - rev 421583
Push 104068 by Callek@gmail.com at Wed, 06 Jun 2018 14:13:27 +0000
Bug 1466222 - Drop unused config upload_branch. r=catlee for "Cleanup l10n mozharness config files." (Batch 2) Differential Revision: https://phabricator.services.mozilla.com/D1562
bb28c2d9d5f51f6e7eb797b892247948f1f7021b: Bug 1466222 - Remove locales_file and locales_platform from desktop and mobile l10n. r=catlee
Justin Wood <Callek@gmail.com> - Tue, 05 Jun 2018 12:58:00 -0400 - rev 421582
Push 104068 by Callek@gmail.com at Wed, 06 Jun 2018 14:13:27 +0000
Bug 1466222 - Remove locales_file and locales_platform from desktop and mobile l10n. r=catlee Leave support for multil10n uses for now. for "Cleanup l10n mozharness config files." (Batch 2) Differential Revision: https://phabricator.services.mozilla.com/D1561
38d7f885284ebda6d92abb9d6b1f45e540770bbf: Bug 1466222 - Clean out actions from multi-locale that are not used. r=catlee
Justin Wood <Callek@gmail.com> - Tue, 05 Jun 2018 11:57:52 -0400 - rev 421581
Push 104068 by Callek@gmail.com at Wed, 06 Jun 2018 14:13:27 +0000
Bug 1466222 - Clean out actions from multi-locale that are not used. r=catlee for "Cleanup l10n mozharness config files." (Batch 2) Differential Revision: https://phabricator.services.mozilla.com/D1560
0970518ff4bd11538f784d66c1e5a3631eabccc8: Bug 1466222 - Cleanup handling of en_us_binary_url. r=catlee
Justin Wood <Callek@gmail.com> - Mon, 04 Jun 2018 20:52:46 -0400 - rev 421580
Push 104068 by Callek@gmail.com at Wed, 06 Jun 2018 14:13:27 +0000
Bug 1466222 - Cleanup handling of en_us_binary_url. r=catlee for "Cleanup l10n mozharness config files." (Batch 2) Differential Revision: https://phabricator.services.mozilla.com/D1549
c71a6be37cfcca8da7e32da37ac09db8092d2f92: Bug 1466222 - Remove a bunch of unused l10n config files. r=catlee
Justin Wood <Callek@gmail.com> - Mon, 04 Jun 2018 20:25:26 -0400 - rev 421579
Push 104068 by Callek@gmail.com at Wed, 06 Jun 2018 14:13:27 +0000
Bug 1466222 - Remove a bunch of unused l10n config files. r=catlee for "Cleanup l10n mozharness config files." (Batch 2) Differential Revision: https://phabricator.services.mozilla.com/D1548
507fe13a38673cdafc0156ff5ab6baed653a5725: Bug 1466222 - pyflake locales.py r=catlee
Justin Wood <Callek@gmail.com> - Mon, 04 Jun 2018 15:29:05 -0400 - rev 421578
Push 104068 by Callek@gmail.com at Wed, 06 Jun 2018 14:13:27 +0000
Bug 1466222 - pyflake locales.py r=catlee for "Cleanup l10n mozharness config files." (Batch 2) Differential Revision: https://phabricator.services.mozilla.com/D1547
3c9e951bdc9e8363bef4df270d0ef01761139cec: Bug 1466222 - hashType is unsued r=catlee
Justin Wood <Callek@gmail.com> - Mon, 04 Jun 2018 14:25:34 -0400 - rev 421577
Push 104068 by Callek@gmail.com at Wed, 06 Jun 2018 14:13:27 +0000
Bug 1466222 - hashType is unsued r=catlee for "Cleanup l10n mozharness config files." (Batch 2) Differential Revision: https://phabricator.services.mozilla.com/D1546
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip