4cf9a1ce9e92dbcc022c1d8d7d6ac8ed185dc082: Bug 1525720, part 11 - Use RemoteBrowser interface instead of IPDL actors in nsFrameLoader. r=nika
Ryan Hunt <rhunt@eqrion.net> - Mon, 06 May 2019 21:29:48 -0500 - rev 474989
Push 113186 by rhunt@eqrion.net at Thu, 23 May 2019 03:45:28 +0000
Bug 1525720, part 11 - Use RemoteBrowser interface instead of IPDL actors in nsFrameLoader. r=nika This commit replaces the direct use of the IPDL actors in nsFrameLoader with the RemoteBrowser interface. Some special use cases are adapted to still use the IPDL actors. In the future, we should burn these use cases down. Differential Revision: https://phabricator.services.mozilla.com/D31442
9d7151b26a9eb72d363b4a309f179c15452dc2bc: Bug 1525720, part 10 - Link BrowserParent and BrowserHost on creation. r=nika
Ryan Hunt <rhunt@eqrion.net> - Wed, 15 May 2019 10:34:03 -0500 - rev 474988
Push 113186 by rhunt@eqrion.net at Thu, 23 May 2019 03:45:28 +0000
Bug 1525720, part 10 - Link BrowserParent and BrowserHost on creation. r=nika This commit adds a link from BrowserParent to it's owning BrowserHost if it is the root BrowserParent. Differential Revision: https://phabricator.services.mozilla.com/D31441
0c53638d28a9d1468e047136db7680394fa39b92: Bug 1525720, part 9 - Fill out implementations of BrowserHost and BrowserBridgeHost. r=nika
Ryan Hunt <rhunt@eqrion.net> - Wed, 08 May 2019 11:27:49 -0500 - rev 474987
Push 113186 by rhunt@eqrion.net at Thu, 23 May 2019 03:45:28 +0000
Bug 1525720, part 9 - Fill out implementations of BrowserHost and BrowserBridgeHost. r=nika This commit implements the RemoteBrowser interface for BrowserHost and BrowserBridgeHost. For BrowserHost, most methods delegate to the root BrowserParent. In the future, we should move these over to BrowserHost. For BrowserBridgeHost, most methods are taken from BrowserBridgeParent. Differential Revision: https://phabricator.services.mozilla.com/D31439
63dea5419ea4a8b824c710b2ddf9a76b52e9b9d8: Bug 1525720, part 8 - Add RemoteBrowser interface and BrowserHost/BrowserBridgeHost implementations. r=nika
Ryan Hunt <rhunt@eqrion.net> - Mon, 06 May 2019 16:04:34 -0500 - rev 474986
Push 113186 by rhunt@eqrion.net at Thu, 23 May 2019 03:45:28 +0000
Bug 1525720, part 8 - Add RemoteBrowser interface and BrowserHost/BrowserBridgeHost implementations. r=nika RemoteBrowser is a common interface between the chrome/content process cases for nsFrameLoader, that allows us to abstract IPC details away. BrowserHost is a concrete implementation for the chrome process, while BrowserBridgeHost implements the content process case. Differential Revision: https://phabricator.services.mozilla.com/D31438
1332810e2604ddb6982860f5a3f2412d2249b42c: Bug 1525720, part 7 - Use getter methods to access mBrowserParent and mBrowserBridgeChild. r=farre
Ryan Hunt <rhunt@eqrion.net> - Thu, 25 Apr 2019 12:36:16 -0500 - rev 474985
Push 113186 by rhunt@eqrion.net at Thu, 23 May 2019 03:45:28 +0000
Bug 1525720, part 7 - Use getter methods to access mBrowserParent and mBrowserBridgeChild. r=farre This prepares nsFrameLoader for replacing mBrowserParent and mBrowserBridgeChild with a common interface by making special case code use a getter method instead of direct access. Differential Revision: https://phabricator.services.mozilla.com/D31437
21985ab71b5b6f052ec26b4341db0eb47e589f32: Bug 1525720, part 6 - Move BrowserBridgeChild creation to ContentChild. r=farre
Ryan Hunt <rhunt@eqrion.net> - Wed, 24 Apr 2019 23:52:47 -0500 - rev 474984
Push 113186 by rhunt@eqrion.net at Thu, 23 May 2019 03:45:28 +0000
Bug 1525720, part 6 - Move BrowserBridgeChild creation to ContentChild. r=farre This makes it symmetrical to how BrowserParent is created by ContentParent. Differential Revision: https://phabricator.services.mozilla.com/D31436
420f10c25da19ddb398bc6c7a1089ee9e7e6839b: Bug 1525720, part 5 - Redirect nsIHttpChannel using content process ID instead of nsIRemoteTab. r=valentin
Ryan Hunt <rhunt@eqrion.net> - Wed, 15 May 2019 12:33:42 -0500 - rev 474983
Push 113186 by rhunt@eqrion.net at Thu, 23 May 2019 03:45:28 +0000
Bug 1525720, part 5 - Redirect nsIHttpChannel using content process ID instead of nsIRemoteTab. r=valentin This code currently works for remote subframes assuming that nsIRemoteTab is implemented by BrowserParent, but will break when nsIRemoteTab is only for a top-level BrowserParent. What this code really wants is a content process ID to retarget the channel to. This commit switches the interfaces to pass this around instead of nsIRemoteTab. Differential Revision: https://phabricator.services.mozilla.com/D31435
5ff1726275aad728e080f4a904885a16261a6c4d: Bug 1525720, part 4 - Assert in DrawSnapshot if not the chrome process. r=mattwoodrow
Ryan Hunt <rhunt@eqrion.net> - Wed, 24 Apr 2019 23:28:31 -0500 - rev 474982
Push 113186 by rhunt@eqrion.net at Thu, 23 May 2019 03:45:28 +0000
Bug 1525720, part 4 - Assert in DrawSnapshot if not the chrome process. r=mattwoodrow This API is only intended to be used in the chrome process and this commit makes this explicit to simplify a later refactoring. Differential Revision: https://phabricator.services.mozilla.com/D31434
707a48ef23385b4b143a9218fe788efcd3e1e3fc: Bug 1525720, part 3 - Remove method to createRemoteFrameLoader from nsIMozBrowserFrame interface. r=farre
Ryan Hunt <rhunt@eqrion.net> - Wed, 24 Apr 2019 23:25:56 -0500 - rev 474981
Push 113186 by rhunt@eqrion.net at Thu, 23 May 2019 03:45:28 +0000
Bug 1525720, part 3 - Remove method to createRemoteFrameLoader from nsIMozBrowserFrame interface. r=farre This appears unused and adds unneeded surface area for these API's to support. Differential Revision: https://phabricator.services.mozilla.com/D31431
37fb118dac6c3b4c113e51e15de9cea7f4e9702f: Bug 1525720, part 2 - Move UITabResolutionChanged method to nsIRemoteTab interface from BrowserParent. r=smaug
Ryan Hunt <rhunt@eqrion.net> - Wed, 24 Apr 2019 23:05:40 -0500 - rev 474980
Push 113186 by rhunt@eqrion.net at Thu, 23 May 2019 03:45:28 +0000
Bug 1525720, part 2 - Move UITabResolutionChanged method to nsIRemoteTab interface from BrowserParent. r=smaug This reduces the amount of code that assumes that BrowserParent implements nsIRemoteTab. Differential Revision: https://phabricator.services.mozilla.com/D31430
c0a4aecf98b026eb7f88e5d105f85c3572ed522a: Bug 1525720, part 1 - Allow calling BrowserParent::InitRendering multiple times, and remove RenderFrame dependency from nsFrameLoader. r=kats
Ryan Hunt <rhunt@eqrion.net> - Wed, 24 Apr 2019 22:36:27 -0500 - rev 474979
Push 113186 by rhunt@eqrion.net at Thu, 23 May 2019 03:45:28 +0000
Bug 1525720, part 1 - Allow calling BrowserParent::InitRendering multiple times, and remove RenderFrame dependency from nsFrameLoader. r=kats This cleanup will simplify refactoring nsFrameLoader later. Differential Revision: https://phabricator.services.mozilla.com/D31429
c8e9b6a81194dff2d37b4f67d23a419fd4587e49: Bug 1519577 Convert toolbarbutton to a custom element r=surkov
Andrew Swan <aswan@mozilla.com> - Mon, 20 May 2019 10:01:02 -0700 - rev 474978
Push 113185 by aswan@mozilla.com at Wed, 22 May 2019 23:25:35 +0000
Bug 1519577 Convert toolbarbutton to a custom element r=surkov Differential Revision: https://phabricator.services.mozilla.com/D31941
595c3065e9ac64ed1d4ada38c3a83c6ba2a0ff91: Bug 1519577 Mark badged page action toolbarbuttons before inserting r=Gijs
Andrew Swan <aswan@mozilla.com> - Tue, 14 May 2019 20:39:38 -0700 - rev 474977
Push 113185 by aswan@mozilla.com at Wed, 22 May 2019 23:25:35 +0000
Bug 1519577 Mark badged page action toolbarbuttons before inserting r=Gijs The "add search engine" page action wants to use badged toolbarbuttons, but it does this by adding the "badged-button" class (which changes the XBL binding) after the button has already been created and added to the DOM. To avoid having to switch between non-badged and badged buttons when toolbarbutton is converted to custom elements, add a property to page actions so that the badged status can be determined when the element is created. Differential Revision: https://phabricator.services.mozilla.com/D31940
82d77e63f4d3971ee341c6a49daacc6524e9d80c: Bug 1519577 Remove support for unused toolbarbutton anchor attribute r=NeilDeakin
Andrew Swan <aswan@mozilla.com> - Tue, 14 May 2019 13:08:53 -0700 - rev 474976
Push 113185 by aswan@mozilla.com at Wed, 22 May 2019 23:25:35 +0000
Bug 1519577 Remove support for unused toolbarbutton anchor attribute r=NeilDeakin This code contains an undesirable dependency between the layout code and the implementation of toolbarbutton. Since it isn't actually used anywhere by the firefox UI, remove it here. Differential Revision: https://phabricator.services.mozilla.com/D31939
8f0abb76f7bb982c13424019f7bda30089acf1e8: Bug 1519577 Update devtools test to use a test-only xbl binding r=jdescottes
Andrew Swan <aswan@mozilla.com> - Thu, 02 May 2019 20:39:20 -0700 - rev 474975
Push 113185 by aswan@mozilla.com at Wed, 22 May 2019 23:25:35 +0000
Bug 1519577 Update devtools test to use a test-only xbl binding r=jdescottes Differential Revision: https://phabricator.services.mozilla.com/D31938
8de5e0880f85d8986b2995cd8685245922e41b5f: Bug 1519577 Remove test_bug562554.xul dependence on button.xml r=bzbarsky
Andrew Swan <aswan@mozilla.com> - Tue, 14 May 2019 16:33:38 -0700 - rev 474974
Push 113185 by aswan@mozilla.com at Wed, 22 May 2019 23:25:35 +0000
Bug 1519577 Remove test_bug562554.xul dependence on button.xml r=bzbarsky This is essentially reverting the test changes from bug 653881. The platform changes that motivated bug 653881 were reverted in bug 888787 but the test changes were left in place at that time. Differential Revision: https://phabricator.services.mozilla.com/D31937
57bf01d965797fac39ca0f267050633039aa4c57: Bug 1519577 Update test_bug467123 to not rely on button.xml r=smaug
Andrew Swan <aswan@mozilla.com> - Thu, 02 May 2019 13:56:15 -0700 - rev 474973
Push 113185 by aswan@mozilla.com at Wed, 22 May 2019 23:25:35 +0000
Bug 1519577 Update test_bug467123 to not rely on button.xml r=smaug Differential Revision: https://phabricator.services.mozilla.com/D31936
f287bb6c18942c75aca41d54987006951270628d: Backed out 18 changesets (bug 1525720) for mass failures on Windows platform e.g ProcessPriorityManager.cpp on a CLOSED TREE.
Gurzau Raul <rgurzau@mozilla.com> - Thu, 23 May 2019 01:57:16 +0300 - rev 474972
Push 113184 by rgurzau@mozilla.com at Wed, 22 May 2019 22:58:26 +0000
Backed out 18 changesets (bug 1525720) for mass failures on Windows platform e.g ProcessPriorityManager.cpp on a CLOSED TREE. Backed out changeset 1f2e86c2d691 (bug 1525720) Backed out changeset 9b79caa460a0 (bug 1525720) Backed out changeset e65cb2d4c5a5 (bug 1525720) Backed out changeset 99f971a02d87 (bug 1525720) Backed out changeset d25963c72ff7 (bug 1525720) Backed out changeset 810b73719871 (bug 1525720) Backed out changeset ee10a8254481 (bug 1525720) Backed out changeset 1bcf9f586c55 (bug 1525720) Backed out changeset d3b2ac8d5ca4 (bug 1525720) Backed out changeset 697774dd8984 (bug 1525720) Backed out changeset eadeacbe4483 (bug 1525720) Backed out changeset 32eeee79d628 (bug 1525720) Backed out changeset 07678a2fa9e7 (bug 1525720) Backed out changeset 757b4f595cc4 (bug 1525720) Backed out changeset b255e0a84e12 (bug 1525720) Backed out changeset 9a255864f75d (bug 1525720) Backed out changeset 5f1c1b609ec1 (bug 1525720) Backed out changeset 00d83f1d02e0 (bug 1525720)
1f2e86c2d6912946eac17beabdd27e4c42accf27: Bug 1525720 - Try to fix build bustage. r=me on a CLOSED TREE
Ryan Hunt <rhunt@eqrion.net> - Wed, 22 May 2019 16:03:26 -0500 - rev 474971
Push 113183 by rhunt@eqrion.net at Wed, 22 May 2019 21:05:09 +0000
Bug 1525720 - Try to fix build bustage. r=me on a CLOSED TREE
9b79caa460a01a7bdf9c27ede487de0ec642ae0b: Bug 1525720, part 17 - Ignore nsIRemoteTab methods after we have destroyed the browser. r=nika
Ryan Hunt <rhunt@eqrion.net> - Wed, 15 May 2019 12:34:14 -0500 - rev 474970
Push 113182 by rhunt@eqrion.net at Wed, 22 May 2019 20:02:12 +0000
Bug 1525720, part 17 - Ignore nsIRemoteTab methods after we have destroyed the browser. r=nika It's possible for front-end references to nsIRemoteTab to outlive the IPDL actor. When this happens, we should ignore methods and property accesses. The one special case is that some code expects to be able to access the TabId after the browser has been destroyed. For this we can just cache the ID. Differential Revision: https://phabricator.services.mozilla.com/D31449
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip