3de2f935e2d2658dda91deba799149ee29ce3837: Bug 1547922 part 1 - Fix broken flex layout tests. r=dholbert
Mats Palmgren <mats@mozilla.com> - Tue, 30 Apr 2019 10:03:29 +0200 - rev 471917
Push 112965 by mpalmgren@mozilla.com at Tue, 30 Apr 2019 19:05:25 +0000
Bug 1547922 part 1 - Fix broken flex layout tests. r=dholbert The flex item tests in this file are completely broken... First, there's a typo in the flex container style when concatenating: "... teal" + containerSizeDecl since you end up with "... tealinline-size:..." etc. Second, none of the tests actaully test anything at all, which you can see by removing the "+ subtest.candStyle" part on the reflow root candidate -- the test still pass! The reason for that is that its child (inner) has a solid purple border so when changing its size it will render differently and make the test pass regardless of any change that we intended to test. After fixing those two bugs it turns out that two of the subtests don't produce a rendering change at all, so those tests are bogus and needs to be rewritten. (I'm commenting them out for now.) Differential Revision: https://phabricator.services.mozilla.com/D29324
0f8f181540096810ec288bcb0954a798c05491ee: Backed out changeset 46179401c77b (bug 1529125) for talos xperf crashes on Windows
Sebastian Hengst <archaeopteryx@coole-files.de> - Tue, 30 Apr 2019 19:22:42 +0200 - rev 471916
Push 112964 by archaeopteryx@coole-files.de at Tue, 30 Apr 2019 17:23:03 +0000
Backed out changeset 46179401c77b (bug 1529125) for talos xperf crashes on Windows
2daf0501d186ae0b7496aad0eb93519791bea0ea: Bug 1543642 - Part 6: Update Gecko to Unicode 12.1. r=jfkthame
André Bargull <andre.bargull@gmail.com> - Tue, 23 Apr 2019 16:46:16 +0200 - rev 471915
Push 112963 by archaeopteryx@coole-files.de at Tue, 30 Apr 2019 17:16:06 +0000
Bug 1543642 - Part 6: Update Gecko to Unicode 12.1. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com//D27355
6bfd3a158f0f5b221ecf73b2fbbef8bca8b52836: Bug 1543642 - Part 5: Update SpiderMonkey to Unicode 12.1. r=jwalden
André Bargull <andre.bargull@gmail.com> - Tue, 23 Apr 2019 16:46:07 +0200 - rev 471914
Push 112963 by archaeopteryx@coole-files.de at Tue, 30 Apr 2019 17:16:06 +0000
Bug 1543642 - Part 5: Update SpiderMonkey to Unicode 12.1. r=jwalden Differential Revision: https://phabricator.services.mozilla.com//D27354
e32ac71686c8942b43d2c7189c649c88b8145d10: Bug 1543642 - Part 4: Remove special-casing for Etc/UCT. r=jwalden
André Bargull <andre.bargull@gmail.com> - Tue, 23 Apr 2019 16:45:55 +0200 - rev 471913
Push 112963 by archaeopteryx@coole-files.de at Tue, 30 Apr 2019 17:16:06 +0000
Bug 1543642 - Part 4: Remove special-casing for Etc/UCT. r=jwalden Etc/UCT resp. UCT is a link to Etc/UTC starting with tzdata 2019a. Differential Revision: https://phabricator.services.mozilla.com//D27353
7375a89e0c85113ab3abbf23d7b028635b103195: Bug 1543642 - Part 3: Update tzdata in ICU data files to 2019a. r=jwalden
André Bargull <andre.bargull@gmail.com> - Tue, 23 Apr 2019 16:45:45 +0200 - rev 471912
Push 112963 by archaeopteryx@coole-files.de at Tue, 30 Apr 2019 17:16:06 +0000
Bug 1543642 - Part 3: Update tzdata in ICU data files to 2019a. r=jwalden Differential Revision: https://phabricator.services.mozilla.com//D27352
645264976a1b4d98333c6082e22e5bc5a036c4f2: Bug 1543642 - Part 2: Update in-tree ICU to release 64.2. r=jwalden
André Bargull <andre.bargull@gmail.com> - Tue, 23 Apr 2019 07:45:23 -0700 - rev 471911
Push 112963 by archaeopteryx@coole-files.de at Tue, 30 Apr 2019 17:16:06 +0000
Bug 1543642 - Part 2: Update in-tree ICU to release 64.2. r=jwalden
022d97621e5b0758fade155e697c48874f0d3b97: Bug 1543642 - Part 1: Update ICU patches to apply cleanly. r=jwalden
André Bargull <andre.bargull@gmail.com> - Tue, 23 Apr 2019 16:45:11 +0200 - rev 471910
Push 112963 by archaeopteryx@coole-files.de at Tue, 30 Apr 2019 17:16:06 +0000
Bug 1543642 - Part 1: Update ICU patches to apply cleanly. r=jwalden Differential Revision: https://phabricator.services.mozilla.com//D27351
e1927f1c0f1e3c3eed9bde2a1bdd6ac0a434458a: Bug 1536154 - Make nsStringInputStream always report the full memory size of the backing string r=baku
Jon Coppeard <jcoppeard@mozilla.com> - Tue, 30 Apr 2019 11:53:42 +0100 - rev 471909
Push 112962 by jcoppeard@mozilla.com at Tue, 30 Apr 2019 15:28:48 +0000
Bug 1536154 - Make nsStringInputStream always report the full memory size of the backing string r=baku Give nsIStringStream separate SizeOfIncludingThisIfUnshared and SizeOfIncludingThisEvenIfShared methods. Use the former for memory reporting and the latter for JS engine memory accounting. Differential Revision: https://phabricator.services.mozilla.com/D29336
a1cf373a4e9fe74741442c2f8d747c080b80175a: Bug 1536154 - Count externally allocated malloc memory as part of total zone memory for scheduling purposes r=sfink
Jon Coppeard <jcoppeard@mozilla.com> - Wed, 24 Apr 2019 15:58:42 +0100 - rev 471908
Push 112962 by jcoppeard@mozilla.com at Tue, 30 Apr 2019 15:28:48 +0000
Bug 1536154 - Count externally allocated malloc memory as part of total zone memory for scheduling purposes r=sfink This will start triggering GCs based on this external memory count, without removing the existing malloc bytes trigger. This should mean we collect earlier in some cases (hopefully those cases where we are not triggering frequently enough at the moment). Note that we clear the malloc bytes count on GC, so this doesn't mean we will trigger twice the number of collections. The patch adds totalBytes() method to Zone and uses this for scheduling decisions. I removed the lock from GCRuntime::maybeAllocTriggerZoneGC because it doesn't seem to serve any purpose. Differential Revision: https://phabricator.services.mozilla.com/D28695
4cf9348fa63c5c1b226578fd888d341f7a07b10a: Bug 1536154 - Update JS_updateMallocCounter callers in xpconnect to use the new APIs r=mccr8
Jon Coppeard <jcoppeard@mozilla.com> - Wed, 24 Apr 2019 15:58:42 +0100 - rev 471907
Push 112962 by jcoppeard@mozilla.com at Tue, 30 Apr 2019 15:28:48 +0000
Bug 1536154 - Update JS_updateMallocCounter callers in xpconnect to use the new APIs r=mccr8 Differential Revision: https://phabricator.services.mozilla.com/D28693
5159ad4a890bf2e2fd94972d798ac9e22f929168: Bug 1536154 - Update JS_updateMallocCounter callers to use the new API r=bzbarsky
Jon Coppeard <jcoppeard@mozilla.com> - Wed, 24 Apr 2019 15:58:42 +0100 - rev 471906
Push 112962 by jcoppeard@mozilla.com at Tue, 30 Apr 2019 15:28:48 +0000
Bug 1536154 - Update JS_updateMallocCounter callers to use the new API r=bzbarsky This updates existing callers to use the new JS::AddAssociatedMemory API and adds calls to RemoveAssociatedMemory in finalizers. The associated memory doesn't need to be exact, so some simplifiations are made, e.g. in CanvasRenderingContext2D where we don't wait for memory to be allocated but update the number of bytes when the dimensions change, and for stream blobs where the value returned by SizeOfIncludingThis changes over the lifetime of the object. Differential Revision: https://phabricator.services.mozilla.com/D28692
b6ca67e7684f4f9409b8e22e0b52afa8e1de2dab: Bug 1536154 - Eagerly run finalizer for any dead reflector JSObject when creating a new reflector for a DOM native r=bzbarsky
Jon Coppeard <jcoppeard@mozilla.com> - Wed, 24 Apr 2019 15:58:39 +0100 - rev 471905
Push 112962 by jcoppeard@mozilla.com at Tue, 30 Apr 2019 15:28:48 +0000
Bug 1536154 - Eagerly run finalizer for any dead reflector JSObject when creating a new reflector for a DOM native r=bzbarsky Currently incremental GC can run the finalizer for a dead reflector for a native after a new reflector for that native has been created and attached. This leads to the confusing situation where there are two reflectors that contain pointers to the same native (which has a pointer to the new one). This is a problem for memory accounting because the JS engine sees the size of the native at finalization time but does not see updates to this size after a new reflector is created. Thus the engine's idea of the size of a native can become incorrect and the memory accounting can become unbalanced. Consider the following situation: 1. Native object created of size 20MB 2. Reflector 1 created 3. Reflector 1 becomes unreachable 4. Reflector 2 created 5. Native size changes to 40MB 6. Reflector 1 finalized The memory associated with reflector 1 will be: 20MB (step 2), -20MB (step 6) The memory associated with reflector 2 will be: 20MB (step 4), 40MB (step 5) The memory associated with reflector 1 ends up negative (which should not be possible) and the total is also wrong. The patch runs the finalizer for any dead reflector when creating a new one. This ensures that finalizer sees the correct state. The native object pointer is cleared when this happens so when the GC later runs the finalizer again it is a no-op. This situation occurs pretty rarely so I don't think there is much overhead to running the finalizer more than once. This also allows us to tighten up the assertions in the finalizer. Differential Revision: https://phabricator.services.mozilla.com/D28690
24e75c822fd37393db9b1237ca42defe4ac89639: Bug 1536154 - Add memory tracker to Zone r=sfink
Jon Coppeard <jcoppeard@mozilla.com> - Wed, 24 Apr 2019 11:53:20 +0100 - rev 471904
Push 112962 by jcoppeard@mozilla.com at Tue, 30 Apr 2019 15:28:48 +0000
Bug 1536154 - Add memory tracker to Zone r=sfink Track external memory associated with JSObjects in a hash table keyed on GC thing and memory use. This ensures that memory associated with an object is correctly removed when the object is finalized. The different uses help to track down problems. Differential Revision: https://phabricator.services.mozilla.com/D28686
6cab2047fa7a7162b258fdaf5cb46e71ce1d70ff: Bug 1535866: Check if a valid DeviceContext is available before attempting to use it. r=rhunt
Bas Schouten <bschouten@mozilla.com> - Sat, 27 Apr 2019 21:01:29 +0000 - rev 471903
Push 112961 by bschouten@mozilla.com at Tue, 30 Apr 2019 15:27:16 +0000
Bug 1535866: Check if a valid DeviceContext is available before attempting to use it. r=rhunt Differential Revision: https://phabricator.services.mozilla.com/D29106
5d43e71f877076bdfc86676ac3f9944dca277097: Bug 1536229: Remove NS_RELEASE_ASSERT that is being tripped and seems to be unnecessary. r=rhunt
Bas Schouten <bschouten@mozilla.com> - Sat, 27 Apr 2019 17:31:49 +0000 - rev 471902
Push 112961 by bschouten@mozilla.com at Tue, 30 Apr 2019 15:27:16 +0000
Bug 1536229: Remove NS_RELEASE_ASSERT that is being tripped and seems to be unnecessary. r=rhunt Differential Revision: https://phabricator.services.mozilla.com/D29105
42f3c8e92866d864095e3c80f25d4fefada97d14: Merge mozilla-central to mozilla-inbound. CLOSED TREE
Sebastian Hengst <archaeopteryx@coole-files.de> - Tue, 30 Apr 2019 15:03:14 +0200 - rev 471901
Push 112960 by archaeopteryx@coole-files.de at Tue, 30 Apr 2019 13:04:04 +0000
Merge mozilla-central to mozilla-inbound. CLOSED TREE
90234f4c094dcc794df28fdd464793dfe065f943: Bug 1547416 - Move nsIPresShell::ScrollAxis to PresShellForwards.h: correct conflict fix. a=bustage-fix
Sebastian Hengst <archaeopteryx@coole-files.de> - Tue, 30 Apr 2019 14:11:09 +0200 - rev 471900
Push 112960 by archaeopteryx@coole-files.de at Tue, 30 Apr 2019 13:04:04 +0000
Bug 1547416 - Move nsIPresShell::ScrollAxis to PresShellForwards.h: correct conflict fix. a=bustage-fix
25e7e6e1239ad796626095f9c80ed19709b791de: Merge mozilla-central to mozilla-inbound. CLOSED TREE
Sebastian Hengst <archaeopteryx@coole-files.de> - Tue, 30 Apr 2019 13:38:11 +0200 - rev 471899
Push 112959 by archaeopteryx@coole-files.de at Tue, 30 Apr 2019 11:38:46 +0000
Merge mozilla-central to mozilla-inbound. CLOSED TREE
83950e03831430c0a00db8b83890d51aad0ff43c: Merge mozilla-inbound to mozilla-central. a=merge
Sebastian Hengst <archaeopteryx@coole-files.de> - Tue, 30 Apr 2019 13:33:07 +0200 - rev 471898
Push 112959 by archaeopteryx@coole-files.de at Tue, 30 Apr 2019 11:38:46 +0000
Merge mozilla-inbound to mozilla-central. a=merge
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip