32af88ce76dab548742417a74be9a13043540143: Backed out 2 changesets (bug 1488439) for build bustage at /build/src/dom/plugins/ipc/PluginProcessParent.cpp on a CLOSED TREE
Coroiu Cristina <ccoroiu@mozilla.com> - Fri, 12 Oct 2018 21:00:41 +0300 - rev 441046
Push 108898 by aciure@mozilla.com at Sat, 13 Oct 2018 09:41:13 +0000
Backed out 2 changesets (bug 1488439) for build bustage at /build/src/dom/plugins/ipc/PluginProcessParent.cpp on a CLOSED TREE Backed out changeset 74b2087ee696 (bug 1488439) Backed out changeset 85575fc37555 (bug 1488439)
a9cb7624c15de659ef31809a19bac825d46e4b18: Bug 1496059 - Make Windows MSVC builds Tier 1. r=froydnj
Ryan VanderMeulen <ryanvm@gmail.com> - Fri, 12 Oct 2018 17:45:01 +0000 - rev 441045
Push 108898 by aciure@mozilla.com at Sat, 13 Oct 2018 09:41:13 +0000
Bug 1496059 - Make Windows MSVC builds Tier 1. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D8457
40af17ba0d2cfda60b2b4e110c025a06618dc316: Bug 1496059 - Run Windows MSVC builds on all branches. r=froydnj
Ryan VanderMeulen <ryanvm@gmail.com> - Fri, 12 Oct 2018 17:44:53 +0000 - rev 441044
Push 108898 by aciure@mozilla.com at Sat, 13 Oct 2018 09:41:13 +0000
Bug 1496059 - Run Windows MSVC builds on all branches. r=froydnj Also removes the signing jobs since they're not needed anymore. Differential Revision: https://phabricator.services.mozilla.com/D8456
1ade03649066860b07165fe788f28f48a0d24a38: Bug 1496059 - Turn off tests for Windows MSVC builds. r=froydnj,ahal,jmaher
Ryan VanderMeulen <ryanvm@gmail.com> - Fri, 12 Oct 2018 17:44:51 +0000 - rev 441043
Push 108898 by aciure@mozilla.com at Sat, 13 Oct 2018 09:41:13 +0000
Bug 1496059 - Turn off tests for Windows MSVC builds. r=froydnj,ahal,jmaher Also removes the signing jobs since they're not needed anymore. Differential Revision: https://phabricator.services.mozilla.com/D8455
f464ecbaeeda2c62e78f5a3b862597f737601f8a: Bug 1496059 - Don't use PGO for Windows opt-msvc builds now that they're not being shipped. r=froydnj
Ryan VanderMeulen <ryanvm@gmail.com> - Fri, 12 Oct 2018 17:44:43 +0000 - rev 441042
Push 108898 by aciure@mozilla.com at Sat, 13 Oct 2018 09:41:13 +0000
Bug 1496059 - Don't use PGO for Windows opt-msvc builds now that they're not being shipped. r=froydnj This is a straight revert of bug 1474756. Differential Revision: https://phabricator.services.mozilla.com/D8454
74b2087ee696eb7369b65727b81fc67121789f7d: Bug 1488439: Part 2 - Patch GetFileAttributesW for appdata parent folders in sandboxed plugin process (r=bobowen,jmathies)
David Parks <dparks@mozilla.com> - Fri, 12 Oct 2018 17:41:29 +0000 - rev 441041
Push 108898 by aciure@mozilla.com at Sat, 13 Oct 2018 09:41:13 +0000
Bug 1488439: Part 2 - Patch GetFileAttributesW for appdata parent folders in sandboxed plugin process (r=bobowen,jmathies) Flash analyzes the parents of the path to its appdata folder on Windows using GetFileAttributesW. If it runs into an error, it makes some internal decisions that cause it to break DRM video. Our new sandbox hardening causes GetFileAttributesW to return an error for some components of the path. This patch alters the behavior of GetFileAttributesW so that it always reports FILE_ATTRIBUTE_DIRECTORY for any path that both 1) would otherwise return an error and 2) is an ancestor of the appdata folder. This may not always be 100% accurate (for instance, if the folder is a reparse point) but restores video functionality. Depends on D7532 Differential Revision: https://phabricator.services.mozilla.com/D7533
53dfca556ff165528d145ebcaf64186ca274ccd3: Bug 1197370 - Add chown method to adb.py, refactor chmod r=bc
Edwin Gao <egao@mozilla.com> - Fri, 12 Oct 2018 16:58:35 +0000 - rev 441040
Push 108898 by aciure@mozilla.com at Sat, 13 Oct 2018 09:41:13 +0000
Bug 1197370 - Add chown method to adb.py, refactor chmod r=bc Behavior changes: - added method for ADBDevice class called chown - when initializing ADBDevice class, check if recursive flag is supported (similar to chmod -R) Other changes: - handling for situation where recursive is desired but -R flag is not supported is in place - changed behavior above situation to mirror chmod (creation of temporary file based on `self.ls` output, then executing script on device using adb Unit Tests: - unit tests to exercise attributes and common paths created. Would need further expansion of tests at some point. - additional mocking fixtures created. Differential Revision: https://phabricator.services.mozilla.com/D8128
2064477895c3d93ec55cab9dede17ba01a434b21: Bug 1494069 - [lint] Explicitly list out objdirs rather than depend on 'obj*' in the global exclude, r=rwood
Andrew Halberstadt <ahalberstadt@mozilla.com> - Fri, 12 Oct 2018 15:57:44 +0000 - rev 441039
Push 108898 by aciure@mozilla.com at Sat, 13 Oct 2018 09:41:13 +0000
Bug 1494069 - [lint] Explicitly list out objdirs rather than depend on 'obj*' in the global exclude, r=rwood When using globs in exclude directorives, FileFinder will return every *file* that gets matched. This is can be thousands of files in the case of an objdir. While we now collapse these files down to highest possible directories, this collapse operation can still take a noticeable amount of time (0.6s). This simply scans topsrcdir for files that start with 'obj' to avoid the glob. This also moves the '_activate_virtualenv' call to the top of the function because in CI, this will cause an objdir to be created (to store the virtualenv). If this happens *after* calculating the global excludes, we won't catch it since it doesn't exist yet. This will result in the objdir's virtualenv being linted and erroneous failures. Depends on D7739 Differential Revision: https://phabricator.services.mozilla.com/D7740
b7e586708ecccea803d5c4b77e3f9d7bbcb912f6: Bug 1494069 - [mozlint] Collapse exclude paths into their smallest possible set, r=egao
Andrew Halberstadt <ahalberstadt@mozilla.com> - Fri, 12 Oct 2018 15:57:42 +0000 - rev 441038
Push 108898 by aciure@mozilla.com at Sat, 13 Oct 2018 09:41:13 +0000
Bug 1494069 - [mozlint] Collapse exclude paths into their smallest possible set, r=egao Often we specify globs in our exclude patterns, e.g: exclude: - **/node_modules - obj* However, these globs get expanded out to *every* file that matches them. This can sometimes be thousands or even tens of thousands of files. We then pass these paths on to the underlying linters and tell them to exclude them all. This causes a lot of overhead and slows down performance. This commit implements a "collapse" function. Given a set of paths, it'll collapse them into the smallest set of parent directories that contain the original set, and that don't contain any extra files. For example, given a directory structure like this: a -- foo.txt -- b -- bar.txt -- baz.txt -- c -- ham.txt -- d -- spam.txt Then the following will happen: >>> collapse(['a/foo.txt', 'a/b/bar.txt', 'a/c/ham.txt', 'a/c/d/spam.txt']) ['a/foo.txt', 'b/bar.txt', 'c'] Since all files under directory 'c' are specified by the original set (both 'c/ham.txt' and 'c/d/spam.txt'), we can collapse it down to just 'c'. However not all files under 'b' are specified (we're missing 'a/b/baz.txt'), so we can't collapse 'b' (and by extension also can't collapse 'a'). If we had included 'a/b/baz.txt': >>> collapse(['a/foo.txt', 'a/b/bar.txt', 'a/b/baz.txt', 'a/c/ham.txt', 'a/c/d/spam.txt']) ['a'] In both cases, the smallest set of paths that contains the original set (and only the original set) is computed. The collapse function has a little bit of overhead but it's not too bad. For example collapsing all files matched by '**/node_modules' takes ~0.015s. Collapsing two full objdirs, takes ~0.6s. But a follow up commit is planned to make sure we stop using 'obj*' to reduce that overhead. Depends on D7738 Differential Revision: https://phabricator.services.mozilla.com/D7739
85575fc37555213a204b8565bbadef7270edd19e: Bug 1488439: Part 1 - Replace Windows temp folder in sandboxed plugin process (r=bobowen,erahm)
David Parks <dparks@mozilla.com> - Fri, 12 Oct 2018 17:40:10 +0000 - rev 441037
Push 108898 by aciure@mozilla.com at Sat, 13 Oct 2018 09:41:13 +0000
Bug 1488439: Part 1 - Replace Windows temp folder in sandboxed plugin process (r=bobowen,erahm) The sandbox blocks GetTempFileName's prior response, causing the system to end up searching a number of (inaccessible) folders to use as a replacement for the temp folder. This patch provides a path to a new folder on the command line for the plugin process. This new temp folder, specific to this plugin process instance, is then communicated to the system via the TEMP/TMP environment variables. This is similar to what is done for the content process but avoids nsDirectoryService, which doesn't exist in plugin processes. Differential Revision: https://phabricator.services.mozilla.com/D7532
b4d64ab443eaf93f046597999253c76e7461953d: Bug 1498316 - Limit the number of nsFontMetrics entries cached by each device context, to avoid excessive growth of this cache in examples such as animated font variations or sizes. r=lsalzman
Jonathan Kew <jkew@mozilla.com> - Sat, 13 Oct 2018 10:03:37 +0100 - rev 441036
Push 108897 by jkew@mozilla.com at Sat, 13 Oct 2018 09:04:14 +0000
Bug 1498316 - Limit the number of nsFontMetrics entries cached by each device context, to avoid excessive growth of this cache in examples such as animated font variations or sizes. r=lsalzman
54598c1940f1b4cf12c1e122431ce709237c686f: Bug 1498680 - Fix wpt runner's browser stop implementation: request stop before waiting; r=kwierso
Wes Kocher <wkocher@mozilla.com> - Fri, 12 Oct 2018 23:55:47 -0700 - rev 441035
Push 108896 by wkocher@mozilla.com at Sat, 13 Oct 2018 07:30:28 +0000
Bug 1498680 - Fix wpt runner's browser stop implementation: request stop before waiting; r=kwierso The current implementation waits for fennec to stop before trying to stop it - easy enough to address. At the same time, I am updating the runner stop implementation to try stop_application before kill: stop_application shuts down the application more cleanly; kill should only be used as a backup.
2cc5b3f51ec4fa0501af01e4ece67be0eed814c4: Bug 1256603. Fix comment in ImageLoader. r=aosmond
Timothy Nikkel <tnikkel@gmail.com> - Sat, 13 Oct 2018 00:31:03 -0500 - rev 441034
Push 108895 by tnikkel@gmail.com at Sat, 13 Oct 2018 05:31:39 +0000
Bug 1256603. Fix comment in ImageLoader. r=aosmond
d8bb90ade0d68eaf309127cb51840c722e4008b5: Bug 1256603. Fix comment for imgIContainer::RequestDecodeForSize to match reality. r=aosmond
Timothy Nikkel <tnikkel@gmail.com> - Sat, 13 Oct 2018 00:31:03 -0500 - rev 441033
Push 108895 by tnikkel@gmail.com at Sat, 13 Oct 2018 05:31:39 +0000
Bug 1256603. Fix comment for imgIContainer::RequestDecodeForSize to match reality. r=aosmond
479653ce6d8c31dd5cddc815f9ad19a5b06b7fda: Bug 1256603. Make aMarkUsed parameters required everywhere. r=aosmond
Timothy Nikkel <tnikkel@gmail.com> - Sat, 13 Oct 2018 00:31:03 -0500 - rev 441032
Push 108895 by tnikkel@gmail.com at Sat, 13 Oct 2018 05:31:39 +0000
Bug 1256603. Make aMarkUsed parameters required everywhere. r=aosmond
8421b16c011ba49a2e495f81853b282413aa7650: Bug 1256603. Only mark images as used in the surface cache if we actually use them. r=aosmond
Timothy Nikkel <tnikkel@gmail.com> - Sat, 13 Oct 2018 00:31:02 -0500 - rev 441031
Push 108895 by tnikkel@gmail.com at Sat, 13 Oct 2018 05:31:39 +0000
Bug 1256603. Only mark images as used in the surface cache if we actually use them. r=aosmond We were marking them used even if only a decode was requested. This can cause us to hold extra decoded copies of the image around because we have a tendency to request decode at the intrinsic size.
0c5f5c2e2a860f9f681e301662aabe2deca8be4b: No bug - Fix compiler warnings on Windows.
Jeff Gilbert <jgilbert@mozilla.com> - Fri, 12 Oct 2018 15:21:40 -0700 - rev 441030
Push 108894 by jgilbert@mozilla.com at Sat, 13 Oct 2018 04:38:04 +0000
No bug - Fix compiler warnings on Windows.
64298e3625ed2a90ec6b64bfba0fb630ab607d2b: No bug - Replace tabs with spaces, strip EOL whitespace.
Jeff Gilbert <jgilbert@mozilla.com> - Fri, 12 Oct 2018 15:16:45 -0700 - rev 441029
Push 108894 by jgilbert@mozilla.com at Sat, 13 Oct 2018 04:38:04 +0000
No bug - Replace tabs with spaces, strip EOL whitespace.
2aede0d5656f05304e2a584cabd0ce9c0337723f: Bug 1498433: Ensure that crash reporter is in the foreground and focused on macOS. r=mstange
Stephen A Pohl <spohl.mozilla.bugs@gmail.com> - Fri, 12 Oct 2018 22:46:40 -0400 - rev 441028
Push 108893 by spohl@mozilla.com at Sat, 13 Oct 2018 02:47:00 +0000
Bug 1498433: Ensure that crash reporter is in the foreground and focused on macOS. r=mstange
3ee73bef9537d1d2f09d397150238523be4f6891: Backed out changeset f7c32e7abf72 (bug 1498458) for causing SM build bustages on oom-allocating-arraybuffer-contents.
Cosmin Sabou <csabou@mozilla.com> - Sat, 13 Oct 2018 04:51:18 +0300 - rev 441027
Push 108892 by csabou@mozilla.com at Sat, 13 Oct 2018 01:52:49 +0000
Backed out changeset f7c32e7abf72 (bug 1498458) for causing SM build bustages on oom-allocating-arraybuffer-contents.
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip