2eaeb35d81d6ff8aff7b3944a5bfe7dd5693dac7: Bug 1591007 - Save Changes in Manage Data dialog in preferences doesn't close the dialog, r=Gijs
JaStenson <jacob@nosnets.co.uk> - Thu, 14 Nov 2019 15:30:27 +0000 - rev 501967
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1591007 - Save Changes in Manage Data dialog in preferences doesn't close the dialog, r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D53020
e727898953edb7c1b536cace1e7add0a7de2a536: Bug 1594743 - ensure that the keyboard audit does not interfere with other audit types. r=nchevobbe
Yura Zenevich <yura.zenevich@gmail.com> - Tue, 12 Nov 2019 15:05:42 +0000 - rev 501966
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1594743 - ensure that the keyboard audit does not interfere with other audit types. r=nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D52378
6e1a7f2f6bb2a106ba490556ee1effd411726651: Bug 1500049 - Wait for MediaCacheStreams to close properly before finishing MediaDecoder shutdown. r=bryce
Andreas Pehrson <apehrson@mozilla.com> - Wed, 13 Nov 2019 22:40:14 +0000 - rev 501965
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1500049 - Wait for MediaCacheStreams to close properly before finishing MediaDecoder shutdown. r=bryce Differential Revision: https://phabricator.services.mozilla.com/D52052
4b0c0545d300dfcfd8a1dfe38621e6513b3b3a79: Bug 1302379 - Remove FinishedOnInactive hack from DOMMediaStream. r=jib
Andreas Pehrson <apehrson@mozilla.com> - Wed, 13 Nov 2019 22:40:16 +0000 - rev 501964
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1302379 - Remove FinishedOnInactive hack from DOMMediaStream. r=jib It is no longer needed with captured tracks' lifetimes spanning across seek operations. Differential Revision: https://phabricator.services.mozilla.com/D52051
a26e7fcb649ad67e85424c4db3bde8d91f807713: Bug 1546756 - Update WPT expectations following bug 1172394. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 14 Nov 2019 14:33:44 +0000 - rev 501963
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1546756 - Update WPT expectations following bug 1172394. r=padenot mediaElementAudioSourceToScriptProcessorTest creates an AudioContext at sample rate 44100, but that might not be the default cubeb rate on some platforms. If it isn't, we end up with two MediaTrackGraphs for the same window, with one being fed by the media element, and the other running the script processor node. It's when this happens that we only get 0 on the output. We force the preferred cubeb rate to 44100 for this test, so we at least keep the test coverage of the media element source node. This became permafail with bug 1172394, whereas before it was intermittent. Unclear why. Differential Revision: https://phabricator.services.mozilla.com/D52050
2516219862e8105ea4a782aaf4b55abfed95ca43: Bug 1172394 - Forward direct listeners to all inputs over a ForwardedInputTrack's lifetime. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 14 Nov 2019 14:56:00 +0000 - rev 501962
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1172394 - Forward direct listeners to all inputs over a ForwardedInputTrack's lifetime. r=padenot This was not needed when inputs to a ForwardedInputTrack could not come and go, but they can now. This keeps direct listeners for a ForwardedInputTrack around until it ends, as that's the terminal state where we know we can no longer process another input. Depends on D52049 Differential Revision: https://phabricator.services.mozilla.com/D53015
ae3cd36f38f669205933cb5c54e3e9a1b4144d99: Bug 1172394 - Always mark a MediaStreamAudioSourceNode attached to a live track as active. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 14 Nov 2019 14:33:44 +0000 - rev 501961
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1172394 - Always mark a MediaStreamAudioSourceNode attached to a live track as active. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D52049
2d4bb8556f0815eb766b781b9d0bf9e086d2cc0d: Bug 1172394 - Ignore video tracks in autoplay checks in MediaStreamAudioSourceNode. r=alwu
Andreas Pehrson <apehrson@mozilla.com> - Wed, 13 Nov 2019 22:39:53 +0000 - rev 501960
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1172394 - Ignore video tracks in autoplay checks in MediaStreamAudioSourceNode. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D52048
6bcd10fe43b97a778ab72ca534fca01d161a8ce5: Bug 1172394 - Hinge UpdateReadyStateInternal off watchables instead of direct updates. r=bryce
Andreas Pehrson <apehrson@mozilla.com> - Wed, 13 Nov 2019 22:39:55 +0000 - rev 501959
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1172394 - Hinge UpdateReadyStateInternal off watchables instead of direct updates. r=bryce Differential Revision: https://phabricator.services.mozilla.com/D52047
4f27806289e24d59e576305d93dbf1305c0e4ba3: Bug 1172394 - Use tail dispatching instead of mSrcStreamTracksAvailable. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Wed, 13 Nov 2019 22:39:58 +0000 - rev 501958
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1172394 - Use tail dispatching instead of mSrcStreamTracksAvailable. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D52046
9d3f254944454ae286c3b8c02cc65ebfc1fd35b8: Bug 1172394 - Update test_streams_element_capture_reset.html per new seeking behavior. r=jib
Andreas Pehrson <apehrson@mozilla.com> - Wed, 13 Nov 2019 22:40:00 +0000 - rev 501957
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1172394 - Update test_streams_element_capture_reset.html per new seeking behavior. r=jib Differential Revision: https://phabricator.services.mozilla.com/D52045
bff56fd97a88ed14df3dda90e57e2bda23b5275e: Bug 1172394 - Modernize test_streams_element_capture_reset.html. r=jib
Andreas Pehrson <apehrson@mozilla.com> - Wed, 13 Nov 2019 22:40:02 +0000 - rev 501956
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1172394 - Modernize test_streams_element_capture_reset.html. r=jib Differential Revision: https://phabricator.services.mozilla.com/D52044
b91bd828c657d85120fe02e57410a0b82ec0acd3: Bug 1172394 - Simplify MediaSink somewhat. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Wed, 13 Nov 2019 22:40:05 +0000 - rev 501955
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1172394 - Simplify MediaSink somewhat. r=padenot This patches does several minor things: - Moves SetSink (from setSinkid) to automatic coalescing of multiple calls through a Canonical/Mirror setup instead of a manual atomic counter. - Simplifies the logic for when to update the sink in SetSink. - Removes PlaybackParams as a general MediaSink property, as it only contains audio params. - Makes PlaybackParams an internal AudioSink concept, that AudioSinkWrapper knows about. - Ensures mMediaSink is only accessed on the decoder TaskQueue, to allow accessing mirrored members when creating it. Differential Revision: https://phabricator.services.mozilla.com/D52043
fdf5dd8ff80792a48fd00771850104df655cd866: Bug 1172394 - Refactor how DecodedStream is set up. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Wed, 13 Nov 2019 22:40:07 +0000 - rev 501954
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1172394 - Refactor how DecodedStream is set up. r=padenot This patch removes the responsibility of js-facing MediaStreamTracks from the MediaDecoder stack, and moves the machinery for setting up DecodedStream to higher order functions like state mirroring and watchables. OutputStreamManager is completely gone, since it was designed to manage MediaStreamTracks across multiple output streams for a single decoder, on main thread. HTMLMediaElement took over its task in the previous patch. The MediaDecoderStateMachine now has three control points for capturing: - mOutputCaptured, which, if true, will capture all decoded data into mOutputTracks. If this is set, but mOutputTracks is empty, we are still waiting for tracks, and DecodedStream will not play any data. When tracks are set, a new DecodedStream is created that will play data through SourceMediaTracks piped into mOutputTracks. - mOutputTracks, which is the set of tracks data is captured into, for forwarding to all the output tracks the media element is managing. This set of tracks is managed by the MediaDecoder owner, and must contain one audio track if the decoder is decoding audio, and one video track if the decoder is decoding video. It may be empty since output can be captured before metadata is loaded, or playback has ended. - mOutputPrincipal, which is the principal of the decoded data. All data sent into SourceMediaTracks is tagged with this principal. Differential Revision: https://phabricator.services.mozilla.com/D52042
9114318b64930ec2e51c69567fa1281aa8f4f210: Bug 1172394 - Merge MediaStream and MediaDecoder track sources. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Wed, 13 Nov 2019 22:40:09 +0000 - rev 501953
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1172394 - Merge MediaStream and MediaDecoder track sources. r=padenot This reworks how media element captureStream works by removing the differences between MediaStream and MediaDecoder capture. MediaDecoder capture will be refactored so that ownership of MediaStreamTracks lies with the media element instead of the OutputStreamManager. The internal MediaDecoder parts happen in a later patch. The new API for capturing a MediaDecoder involves a boolean on/off toggle, the output tracks the decoder pipes data to, and the principal that data is tagged with. If capturing is on but there are no output tracks, playback will not happen, to ensure that no data gets accidentally skipped in the output tracks while captured. This also changes the logic for setting up MediaElementTrackSources in HTMLMediaElement so it's triggered by the WatchManager and thus run in tail dispatched runnables. Differential Revision: https://phabricator.services.mozilla.com/D52040
8e45c51fc6cfe95e6cdb8d54bf635d8a5751c06e: Bug 1172394 - Make dom::MediaTrack lifetime spec compliant. r=bryce
Andreas Pehrson <apehrson@mozilla.com> - Wed, 13 Nov 2019 22:40:12 +0000 - rev 501952
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1172394 - Make dom::MediaTrack lifetime spec compliant. r=bryce This makes us forget tracks at the right times. The spec also says no removetrack events should be fired because of this, yet it seems to be something other user agents do: https://wpt.fyi/results/media-source/mediasource-avtracks.html This is of low importance however, since MediaTracks are prefed off by default. Differential Revision: https://phabricator.services.mozilla.com/D52038
e20ee1ce7ce5a7fd144cedbb051c3858d9f91550: Bug 1172394 - Don't remove dom::MediaTracks on chained metadata updates. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Wed, 13 Nov 2019 22:39:46 +0000 - rev 501951
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1172394 - Don't remove dom::MediaTracks on chained metadata updates. r=padenot HTMLMediaElement avoid creating new tracks in MetadataLoaded when it has already created some, so there should be no side effect to this patch. Differential Revision: https://phabricator.services.mozilla.com/D52037
5b466cf155f9df1f059731abc615cf775e6a5ca0: Bug 1172394 - Perform some forgotten Stream -> Track renaming in DecodedStream. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Wed, 13 Nov 2019 22:39:48 +0000 - rev 501950
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1172394 - Perform some forgotten Stream -> Track renaming in DecodedStream. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D52036
4e3a2ac7a81d5fea15fe332f478037d8d4b0e925: Bug 1594520 - Change directory before running mach in .vscode/tasks.json on Windows. r=jya
Ted Campbell <tcampbell@mozilla.com> - Thu, 14 Nov 2019 10:35:12 +0000 - rev 501949
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1594520 - Change directory before running mach in .vscode/tasks.json on Windows. r=jya The build is quite fragile if the path to mach is not precisely formatted. Work around this by cd-ing to the appropriate directory and then calling 'mach' with a relative path. This mimics a normal user workflow in mozilla-build. Differential Revision: https://phabricator.services.mozilla.com/D52968
393442f15e7de96ea6e34cee4fe722f60fab1532: Bug 1595563 - Remove usage of static_cast<{Audio|Video}Data*> in MediaFormatReader. r=jya
Michael Froman <mfroman@mozilla.com> - Thu, 14 Nov 2019 10:35:40 +0000 - rev 501948
Push 114172 by dluca@mozilla.com at Tue, 19 Nov 2019 11:31:10 +0000
Bug 1595563 - Remove usage of static_cast<{Audio|Video}Data*> in MediaFormatReader. r=jya Differential Revision: https://phabricator.services.mozilla.com/D52881
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 tip