25e1607e6f1e5345cccb8eb501b7cbdad182f9fb: Bug 1547143 - Force the pointer style declaration r=Ehsan
Sylvestre Ledru <sledru@mozilla.com> - Wed, 01 May 2019 08:46:08 +0000 - rev 472093
Push 112978 by apavel@mozilla.com at Wed, 01 May 2019 16:09:45 +0000
Bug 1547143 - Force the pointer style declaration r=Ehsan Differential Revision: https://phabricator.services.mozilla.com/D28954
0e259884f052230b24601efc3cde3a5ef5d4e6ad: Bug 1535945 - Don't skip invalidating frames when creating displayports for async scrollable ancestors. r=tnikkel
Matt Woodrow <mwoodrow@mozilla.com> - Wed, 01 May 2019 04:23:07 +0000 - rev 472092
Push 112978 by apavel@mozilla.com at Wed, 01 May 2019 16:09:45 +0000
Bug 1535945 - Don't skip invalidating frames when creating displayports for async scrollable ancestors. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D23816
732976d3f555a01d9032ede89a28121502ee49e2: Bug 1546459 - remove subsuite=clipboard from manifests. r=ahal
Joel Maher <jmaher@mozilla.com> - Wed, 01 May 2019 08:16:44 +0000 - rev 472091
Push 112978 by apavel@mozilla.com at Wed, 01 May 2019 16:09:45 +0000
Bug 1546459 - remove subsuite=clipboard from manifests. r=ahal remove subsuite=clipboard from manifests Differential Revision: https://phabricator.services.mozilla.com/D28521
995c47d0986b486a6323ea87d32962ed634add41: Bug 1546620 - Add a numDebuggeeRealms counter to JSRuntime. r=jorendorff
Jan de Mooij <jdemooij@mozilla.com> - Wed, 01 May 2019 08:07:31 +0000 - rev 472090
Push 112978 by apavel@mozilla.com at Wed, 01 May 2019 16:09:45 +0000
Bug 1546620 - Add a numDebuggeeRealms counter to JSRuntime. r=jorendorff The Baseline Interpreter will use incrementNumDebuggeeRealms and decrementNumDebuggeeRealms to toggle some debugging things if needed. Differential Revision: https://phabricator.services.mozilla.com/D28636
e607a590c53cf628517629383acbdc922534f8a9: Bug 1514425 - disable webpayment tests as we do not currently ship this feature. r=marcosc,edenchuang
Joel Maher <jmaher@mozilla.com> - Wed, 01 May 2019 06:59:03 +0000 - rev 472089
Push 112978 by apavel@mozilla.com at Wed, 01 May 2019 16:09:45 +0000
Bug 1514425 - disable webpayment tests as we do not currently ship this feature. r=marcosc,edenchuang disable webpayment tests as we do not currently ship this feature Differential Revision: https://phabricator.services.mozilla.com/D28834
38c57ccca71e24c90e73bfd2a06bd6a1de6b17db: Bug 1545395 - Handle Search Engine urls properly where the search terms are in the url rather than as parameters. r=daleharvey
Mark Banner <standard8@mozilla.com> - Tue, 30 Apr 2019 21:25:28 +0000 - rev 472088
Push 112978 by apavel@mozilla.com at Wed, 01 May 2019 16:09:45 +0000
Bug 1545395 - Handle Search Engine urls properly where the search terms are in the url rather than as parameters. r=daleharvey Differential Revision: https://phabricator.services.mozilla.com/D29014
47ea779dc66b06fdcc4a247fbe29bf9770cefa8b: Backed out 2 changesets (bug 1545766, bug 1546633) for causing browser_PanelMultiView_keyboard.js to perma fail CLOSED TREE
Ciure Andrei <aciure@mozilla.com> - Wed, 01 May 2019 09:02:48 +0300 - rev 472087
Push 112978 by apavel@mozilla.com at Wed, 01 May 2019 16:09:45 +0000
Backed out 2 changesets (bug 1545766, bug 1546633) for causing browser_PanelMultiView_keyboard.js to perma fail CLOSED TREE Backed out changeset 041741ce1646 (bug 1546633) Backed out changeset fbc294a6fe78 (bug 1545766)
041741ce164674137968c39aab0a9c80e84c99db: Bug 1546633: PanelMultiView: Send mousedown event when activating a button via the keyboard. r=Gijs
James Teh <jteh@mozilla.com> - Wed, 01 May 2019 04:01:35 +0000 - rev 472086
Push 112978 by apavel@mozilla.com at Wed, 01 May 2019 16:09:45 +0000
Bug 1546633: PanelMultiView: Send mousedown event when activating a button via the keyboard. r=Gijs Previously, we sent a command event and a click event. Normally, the command event executes the action, then the click event closes the menu. However, in some cases (e.g. the Library button), there is no command event handler and the mousedown event executes the action instead. Differential Revision: https://phabricator.services.mozilla.com/D29151
fbc294a6fe785b56a5ef52b5b1ea61d511bebc52: Bug 1545766: PanelMultiView: Don't override keyboard navigation in embedded documents. r=Gijs
James Teh <jteh@mozilla.com> - Wed, 01 May 2019 04:01:35 +0000 - rev 472085
Push 112978 by apavel@mozilla.com at Wed, 01 May 2019 16:09:45 +0000
Bug 1545766: PanelMultiView: Don't override keyboard navigation in embedded documents. r=Gijs Extension panels contain embedded documents; i.e. a <browser> element. We want users to be able to tab to these and we want them to be focused automatically if a subview is opened from the keyboard, so treat them as tabbable. However, once an embedded document is focused, we can't manage keyboard navigation inside it, so don't try. Previously, we tried, which meant keys were overridden even though they didn't do anything, breaking keyboard navigation in extensions altogether. Differential Revision: https://phabricator.services.mozilla.com/D28442
9a0ce3016f03a914367e86c8339a8b885e309c83: Bug 1493225, part 4 - Cancel content JS when navigating through history to prevent hangs r=smaug
Jim Porter <jporter@mozilla.com> - Tue, 30 Apr 2019 23:32:01 +0000 - rev 472084
Push 112978 by apavel@mozilla.com at Wed, 01 May 2019 16:09:45 +0000
Bug 1493225, part 4 - Cancel content JS when navigating through history to prevent hangs r=smaug Add tests to verify the behavior of the previous patches. Differential Revision: https://phabricator.services.mozilla.com/D27370
100acc204e5e0c5e8767740c4861c906e21139f5: Bug 1493225, part 3 - Cancel content JS when navigating through history to prevent hangs r=smaug
Jim Porter <jporter@mozilla.com> - Tue, 30 Apr 2019 23:31:46 +0000 - rev 472083
Push 112978 by apavel@mozilla.com at Wed, 01 May 2019 16:09:45 +0000
Bug 1493225, part 3 - Cancel content JS when navigating through history to prevent hangs r=smaug This patch adds an ID to ensure that we avoid canceling content JS if the next page already started loading by the time we're ready to try canceling the JS. Differential Revision: https://phabricator.services.mozilla.com/D25164
a7fa3041bff04a25fa39fb6f714071314f3cc69b: Bug 1493225, part 2 - Cancel content JS when navigating through history to prevent hangs r=smaug
Jim Porter <jporter@mozilla.com> - Tue, 30 Apr 2019 23:31:36 +0000 - rev 472082
Push 112978 by apavel@mozilla.com at Wed, 01 May 2019 16:09:45 +0000
Bug 1493225, part 2 - Cancel content JS when navigating through history to prevent hangs r=smaug In this part, we pass along the navigation type (and index for when using the dropdown on the back/forward buttons). This allows us to check if there's a top-level load "between" the start and end pages. The patch might look a bit strange, since we're passing the navigation operation to two places from RemoteWebNavigation.js (the normal message passing that existed before this patch and the HangMonitor channel in this patch). This is primarily to make it easier to stop passing the navigation info along the HangMonitor channel once session history is uplifted into the parent process. At that point, the check for whether there's a top-level load could happen in TabParent (I think). Differential Revision: https://phabricator.services.mozilla.com/D23090
5c3bff8f45d696710545579b14346a65c07aa2cf: Bug 1493225, part 1 - Cancel content JS when navigating through history to prevent hangs r=smaug
Jim Porter <jporter@mozilla.com> - Tue, 30 Apr 2019 23:56:17 +0000 - rev 472081
Push 112978 by apavel@mozilla.com at Wed, 01 May 2019 16:09:45 +0000
Bug 1493225, part 1 - Cancel content JS when navigating through history to prevent hangs r=smaug This patch passes a message through the HangMonitor channel when navigating through history to cancel content JS that could hang the chrome JS in the content process responsible for history navigation. If the content JS is actually canceled, this also disables the BF cache for the current page, since it could end up in an inconsistent state due to the JS cancellation. Differential Revision: https://phabricator.services.mozilla.com/D23089
9242458b79d5ae6e9d48c9a2a591680d79c13211: Bug 1539804 - Quantumbar: Re-enable browser_urlbarStopSearchOnSelection.js and fix a couple of related problems. r=mak
Drew Willcoxon <adw@mozilla.com> - Wed, 01 May 2019 02:30:47 +0000 - rev 472080
Push 112978 by apavel@mozilla.com at Wed, 01 May 2019 16:09:45 +0000
Bug 1539804 - Quantumbar: Re-enable browser_urlbarStopSearchOnSelection.js and fix a couple of related problems. r=mak This test uncovered a couple of problems: (1) UrlbarController.handleKeyNavigation relies on event.defaultPrevented to tell whether the one-offs handled the key event. That's a problem when combined with deferring the down arrow key. handleKeyNavigation is called twice in that case. The first time, the event is deferred (so executeAction = false), and handleKeyNavigation calls event.preventDefault. The second time, the event is being replayed, but defaultPrevented is true from the previous call regardless of whether the one-offs actually handled the event. So handleKeyNavigation always returns early because it thinks the one-offs always handled the event, so it never properly replays down arrow keys. (2) UrlbarProviderUnifiedComplete's query promise is never resolved when the query is canceled. That's a problem in general of course but I tripped over it in this test because I need to check results after the query is canceled, and the test ended up hanging since UrlbarTestUtils waits for the query to finish in order to get its results. It's not a problem in UnifiedComplete itself per se because of course awesomebar uses UnifiedComplete too, and it doesn't have this problem. The difference is that nsAutoCompleteController::StopSearch calls input->OnSearchComplete() (via PostSearchCleanup): https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/toolkit/components/autocomplete/nsAutoCompleteController.cpp#1433 Quantumbar's UnifiedComplete provider is missing that behavior, so this patch adds it by resolving its query promise when the query is canceled. Differential Revision: https://phabricator.services.mozilla.com/D29300
cbdf3fdfcbac59d4ccac118d2e6a96ac360a94a5: Bug 1546498 - Split out MaybePrefetchMemory's check into two functions r=aklotz
Doug Thayer <dothayer@mozilla.com> - Wed, 01 May 2019 02:08:28 +0000 - rev 472079
Push 112978 by apavel@mozilla.com at Wed, 01 May 2019 16:09:45 +0000
Bug 1546498 - Split out MaybePrefetchMemory's check into two functions r=aklotz Temporarily just sidestep the issue in bug 1546498 (crash with latest SDK on startup in Windows 7) by just continuing to use the old method in Windows 7. We saw no wins in telemetry for Windows 7 anyway, so we should investigate why that is, and why we see a mysterious crash in the fallback code, in a followup bug. Differential Revision: https://phabricator.services.mozilla.com/D29239
4d0cb443ef8b8ae84d8ea3dd65da1d923da3ff0e: Bug 1547767 Fix buttons in Sync disconnect dialog r=bgrins
Andrew Swan <aswan@mozilla.com> - Tue, 30 Apr 2019 22:58:26 +0000 - rev 472078
Push 112978 by apavel@mozilla.com at Wed, 01 May 2019 16:09:45 +0000
Bug 1547767 Fix buttons in Sync disconnect dialog r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D29432
91859883a54dbdd7cc5376f379466ceb5e8b4e9b: Bug 1538540 - Sanity check frames after TextureCache clears r=bholley
Doug Thayer <dothayer@mozilla.com> - Tue, 30 Apr 2019 23:58:23 +0000 - rev 472077
Push 112978 by apavel@mozilla.com at Wed, 01 May 2019 16:09:45 +0000
Bug 1538540 - Sanity check frames after TextureCache clears r=bholley In trying to diagnose bug 1538540, I'm hitting my limits as far as simply staring at the code and trying to work out possible ways to hit the crash goes. This assertion will split the search space into clear-related causes and non-clear-related causes to narrow things down. Differential Revision: https://phabricator.services.mozilla.com/D29420
c9918832d469c13bb49f895ca2f7562a3f7c19df: Bug 1543627: Allow for --createProfile cmd line arg to work on macOS when Firefox is already running. r=spohl
Yuri <mozilla@yuriydev.com> - Wed, 01 May 2019 10:49:52 -0400 - rev 472076
Push 112977 by spohl@mozilla.com at Wed, 01 May 2019 14:50:11 +0000
Bug 1543627: Allow for --createProfile cmd line arg to work on macOS when Firefox is already running. r=spohl
c6640ffe809f4129e436205d8c5146f4bb90b059: Bug 1547677 - Rename the ReadBarriered wrapper type to WeakHeapPtr and remove WeakRef r=sfink
Jon Coppeard <jcoppeard@mozilla.com> - Mon, 29 Apr 2019 11:30:29 +0100 - rev 472075
Push 112976 by jcoppeard@mozilla.com at Wed, 01 May 2019 12:45:58 +0000
Bug 1547677 - Rename the ReadBarriered wrapper type to WeakHeapPtr and remove WeakRef r=sfink I removed WeakRef since this is already very close to WeakHeapPtr and is an alias of it. I think having the two is more confusing than using the same name for both (the difference is whether you trace it with TraceWeakEdge or sweep it in a more manual fashion). Differential Revision: https://phabricator.services.mozilla.com/D29180 Differential Revision: https://phabricator.services.mozilla.com/D29337
f210be8c82a050a4ea525db1568e7c137d9038b1: Bug 1533735 - Refactor render task pass assignment in preparation for the render graph work. r=gw,kvark
Nicolas Silva <nsilva@mozilla.com> - Mon, 29 Apr 2019 17:53:00 +0200 - rev 472074
Push 112975 by nsilva@mozilla.com at Wed, 01 May 2019 09:14:51 +0000
Bug 1533735 - Refactor render task pass assignment in preparation for the render graph work. r=gw,kvark In addition, batch together render tasks for the cached render tasks. Differential Revision: https://phabricator.services.mozilla.com/D23839
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip