20d58356323629b9b7cd3915842f1979810370dc: servo: Merge #13700 - Run bindings tests with whole crate (from Manishearth:bindgen-testing); r=emilio
Manish Goregaokar <manishsmail@gmail.com> - Wed, 12 Oct 2016 00:14:35 -0500 - rev 339958
Push 86548 by kwierso@gmail.com at Sat, 04 Feb 2017 01:35:21 +0000
servo: Merge #13700 - Run bindings tests with whole crate (from Manishearth:bindgen-testing); r=emilio We currently run bindgen's autogenerated `#[test]` blocks directly on the structs files. That is, after generating them, we run `rustc --test` on them. This works fine for now, but if you want to refer to types defined outside of these files (e.g. in https://bugzilla.mozilla.org/show_bug.cgi?id=1309165), the tests are broken. This puts a `cargo test -p style` in `./mach test-stylo`. I disabled doctests because they were failing (unable to find the `ns!()` and `atom!()` macros), and I couldn't figure out why -- will investigate in a later bug. r? @emilio Source-Repo: https://github.com/servo/servo Source-Revision: 7e192ce6442c69b38f1d86326464b3879fcb0368
d844fcce600ece7386e585fc002ee4ef524a8287: servo: Merge #13696 - Add a custom Debug formatter for ClippingRegion (from mrobinson:clipping_region_print); r=emilio
Martin Robinson <mrobinson@igalia.com> - Tue, 11 Oct 2016 20:58:49 -0500 - rev 339957
Push 86548 by kwierso@gmail.com at Sat, 04 Feb 2017 01:35:21 +0000
servo: Merge #13696 - Add a custom Debug formatter for ClippingRegion (from mrobinson:clipping_region_print); r=emilio <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because debug printing is untested. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> This will make display list dumps more likely to fit on a single line. Source-Repo: https://github.com/servo/servo Source-Revision: b9bd15ebb0e84b48d5b0e7d1e952a911960d4fef
fb24eb654269199c1954f73d415ebc4420d4743b: servo: Merge #13695 - avoid initializing image layers after repeat/origin values have already been written (from heycam:layer-init); r=Manishearth
Cameron McCormack <cam@mcc.id.au> - Tue, 11 Oct 2016 18:37:39 -0500 - rev 339956
Push 86548 by kwierso@gmail.com at Sat, 04 Feb 2017 01:35:21 +0000
servo: Merge #13695 - avoid initializing image layers after repeat/origin values have already been written (from heycam:layer-init); r=Manishearth <!-- Please describe your changes on the following line: --> @bors-servo r=manishearth given in https://bugzilla.mozilla.org/show_bug.cgi?id=1309081 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 4ca7ce6329421d031188dd071c4d75c475a0cc88
a8a707b7b5641596e8bce76e41e39056eb0db86f: servo: Merge #13647 - Unify all rooting traits under RootedReference (from nox:rootedreference); r=jdm
Anthony Ramine <n.oxyde@gmail.com> - Tue, 11 Oct 2016 17:00:55 -0500 - rev 339955
Push 86548 by kwierso@gmail.com at Sat, 04 Feb 2017 01:35:21 +0000
servo: Merge #13647 - Unify all rooting traits under RootedReference (from nox:rootedreference); r=jdm Source-Repo: https://github.com/servo/servo Source-Revision: cf2a6475cb3d7d98b925e7a235ebf36f6abe883d
b44b1bc74fa0d02675fa54d4a45c1cbba0eb20fe: servo: Merge #13602 - layout: Rewrite Servo's `vertical-align` support to match CSS 2.1 § 10.8, and implement `vertical-align: middle` per CSS 2.1 § 10.8.1 (from pcwalton:vertical-align-middle); r=mbrubeck
Patrick Walton <pcwalton@mimiga.net> - Tue, 11 Oct 2016 15:33:47 -0500 - rev 339954
Push 86548 by kwierso@gmail.com at Sat, 04 Feb 2017 01:35:21 +0000
servo: Merge #13602 - layout: Rewrite Servo's `vertical-align` support to match CSS 2.1 § 10.8, and implement `vertical-align: middle` per CSS 2.1 § 10.8.1 (from pcwalton:vertical-align-middle); r=mbrubeck `InlineMetrics` has been split into `InlineMetrics` for fragments and `LineMetrics` for lines. Both structures' fields have been renamed in order to more clearly delineate the difference between *space* and *content*. Vertical positioning of fragments has been reworked to take margins and borders into account only for replaced content. This patch fixes the `vertical_align_super_a.html` reftest. Servo now matches the rendering that Gecko and WebKit produce. Additionally, this includes a test for the popular inline-block centering technique described here: https://s.codepen.io/shshaw/fullpage/gEiDt?#Inline-Block r? @mbrubeck Source-Repo: https://github.com/servo/servo Source-Revision: 768a699fa5d822173b2247d6348413d09951a8bb
f578c95613a1c858456ca268ef078a5a6cf1f7f1: servo: Merge #13693 - Correct the unicode codes used for tree printing (from mrobinson:hexadecimal); r=emilio
Martin Robinson <mrobinson@igalia.com> - Tue, 11 Oct 2016 14:19:44 -0500 - rev 339953
Push 86548 by kwierso@gmail.com at Sat, 04 Feb 2017 01:35:21 +0000
servo: Merge #13693 - Correct the unicode codes used for tree printing (from mrobinson:hexadecimal); r=emilio <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because the tree printing code is untested and this is just a correction of a build fix. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> These were converted from inline UTF-8 to escape sequences, but the sequences should be in hexadecimal instead of decimal. Source-Repo: https://github.com/servo/servo Source-Revision: 717e438b64522b632d62991dc69e9131584db0f6
752a824583bf9b280c2f301c96cbd08b16818343: servo: Merge #13688 - stylo: Use AtomicRefCell for PerDocumentStyleData (from bholley:styleset_refcell); r=Manishearth
Bobby Holley <bobbyholley@gmail.com> - Tue, 11 Oct 2016 12:03:29 -0500 - rev 339952
Push 86548 by kwierso@gmail.com at Sat, 04 Feb 2017 01:35:21 +0000
servo: Merge #13688 - stylo: Use AtomicRefCell for PerDocumentStyleData (from bholley:styleset_refcell); r=Manishearth Gecko bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1309090 Source-Repo: https://github.com/servo/servo Source-Revision: 3916d1d61305bd27338cac4a9e9f9c110182582b
947ebc8b43fc8b3c435e02f41042894e040fafc9: servo: Merge #13677 - Use the fetch stack for HTMLMediaElement (from servo:media-fetch); r=Manishearth
Ms2ger <Ms2ger@gmail.com> - Tue, 11 Oct 2016 11:10:39 -0500 - rev 339951
Push 86548 by kwierso@gmail.com at Sat, 04 Feb 2017 01:35:21 +0000
servo: Merge #13677 - Use the fetch stack for HTMLMediaElement (from servo:media-fetch); r=Manishearth Source-Repo: https://github.com/servo/servo Source-Revision: 51bcf516c831f60a6fc05d970df5fad99730558e
1fbb397120eb5a59693f454216c3f915bc93aa36: servo: Merge #13675 - Clean up the parsers into a single interface (from nox:servoparser); r=Ms2ger
Anthony Ramine <n.oxyde@gmail.com> - Tue, 11 Oct 2016 10:16:23 -0500 - rev 339950
Push 86548 by kwierso@gmail.com at Sat, 04 Feb 2017 01:35:21 +0000
servo: Merge #13675 - Clean up the parsers into a single interface (from nox:servoparser); r=Ms2ger Source-Repo: https://github.com/servo/servo Source-Revision: 928e5ad1e5ca4344e69cd8029749ecb623eabd9f
5704ec2d788109a0495f0b4f4345dc02d678f4fe: servo: Merge #13686 - Fix warnings and make style and geckolib #![deny(warnings)] (from bholley:fix_warnings); r=Manishearth
Bobby Holley <bobbyholley@gmail.com> - Tue, 11 Oct 2016 06:17:44 -0500 - rev 339949
Push 86548 by kwierso@gmail.com at Sat, 04 Feb 2017 01:35:21 +0000
servo: Merge #13686 - Fix warnings and make style and geckolib #![deny(warnings)] (from bholley:fix_warnings); r=Manishearth Warnings have been piling up in the style system, and making it harder to tell when new warnings are introduced. I think we should tighten up on them. CC @emilio @Manishearth @SimonSapin @heycam @pcwalton @metajack @larsbergstrom Source-Repo: https://github.com/servo/servo Source-Revision: e597719b73ff4ed58fb6628b6f998cab4058583c
5890b18db1c9bbcd88579d28eb4a28e1aa65cec4: servo: Merge #13680 - Migrate user agent string to `Cow<'static, str>` (from frewsxcv:user-agent-cow); r=nox
Corey Farwell <coreyf@rwell.org> - Tue, 11 Oct 2016 04:04:20 -0500 - rev 339948
Push 86548 by kwierso@gmail.com at Sat, 04 Feb 2017 01:35:21 +0000
servo: Merge #13680 - Migrate user agent string to `Cow<'static, str>` (from frewsxcv:user-agent-cow); r=nox In most scenarios, where the user of Servo will not override the default user agent, the user agent can be a `&'static str`. But since we allow for customization, we currently use a `String` to represent the user agent. This commit migrates the user agent to be represented as a `Cow<'static, str`, which (at the cost of ergonomics) prevents unnecessary allocations whenever cloning the user agent string in the scenario the user doesn't override the user agent. Source-Repo: https://github.com/servo/servo Source-Revision: 4dcd223e8370816f8d0a424d9e31492aa4755f47
048ebe874ed5698f465a027ca6f7685b21641b06: servo: Merge #13685 - layout: Don't use the existing block position as the float ceiling when placing block formatting contexts in the sequential fallback (from pcwalton:block-formatting-context-fallback-placement); r=notriddle
Patrick Walton <pcwalton@mimiga.net> - Tue, 11 Oct 2016 01:11:24 -0500 - rev 339947
Push 86548 by kwierso@gmail.com at Sat, 04 Feb 2017 01:35:21 +0000
servo: Merge #13685 - layout: Don't use the existing block position as the float ceiling when placing block formatting contexts in the sequential fallback (from pcwalton:block-formatting-context-fallback-placement); r=notriddle The existing block position isn't yet computed at that time, so it contains junk data. It just so happened to work on first reflow because that value is usually set to zero, but it usually failed on subsequent reflows. Improves certain Wikipedia pages. Closes #13630 (though Google is still broken; it was a separate bug and will be split off into a separate issue). r? @notriddle Source-Repo: https://github.com/servo/servo Source-Revision: cad5a4e3261ddb82b542b9a087b48daab51bbfd3
826a79e4f45c3637ecb3331d097043a5f99a6865: servo: Merge #13656 - Refactor style logic to avoid direct access to the node data during the cascade (from bholley:existing_style); r=emilio
Bobby Holley <bobbyholley@gmail.com> - Mon, 10 Oct 2016 23:22:05 -0500 - rev 339946
Push 86548 by kwierso@gmail.com at Sat, 04 Feb 2017 01:35:21 +0000
servo: Merge #13656 - Refactor style logic to avoid direct access to the node data during the cascade (from bholley:existing_style); r=emilio The new restyle architecture doesn't store these things in consistent places, so we need a more abstract API. Source-Repo: https://github.com/servo/servo Source-Revision: abcc4aeaf212fc5fc5f9e15e46feba11e3e9284f
860b1202ced2c81b8571b42e10d3099c3bf638aa: servo: Merge #13679 - Cleanup logic, remove unnecessary allocations in Request API (from frewsxcv:remove-str-alloc); r=KiChjang
Corey Farwell <coreyf@rwell.org> - Mon, 10 Oct 2016 18:53:21 -0500 - rev 339945
Push 86548 by kwierso@gmail.com at Sat, 04 Feb 2017 01:35:21 +0000
servo: Merge #13679 - Cleanup logic, remove unnecessary allocations in Request API (from frewsxcv:remove-str-alloc); r=KiChjang Source-Repo: https://github.com/servo/servo Source-Revision: a618b245ce4b9b7850e1afc28a19cf2ed98bc69c
5b431b765a37a97f7dca63a23e3674bd6950dee1: servo: Merge #13678 - Remove unused trait method (from frewsxcv:unused-trait-method); r=KiChjang
Corey Farwell <coreyf@rwell.org> - Mon, 10 Oct 2016 16:29:25 -0500 - rev 339944
Push 86548 by kwierso@gmail.com at Sat, 04 Feb 2017 01:35:21 +0000
servo: Merge #13678 - Remove unused trait method (from frewsxcv:unused-trait-method); r=KiChjang Source-Repo: https://github.com/servo/servo Source-Revision: f43a14ea687166da92bf23bdd61b546a74288d04
f1bc617cf9efa95d606489eabca774937ee314a0: servo: Merge #13627 - Pipeline always stores frame (from asajeffrey:pipeline-always-stores-frame-id); r=ConnorGBrewster
Alan Jeffrey <ajeffrey@mozilla.com> - Mon, 10 Oct 2016 14:58:14 -0500 - rev 339943
Push 86548 by kwierso@gmail.com at Sat, 04 Feb 2017 01:35:21 +0000
servo: Merge #13627 - Pipeline always stores frame (from asajeffrey:pipeline-always-stores-frame-id); r=ConnorGBrewster <!-- Please describe your changes on the following line: --> This change makes the pipeline always store the frame id, not just optionally. This is the first part of a long slog to use FrameIds rather than PipelineIds to identify frames. cc @ConnorGBrewster --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because refactoring <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 51b806fcc0542c5e49ebc9f00a9f527d52b4556c
66c3a0daf6c6ff3d2b5d79899905a364a0ca36a1: servo: Merge #13661 - Warn and exit mach if it detects MinGW Python (from UK992:mingw-python); r=Wafflespeanut
UK992 <urbankrajnc92@gmail.com> - Mon, 10 Oct 2016 13:45:18 -0500 - rev 339942
Push 86548 by kwierso@gmail.com at Sat, 04 Feb 2017 01:35:21 +0000
servo: Merge #13661 - Warn and exit mach if it detects MinGW Python (from UK992:mingw-python); r=Wafflespeanut <!-- Please describe your changes on the following line: --> r? @Wafflespeanut --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #13644 <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: c1cc2bbbaebf13710bee1cb426484c2eed155f7c
058da893151506587793f4159a4af7b840c41d82: servo: Merge #13676 - Remove usage of deprecated `SipHasher` (from servo:no-siphasher); r=pcwalton
Simon Sapin <simon.sapin@exyr.org> - Mon, 10 Oct 2016 11:39:06 -0500 - rev 339941
Push 86548 by kwierso@gmail.com at Sat, 04 Feb 2017 01:35:21 +0000
servo: Merge #13676 - Remove usage of deprecated `SipHasher` (from servo:no-siphasher); r=pcwalton <!-- Please describe your changes on the following line: --> <s>Hashing in `SimpleHashCache` is not randomized anymore. Does this matter?</s> r? @pcwalton --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: ef7423bf0034a41b12ba50e623c9b3dba39a53bc
671d3032398a9f25c563bb1f0f00d33b4170b15d: servo: Merge #13674 - Implement column-count in stylo (from Manishearth:column_count); r=emilio
Manish Goregaokar <manishsmail@gmail.com> - Mon, 10 Oct 2016 09:37:29 -0500 - rev 339940
Push 86548 by kwierso@gmail.com at Sat, 04 Feb 2017 01:35:21 +0000
servo: Merge #13674 - Implement column-count in stylo (from Manishearth:column_count); r=emilio Unblocks column-fill easy property r? @emilio Source-Repo: https://github.com/servo/servo Source-Revision: aef6054dc64043860e90ca962b60c51c683789f2
8fe6fbd181136b1db84728edf9ac157913219ea7: servo: Merge #13673 - Don't pref-gate properties in geckolib mode (from Manishearth:no-prefs-geckolib); r=emilio
Manish Goregaokar <manishsmail@gmail.com> - Mon, 10 Oct 2016 08:11:32 -0500 - rev 339939
Push 86548 by kwierso@gmail.com at Sat, 04 Feb 2017 01:35:21 +0000
servo: Merge #13673 - Don't pref-gate properties in geckolib mode (from Manishearth:no-prefs-geckolib); r=emilio This led to me wasting a lot of time trying to figure out why my column-count implementation in gecko didn't work. We might eventually want to hook into the Gecko prefs, but the mechanism would probably be different r? @emilio Source-Repo: https://github.com/servo/servo Source-Revision: 960d884fd4dd2ad5dabfb4dd9d52e50f9d5c292c
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip