1a1b309ca7a1d7889c335e0813689988992ec446: Bug 1594466 - Add crashtest. r=bryce
Andreas Pehrson <apehrson@mozilla.com> - Tue, 12 Nov 2019 10:30:03 +0000 - rev 501559
Push 114170 by malexandru@mozilla.com at Tue, 12 Nov 2019 21:58:32 +0000
Bug 1594466 - Add crashtest. r=bryce Differential Revision: https://phabricator.services.mozilla.com/D52519
56cb51a605640ebb245234edec8caeb94dc46b93: Bug 1592007 - land NSS dc9552c2aa77 UPGRADE_NSS_RELEASE, r=kjacobs
J.C. Jones <jc@mozilla.com> - Fri, 08 Nov 2019 22:00:40 +0000 - rev 501558
Push 114170 by malexandru@mozilla.com at Tue, 12 Nov 2019 21:58:32 +0000
Bug 1592007 - land NSS dc9552c2aa77 UPGRADE_NSS_RELEASE, r=kjacobs 2019-11-04 Marcus Burghardt <mburghardt@mozilla.com> * lib/pk11wrap/pk11cert.c: Bug 1590495 - Crash in PK11_MakeCertFromHandle->pk11_fastCert. r=jcj Fixed controls to avoid crashes caused by slots possibly without a token in pk11_fastCert. Also, improved arguments controls in PK11_MakeCertFromHandle. [dc9552c2aa77] [tip] 2019-11-01 Franziskus Kiefer <franziskuskiefer@gmail.com> * gtests/pk11_gtest/manifest.mn, gtests/pk11_gtest/pk11_des_unittest.cc, gtests/pk11_gtest/pk11_gtest.gyp, lib/softoken/pkcs11c.c: Bug 1591742 - check des iv length and add test for it, r=jcj,kjacobs Summary: Let's make sure the DES IV has the length we expect it to have. Bug #: 1591742 [35857ae98190] 2019-11-01 Dana Keeler <dkeeler@mozilla.com> * gtests/mozpkix_gtest/pkixcheck_CheckKeyUsage_tests.cpp, lib/mozpkix /test-lib/pkixtestnss.cpp, tests/gtests/gtests.sh: Bug 1588567 - enable mozilla::pkix gtests in NSS r=jcj [27a29997f598] 2019-11-01 Deian Stefan <deian@cs.ucsd.edu> * lib/softoken/pkcs11c.c: Bug 1591315 - Update NSC_Decrypt length in constant time r=kjacobs Update NSC_Decrypt length in constant time [7f578a829b29] 2019-11-01 Kai Engert <kaie@kuix.de> * automation/taskcluster/graph/src/queue.js: Bug 1562671 - Limit Master Password KDF iterations for NSS continuous integration tests. r=mt [c8b490583b86] * lib/softoken/lgglue.c, lib/softoken/sftkdb.c, lib/softoken/sftkdb.h, lib/softoken/sftkdbti.h, lib/softoken/sftkpwd.c: Bug 1562671 - Add environment variables to control Master Password KDF iteration count. Disable iteration count for legacy DBM storage by default. r=rrelyea [ced91a705aa3] 2019-11-01 Bob Relyea <rrelyea@redhat.com> * lib/softoken/legacydb/keydb.c, lib/softoken/lgglue.c, lib/softoken/pkcs11.c, lib/softoken/sftkdb.c, lib/softoken/sftkdb.h, lib/softoken/sftkdbti.h, lib/softoken/sftkpwd.c: Bug 1562671 - Support higher iteration count for Master Password KDF. Bob Relyea's base patch. Requires the follow-up patch. r=kaie [6619bb43d746] 2019-10-28 Martin Thomson <mt@lowentropy.net> * coreconf/Linux.mk, coreconf/WIN32.mk, coreconf/command.mk, coreconf/config.gypi, coreconf/rules.mk, lib/freebl/aes-armv8.c, lib/freebl/aes-x86.c, lib/freebl/config.mk, lib/freebl/freebl.gyp, lib/freebl/intel-aes.h, lib/freebl/intel-gcm-wrap.c, lib/freebl/rijndael.c, lib/freebl/rijndael.h, lib/ssl/config.mk, lib/ssl/ssl.gyp: Bug 1590972 - Use -std=c99 for all C code, r=jcj This switches to using -std=c99 for compiling all C code. Previously, we only enabled this option for lib/freebl and lib/ssl. For Linux, this means we need to define _DEFAULT_SOURCE to access some of the functions we use. On glibc 2.12 (our oldest supported version), we also need to define _BSD_SOURCE to access these functions. The only tricky part is dealing with partial C99 implementation in gcc 4.4. From what I've seen, the only problem is that - in that mode - it doesn't support nesting of unnamed fields: https://gcc.gnu.org/onlinedocs/gcc-4.4.7/gcc/Unnamed-Fields.html This also switches from -std=c++0x to -std=c++11 as the 0x variant, though identical in meaning, is deprecated. [dbba7db4b79d] 2019-10-30 Giulio Benetti <giulio.benetti@benettiengineering.com> * lib/freebl/aes-armv8.c, lib/freebl/rijndael.c: Bug 1590676 - Fix build if arm doesn't support NEON r=kjacobs At the moment NSS assumes that ARM supports NEON extension but this is not true and leads to build failure on ARM without NEON extension. Add check to assure USE_HW_AES is not defined if ARM without NEON extension is used. [58f2471ace3b] 2019-10-30 Martin Thomson <mt@lowentropy.net> * gtests/ssl_gtest/tls_agent.cc: Bug 1575411 - Disable EMS for tests, a=bustage [6e5f69781137] 2019-10-29 J.C. Jones <jjones@mozilla.com> * gtests/ssl_gtest/tls_esni_unittest.cc: Bug 1590970 - Fix clang-format from e7956ee3ba1b6d05e3175bbcd795583fde867720 r=me [d1e43cb9f227] 2019-10-29 Giulio Benetti <giulio.benetti@benettiengineering.com> * lib/ssl/tls13esni.c: Bug 1590678 - Remove -Wmaybe-uninitialized warning in tls13esni.c r=jcj [df5e9021809a] 2019-10-29 Martin Thomson <martin.thomson@gmail.com> * lib/ssl/ssl.h, lib/ssl/sslsock.c: Bug 1575411 - Enable extended master secret by default, r=jcj,kjacobs See the bug for discussion about the implications of this. [d1c68498610d] 2019-10-29 Martin Thomson <mt@lowentropy.net> * gtests/ssl_gtest/tls_esni_unittest.cc, lib/ssl/sslexp.h: Bug 1590970 - Stop using time() for ESNI tests, r=kjacobs Summary: The ESNI tests were using time() rather than PR_Now(), so they slipped the net when I went looking for bad time functions. Now they do the right thing again. What we were probably seeing in the intermittents was the case where we set the time for most of the SSL functions to PR_Now(), and that was just before a second rollover. Then, when time() was called, it returned t+1 so the ESNI keys that were being generated in the ESNI tests were given a notBefore time that was in the future relative to the time being given to the TLS stack. Had the ESNI keys generation been given time() - 1 for notBefore, as I have done here, this would never have turned up. Reviewers: kjacobs Tags: #secure-revision Bug #: 1590970 [e7956ee3ba1b] Differential Revision: https://phabricator.services.mozilla.com/D51858
50eb05e09687628f707adb8b5c68487125109baf: Bug 1594559 - Set env var NSS_MAX_MP_PBE_ITERATION_COUNT for tests r=jmaher
J.C. Jones <jjones@mozilla.com> - Tue, 12 Nov 2019 15:40:24 +0000 - rev 501557
Push 114170 by malexandru@mozilla.com at Tue, 12 Nov 2019 21:58:32 +0000
Bug 1594559 - Set env var NSS_MAX_MP_PBE_ITERATION_COUNT for tests r=jmaher Differential Revision: https://phabricator.services.mozilla.com/D52212
3a7d12c89f4cc7745efedb01a5522211fa609a89: Backed out changeset 38f7b7e307b3 (bug 1594438) for causing high load on linux and windows hardware test machines on a CLOSED TREE
Andreea Pavel <apavel@mozilla.com> - Tue, 12 Nov 2019 17:00:27 +0200 - rev 501556
Push 114170 by malexandru@mozilla.com at Tue, 12 Nov 2019 21:58:32 +0000
Backed out changeset 38f7b7e307b3 (bug 1594438) for causing high load on linux and windows hardware test machines on a CLOSED TREE
2d63fadd766dc06498fda7c23c36570494d5225b: Bug 1562642 - add missing license in taskcluster r=dustin
Sylvestre Ledru <sledru@mozilla.com> - Mon, 11 Nov 2019 22:16:37 +0000 - rev 501555
Push 114170 by malexandru@mozilla.com at Tue, 12 Nov 2019 21:58:32 +0000
Bug 1562642 - add missing license in taskcluster r=dustin Depends on D52579 Differential Revision: https://phabricator.services.mozilla.com/D52581
5bd5020154a171493756d63edf6047a607994dc5: Bug 1562642 - add missing license in xpcom/ r=froydnj
Sylvestre Ledru <sledru@mozilla.com> - Mon, 11 Nov 2019 21:44:32 +0000 - rev 501554
Push 114170 by malexandru@mozilla.com at Tue, 12 Nov 2019 21:58:32 +0000
Bug 1562642 - add missing license in xpcom/ r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D52579
cc462b36cf3ff3b17074acc8591abba3b0bedbb3: Bug 1595271 - Display Http3 in about:networking. r=valentin,fluent-reviewers,flod,smaug
Dragana Damjanovic <dd.mozilla@gmail.com> - Tue, 12 Nov 2019 08:27:38 +0000 - rev 501553
Push 114170 by malexandru@mozilla.com at Tue, 12 Nov 2019 21:58:32 +0000
Bug 1595271 - Display Http3 in about:networking. r=valentin,fluent-reviewers,flod,smaug Differential Revision: https://phabricator.services.mozilla.com/D52529
452d9227aee6104ef06b7cb91eb463ca6e6128d8: Bug 1591113 - Remove support for third-party vibrate r=baku,snorp
Thomas Nguyen <tnguyen@mozilla.com> - Tue, 12 Nov 2019 08:42:02 +0000 - rev 501552
Push 114170 by malexandru@mozilla.com at Tue, 12 Nov 2019 21:58:32 +0000
Bug 1591113 - Remove support for third-party vibrate r=baku,snorp Differential Revision: https://phabricator.services.mozilla.com/D52531
a4e17e19b2078866776be8a8998aafed47e4aad1: Bug 1595541 - enable test_same_site_cookies_laxByDefault with fission r=ckerschb
Sebastian Streich <sstreich@mozilla.com> - Tue, 12 Nov 2019 07:50:25 +0000 - rev 501551
Push 114170 by malexandru@mozilla.com at Tue, 12 Nov 2019 21:58:32 +0000
Bug 1595541 - enable test_same_site_cookies_laxByDefault with fission r=ckerschb Differential Revision: https://phabricator.services.mozilla.com/D52552
7943aaba33624296d3942c13cd261991fa6af082: Bug 1592204 - P2 - Ignore the unknown files in repositories; r=janv
Tom Tung <ttung@mozilla.com> - Tue, 12 Nov 2019 07:52:14 +0000 - rev 501550
Push 114170 by malexandru@mozilla.com at Tue, 12 Nov 2019 21:58:32 +0000
Bug 1592204 - P2 - Ignore the unknown files in repositories; r=janv Differential Revision: https://phabricator.services.mozilla.com/D51872
a6786e02d33794542dbf0a3de5614943807a3ff4: Bug 1592204 - P1 - Ignore the unknown files in origin directories; r=asuth,janv
Tom Tung <ttung@mozilla.com> - Mon, 11 Nov 2019 13:50:03 +0000 - rev 501549
Push 114170 by malexandru@mozilla.com at Tue, 12 Nov 2019 21:58:32 +0000
Bug 1592204 - P1 - Ignore the unknown files in origin directories; r=asuth,janv Differential Revision: https://phabricator.services.mozilla.com/D51669
d3885b9d42d38e9685e2f430d99200ec7b719a2c: Bug 1587116 - only include sys/auxv.h on platforms where it might exist r=glandium
Landry Breuil <landry@openbsd.org> - Tue, 12 Nov 2019 07:10:12 +0000 - rev 501548
Push 114170 by malexandru@mozilla.com at Tue, 12 Nov 2019 21:58:32 +0000
Bug 1587116 - only include sys/auxv.h on platforms where it might exist r=glandium Differential Revision: https://phabricator.services.mozilla.com/D51803
a4604fe5bc45f73c7b04fefe147b311d4980adc4: Backed out 2 changesets (bug 1593736) for Spidermonkey failure in Simulator-arm.cpp
Oana Pop Rus <opoprus@mozilla.com> - Tue, 12 Nov 2019 07:36:15 +0200 - rev 501547
Push 114170 by malexandru@mozilla.com at Tue, 12 Nov 2019 21:58:32 +0000
Backed out 2 changesets (bug 1593736) for Spidermonkey failure in Simulator-arm.cpp Backed out changeset 6f894c71dabe (bug 1593736) Backed out changeset 4d1dc9dc93be (bug 1593736)
6f894c71dabe09331fcb09ed8f2e5215c6eaecea: Bug 1593736 - Rename ArgType_Double to ArgType_Float64. r=lth
Ryan Hunt <rhunt@eqrion.net> - Fri, 08 Nov 2019 08:26:45 +0000 - rev 501546
Push 114170 by malexandru@mozilla.com at Tue, 12 Nov 2019 21:58:32 +0000
Bug 1593736 - Rename ArgType_Double to ArgType_Float64. r=lth Also shuffle constants and add a comment for clarity. Depends on D52177 Differential Revision: https://phabricator.services.mozilla.com/D52178
4d1dc9dc93be754a602f067dd769dd6b75bdc95d: Bug 1593736 - Give ArgType_General pointer semantics in Wasm builtin code. r=lth
Ryan Hunt <rhunt@eqrion.net> - Fri, 08 Nov 2019 08:37:20 +0000 - rev 501545
Push 114170 by malexandru@mozilla.com at Tue, 12 Nov 2019 21:58:32 +0000
Bug 1593736 - Give ArgType_General pointer semantics in Wasm builtin code. r=lth After examining bug 1591047, I believe we should have added an Int32 type instead of changing the semantics of ArgType_General to be Int32. The reason is that the existing code assumes ArgType_General is pointer sized, and changing this is scary for all the existing uses. (e.g. simulator, MacroAssembler::appendSignatureType) * Adds ArgType_Int32 * Changes ArgType_General -> ArgType_Int32, ArgType_Pointer -> ArgType_General for ABIFunctionTypes introduced in bug 1591047 (which are only used for Wasm instance calls). * ToMirType(ArgType_General) -> MIRType::Pointer (should only affect wasm) * ToMirType(ArgType_Int32) -> MIRType::Int32 (should only affect wasm) Differential Revision: https://phabricator.services.mozilla.com/D52177
5f0b392beadb7300abdaa3e5e1cc1c0d5a9f0791: Bug 1565902 - Test the impact of removing startup dll readahead r=glandium
Doug Thayer <dothayer@mozilla.com> - Tue, 12 Nov 2019 04:00:00 +0000 - rev 501544
Push 114170 by malexandru@mozilla.com at Tue, 12 Nov 2019 21:58:32 +0000
Bug 1565902 - Test the impact of removing startup dll readahead r=glandium We haven't tested this in recent times, and it would be good to understand what the impact is looking at telemetry measures of startup in Nightly. This doesn't rip out everything, but we will need to do that if we determine that the readahead has a neutral / negative effect. Differential Revision: https://phabricator.services.mozilla.com/D50512
4b3eacb45a38a33175976e7d76d1651334f52d82: Bug 1568595 - [Nudges] Implement an experiment API to check whether a notification is being displayed in Firefox r=mak,mixedpuppy
Drew Willcoxon <adw@mozilla.com> - Tue, 12 Nov 2019 02:55:15 +0000 - rev 501543
Push 114170 by malexandru@mozilla.com at Tue, 12 Nov 2019 21:58:32 +0000
Bug 1568595 - [Nudges] Implement an experiment API to check whether a notification is being displayed in Firefox r=mak,mixedpuppy This sets up a `browser.experiments.urlbar` WebExtension Experiment API and adds a function called `isBrowserShowingNotification`. To recap, for the nudges experiment, we want to open the urlbar view automatically in some cases to show a nudge, but only if the browser isn't already showing a notification. There are a few things to point out about this patch. What counts as a notification is a little fuzzy. I chose: the tracking protection doorhanger, site identity doorhanger, app menu notifications, notification box (info bar), page action panels, and toolbar button panels. The last two aren't really notifications, but they're panels similar to doorhanger notifications. I also count the urlbar view as a notification since we don't want to show a nudge if the urlbar view is already open. I didn't bother with tab-modal dialogs since none of the pages we want to show nudges on will have them. I didn't bother with app-modal dialogs since the user can't interact with the browser until they're dismissed. I chose `browser.experiments.urlbar` as the namespace, which we previously used in the top-sites experiment. There was also discussion of `browser.experiments.app` (bug 1579933), but I think we should keep all our urlbar experiment-related APIs in a urlbar namespace even when they aren't actually related to the urlbar. It's not a big deal though. Shane recommends that we land tests for our experiment APIs in mozilla-central even though they won't ship in mozilla-central, at least for APIs that will be used in more than one version of Firefox. I think that's also a good idea for APIs we reuse in multiple experiments. It may not be necessary in this case since I'm not sure how broadly useful this notification API is, so I'm open to removing it and keeping it only in the experiment's GitHub repo. But I found that this was actually a nice way to develop and test this patch. Also, if we keep our experiment APIs in mozilla-central this way, we may not need a separate GitHub repo for them, or at most it'll just be a copy of this browser/components/urlbar/tests/ext directory. As mentioned, I made a new ext tests directory. I think we should keep these files separate from the normal tests. Differential Revision: https://phabricator.services.mozilla.com/D52312
71e6f3199f98ea08f93ed6f5a5cfab9ca5ca221d: Bug 1594949 - Fix assertion of gfx::Path when changing offset-path on some svg frames. r=heycam
Boris Chiou <boris.chiou@gmail.com> - Mon, 11 Nov 2019 23:31:23 +0000 - rev 501542
Push 114170 by malexandru@mozilla.com at Tue, 12 Nov 2019 21:58:32 +0000
Bug 1594949 - Fix assertion of gfx::Path when changing offset-path on some svg frames. r=heycam 1. Use Nothing() for motion path in IncrementScaleResytleCountIfNeeded. Since motion path only produces 2d translate and 2d rotate, so it shouldn't have any impact on BaseMatrix::ScaleFactors(). We use Nothing() to avoid any redundant calculation. 2. Drop SVGTextFrame::DidSetComputedStyle() because nsFrame::DidSetComputedStyle() should have handled ScheduleReflowSVGNonDisplayText well. 3. Let nsSVGForeignObjectFrame::DidSetComputedStyle() call their parents' DidSetComputedStyle. This makes sure we update the frame properly. Differential Revision: https://phabricator.services.mozilla.com/D52290
baffa8a7b9618e9a02e4bd808adb71dead99cce5: Bug 1589270 - Part 3: Convert nsExternalHelperApp to use BrowsingContext instead of nsIInterfaceRequestor. r=bzbarsky
Matt Woodrow <mwoodrow@mozilla.com> - Fri, 08 Nov 2019 04:35:05 +0000 - rev 501541
Push 114170 by malexandru@mozilla.com at Tue, 12 Nov 2019 21:58:32 +0000
Bug 1589270 - Part 3: Convert nsExternalHelperApp to use BrowsingContext instead of nsIInterfaceRequestor. r=bzbarsky This also converts MaybeCloseWindowHelper, and results in the window close operations being always run in the parent (even without DocumentChannel). Differential Revision: https://phabricator.services.mozilla.com/D49528
68bc2ae9b89a74996c48d8e885a3f06e85c679bc: Bug 1589270 - Part 2: Remove support for handling the Refresh header while processing a download. r=bzbarsky
Matt Woodrow <mwoodrow@mozilla.com> - Fri, 08 Nov 2019 03:01:03 +0000 - rev 501540
Push 114170 by malexandru@mozilla.com at Tue, 12 Nov 2019 21:58:32 +0000
Bug 1589270 - Part 2: Remove support for handling the Refresh header while processing a download. r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D49527
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 tip