183249d9d7f77f3c0f3ef13b7e5c18cb4feb40ec: Bug 1396698 - Part2 - Dispatch to mainthread by ourself and do the synchronization to avoid race. r=kikuo
James Cheng <jacheng@mozilla.com> - Fri, 03 Nov 2017 14:22:41 +0800 - rev 390046
Push 96988 by archaeopteryx@coole-files.de at Sat, 04 Nov 2017 10:03:29 +0000
Bug 1396698 - Part2 - Dispatch to mainthread by ourself and do the synchronization to avoid race. r=kikuo MozReview-Commit-ID: 6rA2TvESyEz
b8fe495f5f4ba6510e08665031ae72da97b0de4c: Bug 1396698 - Part1 - Remove the dispatchTo gecko main thread attribute. r=kikuo
James Cheng <jacheng@mozilla.com> - Fri, 03 Nov 2017 13:40:46 +0800 - rev 390045
Push 96988 by archaeopteryx@coole-files.de at Sat, 04 Nov 2017 10:03:29 +0000
Bug 1396698 - Part1 - Remove the dispatchTo gecko main thread attribute. r=kikuo MozReview-Commit-ID: 9Opa894ZQMQ
1c78029ded02384d293d27421ec5cce979f3d391: Bug 1410940 - Unify the parts of onDrop and paste that get the transaction information. r=mak
Mark Banner <standard8@mozilla.com> - Mon, 23 Oct 2017 18:18:00 +0100 - rev 390044
Push 96988 by archaeopteryx@coole-files.de at Sat, 04 Nov 2017 10:03:29 +0000
Bug 1410940 - Unify the parts of onDrop and paste that get the transaction information. r=mak This also fixes inserting bookmarks on paste at the right insertion points. MozReview-Commit-ID: Km93oZt1UHm
37ceb314b2b3ae5c629a028dd5ac46c222015a56: Bug 1410940 - Make PlacesController#paste and PlacesControllerDragHelper#onDrop more similar to each other. r=mak
Mark Banner <standard8@mozilla.com> - Mon, 23 Oct 2017 15:50:52 +0100 - rev 390043
Push 96988 by archaeopteryx@coole-files.de at Sat, 04 Nov 2017 10:03:29 +0000
Bug 1410940 - Make PlacesController#paste and PlacesControllerDragHelper#onDrop more similar to each other. r=mak MozReview-Commit-ID: EEFizNPmKpr
f7206a54b9aaa37e811b91d8bb07f0901280bac5: Backed out 3 changesets (bug 1368209)xpcshell failures services/sync/tests/unit/test_syncengine_sync.js on CLOSED TREE
NARCIS BELEUZU <nbeleuzu@mozilla.com> - Fri, 03 Nov 2017 11:40:06 +0200 - rev 390042
Push 96988 by archaeopteryx@coole-files.de at Sat, 04 Nov 2017 10:03:29 +0000
Backed out 3 changesets (bug 1368209)xpcshell failures services/sync/tests/unit/test_syncengine_sync.js on CLOSED TREE Backed out changeset 1b868efa368f (bug 1368209) Backed out changeset b88c681ccdc1 (bug 1368209) Backed out changeset 4b8e56844ae9 (bug 1368209)
bbbd75cd12a945396d21f2000f5a9d4bc09602bb: Bug 366192 - Fixed http/https regex checks. r=mak
Moritz Brunner <moritzbrunner@freenet.de> - Thu, 02 Nov 2017 22:43:19 +0100 - rev 390041
Push 96988 by archaeopteryx@coole-files.de at Sat, 04 Nov 2017 10:03:29 +0000
Bug 366192 - Fixed http/https regex checks. r=mak MozReview-Commit-ID: FL0AWkM9Ggm
dfc3f11935aa57dbb750007a59c1758933cb957e: Bug 1404850 - Fix self-XSS protection in new console and enable test; r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 24 Oct 2017 11:08:02 +0200 - rev 390040
Push 96988 by archaeopteryx@coole-files.de at Sat, 04 Nov 2017 10:03:29 +0000
Bug 1404850 - Fix self-XSS protection in new console and enable test; r=Honza. The self-XSS protection was broken since the switch to an HTML document. We went from using the XUL <notificationbox> tag to a simple div. But notificationbox has method that a simple div has not, and when trying to display the warning message, there was an error in terminal. This patch uses the NotificationBox React component and create it when needed. It also rename and enable the test that ensures that XSS is working. MozReview-Commit-ID: BhxIqf7gzAG
1b868efa368f0e8f2caa4df8568fca04f756a00e: Bug 1368209 - Refactor `Engine::_processIncoming` into three stages. r=eoger,tcsc
Kit Cambridge <kit@yakshaving.ninja> - Wed, 01 Nov 2017 11:09:57 -0700 - rev 390039
Push 96988 by archaeopteryx@coole-files.de at Sat, 04 Nov 2017 10:03:29 +0000
Bug 1368209 - Refactor `Engine::_processIncoming` into three stages. r=eoger,tcsc * In the first stage, we fetch changed records, newest first, up to the download limit. We keep track of the oldest record modified time we see. * Once we've fetched all records, we reconcile, noting records that fail to decrypt or reconcile for the next sync. We then ask the store to apply all remaining records. Previously, `applyIncomingBatchSize` specified how many records to apply at a time. I removed this because it added an extra layer of indirection that's no longer necessary, now that download batching buffers all records in memory, and all stores are async. * In the second stage, we fetch IDs for all remaining records changed between the last sync and the oldest modified time we saw in the first stage. We *don't* set the download limit here, to ensure we add *all* changed records to our backlog, and we use the `"oldest"` sort order instead of `"index"`. * In the third stage, we backfill as before. We don't want large deltas to delay other engines from syncing, so we still only take IDs up to the download limit from the backlog, and include failed IDs from the previous sync. On subsequent syncs, we'll keep fetching from the backlog until it's empty. Other changes to note in this patch: * `Collection::_rebuildURL` now allows callers to specify both `older` and `newer`. According to :rfkelly, this is explicitly and intentionally supported. * Tests that exercise `applyIncomingBatchSize` are gone, since that's no longer a thing. * The test server now shuffles records if the sort order is unspecified. MozReview-Commit-ID: 4EXvNOa8mIo
b88c681ccdc1614c3589730e72ac37ff342d22a7: Bug 1368209 - Add a test for fetching backlogged history records. r=tcsc
Kit Cambridge <kit@yakshaving.ninja> - Fri, 27 Oct 2017 17:54:48 -0700 - rev 390038
Push 96988 by archaeopteryx@coole-files.de at Sat, 04 Nov 2017 10:03:29 +0000
Bug 1368209 - Add a test for fetching backlogged history records. r=tcsc The test captures the existing logic in `_processIncoming`, even though it's not quite correct: * First, we fetch all records changed since the last sync, up to the download limit, and without an explicit sort order. This happens to work correctly now because the Python server uses "newest" by default, but can change in the future. * If we reached the download limit fetching records, we request IDs for all records changed since the last sync, also up to the download limit, and sorted by index. This is likely to return IDs for records we've already seen, since the index is based on the frecency. It's also likely to miss IDs for other changed records, because the number of changed records might be higher than the download limit. * Since we then fast-forward the last sync time, we'll never download any remaining changed records that we didn't add to our backlog. * Finally, we backfill previously failed and backlogged records. MozReview-Commit-ID: 7uQLXMseMIU
4b8e56844ae98e4129f567c23491f34d4f6ce708: Bug 1368209 - Add support for `sortindex` and `older` to the mock Sync server. r=tcsc
Kit Cambridge <kit@yakshaving.ninja> - Fri, 27 Oct 2017 17:55:30 -0700 - rev 390037
Push 96988 by archaeopteryx@coole-files.de at Sat, 04 Nov 2017 10:03:29 +0000
Bug 1368209 - Add support for `sortindex` and `older` to the mock Sync server. r=tcsc MozReview-Commit-ID: 6YI1OEE8x7R
12f7bd502d4dbff24bc1e381de45df9c41cf5f6f: Bug 1403358 Only reference ActivationContext if Acessibility is enabled r=aklotz
Tom Ritter <tom@mozilla.com> - Thu, 26 Oct 2017 15:09:50 -0500 - rev 390036
Push 96988 by archaeopteryx@coole-files.de at Sat, 04 Nov 2017 10:03:29 +0000
Bug 1403358 Only reference ActivationContext if Acessibility is enabled r=aklotz This also enables the crash reporter on the MinGW build, as this is the only thing blocking that from working. MozReview-Commit-ID: Hygd7UUQvwl
9ee2bbdb739021cf352e4cac630d0bdd596b6c33: Bug 1413680 - DrawTargetRecording should return the real size instead of the dummy drawtarget's size. r=jrmuizel
Ethan Lin <ethlin@mozilla.com> - Thu, 02 Nov 2017 13:50:38 +0800 - rev 390035
Push 96988 by archaeopteryx@coole-files.de at Sat, 04 Nov 2017 10:03:29 +0000
Bug 1413680 - DrawTargetRecording should return the real size instead of the dummy drawtarget's size. r=jrmuizel MozReview-Commit-ID: E63f8ZIGYm2
a16aef250227226e3abe41cf0e835fdbb57ded13: Bug 1413397 - Avoid empty border's fallback. r=kats
Ethan Lin <ethlin@mozilla.com> - Wed, 01 Nov 2017 17:30:04 +0800 - rev 390034
Push 96988 by archaeopteryx@coole-files.de at Sat, 04 Nov 2017 10:03:29 +0000
Bug 1413397 - Avoid empty border's fallback. r=kats MozReview-Commit-ID: 1KXYjcObJdi
2c77266e1b40c7a67901de4c3ccca2554422da4a: Bug 1407561 - Lazy loading of tooltip text when user hovers the status column. r=gasolin
abhinav <abhinav.koppula@gmail.com> - Tue, 31 Oct 2017 08:27:21 +0530 - rev 390033
Push 96988 by archaeopteryx@coole-files.de at Sat, 04 Nov 2017 10:03:29 +0000
Bug 1407561 - Lazy loading of tooltip text when user hovers the status column. r=gasolin MozReview-Commit-ID: BXP8B10Q5LT
e15cf10f369acd8129126525c349ade395abf876: Bug 1414097 - Convert nsDisplaySelectionOverlay to WebRender. r=ethlin
Markus Stange <mstange@themasta.com> - Thu, 02 Nov 2017 19:43:08 -0400 - rev 390032
Push 96988 by archaeopteryx@coole-files.de at Sat, 04 Nov 2017 10:03:29 +0000
Bug 1414097 - Convert nsDisplaySelectionOverlay to WebRender. r=ethlin MozReview-Commit-ID: 5icpe4OR0Qa
efbfeacfdb9621ab2c67b2400cb89d92669b6c53: Bug 1411808. P3 - InitAsClone() shouldn't call |mMediaCache->OpenStream(this)| until initialization is done. r=gerald
JW Wang <jwwang@mozilla.com> - Thu, 26 Oct 2017 11:13:38 +0800 - rev 390031
Push 96988 by archaeopteryx@coole-files.de at Sat, 04 Nov 2017 10:03:29 +0000
Bug 1411808. P3 - InitAsClone() shouldn't call |mMediaCache->OpenStream(this)| until initialization is done. r=gerald We don't want MediaCache to use a half-initialized stream. MozReview-Commit-ID: LjPLOYwy0Wd
875d91b29c311400cc3108f959da53d09bab66b3: Bug 1411808. P2 - don't call mClient->IsSuspended() off the main thread in Update(). r=gerald
JW Wang <jwwang@mozilla.com> - Tue, 24 Oct 2017 11:25:41 +0800 - rev 390030
Push 96988 by archaeopteryx@coole-files.de at Sat, 04 Nov 2017 10:03:29 +0000
Bug 1411808. P2 - don't call mClient->IsSuspended() off the main thread in Update(). r=gerald By mirroring the suspend status of the client, Update() is able to make decisions on reading streams without calling mClient->IsSuspended(). MozReview-Commit-ID: G4gS2VGiMjj
f26682779a1841d5ff52797e9693dee02d8fbade: Bug 1411808. P1 - run Update() loops off the main thread. r=gerald
JW Wang <jwwang@mozilla.com> - Mon, 23 Oct 2017 17:12:07 +0800 - rev 390029
Push 96988 by archaeopteryx@coole-files.de at Sat, 04 Nov 2017 10:03:29 +0000
Bug 1411808. P1 - run Update() loops off the main thread. r=gerald Note we will fix bugs required to run Update() off the main thread in the following patches. MozReview-Commit-ID: CYwT5kDjD9R
1955a40abe6fadb8a2a870a98a626e3e4b6bae40: Bug 1413484 - tighten some assertions. r=gerald
JW Wang <jwwang@mozilla.com> - Fri, 27 Oct 2017 22:17:41 +0800 - rev 390028
Push 96988 by archaeopteryx@coole-files.de at Sat, 04 Nov 2017 10:03:29 +0000
Bug 1413484 - tighten some assertions. r=gerald mCallback->GetMediaOwner() now is always called before Close() and won't return null. So is owner->GetMediaElement(). MozReview-Commit-ID: HbxbyuogYAB
6af2bb14bd4c1ada3e9dc68ff9c40b3a9e0893e0: Bug 1413829 - RequestListContent scroll to bottom should avoid sync reflow r=Honza
Ricky Chien <ricky060709@gmail.com> - Thu, 02 Nov 2017 16:56:53 +0800 - rev 390027
Push 96988 by archaeopteryx@coole-files.de at Sat, 04 Nov 2017 10:03:29 +0000
Bug 1413829 - RequestListContent scroll to bottom should avoid sync reflow r=Honza MozReview-Commit-ID: KwPVFJfRQQK
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip