138f68288387ca1ae709d54b3cd452ad59a87651: Merge m-c to autoland. a=merge
Ryan VanderMeulen <ryanvm@gmail.com> - Sun, 12 Nov 2017 21:26:51 -0500 - rev 391492
Push 97280 by nbeleuzu@mozilla.com at Mon, 13 Nov 2017 10:03:29 +0000
Merge m-c to autoland. a=merge
d0207f4cfe8dc7537f8f992f051a2c2b9c9d329e: servo: Merge #19178 - enhance android build debug info in `build_commands.py` (from tigercosmos:python12); r=emilio
tigercosmos <b04209032@ntu.edu.tw> - Sun, 12 Nov 2017 18:37:10 -0600 - rev 391491
Push 97280 by nbeleuzu@mozilla.com at Mon, 13 Nov 2017 10:03:29 +0000
servo: Merge #19178 - enhance android build debug info in `build_commands.py` (from tigercosmos:python12); r=emilio <!-- Please describe your changes on the following line: --> I have some experience with building android. Sometimes I forget to set `ANDROID_NDK` or `ANDROID_SDK` when I create a new clean environment, and I would know only when build error message come out.(After very long time) I think we could enhance the debug engineering at the beginning. Also fix the previous work #19109 I forgot to consider if `open()` crash(file not exist). --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #19095 (github issue number if applicable). <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: ccc739d635b8071e0375fbf6c9fb2eb2366882eb
9ed88d4cc9b6207136fba334bb3298efdf01acae: servo: Merge #19127 - scroll, SetScrollTop, SetScrollLeft in `element.rs` (from tigercosmos:overflow10); r=emilio
tigercosmos <b04209032@ntu.edu.tw> - Sun, 12 Nov 2017 17:24:33 -0600 - rev 391490
Push 97280 by nbeleuzu@mozilla.com at Mon, 13 Nov 2017 10:03:29 +0000
servo: Merge #19127 - scroll, SetScrollTop, SetScrollLeft in `element.rs` (from tigercosmos:overflow10); r=emilio <!-- Please describe your changes on the following line: --> Currently dom-element-scroll have not finished yet. (Step 10) This PR finish the step 10 of `scroll`, `SetScrollTop`, `SetScrollLeft` [Step 10 description](https://drafts.csswg.org/cssom-view/#dom-element-scrolltop): > If the element does not have any associated CSS layout box, the element has no associated scrolling box, or the element has no overflow, terminate these steps. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #19114 (github issue number if applicable). <!-- Either: --> - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 37760054e2cf742c9043b96b832d2fbdf796d367
cf6e51eb9bae57ae0ea5a674342666a2a33f0597: Bug 1416597 - Include Printf.h in Logging.cpp. r=froydnj
Chris Pearce <cpearce@mozilla.com> - Mon, 13 Nov 2017 10:07:39 +1300 - rev 391489
Push 97280 by nbeleuzu@mozilla.com at Mon, 13 Nov 2017 10:03:29 +0000
Bug 1416597 - Include Printf.h in Logging.cpp. r=froydnj MozReview-Commit-ID: 5ZMMkvaOKtO
64bd4d75004d2af2256ad76f4f23c50e2d7ffe8c: Bug 1353319 - Fix cyrillic text test after re-adding the HTML preview. r=Honza
Brandon Cheng <brandon.cheng@protonmail.com> - Sat, 28 Oct 2017 23:33:41 -0400 - rev 391488
Push 97280 by nbeleuzu@mozilla.com at Mon, 13 Nov 2017 10:03:29 +0000
Bug 1353319 - Fix cyrillic text test after re-adding the HTML preview. r=Honza Adding an HTML preview above the raw payload viewer on the developer tools response tab caused browser_net_cyrillic-02.js to fail since CodeMirror only renders visible lines to the DOM. The new HTML preview shares space with the CodeMirror editor, so the resulting height became shorter; enough to hide the line this test was looking for. This solution uses CodeMirror.getValue() to retrieve the contents of all lines stored in memory. Checking against that will allow the test to pass since it contains the cyrillic text. One downside is that this makes the test less reliable since it may not be guaranteed that what CodeMirror has buffered to render will actually be what's inserted into the DOM. Two other solutions were explored before settling on the one above. The first was simulating scroll events through EventUtils.sendWheelAndPaint. const event = { deltaMode: WheelEvent.DOM_DELTA_LINE, deltaY: 20 } yield new Promise(resolve => { EventUtils.sendWheelAndPaint( document.querySelector(".CodeMirror-scroll"), 10, 10, event, resolve, monitor.panelWin ); }) This did scroll the editor enough to render content and pass the test, but caused additional errors since monitor.panelWin did not have a .waitForAllPaintsFlushed() method that EventUtils.sendWheelAndPaint expected. The below alternative uses a hard-coded scroll amount and a requestAnimationFrame as a rough estimate of when scrolling finished. It worked in the ten or so runs I tested, but there's nothing guaranteed about requestAnimationFrame that indicates when CodeMirror's rendering has finished. document.querySelector(".CodeMirror-scroll").scrollBy(0, 200); yield new Promise(resolve => requestAnimationFrame(resolve)); MozReview-Commit-ID: H95HjR8UNpx
edbc03f93f6a03fcc376cae723b0c6ed12228616: Bug 1353319 - Make SourceEditor flex when next to an HTML preview. r=Honza
Brandon Cheng <brandon.cheng@protonmail.com> - Sat, 28 Oct 2017 23:33:22 -0400 - rev 391487
Push 97280 by nbeleuzu@mozilla.com at Mon, 13 Nov 2017 10:03:29 +0000
Bug 1353319 - Make SourceEditor flex when next to an HTML preview. r=Honza MozReview-Commit-ID: 71sq86ka2ZL
4bab59d6b58f2edc7d8052300ea4c8a762cb108a: Bug 1353319 - Render HTML preview within Response side-panel. r=Honza
Brandon Cheng <brandon.cheng@protonmail.com> - Sat, 28 Oct 2017 23:33:02 -0400 - rev 391486
Push 97280 by nbeleuzu@mozilla.com at Mon, 13 Nov 2017 10:03:29 +0000
Bug 1353319 - Render HTML preview within Response side-panel. r=Honza Restoring the HTML preview in the response panel was requested by many users who rely on it to debug erroring AJAX requests. Many web backend frameworks display an HTML stacktrace helping users trace down the problem. The html-preview.js component was taken from a previous commit of the source code before the preview panel was removed. A few modifications with its name and CSS classname were made. MozReview-Commit-ID: JFyF6cBMaNf
1751e2272b0721fbecc18003f9a627aace1f5c1e: Merge mozilla-central to mozilla-autoland. r=merge a=merge CLOSED TREE
Margareta Eliza Balazs <ebalazs@mozilla.com> - Mon, 13 Nov 2017 00:03:56 +0200 - rev 391485
Push 97280 by nbeleuzu@mozilla.com at Mon, 13 Nov 2017 10:03:29 +0000
Merge mozilla-central to mozilla-autoland. r=merge a=merge CLOSED TREE
137c612674b1d994a3098fd976b67909b80d15a9: servo: Merge #19141 - Implement -moz-window-transform{,-origin} internal properties (from upsuper:window-transform); r=emilio
Xidorn Quan <me@upsuper.org> - Sun, 12 Nov 2017 13:04:22 -0600 - rev 391484
Push 97280 by nbeleuzu@mozilla.com at Mon, 13 Nov 2017 10:03:29 +0000
servo: Merge #19141 - Implement -moz-window-transform{,-origin} internal properties (from upsuper:window-transform); r=emilio This fixes [bug 1374178](https://bugzilla.mozilla.org/show_bug.cgi?id=1374178). Note that the impl of `-moz-window-transform-origin` doesn't exactly match how it is implemented in Gecko. Specifically, that property doesn't accept depth value in Gecko, but it does in this impl. The depth value is simply dropped during conversion. This is because I don't think it's worth adding code for handling this internal property to make it as restrictive. This is a modified version of #19106. The only difference since then is how `impl_transform_origin` distinguish between `transform-origin` and `-moz-window-transform-origin`. The previous PR has a bug which checks against `transform` rather than `transform-origin`, while this PR changes it to checking the length of the array. It introduces an unsuppressible warning due to rust-lang/rust#45850. This doesn't cause build failure, so maybe it's fine? Source-Repo: https://github.com/servo/servo Source-Revision: bc58e18761ef687bd6c5efcda635cabdb742069a
ae668855bc6ecb341599a1674dddd11c90b2d62e: servo: Merge #19186 - style: Derive more stuff (from emilio:derive-more-stuff); r=nox
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 12 Nov 2017 09:41:04 -0600 - rev 391483
Push 97280 by nbeleuzu@mozilla.com at Mon, 13 Nov 2017 10:03:29 +0000
servo: Merge #19186 - style: Derive more stuff (from emilio:derive-more-stuff); r=nox Source-Repo: https://github.com/servo/servo Source-Revision: fad4d7ae49140b8919f9b823542b440aeb0ecc9e
cb39c30dc214bd0161fa8a8620edd547cd969c7d: Bug 1394831 part 19 - Factor out maybeToDictionaryModeForPut. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Mon, 13 Nov 2017 10:54:12 +0100 - rev 391482
Push 97279 by jandemooij@gmail.com at Mon, 13 Nov 2017 09:54:45 +0000
Bug 1394831 part 19 - Factor out maybeToDictionaryModeForPut. r=bhackett
53a3033449d325ffb8c326e6ace749eb9f5d027b: Bug 1394831 part 18 - Factor out updateDictionaryTable. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Mon, 13 Nov 2017 10:53:14 +0100 - rev 391481
Push 97279 by jandemooij@gmail.com at Mon, 13 Nov 2017 09:54:45 +0000
Bug 1394831 part 18 - Factor out updateDictionaryTable. r=bhackett
f1b13194212c9cc0150abc4fed231c4c4a84c2fd: Bug 1394831 part 17 - Factor out maybeConvertToOrGrowDictionaryForAdd. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Mon, 13 Nov 2017 10:52:38 +0100 - rev 391480
Push 97279 by jandemooij@gmail.com at Mon, 13 Nov 2017 09:54:45 +0000
Bug 1394831 part 17 - Factor out maybeConvertToOrGrowDictionaryForAdd. r=bhackett
ce448d8a91b3b4014346e9142ddb23fe0e0606ab: Bug 1394831 part 16 - Scope table/entry better in putDataProperty/putAccessorProperty. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Mon, 13 Nov 2017 10:52:04 +0100 - rev 391479
Push 97279 by jandemooij@gmail.com at Mon, 13 Nov 2017 09:54:45 +0000
Bug 1394831 part 16 - Scope table/entry better in putDataProperty/putAccessorProperty. r=bhackett
ef44b38b852a0b67b16a265ba29c8dacfb37cdf7: Bug 1394831 part 15 - Pass ShapeTable* to add*Property. r=bhackett
Jan de Mooij <jdemooij@mozilla.com> - Mon, 13 Nov 2017 10:51:10 +0100 - rev 391478
Push 97279 by jandemooij@gmail.com at Mon, 13 Nov 2017 09:54:45 +0000
Bug 1394831 part 15 - Pass ShapeTable* to add*Property. r=bhackett
d7cb7c614fe1cf336683a9b80e9706f097cc8aec: Bug 1415014 - Part 2. Remove duplicated icon48.png from branding files. r=dao
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Fri, 10 Nov 2017 12:38:57 +0900 - rev 391477
Push 97278 by m_kato@ga2.so-net.ne.jp at Mon, 13 Nov 2017 09:40:36 +0000
Bug 1415014 - Part 2. Remove duplicated icon48.png from branding files. r=dao default48.png and icon48.png is same file. So we should remove one side. MozReview-Commit-ID: 6WuxH0QFQ25
7dabae5e261a121818cf7ce8e06fe91bd68a4913: Bug 1415014 - Part 1. Add default64.png and default128.png for GTK HiDPI icons. r=dao
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Fri, 10 Nov 2017 12:34:36 +0900 - rev 391476
Push 97278 by m_kato@ga2.so-net.ne.jp at Mon, 13 Nov 2017 09:40:36 +0000
Bug 1415014 - Part 1. Add default64.png and default128.png for GTK HiDPI icons. r=dao Now, default48.png is highest resolition icon for Firfox/GTK. So we should add default64.png (from icon64.png) and default128.png (from mozicon128.png) for HiDPI. Also mozicon128.png is for Linux distribution, we should move to correct place for our GTK icons. MozReview-Commit-ID: BeLXzUcOgQu
f962fb3449f44bdbe51299b8fa9b3b5a4970321b: Bug 1411384 - nested sync XHR should throw, r=smaug
Andrea Marchesini <amarchesini@mozilla.com> - Mon, 13 Nov 2017 10:17:05 +0100 - rev 391475
Push 97277 by amarchesini@mozilla.com at Mon, 13 Nov 2017 09:17:31 +0000
Bug 1411384 - nested sync XHR should throw, r=smaug
37fb5ea900d3f76612d1bc44434337d4bd8e1040: Bug 1416206 - disambiguate a namespace. r=jandem
Lars T Hansen <lhansen@mozilla.com> - Fri, 10 Nov 2017 13:59:33 +0100 - rev 391474
Push 97276 by lhansen@mozilla.com at Mon, 13 Nov 2017 07:58:22 +0000
Bug 1416206 - disambiguate a namespace. r=jandem
fc119ef7a5b0e1ef590e4a2a107e24e089ce0490: Backed out changeset 607fd3ab6953 (bug 1415014) due to mistake merge
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 13 Nov 2017 15:11:55 +0900 - rev 391473
Push 97275 by m_kato@ga2.so-net.ne.jp at Mon, 13 Nov 2017 06:13:51 +0000
Backed out changeset 607fd3ab6953 (bug 1415014) due to mistake merge MozReview-Commit-ID: 4vyXS8Mv883
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip