0f1a064cc4d7a320e52d6c2ad9ab0a4bdc378b09: Backed out changeset a88235c19594 (bug 1444327) for ESlint failure at devtools/client/inspector/fonts/test/browser_fontinspector_copy-URL.js
Coroiu Cristina <ccoroiu@mozilla.com> - Wed, 14 Mar 2018 17:01:11 +0200 - rev 408196
Push 100889 by apavel@mozilla.com at Wed, 14 Mar 2018 22:12:10 +0000
Backed out changeset a88235c19594 (bug 1444327) for ESlint failure at devtools/client/inspector/fonts/test/browser_fontinspector_copy-URL.js
a277657bfffad2c7bd6bb1f1782eb32c79596ec3: Bug 1310295 - Provide a Places database migration routine to remove non-built-in roots. r=mak
Mark Banner <standard8@mozilla.com> - Fri, 02 Mar 2018 11:09:12 +0000 - rev 408195
Push 100889 by apavel@mozilla.com at Wed, 14 Mar 2018 22:12:10 +0000
Bug 1310295 - Provide a Places database migration routine to remove non-built-in roots. r=mak MozReview-Commit-ID: G2vdW3PRlqo
b1af75c617eafc84cd87c1e0ac94fb26929c56bf: Bug 1310295 - Make left pane queries virtual in the Places Library window. r=kitcambridge,mak
Mark Banner <standard8@mozilla.com> - Fri, 16 Feb 2018 20:30:04 +0000 - rev 408194
Push 100889 by apavel@mozilla.com at Wed, 14 Mar 2018 22:12:10 +0000
Bug 1310295 - Make left pane queries virtual in the Places Library window. r=kitcambridge,mak MozReview-Commit-ID: DcEMAlrXu8R
a88235c19594b34b1f7f3b2022f89b35fe1f21bf: Bug 1444327 - Bring back ability to copy font URL by adding context menu; r=jdescottes
Patrick Brosset <pbrosset@mozilla.com> - Mon, 12 Mar 2018 14:49:14 +0100 - rev 408193
Push 100889 by apavel@mozilla.com at Wed, 14 Mar 2018 22:12:10 +0000
Bug 1444327 - Bring back ability to copy font URL by adding context menu; r=jdescottes In the fonts panel UI prior to Firefox 60, remote font URLs used to be displayed in full in a text input field. It made it easy to copy them. With the redesign that happened in 60 (bug 1437548 and 1442001), getting the URL became harder. The URL isn't visible anymore easily. There's a link that can be clicked to load the URL in the browser, or it can also be copied from the @font-face CSS rule code section. But that's harder. This change adds a simple right-click context menu to the link that has one item only: copy link. MozReview-Commit-ID: 2oSMoWKYhTk
9ddcc7fdda30b289a0ef9592151293e006b024ab: servo: Merge #20294 - Update WR (port blurs and blits to brush_image) (from glennw:update-wr-blend-brush); r=jdm
Glenn Watson <github@intuitionlibrary.com> - Wed, 14 Mar 2018 08:52:20 -0400 - rev 408192
Push 100889 by apavel@mozilla.com at Wed, 14 Mar 2018 22:12:10 +0000
servo: Merge #20294 - Update WR (port blurs and blits to brush_image) (from glennw:update-wr-blend-brush); r=jdm Source-Repo: https://github.com/servo/servo Source-Revision: daaee046b3a5a949a22b69a7ba42d2d741914645
b98d3bc2333f951e81fe04f1f1f6959c0a1f5317: Bug 1443457 - Stop referencing the addon-sdk loader in devtools code r=jdescottes
Michael Ratcliffe <mratcliffe@mozilla.com> - Fri, 09 Mar 2018 15:36:45 +0000 - rev 408191
Push 100889 by apavel@mozilla.com at Wed, 14 Mar 2018 22:12:10 +0000
Bug 1443457 - Stop referencing the addon-sdk loader in devtools code r=jdescottes MozReview-Commit-ID: 7lwCG8JT7cV
5b4fefc4bb907786c3bc2fc81aad9515a5307864: Backed out changeset ae1924aff61b (bug 1443457) as requested by developer
Dorel Luca <dluca@mozilla.com> - Wed, 14 Mar 2018 12:35:38 +0200 - rev 408190
Push 100889 by apavel@mozilla.com at Wed, 14 Mar 2018 22:12:10 +0000
Backed out changeset ae1924aff61b (bug 1443457) as requested by developer
a2a0cf1b3b02f9a6147b79218bf48899937537a5: Backed out 2 changesets (bug 1443421) for Valgrind leak on Linux x64 opt
Dorel Luca <dluca@mozilla.com> - Wed, 14 Mar 2018 12:31:23 +0200 - rev 408189
Push 100889 by apavel@mozilla.com at Wed, 14 Mar 2018 22:12:10 +0000
Backed out 2 changesets (bug 1443421) for Valgrind leak on Linux x64 opt Backed out changeset 6afa399e604a (bug 1443421) Backed out changeset edc1455e7082 (bug 1443421)
3c176f583fe86a705f54053f9a6b6e161fb91734: Backed out changeset e226de7caa88 (bug 1444572) for conflicts while backing out 1443421
Dorel Luca <dluca@mozilla.com> - Wed, 14 Mar 2018 12:28:59 +0200 - rev 408188
Push 100889 by apavel@mozilla.com at Wed, 14 Mar 2018 22:12:10 +0000
Backed out changeset e226de7caa88 (bug 1444572) for conflicts while backing out 1443421
86919fbab7882bacdf7d680b89b6a4658c1b6ca1: Bug 1445153 - Remove remaining references to computedview in boxmodel component;r=pbro
Julian Descottes <jdescottes@mozilla.com> - Tue, 13 Mar 2018 08:51:34 +0100 - rev 408187
Push 100889 by apavel@mozilla.com at Wed, 14 Mar 2018 22:12:10 +0000
Bug 1445153 - Remove remaining references to computedview in boxmodel component;r=pbro MozReview-Commit-ID: CxX09ZQ9jhk
ae1924aff61b6f4ef104723cd3a7df3f043bd4da: Bug 1443457 - Stop referencing the addon-sdk loader in devtools code r=jdescottes
Michael Ratcliffe <mratcliffe@mozilla.com> - Fri, 09 Mar 2018 15:36:45 +0000 - rev 408186
Push 100889 by apavel@mozilla.com at Wed, 14 Mar 2018 22:12:10 +0000
Bug 1443457 - Stop referencing the addon-sdk loader in devtools code r=jdescottes MozReview-Commit-ID: 7lwCG8JT7cV
4f104b611240657502e6953e7725e9a39742da76: Merge mozilla-central to autoland
arthur.iakab <aiakab@mozilla.com> - Wed, 14 Mar 2018 12:16:00 +0200 - rev 408185
Push 100889 by apavel@mozilla.com at Wed, 14 Mar 2018 22:12:10 +0000
Merge mozilla-central to autoland
e226de7caa882aedbdadf588adb2632991e63f9c: Bug 1444572 - IMContextWrapper should dispatch fake eKeyDown event during composition if active IM is uim r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 12 Mar 2018 15:41:39 +0900 - rev 408184
Push 100889 by apavel@mozilla.com at Wed, 14 Mar 2018 22:12:10 +0000
Bug 1444572 - IMContextWrapper should dispatch fake eKeyDown event during composition if active IM is uim r=m_kato uim is an old IM which uses key snooper to listen to key events rather than via filter key event API which should be called by applications. It's still used by Debian 9.x, so, we still need to support this. Unfortunately, we cannot detect if uim actually uses key snooper because it's switch by build option of uim. Currently, Debian builds uim as using key snooper. So, we should assume uim uses key snooper always. On the other hand, somebody *might* use uim built as not using key snooper, so, let's decide if uim uses key snooper with new pref, "intl.ime.hack.uim.using_key_snooper", but its default should be true. Note that ibus and Fcitx also have the mode to use key snooper (perhaps for backward compatibility with uim). However, it's not enabled in default settings and even if it's enabled, Firefox is in whitelist in the default settings of them for stop using key snooper. Therefore, we don't need to support key snooper mode for them unless we'll get some requests to support their key snooping mode. MozReview-Commit-ID: 6fTsfKrHzvo
e5cca677e835e18e0eb74499d5c0448497aa779c: Backed out changeset 2c8540f7800f (bug 1443457) for ESlint failure at /builds/worker/checkouts/gecko/devtools/server/tests/mochitest/test_getProcess.html
Coroiu Cristina <ccoroiu@mozilla.com> - Wed, 14 Mar 2018 11:41:12 +0200 - rev 408183
Push 100889 by apavel@mozilla.com at Wed, 14 Mar 2018 22:12:10 +0000
Backed out changeset 2c8540f7800f (bug 1443457) for ESlint failure at /builds/worker/checkouts/gecko/devtools/server/tests/mochitest/test_getProcess.html
b1117fa567eb9067f2816a813046a129406f20cf: Backed out 2 changesets (bug 1443080) for spidermonkey build bustage at build/src/js/src/jit/BaselineCacheIRCompiler.cpp
Coroiu Cristina <ccoroiu@mozilla.com> - Wed, 14 Mar 2018 11:13:21 +0200 - rev 408182
Push 100889 by apavel@mozilla.com at Wed, 14 Mar 2018 22:12:10 +0000
Backed out 2 changesets (bug 1443080) for spidermonkey build bustage at build/src/js/src/jit/BaselineCacheIRCompiler.cpp Backed out changeset 7d509bb8a35d (bug 1443080) Backed out changeset 53bdcd5937cd (bug 1443080)
2c8540f7800fcaae3599e6c64154ba9e5ac95f17: Bug 1443457 - Stop referencing the addon-sdk loader in devtools code r=jdescottes
Michael Ratcliffe <mratcliffe@mozilla.com> - Fri, 09 Mar 2018 15:36:45 +0000 - rev 408181
Push 100889 by apavel@mozilla.com at Wed, 14 Mar 2018 22:12:10 +0000
Bug 1443457 - Stop referencing the addon-sdk loader in devtools code r=jdescottes MozReview-Commit-ID: 7lwCG8JT7cV
6afa399e604a399e09742f16211ae69f22b3ab75: Bug 1443421 - part 2: IMContextWrapper should dispatch eKeyDown or eKeyUp event as "processed by IME" even when IM sent some signals without sending key event again r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 09 Mar 2018 12:39:40 +0900 - rev 408180
Push 100889 by apavel@mozilla.com at Wed, 14 Mar 2018 22:12:10 +0000
Bug 1443421 - part 2: IMContextWrapper should dispatch eKeyDown or eKeyUp event as "processed by IME" even when IM sent some signals without sending key event again r=m_kato ibus and fcitx usually post key event to other IME process, then, if it causes some signals to updating composition string, they may not send the posted key event to us again. Then, IMContextWrapper dispatches neither eKeyDown nor eKeyUp event since mProcessingKeyEvent becomes non-nullptr only while OnKeyEvent() is called. So, IMContextWrapper need to store key event if OnKeyEvent() assumes that given key event is posted to different process. Then, if IMContextWrapper receives some signals, it should dispatch eKeyDown and eKeyUp event with stored key event. Note that we cannot compare the pointer of first event and following event directly even though usually both events are same address as far as I checked because according to the source code of ibus, fcitx and GDK, they use gdk_event_copy() to keep storing original event. According to the document of the API, it might just increment refcount. However, the actual implementation of the API always creates another instance and return it. So, it might be used same address by arena allocation or something accidentally. Anyway, we shouldn't compare them. Instead, we need to compare each information of two key events. Unfortunately, we also cannot compare them simply. Both ibus and fcitx set unused bits of GdkEventKey::state to true when they send back the event to us. Therefore, we should compare some of or all of the members by ourselves. I think that matching time must be enough in most cases since its value of native key events are properly set. However, for safer code, this patch also checks type, keyval and part of state. MozReview-Commit-ID: FZSwN61v0Sd
edc1455e7082f769a2c358a0b15c8950629dc4f3: Bug 1443421 - part 1: Make IMContextWrapper not dispatch eKeyDown and eKeyUp event if the native key event is being handled by other IME process r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 09 Mar 2018 00:46:52 +0900 - rev 408179
Push 100889 by apavel@mozilla.com at Wed, 14 Mar 2018 22:12:10 +0000
Bug 1443421 - part 1: Make IMContextWrapper not dispatch eKeyDown and eKeyUp event if the native key event is being handled by other IME process r=m_kato ibus and fcitx have asynchronous key event handling mode and it's enabled in default settings. That is, when they receive a key event from application via a call of gtk_im_context_filter_keypress(), they may post the key event information to other IME process, then does nothing but store the copy of the event with gdk_event_copy() and returns true for the result of gtk_im_context_filter_keypress(). When the other IME process handles the event, returns the result to them in our process. Then, they send the stored key event to us again. Finally, they actually handles the event in our process actually. Therefore, we may receive every key event twice. So, this causes dispatching eKeyDown event and eKeyUp event twice. Preceding key event is always marked as "processed by IME" since gtk_im_context_filter_keypress() returns true temporarily and following key event is dispatched as expected. So, we need to ignore the first event only when gtk_im_context_filter_keypress() returns true but the event is posted to different process. Unfortunately, we cannot know if the key event is actually posted to different process directly. However, we can know if active IM is ibus, fcitx or another one and if ibus or fcitx is in asynchronous key handling mode. The former information is provided by gtk_im_multicontext_get_context_id(). It returns a string which is set to the IM multicontext instance by creator. We'll get "ibus" if IM is ibus, get "fcitx" if IM is fcitx. The latter information is not provided. However, they consider the mode from env value. ibus checks IBUS_ENABLE_SYNC_MODE. fcitx checks both IBUS_ENABLE_SYNC_MODE and FCITX_ENABLE_SYNC_MODE. Additionally, we can know if received key event has already been posted to other IME process. They use undefined bit of GdkEventKey::state to store if the key event has already been posted (1 << 25, they called "ignored" flag). Although their approach is really hacky but we can refer the information at least for now. Finally, when we guess a key event is posted to other IME process, let's IMContextWrapper::OnKeyEvent() not dispatch eKeyDown nor eKeyUp event. Note that if it's handled synchronously as unexpected, it may causes dispatching one or more composition events and/or delete content event. So, in such case, we dispatch a keyboard event for processing key event anyway. There is only once case we'll fail to dispatch keyboard event. If we receive signals to dispatch composition events or delete content command event when IM receives the result from other IME process but it doesn't send the key event to us. This will be fixed by the following patch. MozReview-Commit-ID: 94PrlnmQ3uJ
552d61cb273abe05e86c9d64a7a0077ed1046856: Bug 1437438 - Add a performance counter to track scheduler activity - r=farre,froydnj
Tarek Ziadé <tarek@mozilla.com> - Tue, 06 Mar 2018 10:19:19 +0100 - rev 408178
Push 100889 by apavel@mozilla.com at Wed, 14 Mar 2018 22:12:10 +0000
Bug 1437438 - Add a performance counter to track scheduler activity - r=farre,froydnj Adds a PeformanceCounter class that is used in DocGroup and WorkerPrivate to track runnables execution and dispatch counts. MozReview-Commit-ID: 51DLj6ORD2O
7d509bb8a35d278c15597bff0a0e7855479987e3: Bug 1443080 - Now that we use static call, some var instances are not needed anymore r=Ehsan
Sylvestre Ledru <sledru@mozilla.com> - Mon, 05 Mar 2018 09:33:02 +0100 - rev 408177
Push 100889 by apavel@mozilla.com at Wed, 14 Mar 2018 22:12:10 +0000
Bug 1443080 - Now that we use static call, some var instances are not needed anymore r=Ehsan MozReview-Commit-ID: AiuJIY8Gssl
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip