07184f24860bafda10d0eac583236ae2e4544fef: Bug 1494127 - Fix trivial calls to do_QueryInterface that return an nsresult r=smaug
Andrew McCreight <continuation@gmail.com> - Mon, 01 Oct 2018 21:38:43 +0000 - rev 439244
Push 108542 by dvarga@mozilla.com at Tue, 02 Oct 2018 22:18:02 +0000
Bug 1494127 - Fix trivial calls to do_QueryInterface that return an nsresult r=smaug Calls to do_QueryInterface to a base class can be replaced by a static cast, which is faster. Differential Revision: https://phabricator.services.mozilla.com/D7224
995cd5fca351d5bf3c00e745f3cc22a2fab6fd72: Bug 1495571 - Part 8: Add support for early escape from the loop. Eliminate the Action enum. r=efaust
Jason Orendorff <jorendorff@mozilla.com> - Tue, 02 Oct 2018 14:26:35 +0000 - rev 439243
Push 108542 by dvarga@mozilla.com at Tue, 02 Oct 2018 22:18:02 +0000
Bug 1495571 - Part 8: Add support for early escape from the loop. Eliminate the Action enum. r=efaust Depends on D7376 Differential Revision: https://phabricator.services.mozilla.com/D7377
b999f2758e3ea42c804b504dc45ac322bcd7fa80: Bug 1495571 - Part 7: Make the output a lambda. r=efaust
Jason Orendorff <jorendorff@mozilla.com> - Tue, 02 Oct 2018 14:26:01 +0000 - rev 439242
Push 108542 by dvarga@mozilla.com at Tue, 02 Oct 2018 22:18:02 +0000
Bug 1495571 - Part 7: Make the output a lambda. r=efaust Depends on D7375 Differential Revision: https://phabricator.services.mozilla.com/D7376
a82ed21f664cba5d170a9268885326d8f0e42247: Bug 1495571 - Part 6: Specify the replacement character explicitly, not as a function of CharT. r=efaust
Jason Orendorff <jorendorff@mozilla.com> - Tue, 02 Oct 2018 15:17:59 +0000 - rev 439241
Push 108542 by dvarga@mozilla.com at Tue, 02 Oct 2018 22:18:02 +0000
Bug 1495571 - Part 6: Specify the replacement character explicitly, not as a function of CharT. r=efaust This is not great but we're getting rid of CharT. Depends on D7374 Differential Revision: https://phabricator.services.mozilla.com/D7375
a35af6689749d7321ea8d3c63656cd23f1f332d8: Bug 1495571 - Part 5: Rename InflateUTF8StringToBuffer and add a little documentation. r=efaust
Jason Orendorff <jorendorff@mozilla.com> - Tue, 02 Oct 2018 14:25:07 +0000 - rev 439240
Push 108542 by dvarga@mozilla.com at Tue, 02 Oct 2018 22:18:02 +0000
Bug 1495571 - Part 5: Rename InflateUTF8StringToBuffer and add a little documentation. r=efaust Depends on D7373 Differential Revision: https://phabricator.services.mozilla.com/D7374
efc1efbc569a3048d897730639b121a796ad8380: Bug 1495571 - Part 4: Remove first template parameter to InflateUTF8StringHelper, as it is now always Count. r=efaust
Jason Orendorff <jorendorff@mozilla.com> - Tue, 02 Oct 2018 14:24:48 +0000 - rev 439239
Push 108542 by dvarga@mozilla.com at Tue, 02 Oct 2018 22:18:02 +0000
Bug 1495571 - Part 4: Remove first template parameter to InflateUTF8StringHelper, as it is now always Count. r=efaust Depends on D7372 Differential Revision: https://phabricator.services.mozilla.com/D7373
0f95c1e8fca93909844336d21612f4a25fe9c158: Bug 1495571 - Part 3: Simplify InflateUTF8Action now that the error behavior has been factored out. r=efaust
Jason Orendorff <jorendorff@mozilla.com> - Tue, 02 Oct 2018 14:24:22 +0000 - rev 439238
Push 108542 by dvarga@mozilla.com at Tue, 02 Oct 2018 22:18:02 +0000
Bug 1495571 - Part 3: Simplify InflateUTF8Action now that the error behavior has been factored out. r=efaust Depends on D7371 Differential Revision: https://phabricator.services.mozilla.com/D7372
4775742238180accb463cc2ff53463ddcafa4f59: Bug 1495571 - Part 2: Introduce OnUTF8Error. r=efaust
Jason Orendorff <jorendorff@mozilla.com> - Tue, 02 Oct 2018 15:19:33 +0000 - rev 439237
Push 108542 by dvarga@mozilla.com at Tue, 02 Oct 2018 22:18:02 +0000
Bug 1495571 - Part 2: Introduce OnUTF8Error. r=efaust Depends on D7370 Differential Revision: https://phabricator.services.mozilla.com/D7371
5a66c886df15268b57449f869c0fa654b2c2eb0a: Bug 1495571 - Part 1: Do not parameterize character-encoding templates for ContextT. r=efaust
Jason Orendorff <jorendorff@mozilla.com> - Tue, 02 Oct 2018 14:23:28 +0000 - rev 439236
Push 108542 by dvarga@mozilla.com at Tue, 02 Oct 2018 22:18:02 +0000
Bug 1495571 - Part 1: Do not parameterize character-encoding templates for ContextT. r=efaust This is an old hack that we have not needed for ages. It's all JSContext now. Differential Revision: https://phabricator.services.mozilla.com/D7370
5780816ec3a9eff36b3d7f1c221c5f58aa6aba47: Bug 1494662 - Integrate the urlbar provider manager with the controller. r=dao
Mark Banner <standard8@mozilla.com> - Tue, 02 Oct 2018 14:22:29 +0000 - rev 439235
Push 108542 by dvarga@mozilla.com at Tue, 02 Oct 2018 22:18:02 +0000
Bug 1494662 - Integrate the urlbar provider manager with the controller. r=dao This picks up naming changes from the provider manager landing, and also makes starting a query be named consistently across the modules. Differential Revision: https://phabricator.services.mozilla.com/D7297
fb7f5d71b31ad06c7207f0945cd8fdbee003e237: Bug 1495478 - Move LogConstraints() to class MediaConstraintsHelper and add logging of missing constraints (rollup includes backed-out bug 1494498) r=pehrsons
Jan-Ivar Bruaroey <jib@mozilla.com> - Tue, 02 Oct 2018 16:13:20 +0000 - rev 439234
Push 108542 by dvarga@mozilla.com at Tue, 02 Oct 2018 22:18:02 +0000
Bug 1495478 - Move LogConstraints() to class MediaConstraintsHelper and add logging of missing constraints (rollup includes backed-out bug 1494498) r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D7378
cefdf4d102faabf8a000caa821d311ca3d289701: Merge mozilla-central to autoland. a=merge CLOSED TREE
Gurzau Raul <rgurzau@mozilla.com> - Tue, 02 Oct 2018 19:07:23 +0300 - rev 439233
Push 108542 by dvarga@mozilla.com at Tue, 02 Oct 2018 22:18:02 +0000
Merge mozilla-central to autoland. a=merge CLOSED TREE
ac55a8f97f06897ee34d65d6bbfc773091e2341e: Bug 1495067 - Enable a test. r=me
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 02 Oct 2018 18:00:48 +0200 - rev 439232
Push 108542 by dvarga@mozilla.com at Tue, 02 Oct 2018 22:18:02 +0000
Bug 1495067 - Enable a test. r=me
9e5ba5a3b22c2d6ce5cc6bd0c331af5bdec7c6a5: Bug 1494135 add pinned option to page_action manifest, r=aswan
Shane Caraveo <scaraveo@mozilla.com> - Tue, 02 Oct 2018 15:39:16 +0000 - rev 439231
Push 108542 by dvarga@mozilla.com at Tue, 02 Oct 2018 22:18:02 +0000
Bug 1494135 add pinned option to page_action manifest, r=aswan Differential Revision: https://phabricator.services.mozilla.com/D7098
66b90e5af6d162fa2c5d27b5d0df4140f108d84b: Bug 1495517 - Migrate improvesearch.topSiteSearchShortcuts pref from ActivityStream.jsm to firefox.js r=k88hudson
Ursula Sarracini <ursulasarracini@gmail.com> - Tue, 02 Oct 2018 15:37:51 +0000 - rev 439230
Push 108542 by dvarga@mozilla.com at Tue, 02 Oct 2018 22:18:02 +0000
Bug 1495517 - Migrate improvesearch.topSiteSearchShortcuts pref from ActivityStream.jsm to firefox.js r=k88hudson Differential Revision: https://phabricator.services.mozilla.com/D7325
8a9bb797623dae8f4f4d478b7adf6e1dde504de7: Bug 1490375 - Align about:addons with about:preferences sidebar r=aswan
Mark Striemer <mstriemer@mozilla.com> - Mon, 01 Oct 2018 17:15:23 +0000 - rev 439229
Push 108542 by dvarga@mozilla.com at Tue, 02 Oct 2018 22:18:02 +0000
Bug 1490375 - Align about:addons with about:preferences sidebar r=aswan Differential Revision: https://phabricator.services.mozilla.com/D7264
7a728776d81231f97d7e126cdff83c6935bbc158: Backed out changeset 1f4d7ab6cd6d (bug 1480529) for perma failing on browser_multiselect_tabs_bookmark.js
Bogdan Tara <btara@mozilla.com> - Tue, 02 Oct 2018 18:33:49 +0300 - rev 439228
Push 108542 by dvarga@mozilla.com at Tue, 02 Oct 2018 22:18:02 +0000
Backed out changeset 1f4d7ab6cd6d (bug 1480529) for perma failing on browser_multiselect_tabs_bookmark.js
ec51b039eef15fd55908f1fa1051b0624c4b4a46: Bug 1380830 - Enable container-with-clamping reftest again. r=dbaron
Jan Henning <jh+bugzilla@buttercookie.de> - Tue, 02 Oct 2018 15:23:19 +0000 - rev 439227
Push 108542 by dvarga@mozilla.com at Tue, 02 Oct 2018 22:18:02 +0000
Bug 1380830 - Enable container-with-clamping reftest again. r=dbaron Judging from the description in comment 3 and the fact that this test started failing shortly after bug 1308876 landed, it is highly likely that this test is being hit by the same issue as bug 1428670. This also makes sense given that this test is supposed to test the clamping of the effective container width for font inflation by the actually visible area of that frame - be that the viewport for a top level document as in bug 1428670, or the width of an <iframe> as in this test. Without the patches for bug 1428670, this test is still failing very frequently. With those patches applied on the other hand, no more failures are encountered. Differential Revision: https://phabricator.services.mozilla.com/D5580
57e3c8d09acea5e0bff83ddbb78d385f71dd352d: Bug 1428670 - Part 3: Store the effective container ISize within the FontInflationData. r=dbaron
Jan Henning <jh+bugzilla@buttercookie.de> - Tue, 02 Oct 2018 15:23:17 +0000 - rev 439226
Push 108542 by dvarga@mozilla.com at Tue, 02 Oct 2018 22:18:02 +0000
Bug 1428670 - Part 3: Store the effective container ISize within the FontInflationData. r=dbaron When one of the two factors governing the effective container width for font inflation changes, we need to mark all affected frames as dirty. While the visible area commonly changes because of viewport changes and we can catch those through the check for ISize resizes of the top-level frame ("!mFrame->GetParent() && isIResize"), it still seems nicer to move calculation of the effective container width into the FontInflationData itself, especially since the effective container width calculation in nsLayoutUtils is the only consumer of the NCAISize currently stored by the FontInflationData. That way - we can be sure that really all changes of the visible width will correctly mark all affected frames as dirty - can avoid repeatedly recalculating the effective container width - can also detect the cases where the effective container width actually remains the same after a change in one of its input factors and skip forcing a full dirty reflow for all descendants just because of font inflation. While the code in nsLayoutUtils was technically always using the writing mode (horizontal/vertical) of each individual frame for determining which dimension of the visible size should be used for clamping, just using the writing mode of the respective flow root should be enough, since each change in the writing mode should create a new flow root. This assumption should already hold today because 1. as per the Writing Modes CSS spec, a change in writing mode compared to its parent means that the affected block cannot be purely "inline", but at most "inline-block". 2. Generally, any non-inline frame will be marked as a font inflation container. 3. Any block frame whose writing direction doesn't match its parent will be a block formatting context, which implies NS_BLOCK_FLOAT_MGR. 4. Any block frame that has both NS_BLOCK_FLOAT_MGR set and is a font inflation container will also become a font inflation flow root. but because this chain of reasoning is not the most direct, we also add a corresponding assertion to better catch any potential bugs here. Differential Revision: https://phabricator.services.mozilla.com/D5578
87971e291470b0d0ed5be19f323312ae39ac5308: Bug 1428670 - Part 2: Correctly mark all child frames as dirty when font inflation status changes. r=dbaron
Jan Henning <jh+bugzilla@buttercookie.de> - Tue, 02 Oct 2018 15:23:12 +0000 - rev 439225
Push 108542 by dvarga@mozilla.com at Tue, 02 Oct 2018 22:18:02 +0000
Bug 1428670 - Part 2: Correctly mark all child frames as dirty when font inflation status changes. r=dbaron Before bug 1308876, child frames marked themselves as dirty during reflow if their parent was dirty, too. After bug 1308876, the point where dirtiness is being propagated to a frame's descendants has been shifted: Now, dirty parents are responsible for marking all their children as dirty, too, when the parent starts reflowing. This means that if a frame wants to mark a whole subtree as dirty *during its own* reflow, it's no longer sufficient to just mark the root of the subtree as dirty and then rely on all further children marking themselves as dirty as well when reflow reaches them. The font inflation code is one such case. When the font inflation data on a font inflation flow root has become dirty, or we're resizing the top-level frame (which because of the effective container width clamping from bug 707855 can affect the font inflation font size as well), we now need to explicitly mark all affected children as dirty. Differential Revision: https://phabricator.services.mozilla.com/D5577
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip