02a46b307edd115a43611ef81b603f52f15fcfae: Bug 1471116 - Use nsCSSProps::kPropertyPrefTable for pref callback register of nsComputedDOMStyle. r=emilio
Xidorn Quan <me@upsuper.org> - Tue, 26 Jun 2018 14:06:46 +1000 - rev 423876
Push 104680 by dluca@mozilla.com at Wed, 27 Jun 2018 10:41:30 +0000
Bug 1471116 - Use nsCSSProps::kPropertyPrefTable for pref callback register of nsComputedDOMStyle. r=emilio MozReview-Commit-ID: 7VvFGYi12te
f5075fe188376e52061b9f1ae42d7485b389b75c: Bug 1470079 - Add fuzzing coverage build to taskcluster r=marco
rforbes <rforbes@mozilla.com> - Sun, 24 Jun 2018 18:48:52 -0700 - rev 423875
Push 104680 by dluca@mozilla.com at Wed, 27 Jun 2018 10:41:30 +0000
Bug 1470079 - Add fuzzing coverage build to taskcluster r=marco MozReview-Commit-ID: 5TyxY2KmLCs
f3df0a04b93edfbf6d213a7fd2c76ecda271d355: Bug 1438574: Changed unknown group semantic handling, r=dminor
Johannes Willbold <j.willbold@mozilla.com> - Mon, 25 Jun 2018 16:16:18 -0700 - rev 423874
Push 104680 by dluca@mozilla.com at Wed, 27 Jun 2018 10:41:30 +0000
Bug 1438574: Changed unknown group semantic handling, r=dminor Unknown group semantics are no longer an error but a warning indicating that the lines was skipped. Made rust unit test test_parse_attribute_group more explicit. MozReview-Commit-ID: 7adMSzH195H
50d485b6ba4579098dbe1d1ce205564f4e294542: Bug 1471267 - Update some baseline-querying utility functions to bail on frames that have 'contain:size'. r=dholbert
Morgan Rae Reschenberg <mreschenberg@mozilla.com> - Tue, 26 Jun 2018 15:34:15 -0700 - rev 423873
Push 104680 by dluca@mozilla.com at Wed, 27 Jun 2018 10:41:30 +0000
Bug 1471267 - Update some baseline-querying utility functions to bail on frames that have 'contain:size'. r=dholbert MozReview-Commit-ID: Bk2P73tlRqG
b23bf217d88ffa08aa9798eaf9de67f07fb2a1d5: Bug 1432932: Sanity check for simulcast recv rids. r=bwc,dminor
Johannes Willbold <j.willbold@mozilla.com> - Fri, 08 Jun 2018 13:22:16 -0700 - rev 423872
Push 104680 by dluca@mozilla.com at Wed, 27 Jun 2018 10:41:30 +0000
Bug 1432932: Sanity check for simulcast recv rids. r=bwc,dminor Added Rid attribute parsing Added C++/Rust glue code for the rid attribute Added SdpInternalError for ParseFloatError Added Rust unit test for parse_rid in Rust Added U16Vec in C++/Rust glue code. The C++ glue code no longer parses rid attributes on his own if the rust parser is used. Reworked Simulcast parsing in rust Added C++/rust glue code for Simulcast Enabled CheckSimulcast c++ unit test Added sanity check, that checks for simulcast rids that have nt been defined Enabled ParseInvalidSimulcastNoSuchRecvRid C++ unit test Added comments with bug number to remove redundant parsing functions. Removed C++ unit test ParseInvalidSimulcastNoSuchPt Added C++ unit test ParseInvalidRidNoSuchPt Added sanity check for rid pts. MozReview-Commit-ID: 7rvsOKIbxVP
909312d0fc69e078cd26c545df63067baada1816: Bug 1471096 - Choose OOM hooking version to use at build time rather than configure time. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Sat, 23 Jun 2018 07:28:26 +0900 - rev 423871
Push 104680 by dluca@mozilla.com at Wed, 27 Jun 2018 10:41:30 +0000
Bug 1471096 - Choose OOM hooking version to use at build time rather than configure time. r=froydnj When I originally implemented bug 1458161, this is how it was done, but it was suggested to use a configure-time check. This turned out to not be great, because the rust compiler changes regularly, and we don't run the configure tests when the version changes. When people upgraded their rust compiler to 1.27, the code subsequently failed to build because the features were still set for the previous version they had installed.
daca982d64132d8d798b8e17881da51523e18729: Bug 1471096 - Vendor rustc_version. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Tue, 26 Jun 2018 10:00:26 +0900 - rev 423870
Push 104680 by dluca@mozilla.com at Wed, 27 Jun 2018 10:41:30 +0000
Bug 1471096 - Vendor rustc_version. r=froydnj
ded85684155377e4ac405fca8d01f61ae150dd0d: Bug 1470701 - Use run-time page size when changing mapping permissions in elfhack injected code. r=froydnj
Mike Hommey <mh@glandium.org> - Sun, 24 Jun 2018 09:02:38 +0900 - rev 423869
Push 104680 by dluca@mozilla.com at Wed, 27 Jun 2018 10:41:30 +0000
Bug 1470701 - Use run-time page size when changing mapping permissions in elfhack injected code. r=froydnj When a binary has a PT_GNU_RELRO segment, the elfhack injected code uses mprotect to add the writable flag to relocated pages before applying relocations, removing it afterwards. To do so, the elfhack program uses the location and size of the PT_GNU_RELRO segment, and adjusts it to be aligned according to the PT_LOAD alignment. The problem here is that the PT_LOAD alignment doesn't necessarily match the actual page alignment, and the resulting mprotect may end up not covering the full extent of what the dynamic linker has protected read-only according to the PT_GNU_RELRO segment. In turn, this can lead to a crash on startup when trying to apply relocations to the still read-only locations. Practically speaking, this doesn't end up being a problem on x86, where the PT_LOAD alignment is usually 4096, which happens to be the page size, but on Debian armhf, it is 64k, while the run time page size can be 4k.
28bedb658af486ccd8ed69dff559327aa2653a1c: Bug 1340498 - Fix unified sources build errors r=mrbkap
Doug Thayer <dothayer@mozilla.com> - Fri, 13 Apr 2018 11:04:47 -0700 - rev 423868
Push 104680 by dluca@mozilla.com at Wed, 27 Jun 2018 10:41:30 +0000
Bug 1340498 - Fix unified sources build errors r=mrbkap Adding the Places* files into unified sources pushed the unified sources into a situation that exposed a strangely large number of errors. This seems to be the minimum set of changes I could make to resolve all of the issues. MozReview-Commit-ID: C2H9ce8FmE4
f950a2310e26ec1f9e91423e9e0041b6d512213c: Bug 1340498 - Update onVisits tests to use 'page-visited' r=mak
Doug Thayer <dothayer@mozilla.com> - Wed, 14 Feb 2018 09:17:41 -0800 - rev 423867
Push 104680 by dluca@mozilla.com at Wed, 27 Jun 2018 10:41:30 +0000
Bug 1340498 - Update onVisits tests to use 'page-visited' r=mak MozReview-Commit-ID: FxC3gcUF9hl
5fcd31c65fe0f854b3a82e15c9becfa21db0ac92: Bug 1340498 - Update onVisits uses to 'page-visited' r=mak
Doug Thayer <dothayer@mozilla.com> - Wed, 14 Feb 2018 09:11:49 -0800 - rev 423866
Push 104680 by dluca@mozilla.com at Wed, 27 Jun 2018 10:41:30 +0000
Bug 1340498 - Update onVisits uses to 'page-visited' r=mak Consuming the new 'page-visited' notification was fairly trivial, since it was already brought over to onVisits. There's not much to say about this other than that I'm a little bit uncertain about all the hoops we have to jump through to get a JSContext and GlobalObject from History.cpp (which is discussed in the earlier commit in the series). MozReview-Commit-ID: LHaBWSylyLI
515bb5e24dd7e135f46cc14e596cf0af5c480a1c: Bug 1340498 - Implement new Places Observers interface r=mrbkap
Doug Thayer <dothayer@mozilla.com> - Wed, 14 Feb 2018 09:06:15 -0800 - rev 423865
Push 104680 by dluca@mozilla.com at Wed, 27 Jun 2018 10:41:30 +0000
Bug 1340498 - Implement new Places Observers interface r=mrbkap See the design doc[1] for further info. We would like to redesign the places observer system to be more performant and more friendly to consume. WebIDL was recommended as it simplifies creating simple dictionary payloads while allowing dynamic typing with `any`. There were some difficulties with WebIDL though, most of which revolved around allowing consumers to be weakly referenced, from both C++ and JS. The simplest solution I could come up with was to create a simple native interface for the C++ case, and a WebIDL wrapper for a JS callback in the JS case. Suggestions for simpler alternatives are very welcome though. [1] https://docs.google.com/document/d/1G45vfd6RXFXwNz7i4FV40lDCU0ao-JX_bZdgJV4tLjk/edit?usp=sharing MozReview-Commit-ID: ACnAEfa5WxO
79a8619bd3e2de41afbbe901ce3e9c0bdb79bfa9: Bug 1340498 - Add new globals to lint config r=standard8
Doug Thayer <dothayer@mozilla.com> - Mon, 29 Jan 2018 11:07:28 -0800 - rev 423864
Push 104680 by dluca@mozilla.com at Wed, 27 Jun 2018 10:41:30 +0000
Bug 1340498 - Add new globals to lint config r=standard8 MozReview-Commit-ID: 360gup8cWvi
0c8c7b025aeed7de7a6303aa3ea1c07da020f450: Bug 1447116 - Require rust 1.26. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Tue, 26 Jun 2018 18:05:23 +0900 - rev 423863
Push 104680 by dluca@mozilla.com at Wed, 27 Jun 2018 10:41:30 +0000
Bug 1447116 - Require rust 1.26. r=froydnj We're well overdue for an upgrade of the rust compiler requirements. Now that we're building with 1.28 (albeit a beta, due to be bumped when it's released), we can bump the requirement away from 1.24 which is now old. 1.27 is too new, though, so settle for the older 1.26.
82dc9159f28d7d3c08ab2c3b6a725aa45c49edd1: Bug 1447116 - Update builders to rust 1.28. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Tue, 26 Jun 2018 17:34:28 +0900 - rev 423862
Push 104680 by dluca@mozilla.com at Wed, 27 Jun 2018 10:41:30 +0000
Bug 1447116 - Update builders to rust 1.28. r=froydnj
b7873993686ffeb10a68d7a7bcedae6ec9b21040: Bug 1471132 - Make building a binary component a compile-time error. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Tue, 26 Jun 2018 16:18:14 +0900 - rev 423861
Push 104680 by dluca@mozilla.com at Wed, 27 Jun 2018 10:41:30 +0000
Bug 1471132 - Make building a binary component a compile-time error. r=froydnj Loading binary components is not supported since bug 1314955.
32d574a02a2eb31ccee9259a210d67edaab0fb03: Bug 1471132 - Change how static xpcom components are initialized. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Tue, 26 Jun 2018 16:10:30 +0900 - rev 423860
Push 104680 by dluca@mozilla.com at Wed, 27 Jun 2018 10:41:30 +0000
Bug 1471132 - Change how static xpcom components are initialized. r=froydnj The sStaticModules list is, practically speaking, a copy of the list of components we already have in libxul, augmented at runtime with a few other components for tests (for gtest and xpcshell). We don't actually need to keep that copy in memory. We can instead just use the pointers in libxul directly to register them to the component manager, and use a separate list, only for those extra components when they need to be registered.
7839040f0d428201a5d9afed324b7763ed555024: Bug 1471132 - Change how static xpcom components are linked. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Tue, 26 Jun 2018 14:40:51 +0900 - rev 423859
Push 104680 by dluca@mozilla.com at Wed, 27 Jun 2018 10:41:30 +0000
Bug 1471132 - Change how static xpcom components are linked. r=froydnj Overall, this makes the whole setup less fragile, and make it work with LTO in more situations.
dfd0afd7b60fe420b67ebee82634915efaaf48b0: Bug 1471132 - Avoid ASAN padding between NSModules. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Tue, 26 Jun 2018 14:39:49 +0900 - rev 423858
Push 104680 by dluca@mozilla.com at Wed, 27 Jun 2018 10:41:30 +0000
Bug 1471132 - Avoid ASAN padding between NSModules. r=froydnj
9f4d1a4296ba62cc65296bb2770ef617925554fd: Bug 1470127 - Move binary checks to a standalone script. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Thu, 21 Jun 2018 18:13:03 +0900 - rev 423857
Push 104680 by dluca@mozilla.com at Wed, 27 Jun 2018 10:41:30 +0000
Bug 1470127 - Move binary checks to a standalone script. r=froydnj We perform, on the binaries we build, a series of check, that are implemented as half-baked make commands, invoked after linking them. - check libstdc++ symbol versions to ensure binary compatibility with a baseline. - check glibc symbol versions to ensure binary compatibility with a baseline. - check that target binaries don't contain text relocations. - check that libmozglue is linked before libc on android. - on libxul, check that NSModules are laid out correctly. - on libxul, check that there is more than one PT_LOAD segment. Those checks happen to work where they matter, but their setup is unreliable. For example, the checks for symbol versions are supposed to work for libclang-plugin on cross osx builds, but in fact, don't, because the readelf path doesn't exist, and the command doesn't fail in that case. So move them all to a standalone script, performing the checks more thoroughly (especially the NSModules one, where we now also check that they are all adjacent), and more verbosely.
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip