author Masayuki Nakano <>
Thu, 07 Sep 2017 22:54:49 +0900
changeset 379758 ef1641e40903ff5e6cff94f2a1d1a3188598e563
parent 301276 435c691340a05280302417b3ba150a317cc16c08
child 401804 55250a54852a06bdb4c93adae23d7efb685f65e0
permissions -rw-r--r--
Bug 1369072 - part3: nsXBLPrototypeHandler::DispatchXBLCommand() should use controller of visible window r=smaug With previous change, KeyboardEvent is dispatched even when invisible window has focus. However, nsRootWindow::GetControllerForCommand() returns controller for focused window even when the window is invisible because it uses nsFocusManager::GetFocusedDescendant() to retrieve focused window. Perhaps, we can assume that users won't expect to do something with invisible window when they type some keys. Then, nsRootWindow::GetControllerForCommand() should return controller for visible ancestor window if focused window is invisible. This patch makes nsFocusManager::GetFocusedDescendant() can return only visible descendants. However, it already has a bool argument. Therefore, it should have a flag instead of adding new flag. Most changes of this patch is replacing its callers. Then, nsRootWindow::GetControllerForCommand() and nsRootWindow::GetControllers() should have a bool flag if it should return controller(s) for visible window. This patch adds a bool flag for it. Fortunately, the interface isn't scriptable. Finally, this patch makes nsXBLPrototypeHandler::DispatchXBLCommand() and EventStateManager::DoContentCommandEvent() retrieve controller for visible window since they are always handles user input. MozReview-Commit-ID: GygttTHuKRm

/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
/* This Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at */

#ifndef nsPIWindowRoot_h__
#define nsPIWindowRoot_h__

#include "nsISupports.h"
#include "mozilla/dom/EventTarget.h"
#include "nsWeakReference.h"

class nsPIDOMWindowOuter;
class nsIControllers;
class nsIController;

namespace mozilla {
namespace dom {
class TabParent;
} // namespace dom
} // namespace mozilla

{ 0xb8724c49, 0xc398, 0x4f9b, \
  { 0x82, 0x59, 0x87, 0x27, 0xa6, 0x47, 0xdd, 0x0f } }

class nsPIWindowRoot : public mozilla::dom::EventTarget

  virtual nsPIDOMWindowOuter* GetWindow()=0;

  // get and set the node that is the context of a popup menu
  virtual nsIDOMNode* GetPopupNode() = 0;
  virtual void SetPopupNode(nsIDOMNode* aNode) = 0;

   * @param aForVisibleWindow   true if caller needs controller which is
   *                            associated with visible window.
  virtual nsresult GetControllerForCommand(const char *aCommand,
                                           bool aForVisibleWindow,
                                           nsIController** aResult) = 0;

   * @param aForVisibleWindow   true if caller needs controllers which are
   *                            associated with visible window.
  virtual nsresult GetControllers(bool aForVisibleWindow,
                                  nsIControllers** aResult) = 0;

  virtual void GetEnabledDisabledCommands(nsTArray<nsCString>& aEnabledCommands,
                                          nsTArray<nsCString>& aDisabledCommands) = 0;

  virtual void SetParentTarget(mozilla::dom::EventTarget* aTarget) = 0;
  virtual mozilla::dom::EventTarget* GetParentTarget() = 0;

  // Stores a weak reference to the browser.
  virtual void AddBrowser(mozilla::dom::TabParent* aBrowser) = 0;
  virtual void RemoveBrowser(mozilla::dom::TabParent* aBrowser) = 0;

  typedef void (*BrowserEnumerator)(mozilla::dom::TabParent* aTab, void* aArg);

  // Enumerate all stored browsers that for which the weak reference is valid.
  virtual void EnumerateBrowsers(BrowserEnumerator aEnumFunc, void* aArg) = 0;

  virtual bool ShowAccelerators() = 0;
  virtual bool ShowFocusRings() = 0;
  virtual void SetShowAccelerators(bool aEnable) = 0;
  virtual void SetShowFocusRings(bool aEnable) = 0;


#endif // nsPIWindowRoot_h__